Re: [PATCH v2] powerpc/rtas: Keep MSR[RI] set when calling RTAS

2022-05-03 Thread Michael Ellerman
Laurent Dufour writes: > On 03/05/2022, 17:06:41, Michael Ellerman wrote: >> Laurent Dufour writes: ... >>> diff --git a/arch/powerpc/kernel/rtas.c b/arch/powerpc/kernel/rtas.c >>> index 1f42aabbbab3..d7775b8c8853 100644 >>> --- a/arch/powerpc/kernel/rtas.c >>> +++ b/arch/powerpc/kernel/rtas.c >>

Re: [PATCH v2] powerpc/rtas: Keep MSR[RI] set when calling RTAS

2022-05-03 Thread Michael Ellerman
Laurent Dufour writes: > On 03/05/2022, 18:16:29, Fabiano Rosas wrote: >> Michael Ellerman writes: >> diff --git a/arch/powerpc/kernel/entry_64.S b/arch/powerpc/kernel/entry_64.S index 9581906b5ee9..65cb14b56f8d 100644 --- a/arch/powerpc/kernel/entry_64.S +++ b/arch/pow

Re: [PATCH v2] powerpc/rtas: Keep MSR[RI] set when calling RTAS

2022-05-03 Thread Michael Ellerman
Fabiano Rosas writes: > Michael Ellerman writes: >>> diff --git a/arch/powerpc/kernel/entry_64.S b/arch/powerpc/kernel/entry_64.S >>> index 9581906b5ee9..65cb14b56f8d 100644 >>> --- a/arch/powerpc/kernel/entry_64.S >>> +++ b/arch/powerpc/kernel/entry_64.S >>> @@ -330,22 +330,18 @@ _GLOBAL(enter_r

Re: Apply d799769188529abc6cbf035a10087a51f7832b6b to 5.17 and 5.15?

2022-05-03 Thread Michael Ellerman
Nathan Chancellor writes: > On Thu, Apr 21, 2022 at 08:13:13AM -0700, Nathan Chancellor wrote: >> On Thu, Apr 21, 2022 at 05:46:52PM +1000, Michael Ellerman wrote: >> > Nathan Chancellor writes: >> > > Hi Greg, Sasha, and Michael, >> > > >> > > Commit d79976918852 ("powerpc/64: Add UADDR64 reloca

Re: [PATCH kernel] powerpc/llvm/lto: Allow LLVM LTO builds

2022-05-03 Thread Alexey Kardashevskiy
On 5/4/22 07:24, Nick Desaulniers wrote: On Thu, Apr 28, 2022 at 11:46 PM Alexey Kardashevskiy wrote: diff --git a/arch/powerpc/kernel/exceptions-64s.S b/arch/powerpc/kernel/exceptions-64s.S index b66dd6f775a4..5b783bd51260 100644 --- a/arch/powerpc/kernel/exceptions-64s.S +++ b/arch/power

Re: [PATCH 04/30] firmware: google: Convert regular spinlock into trylock on panic path

2022-05-03 Thread Evan Green
Hi Guilherme, On Tue, May 3, 2022 at 12:12 PM Guilherme G. Piccoli wrote: > > On 03/05/2022 15:03, Evan Green wrote: > > [...] > > gsmi_shutdown_reason() is a common function called in other scenarios > > as well, like reboot and thermal trip, where it may still make sense > > to wait to acquire

Re: [PATCH 04/30] firmware: google: Convert regular spinlock into trylock on panic path

2022-05-03 Thread Guilherme G. Piccoli
On 03/05/2022 15:03, Evan Green wrote: > [...] > gsmi_shutdown_reason() is a common function called in other scenarios > as well, like reboot and thermal trip, where it may still make sense > to wait to acquire a spinlock. Maybe we should add a parameter to > gsmi_shutdown_reason() so that you can

Re: [PATCH 16/30] drivers/hv/vmbus, video/hyperv_fb: Untangle and refactor Hyper-V panic notifiers

2022-05-03 Thread Guilherme G. Piccoli
On 03/05/2022 15:13, Michael Kelley (LINUX) wrote: > [...] >> (a) We could forget about this change, and always do the clean-up here, >> not relying in machine_crash_shutdown(). >> Pro: really simple, behaves the same as it is doing currently. >> Con: less elegant/concise, doesn't allow arm64 custo

RE: [PATCH 16/30] drivers/hv/vmbus, video/hyperv_fb: Untangle and refactor Hyper-V panic notifiers

2022-05-03 Thread Michael Kelley (LINUX)
From: Guilherme G. Piccoli Sent: Friday, April 29, 2022 3:35 PM > > Hi Michael, first of all thanks for the great review, much appreciated. > Some comments inline below: > > On 29/04/2022 14:16, Michael Kelley (LINUX) wrote: > > [...] > >> hypervisor I/O completion), so we postpone that to run

Re: [PATCH 04/30] firmware: google: Convert regular spinlock into trylock on panic path

2022-05-03 Thread Evan Green
On Wed, Apr 27, 2022 at 3:51 PM Guilherme G. Piccoli wrote: > > Currently the gsmi driver registers a panic notifier as well as > reboot and die notifiers. The callbacks registered are called in > atomic and very limited context - for instance, panic disables > preemption, local IRQs and all other

Re: [PATCH 19/30] panic: Add the panic hypervisor notifier list

2022-05-03 Thread Guilherme G. Piccoli
On 03/05/2022 14:44, Michael Kelley (LINUX) wrote: > [...] >> >> Hi Michael, thanks for your feedback! I agree that your idea could work, >> but...there is one downside: imagine the kmsg_dump() approach is not set >> in some Hyper-V guest, then we would rely in the regular notification >> mechanism

RE: [PATCH 19/30] panic: Add the panic hypervisor notifier list

2022-05-03 Thread Michael Kelley (LINUX)
From: Guilherme G. Piccoli Sent: Friday, April 29, 2022 11:04 AM > > On 29/04/2022 14:30, Michael Kelley (LINUX) wrote: > > From: Guilherme G. Piccoli Sent: Wednesday, April 27, > > 2022 > 3:49 PM > >> [...] > >> > >> @@ -2843,7 +2843,7 @@ static void __exit vmbus_exit(void) > >>if (ms_hyp

Re: Apply d799769188529abc6cbf035a10087a51f7832b6b to 5.17 and 5.15?

2022-05-03 Thread Nathan Chancellor
On Thu, Apr 21, 2022 at 08:13:13AM -0700, Nathan Chancellor wrote: > On Thu, Apr 21, 2022 at 05:46:52PM +1000, Michael Ellerman wrote: > > Nathan Chancellor writes: > > > Hi Greg, Sasha, and Michael, > > > > > > Commit d79976918852 ("powerpc/64: Add UADDR64 relocation support") fixes > > > a boot

Re: [PATCH 24/30] panic: Refactor the panic path

2022-05-03 Thread Guilherme G. Piccoli
On 03/05/2022 14:31, Michael Kelley (LINUX) wrote: > [...] > > To me, it's a weak correlation between having a kmsg dumper, and > wanting or not wanting the info level output to come before kdump. > Hyper-V is one of only a few places that register a kmsg dumper, so most > Linux instances outside

RE: [PATCH 24/30] panic: Refactor the panic path

2022-05-03 Thread Michael Kelley (LINUX)
From: Guilherme G. Piccoli Sent: Friday, April 29, 2022 1:38 PM > > On 29/04/2022 14:53, Michael Kelley (LINUX) wrote: > > From: Guilherme G. Piccoli Sent: Wednesday, April 27, > > 2022 > 3:49 PM > >> [...] > >> + panic_notifiers_level= > >> + [KNL] Set the panic notifiers ex

[PATCH] powerpc: Enable the DAWR on POWER9 DD2.3 and above

2022-05-03 Thread Reza Arbab
The hardware bug in POWER9 preventing use of the DAWR was fixed in DD2.3. Set the CPU_FTR_DAWR feature bit on these newer systems to start using it again, and update the documentation accordingly. The CPU features for DD2.3 are currently determined by "DD2.2 or later" logic. In adding DD2.3 as a d

Re: [PATCH v2] powerpc/rtas: Keep MSR[RI] set when calling RTAS

2022-05-03 Thread Laurent Dufour
On 03/05/2022, 18:16:29, Fabiano Rosas wrote: > Michael Ellerman writes: > >>> diff --git a/arch/powerpc/kernel/entry_64.S b/arch/powerpc/kernel/entry_64.S >>> index 9581906b5ee9..65cb14b56f8d 100644 >>> --- a/arch/powerpc/kernel/entry_64.S >>> +++ b/arch/powerpc/kernel/entry_64.S >>> @@ -330,22

Re: [PATCH v10 01/13] mm, hugetlbfs: Allow for "high" userspace addresses

2022-05-03 Thread Christophe Leroy
Le 09/04/2022 à 19:17, Christophe Leroy a écrit : > This is a complement of f6795053dac8 ("mm: mmap: Allow for "high" > userspace addresses") for hugetlb. > > This patch adds support for "high" userspace addresses that are > optionally supported on the system and have to be requested via a hint

Re: [PATCH 2/2] recordmcount: Handle sections with no non-weak symbols

2022-05-03 Thread Steven Rostedt
On Tue, 3 May 2022 11:20:22 + Christophe Leroy wrote: > Maybe I misunderstood. When you say 'after linking', do you mean vmlinux > or vmlinux.o ? Whichever ;-) > > In vmlinux, the addresses to be saved in __mcount_loc table might not > contain anymore a call to _mcount but a call to a tr

Re: [PATCH v2] powerpc/rtas: Keep MSR[RI] set when calling RTAS

2022-05-03 Thread Laurent Dufour
Thanks Michael for reviewing this. On 03/05/2022, 17:06:41, Michael Ellerman wrote: > Laurent Dufour writes: >> RTAS runs in real mode (MSR[DR] and MSR[IR] unset) and in 32bits >> mode (MSR[SF] unset). > > Probably also worth mentioning that it runs in big endian mode :) > > It is specified in

Re: [PATCH v2] powerpc/rtas: Keep MSR[RI] set when calling RTAS

2022-05-03 Thread Fabiano Rosas
Michael Ellerman writes: >> diff --git a/arch/powerpc/kernel/entry_64.S b/arch/powerpc/kernel/entry_64.S >> index 9581906b5ee9..65cb14b56f8d 100644 >> --- a/arch/powerpc/kernel/entry_64.S >> +++ b/arch/powerpc/kernel/entry_64.S >> @@ -330,22 +330,18 @@ _GLOBAL(enter_rtas) >> clrldi r4,r4,2

Re: [PATCH v2] powerpc/rtas: Keep MSR[RI] set when calling RTAS

2022-05-03 Thread Michael Ellerman
Laurent Dufour writes: > RTAS runs in real mode (MSR[DR] and MSR[IR] unset) and in 32bits > mode (MSR[SF] unset). Probably also worth mentioning that it runs in big endian mode :) It is specified in PAPR (R1-7.2.1-6). > The change in MSR is done in enter_rtas() in a relatively complex way, > si

Patch "perf symbol: Remove arch__symbols__fixup_end()" has been added to the 5.15-stable tree

2022-05-03 Thread gregkh
This is a note to let you know that I've just added the patch titled perf symbol: Remove arch__symbols__fixup_end() to the 5.15-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: perf-sy

Patch "perf symbol: Remove arch__symbols__fixup_end()" has been added to the 5.10-stable tree

2022-05-03 Thread gregkh
This is a note to let you know that I've just added the patch titled perf symbol: Remove arch__symbols__fixup_end() to the 5.10-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: perf-sy

Re: [PATCH for v5.15] perf symbol: Remove arch__symbols__fixup_end()

2022-05-03 Thread Greg KH
On Mon, May 02, 2022 at 05:37:36PM -0700, Namhyung Kim wrote: > Now the generic code can handle kallsyms fixup properly so no need to > keep the arch-functions anymore. > > Signed-off-by: Namhyung Kim > Acked-by: Ian Rogers > Cc: Heiko Carstens > Cc: Ingo Molnar > Cc: Jiri Olsa > Cc: John Gar

Re: [next] powerpc: multiple definition of `____cacheline_aligned'; sound/core/oss/pcm_oss.o:(.bss+0x40): first defined here

2022-05-03 Thread Christophe Leroy
Le 03/05/2022 à 15:10, Christophe Leroy a écrit : Le 29/04/2022 à 16:45, Naresh Kamboju a écrit : Following powerpc builds failed on Linux next-20220428 and next-20220429. Regressions found on powerpc:     - gcc-11-ppc64e_defconfig     - gcc-10-ppc64e_defconfig     - gcc-9-ppc64e_defconfig

Re: [PATCH 3/3] mm: rmap: Fix CONT-PTE/PMD size hugetlb issue when unmapping

2022-05-03 Thread Baolin Wang
On 5/3/2022 6:03 PM, Gerald Schaefer wrote: On Tue, 3 May 2022 10:19:46 +0800 Baolin Wang wrote: On 5/2/2022 10:02 PM, Gerald Schaefer wrote: On Sat, 30 Apr 2022 11:22:33 +0800 Baolin Wang wrote: On 4/30/2022 4:02 AM, Gerald Schaefer wrote: On Fri, 29 Apr 2022 16:14:43 +0800 Baolin

Re: [next] powerpc: multiple definition of `____cacheline_aligned'; sound/core/oss/pcm_oss.o:(.bss+0x40): first defined here

2022-05-03 Thread Christophe Leroy
Le 29/04/2022 à 16:45, Naresh Kamboju a écrit : > Following powerpc builds failed on Linux next-20220428 and next-20220429. > > Regressions found on powerpc: > - gcc-11-ppc64e_defconfig > - gcc-10-ppc64e_defconfig > - gcc-9-ppc64e_defconfig > - gcc-8-ppc64e_defconfig > - clan

Re: [PATCH] crypto: vmx - Align the short log with Makefile cleanups

2022-05-03 Thread kernel test robot
Hi Masahiro, I love your patch! Yet something to improve: [auto build test ERROR on herbert-crypto-2.6/master] [also build test ERROR on herbert-cryptodev-2.6/master powerpc/next v5.18-rc5 next-20220503] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting

Re: [PATCH 2/2] recordmcount: Handle sections with no non-weak symbols

2022-05-03 Thread Christophe Leroy
Le 03/05/2022 à 01:52, Steven Rostedt a écrit : > On Mon, 2 May 2022 14:44:56 + > Christophe Leroy wrote: > >> If we do that after the linking, won't it be a nightmare with the >> trampolines installed by the linker when the destination is over the 24 >> bits limit ? > > Not sure what you

Re: [PATCH 3/3] mm: rmap: Fix CONT-PTE/PMD size hugetlb issue when unmapping

2022-05-03 Thread Gerald Schaefer
On Tue, 3 May 2022 10:19:46 +0800 Baolin Wang wrote: > > > On 5/2/2022 10:02 PM, Gerald Schaefer wrote: > > On Sat, 30 Apr 2022 11:22:33 +0800 > > Baolin Wang wrote: > > > >> > >> > >> On 4/30/2022 4:02 AM, Gerald Schaefer wrote: > >>> On Fri, 29 Apr 2022 16:14:43 +0800 > >>> Baolin Wang wro