[PATCH] kvm: fix incorrect NULL check on list iterator

2022-03-26 Thread Xiaomeng Tong
The bug is here: if (!p) return ret; The list iterator value 'p' will *always* be set and non-NULL by list_for_each_entry(), so it is incorrect to assume that the iterator value will be NULL if the list is empty or no element is found. To fix the bug, Use a new value 'iter

Re: [PATCH 16/22] dvb-usb: Replace comments with C99 initializers

2022-03-26 Thread Mauro Carvalho Chehab
Em Sat, 26 Mar 2022 15:11:46 -0500 Larry Finger escreveu: > On 3/26/22 14:51, Joe Perches wrote: > > On Sat, 2022-03-26 at 19:27 +0100, Mauro Carvalho Chehab wrote: > >> Em Sat, 26 Mar 2022 19:24:54 +0100 > >> Mauro Carvalho Chehab escreveu: > >> > >>> Em Sat, 26 Mar 2022 17:59:03 +0100 > >>

Re: [PATCH 01/22] orion5x: Replace comments with C99 initializers

2022-03-26 Thread Arnd Bergmann
On Sat, Mar 26, 2022 at 5:58 PM Benjamin Stürz wrote: > > This replaces comments with C99's designated > initializers because the kernel supports them now. The change looks fine, but the comment looks misplaced, as enum initializers are not c99 feature. Also, the named array and struct intializer

Re: [PATCH 16/22] dvb-usb: Replace comments with C99 initializers

2022-03-26 Thread Larry Finger
On 3/26/22 14:51, Joe Perches wrote: On Sat, 2022-03-26 at 19:27 +0100, Mauro Carvalho Chehab wrote: Em Sat, 26 Mar 2022 19:24:54 +0100 Mauro Carvalho Chehab escreveu: Em Sat, 26 Mar 2022 17:59:03 +0100 Benjamin Stürz escreveu: This replaces comments with C99's designated initializers beca

Re: [PATCH 16/22] dvb-usb: Replace comments with C99 initializers

2022-03-26 Thread Joe Perches
On Sat, 2022-03-26 at 19:27 +0100, Mauro Carvalho Chehab wrote: > Em Sat, 26 Mar 2022 19:24:54 +0100 > Mauro Carvalho Chehab escreveu: > > > Em Sat, 26 Mar 2022 17:59:03 +0100 > > Benjamin Stürz escreveu: > > > > > This replaces comments with C99's designated > > > initializers because the kern

Re: [PATCH 02/22] s3c: Replace comments with C99 initializers

2022-03-26 Thread Joe Perches
On Sat, 2022-03-26 at 17:58 +0100, Benjamin Stürz wrote: > This replaces comments with C99's designated > initializers because the kernel supports them now. [] > diff --git a/arch/arm/mach-s3c/bast-irq.c b/arch/arm/mach-s3c/bast-irq.c [] > @@ -29,22 +29,22 @@ > * the irq is not implemented > */

Re: [PATCH 21/22] rtw89: Replace comments with C99 initializers

2022-03-26 Thread Larry Finger
On 3/26/22 11:59, Benjamin Stürz wrote: This replaces comments with C99's designated initializers because the kernel supports them now. Signed-off-by: Benjamin Stürz --- drivers/net/wireless/realtek/rtw89/coex.c | 40 +++ 1 file changed, 20 insertions(+), 20 deletions(-)

Re: [PATCH 16/22] dvb-usb: Replace comments with C99 initializers

2022-03-26 Thread Mauro Carvalho Chehab
Em Sat, 26 Mar 2022 19:24:54 +0100 Mauro Carvalho Chehab escreveu: > Em Sat, 26 Mar 2022 17:59:03 +0100 > Benjamin Stürz escreveu: > > > This replaces comments with C99's designated > > initializers because the kernel supports them now. > > > > Signed-off-by: Benjamin Stürz > > --- > > drive

Re: [PATCH 16/22] dvb-usb: Replace comments with C99 initializers

2022-03-26 Thread Mauro Carvalho Chehab
Em Sat, 26 Mar 2022 17:59:03 +0100 Benjamin Stürz escreveu: > This replaces comments with C99's designated > initializers because the kernel supports them now. > > Signed-off-by: Benjamin Stürz > --- > drivers/media/usb/dvb-usb/dibusb-mb.c | 62 +-- > drivers/media/usb/

Re: [PATCH 01/22] orion5x: Replace comments with C99 initializers

2022-03-26 Thread Mauro Carvalho Chehab
Em Sat, 26 Mar 2022 17:58:48 +0100 Benjamin Stürz escreveu: > This replaces comments with C99's designated > initializers because the kernel supports them now. Please: 1. Split this series per sub-system. It makes no sense to mailbomb all subsystems for things that won't belong there; 2. Ad

Re: [RFC PATCH 3/3] objtool/mcount: Add powerpc specific functions

2022-03-26 Thread Christophe Leroy
Le 21/03/2022 a 08:56, Christophe Leroy a ecrit : > > > Le 21/03/2022 a 03:27, Michael Ellerman a ecrit : >> Christophe Leroy writes: >>> Le 18/03/2022 a 13:26, Peter Zijlstra a ecrit : On Fri, Mar 18, 2022 at 04:21:40PM +0530, Sathvika Vasireddy wrote: > This patch adds powerpc specifi