Re: Bogus struct page layout on 32-bit

2021-04-09 Thread Jesper Dangaard Brouer
On Sat, 10 Apr 2021 03:43:13 +0100 Matthew Wilcox wrote: > On Sat, Apr 10, 2021 at 06:45:35AM +0800, kernel test robot wrote: > > >> include/linux/mm_types.h:274:1: error: static_assert failed due to > > >> requirement '__builtin_offsetof(struct page, lru) == > > >> __builtin_offsetof(struct fo

Bogus struct page layout on 32-bit

2021-04-09 Thread Matthew Wilcox
On Sat, Apr 10, 2021 at 06:45:35AM +0800, kernel test robot wrote: > >> include/linux/mm_types.h:274:1: error: static_assert failed due to > >> requirement '__builtin_offsetof(struct page, lru) == > >> __builtin_offsetof(struct folio, lru)' "offsetof(struct page, lru) == > >> offsetof(struct fol

Re: [PATCH v6 32/48] KVM: PPC: Book3S HV P9: Read machine check registers while MSR[RI] is 0

2021-04-09 Thread Nicholas Piggin
Excerpts from Alexey Kardashevskiy's message of April 9, 2021 6:55 pm: > > > On 05/04/2021 11:19, Nicholas Piggin wrote: >> SRR0/1, DAR, DSISR must all be protected from machine check which can >> clobber them. Ensure MSR[RI] is clear while they are live. >> >> Signed-off-by: Nicholas Piggin >>

Re: [PATCH v6 30/48] KVM: PPC: Book3S HV P9: Implement the rest of the P9 path in C

2021-04-09 Thread Nicholas Piggin
Excerpts from Alexey Kardashevskiy's message of April 9, 2021 1:57 pm: > > > On 05/04/2021 11:19, Nicholas Piggin wrote: >> Almost all logic is moved to C, by introducing a new in_guest mode for >> the P9 path that branches very early in the KVM interrupt handler to >> P9 exit code. >> >> The ma

Re: [PATCH v4] powerpc/traps: Enhance readability for trap types

2021-04-09 Thread Nicholas Piggin
Thanks for working on this, I think it's a nice cleanup and helps non-powerpc people understand the code a bit better. Excerpts from Xiongwei Song's message of April 10, 2021 12:28 am: > From: Xiongwei Song > > Create a new header named traps.h, define macros to list ppc interrupt > types in tra

Re: [PATCH v3] powerpc/traps: Enhance readability for trap types

2021-04-09 Thread Michael Ellerman
Christophe Leroy writes: > Le 08/04/2021 à 16:07, Xiongwei Song a écrit : >> From: Xiongwei Song >> >> Create a new header named traps.h, define macros to list ppc interrupt >> types in traps.h, replace the reference of the trap hex values with these >> macros. ... >> diff --git a/arch/powerpc/i

Re: [PATCH v2 1/1] kernel.h: Split out panic and oops helpers

2021-04-09 Thread Thomas Bogendoerfer
On Fri, Apr 09, 2021 at 01:02:50PM +0300, Andy Shevchenko wrote: > kernel.h is being used as a dump for all kinds of stuff for a long time. > Here is the attempt to start cleaning it up by splitting out panic and > oops helpers. > > There are several purposes of doing this: > - dropping dependency

Re: [PATCH v2 1/1] kernel.h: Split out panic and oops helpers

2021-04-09 Thread Helge Deller
On 4/9/21 12:02 PM, Andy Shevchenko wrote: kernel.h is being used as a dump for all kinds of stuff for a long time. Here is the attempt to start cleaning it up by splitting out panic and oops helpers. There are several purposes of doing this: - dropping dependency in bug.h - dropping a loop by m

Re: [PATCH v2 1/1] kernel.h: Split out panic and oops helpers

2021-04-09 Thread Luis Chamberlain
On Fri, Apr 09, 2021 at 01:02:50PM +0300, Andy Shevchenko wrote: > kernel.h is being used as a dump for all kinds of stuff for a long time. > Here is the attempt to start cleaning it up by splitting out panic and > oops helpers. > > There are several purposes of doing this: > - dropping dependency

Re: [PATCH v2 1/1] kernel.h: Split out panic and oops helpers

2021-04-09 Thread Stephen Boyd
Quoting Andy Shevchenko (2021-04-09 03:02:50) > kernel.h is being used as a dump for all kinds of stuff for a long time. > Here is the attempt to start cleaning it up by splitting out panic and > oops helpers. > > There are several purposes of doing this: > - dropping dependency in bug.h > - dropp

RE: [PATCH -next] soc: fsl: qe: use DEFINE_SPINLOCK() for spinlock

2021-04-09 Thread Leo Li
> -Original Message- > From: Ye Bin > Sent: Friday, April 9, 2021 4:52 AM > To: yebi...@huawei.com; Qiang Zhao ; Leo Li > > Cc: linuxppc-dev@lists.ozlabs.org; linux-arm-ker...@lists.infradead.org; > linux-ker...@vger.kernel.org; kernel-janit...@vger.kernel.org; Hulk Robot > > Subject:

[Bug 212631] Misaligned floating point loads and store occasionally fail

2021-04-09 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=212631 --- Comment #2 from Trevor Davenport (trevor_davenp...@selinc.com) --- A git bisect found this has existed for quite a while. git bisect start # bad: [0cc244011f40280b78fc344d5c2aac5a0c659f77] Linux 4.14.229 git bisect bad 0cc244011f40280b78fc34

Re: [PATCH v3] powerpc/traps: Enhance readability for trap types

2021-04-09 Thread Segher Boessenkool
On Fri, Apr 09, 2021 at 06:14:19PM +0200, Christophe Leroy wrote: > >+#define INTERRUPT_SYSTEM_RESET0x100 > > INT_SRESET SRESET exists on many PowerPC, it means "soft reset". Not the same thing at all. I think "INT" is not a great prefix fwiw, there are many things you can abbr to "INT". >

Re: [PATCHv5 2/2] powerpc/pseries: update device tree before ejecting hotplug uevents

2021-04-09 Thread Michal Suchánek
Hello, On Fri, Aug 28, 2020 at 04:10:09PM +0800, Pingfan Liu wrote: > On Thu, Aug 27, 2020 at 3:53 PM Laurent Dufour wrote: > > > > Le 10/08/2020 à 10:52, Pingfan Liu a écrit : > > > A bug is observed on pseries by taking the following steps on rhel: > > > -1. drmgr -c mem -r -q 5 > > > -2. echo

Re: [PATCH v3] powerpc/traps: Enhance readability for trap types

2021-04-09 Thread Christophe Leroy
Le 08/04/2021 à 16:07, Xiongwei Song a écrit : From: Xiongwei Song Create a new header named traps.h, define macros to list ppc interrupt types in traps.h, replace the reference of the trap hex values with these macros. Referred the hex number in arch/powerpc/kernel/exceptions-64e.S, arch/p

[Bug 212631] Misaligned floating point loads and store occasionally fail

2021-04-09 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=212631 --- Comment #1 from Trevor Davenport (trevor_davenp...@selinc.com) --- I can also reproduce this with kernel version 5.11.12. -- You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of

[Bug 212631] New: Misaligned floating point loads and store occasionally fail

2021-04-09 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=212631 Bug ID: 212631 Summary: Misaligned floating point loads and store occasionally fail Product: Platform Specific/Hardware Version: 2.5 Kernel Version: 5.4.110 Hardware: A

[PATCH v4] powerpc/traps: Enhance readability for trap types

2021-04-09 Thread Xiongwei Song
From: Xiongwei Song Create a new header named traps.h, define macros to list ppc interrupt types in traps.h, replace the references of the trap hex values with these macros. Referred the hex numbers in arch/powerpc/kernel/exceptions-64e.S, arch/powerpc/kernel/exceptions-64s.S and arch/powerpc/in

Re: [PATCH v2 1/1] kernel.h: Split out panic and oops helpers

2021-04-09 Thread Sebastian Reichel
Hi, On Fri, Apr 09, 2021 at 01:02:50PM +0300, Andy Shevchenko wrote: > kernel.h is being used as a dump for all kinds of stuff for a long time. > Here is the attempt to start cleaning it up by splitting out panic and > oops helpers. > > There are several purposes of doing this: > - dropping depen

[PATCH v2 1/1] kernel.h: Split out panic and oops helpers

2021-04-09 Thread Andy Shevchenko
kernel.h is being used as a dump for all kinds of stuff for a long time. Here is the attempt to start cleaning it up by splitting out panic and oops helpers. There are several purposes of doing this: - dropping dependency in bug.h - dropping a loop by moving out panic_notifier.h - unload kernel.h

Re: [PATCH] powerpc/perf: Fix PMU callbacks to clear pending PMI before resetting an overflown PMC

2021-04-09 Thread Athira Rajeev
> On 09-Apr-2021, at 6:38 AM, Nicholas Piggin wrote: > Hi Nick, Thanks for checking the patch and sharing review comments. > I was going to nitpick "overflown" here as something birds do, but some > sources says overflown is okay for past tense. > > You could use "overflowed" for that, but

Re: [PATCH 2/2] powerpc: make 'boot_text_mapped' static

2021-04-09 Thread Segher Boessenkool
Hi! On Thu, Apr 08, 2021 at 07:04:35AM +0200, Christophe Leroy wrote: > Le 08/04/2021 à 03:18, Yu Kuai a écrit : > >-int boot_text_mapped __force_data = 0; > >+static int boot_text_mapped __force_data; > > Are you sure the initialisation to 0 can be removed ? Usually > initialisation to 0 is not

Re: [PATCH v3 8/9] mm/mremap: Allow arch runtime override

2021-04-09 Thread Aneesh Kumar K.V
On 4/9/21 3:05 PM, Christophe Leroy wrote: Le 30/03/2021 à 08:07, Aneesh Kumar K.V a écrit : Architectures like ppc64 can only support faster mremap only with radix ... only only ... translation. Hence allow a runtime check w.r.t support for fast mremap. will fix that Signed-off-

[kbuild] Re: [PATCH net-next v2 1/2] of: net: pass the dst buffer to of_get_mac_address()

2021-04-09 Thread Dan Carpenter
Hi Michael, I love your patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Michael-Walle/of-net-support-non-platform-devices-in-of_get_mac_address/20210406-234030 base: https://git.kernel.org/pub/scm/linux/kerne

[PATCH RESEND v8 0/7] dt-bindings: usb: Harmonize xHCI/EHCI/OHCI/DWC3 nodes name

2021-04-09 Thread Serge Semin
As the subject states this series is an attempt to harmonize the xHCI, EHCI, OHCI and DWC USB3 DT nodes with the DT schema introduced in the framework of the patchset [1]. Firstly as Krzysztof suggested we've deprecated a support of DWC USB3 controllers with "synopsys,"-vendor prefix compatible st

[PATCH RESEND v8 3/7] powerpc: dts: akebono: Harmonize EHCI/OHCI DT nodes name

2021-04-09 Thread Serge Semin
In accordance with the Generic EHCI/OHCI bindings the corresponding node name is suppose to comply with the Generic USB HCD DT schema, which requires the USB nodes to have the name acceptable by the regexp: "^usb(@.*)?" . Make sure the "generic-ehci" and "generic-ohci"-compatible nodes are correctl

Re: [PATCH v4 18/20] x86: Convert to GENERIC_CMDLINE

2021-04-09 Thread Christophe Leroy
Le 08/04/2021 à 21:41, Rob Herring a écrit : On Fri, Apr 02, 2021 at 03:18:20PM +, Christophe Leroy wrote: This converts the architecture to GENERIC_CMDLINE. Signed-off-by: Christophe Leroy --- arch/x86/Kconfig| 45 ++--- arch/x86/kernel/se

Re: [PATCH 1/1] powerpc/smp: Set numa node before updating mask

2021-04-09 Thread Srikar Dronamraju
Hey Nathan, > > Regardless of your change: at boot time, this set of calls to > set_numa_node() and set_numa_mem() is redundant, right? Because > smp_prepare_cpus() has: > > for_each_possible_cpu(cpu) { > ... > if (cpu_present(cpu)) { > set_c

[PATCH -next] [POWERPC] Rename get_property to of_get_property: use DEFINE_SPINLOCK() for spinlock

2021-04-09 Thread Ye Bin
spinlock can be initialized automatically with DEFINE_SPINLOCK() rather than explicitly calling spin_lock_init(). Reported-by: Hulk Robot Signed-off-by: Ye Bin --- drivers/macintosh/via-pmu-led.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/macintosh/via-pmu-le

[PATCH -next] powerpc/pmac: Make some symbols static

2021-04-09 Thread Zucheng Zheng
ppc_override_l2cr/ppc_override_l2cr_value/has_l2cache symbol is not used outside of setup.c, so commit marks it static. Reported-by: Hulk Robot Signed-off-by: Zucheng Zheng --- arch/powerpc/platforms/powermac/setup.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch

[PATCH -next] powerpc/pmac: remove not use symbol

2021-04-09 Thread Zucheng Zheng
sccdbg symbol is not used, so remove it Reported-by: Hulk Robot Signed-off-by: Zucheng Zheng --- arch/powerpc/platforms/powermac/setup.c | 4 1 file changed, 4 deletions(-) diff --git a/arch/powerpc/platforms/powermac/setup.c b/arch/powerpc/platforms/powermac/setup.c index db5107c80485..

Re: [PATCH -next] [POWERPC] Rename get_property to of_get_property: use DEFINE_SPINLOCK() for spinlock

2021-04-09 Thread weiyongjun (A)
Rename get_property to of_get_property: use DEFINE_SPINLOCK() for spinlock ^ Please fix the module name in the patch subject. spinlock can be initialized automatically with DEFINE_SPINLOCK() rather than explicitly calling spin_lock_init(). Reported-by: Hulk Robot Signed-off-by:

Re: [PATCH -next] [POWERPC] Rename get_property to of_get_property: use DEFINE_SPINLOCK() for spinlock

2021-04-09 Thread weiyongjun (A)
Rename get_property to of_get_property: use DEFINE_SPINLOCK() for spinlock ~ 这是啥模块名? 在 2021/4/9 17:51, Ye Bin 写道: spinlock can be initialized automatically with DEFINE_SPINLOCK() rather than explicitly calling spin_lock_init(). Reported-by: Hulk Robot Signed-off-by: Ye Bin ---

[PATCH -next] soc: fsl: qe: use DEFINE_SPINLOCK() for spinlock

2021-04-09 Thread Ye Bin
spinlock can be initialized automatically with DEFINE_SPINLOCK() rather than explicitly calling spin_lock_init(). Reported-by: Hulk Robot Signed-off-by: Ye Bin --- drivers/soc/fsl/qe/qe_common.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/soc/fsl/qe/qe_common.c

[PATCH -next] macintosh/via-pmu: Use DEFINE_SPINLOCK() for spinlock

2021-04-09 Thread Ye Bin
spinlock can be initialized automatically with DEFINE_SPINLOCK() rather than explicitly calling spin_lock_init(). Reported-by: Hulk Robot Signed-off-by: Ye Bin --- drivers/macintosh/via-pmu.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/macintosh/via-pmu.c b/

Re: [PATCH v6 33/48] KVM: PPC: Book3S HV P9: Improve exit timing accounting coverage

2021-04-09 Thread Alexey Kardashevskiy
On 05/04/2021 11:19, Nicholas Piggin wrote: The C conversion caused exit timing to become a bit cramped. Expand it to cover more of the entry and exit code. Signed-off-by: Nicholas Piggin Reviewed-by: Alexey Kardashevskiy --- arch/powerpc/kvm/book3s_hv_interrupt.c | 8 1 fi

Re: [PATCH v3 8/9] mm/mremap: Allow arch runtime override

2021-04-09 Thread Christophe Leroy
Le 30/03/2021 à 08:07, Aneesh Kumar K.V a écrit : Architectures like ppc64 can only support faster mremap only with radix ... only only ... translation. Hence allow a runtime check w.r.t support for fast mremap. Signed-off-by: Aneesh Kumar K.V --- arch/arc/include/asm/tlb.h |

Re: [PATCH v3 5/9] powerpc/mm/book3s64: Update tlb flush routines to take a page walk cache flush argument

2021-04-09 Thread Christophe Leroy
Le 30/03/2021 à 08:07, Aneesh Kumar K.V a écrit : Signed-off-by: Aneesh Kumar K.V --- .../include/asm/book3s/64/tlbflush-radix.h| 19 --- arch/powerpc/include/asm/book3s/64/tlbflush.h | 23 +++ arch/powerpc/mm/book3s64/radix_hugetlbpage.c | 4 ++-- arch/

Re: [PATCH v3 4/9] powerpc/mm/book3s64: Fix possible build error

2021-04-09 Thread Christophe Leroy
Le 30/03/2021 à 08:07, Aneesh Kumar K.V a écrit : Update _tlbiel_pid() such that we can avoid build errors like below when using this function in other places. arch/powerpc/mm/book3s64/radix_tlb.c: In function ‘__radix__flush_tlb_range_psize’: arch/powerpc/mm/book3s64/radix_tlb.c:114:2: warn

[PATCH -next] powerpc/perf/hv-24x7: Make some symbols static

2021-04-09 Thread Bixuan Cui
The sparse tool complains as follows: arch/powerpc/perf/hv-24x7.c:229:1: warning: symbol '__pcpu_scope_hv_24x7_txn_flags' was not declared. Should it be static? arch/powerpc/perf/hv-24x7.c:230:1: warning: symbol '__pcpu_scope_hv_24x7_txn_err' was not declared. Should it be static? arch/powerpc/p

[PATCH -next] powerpc/perf: Make symbol 'isa207_pmu_format_attr' static

2021-04-09 Thread Bixuan Cui
The sparse tool complains as follows: arch/powerpc/perf/isa207-common.c:24:18: warning: symbol 'isa207_pmu_format_attr' was not declared. Should it be static? This symbol is not used outside of isa207-common.c, so this commit marks it static. Reported-by: Hulk Robot Signed-off-by: Bixuan Cui

[PATCH -next] powerpc/pseries/pmem: Make symbol 'drc_pmem_match' static

2021-04-09 Thread Bixuan Cui
The sparse tool complains as follows: arch/powerpc/platforms/pseries/pmem.c:142:27: warning: symbol 'drc_pmem_match' was not declared. Should it be static? This symbol is not used outside of pmem.c, so this commit marks it static. Reported-by: Hulk Robot Signed-off-by: Bixuan Cui --- arch/po

[PATCH -next] powerpc/pseries: Make symbol '__pcpu_scope_hcall_stats' static

2021-04-09 Thread Bixuan Cui
The sparse tool complains as follows: arch/powerpc/platforms/pseries/hvCall_inst.c:29:1: warning: symbol '__pcpu_scope_hcall_stats' was not declared. Should it be static? This symbol is not used outside of hvCall_inst.c, so this commit marks it static. Reported-by: Hulk Robot Signed-off-by: Bi

Re: [PATCH v6 32/48] KVM: PPC: Book3S HV P9: Read machine check registers while MSR[RI] is 0

2021-04-09 Thread Alexey Kardashevskiy
On 05/04/2021 11:19, Nicholas Piggin wrote: SRR0/1, DAR, DSISR must all be protected from machine check which can clobber them. Ensure MSR[RI] is clear while they are live. Signed-off-by: Nicholas Piggin --- arch/powerpc/kvm/book3s_hv.c | 11 +++-- arch/powerpc/kvm/book3s_hv

[PATCH] [V2]powerpc/dts: fix not include DTC_FLAGS

2021-04-09 Thread Youlin Song
A central rule exists to create `$(obj)/%.dtb` from `$(src)/%.dts`,DTC_FLAGS flag must be used with it. See other architecture and Documentation: arch/microblaze/boot/dts/Makefile Documentation/kbuild/makefiles.rst +1433 Signed-off-by: Youlin Song --- arch/powerpc/boot/Makefile | 2 -- arch/

Re: [PATCH v1 1/1] kernel.h: Split out panic and oops helpers

2021-04-09 Thread Andy Shevchenko
On Thu, Apr 08, 2021 at 11:23:03PM -0700, Andrew Morton wrote: > On Wed, 7 Apr 2021 11:46:37 +0300 Andy Shevchenko > wrote: > > > On Wed, Apr 7, 2021 at 11:17 AM Kees Cook wrote: > > > > > > On Tue, Apr 06, 2021 at 04:31:58PM +0300, Andy Shevchenko wrote: > > > > kernel.h is being used as a dum

Re: [PATCH] powerpc/dts: fix not include DTC_FLAGS

2021-04-09 Thread Sam Song
In my test, DTC_FLAGS in arch/powerpc/boot/Makefile is not to work,I will send V2 to removing it. Michael Ellerman 于2021年4月7日周三 下午7:27写道: > Youlin Song writes: > > I wanted to build the fsl dts in my machine and found that > > the dtb have not extra space,so uboot will cause about > > FDT_ERR_

Re: [PATCH v2 2/4] powerpc/selftests/perf-hwbreak: Coalesce event creation code

2021-04-09 Thread Daniel Axtens
Hi Ravi, > perf-hwbreak selftest opens hw-breakpoint event at multiple places for > which it has same code repeated. Coalesce that code into a function. > > Signed-off-by: Ravi Bangoria > --- > .../selftests/powerpc/ptrace/perf-hwbreak.c | 78 +-- This doesn't simplify things v

[PATCH -next] powerpc/powernv: make symbol 'mpipl_kobj' static

2021-04-09 Thread Bixuan Cui
The sparse tool complains as follows: arch/powerpc/platforms/powernv/opal-core.c:74:16: warning: symbol 'mpipl_kobj' was not declared. This symbol is not used outside of opal-core.c, so marks it static. Reported-by: Hulk Robot Signed-off-by: Bixuan Cui --- arch/powerpc/platforms/powernv/opal

[PATCH -next] powerpc/xmon: Make symbol 'spu_inst_dump' static

2021-04-09 Thread Pu Lehui
Fix sparse warning: arch/powerpc/xmon/xmon.c:4216:1: warning: symbol 'spu_inst_dump' was not declared. Should it be static? This symbol is not used outside of xmon.c, so make it static. Signed-off-by: Pu Lehui --- arch/powerpc/xmon/xmon.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-