Re: [PATCH kernel] powerpc/iommu: Annotate nested lock for lockdep

2021-02-19 Thread Alexey Kardashevskiy
On 18/02/2021 23:59, Frederic Barrat wrote: On 16/02/2021 04:20, Alexey Kardashevskiy wrote: The IOMMU table is divided into pools for concurrent mappings and each pool has a separate spinlock. When taking the ownership of an IOMMU group to pass through a device to a VM, we lock these spinl

Re: [PATCH RFC v1 5/6] xen-swiotlb: convert variables to arrays

2021-02-19 Thread Boris Ostrovsky
On 2/19/21 3:32 PM, Konrad Rzeszutek Wilk wrote: > On Sun, Feb 07, 2021 at 04:56:01PM +0100, Christoph Hellwig wrote: >> On Thu, Feb 04, 2021 at 09:40:23AM +0100, Christoph Hellwig wrote: >>> So one thing that has been on my mind for a while: I'd really like >>> to kill the separate dma ops in X

[PATCH v2] powerpc/kexec_file: Restore FDT size estimation for kdump kernel

2021-02-19 Thread Thiago Jung Bauermann
c/kexec/file_load_64.c | 26 -- 3 files changed, 10 insertions(+), 20 deletions(-) Applies on top of next-20210219. Changes since v1: - Adjusted comment describing kexec_extra_fdt_size_ppc64() as suggested by Lakshmi. diff --git a/arch/powerpc/include/asm/kexec.h b/arch

Re: [PATCH RFC v1 5/6] xen-swiotlb: convert variables to arrays

2021-02-19 Thread Konrad Rzeszutek Wilk
On Sun, Feb 07, 2021 at 04:56:01PM +0100, Christoph Hellwig wrote: > On Thu, Feb 04, 2021 at 09:40:23AM +0100, Christoph Hellwig wrote: > > So one thing that has been on my mind for a while: I'd really like > > to kill the separate dma ops in Xen swiotlb. If we compare xen-swiotlb > > to swiotlb

Re: [PATCH] powerpc/kexec_file: Restore FDT size estimation for kdump kernel

2021-02-19 Thread Thiago Jung Bauermann
Lakshmi Ramasubramanian writes: > On 2/19/21 6:25 AM, Thiago Jung Bauermann wrote: > > One small nit in the function header (please see below), but otherwise the > change looks good. > > Reviewed-by: Lakshmi Ramasubramanian Thanks for your review. I incorporated your suggestion and will send

[PATCH 8/9] ASoC: fsl: mpc8610: remove useless assignment

2021-02-19 Thread Pierre-Louis Bossart
cppcheck warning: sound/soc/fsl/mpc8610_hpcd.c:333:6: style: Redundant initialization for 'ret'. The initialized value is overwritten before it is read. [redundantInitialization] ret = fsl_asoc_get_dma_channel(np, "fsl,playback-dma", ^ sound/soc/fsl/mpc8610_hpcd.c:193:10: note: ret is initia

[PATCH 6/9] ASoC: fsl: imx-hdmi: remove unused structure members

2021-02-19 Thread Pierre-Louis Bossart
cppcheck warning: sound/soc/fsl/imx-hdmi.c:21:16: style: struct member 'cpu_priv::sysclk_freq' is never used. [unusedStructMember] unsigned long sysclk_freq[2]; ^ Additional checks show the sysclk_dir member is also not used. Signed-off-by: Pierre-Louis Bossart --- sound/soc/fs

[PATCH 5/9] ASoC: fsl: fsl_ssi: remove unnecessary tests

2021-02-19 Thread Pierre-Louis Bossart
cppcheck warnings: sound/soc/fsl/fsl_ssi.c:767:34: style: Condition 'div2' is always false [knownConditionTrueFalse] stccr = SSI_SxCCR_PM(pm + 1) | (div2 ? SSI_SxCCR_DIV2 : 0) | ^ sound/soc/fsl/fsl_ssi.c:722:9: note: Assignment 'div2=0', assigned value is 0 div2

[PATCH 4/9] ASoC: fsl: fsl_esai: clarify expression

2021-02-19 Thread Pierre-Louis Bossart
cppcheck warning: sound/soc/fsl/fsl_esai.c:307:16: style: Clarify calculation precedence for '%' and '?'. [clarifyCalculation] clk_id % 2 ? "extal" : "fsys"); ^ Signed-off-by: Pierre-Louis Bossart --- sound/soc/fsl/fsl_esai.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH 3/9] ASoC: fsl: fsl_easrc: remove useless assignments

2021-02-19 Thread Pierre-Louis Bossart
cppcheck warnings: sound/soc/fsl/fsl_easrc.c:751:53: style: Variable 'st2_mem_alloc' is assigned a value that is never used. [unreadVariable] int st1_chanxexp, st1_mem_alloc = 0, st2_mem_alloc = 0; ^ sound/soc/fsl/fsl_easrc.c:1331:11: style: Var

[PATCH 2/9] ASoC: fsl: fsl_dma: remove unused variable

2021-02-19 Thread Pierre-Louis Bossart
cppcheck warning: sound/soc/fsl/fsl_dma.c:411:10: style: Variable 'channel' is assigned a value that is never used. [unreadVariable] channel = substream->stream == SNDRV_PCM_STREAM_PLAYBACK ? 0 : 1; ^ Removing this line shows the variable isn't needed any longer so remove declaration a

[PATCH 1/9] ASoC: fsl: fsl_asrc: remove useless assignment

2021-02-19 Thread Pierre-Louis Bossart
cppcheck warning: sound/soc/fsl/fsl_asrc.c:613:8: style: Variable 'i' is assigned a value that is never used. [unreadVariable] int i = 0, j = 0; ^ The same issue occurs for the 'j' variable. Signed-off-by: Pierre-Louis Bossart --- sound/soc/fsl/fsl_asrc.c | 2 +- 1 file changed, 1 inse

Re: [PATCH 3/8] xen-swiotlb: use io_tlb_end in xen_swiotlb_dma_supported

2021-02-19 Thread Konrad Rzeszutek Wilk
On Sun, Feb 07, 2021 at 05:09:29PM +0100, Christoph Hellwig wrote: > Use the existing variable that holds the physical address for > xen_io_tlb_end to simplify xen_swiotlb_dma_supported a bit, and remove > the otherwise unused xen_io_tlb_end variable and the xen_virt_to_bus > helper. > Reviewed-by

Re: [PATCH 2/8] xen-swiotlb: use is_swiotlb_buffer in is_xen_swiotlb_buffer

2021-02-19 Thread Konrad Rzeszutek Wilk
On Sun, Feb 07, 2021 at 05:09:28PM +0100, Christoph Hellwig wrote: > Use the is_swiotlb_buffer to check if a physical address is > a swiotlb buffer. This works because xen-swiotlb does use the > same buffer as the main swiotlb code, and xen_io_tlb_{start,end} > are just the addresses for it that w

Re: [PATCH] of: error: 'const struct kimage' has no member named 'arch'

2021-02-19 Thread Lakshmi Ramasubramanian
On 2/19/21 10:09 AM, Thiago Jung Bauermann wrote: Mimi Zohar writes: On Fri, 2021-02-19 at 11:43 -0600, Rob Herring wrote: On Fri, Feb 19, 2021 at 10:57 AM Lakshmi Ramasubramanian wrote: On 2/19/21 6:16 AM, Rob Herring wrote: On Thu, Feb 18, 2021 at 8:53 PM Lakshmi Ramasubramanian wrote

Re: [PATCH] of: error: 'const struct kimage' has no member named 'arch'

2021-02-19 Thread Thiago Jung Bauermann
Mimi Zohar writes: > On Fri, 2021-02-19 at 11:43 -0600, Rob Herring wrote: >> On Fri, Feb 19, 2021 at 10:57 AM Lakshmi Ramasubramanian >> wrote: >> > >> > On 2/19/21 6:16 AM, Rob Herring wrote: >> > > On Thu, Feb 18, 2021 at 8:53 PM Lakshmi Ramasubramanian >> > > wrote: >> > >> >> > >> On 2/1

Re: [PATCH] of: error: 'const struct kimage' has no member named 'arch'

2021-02-19 Thread Mimi Zohar
On Fri, 2021-02-19 at 11:43 -0600, Rob Herring wrote: > On Fri, Feb 19, 2021 at 10:57 AM Lakshmi Ramasubramanian > wrote: > > > > On 2/19/21 6:16 AM, Rob Herring wrote: > > > On Thu, Feb 18, 2021 at 8:53 PM Lakshmi Ramasubramanian > > > wrote: > > >> > > >> On 2/18/21 5:13 PM, Thiago Jung Bauerma

Re: [PATCH] of: error: 'const struct kimage' has no member named 'arch'

2021-02-19 Thread Rob Herring
On Fri, Feb 19, 2021 at 10:57 AM Lakshmi Ramasubramanian wrote: > > On 2/19/21 6:16 AM, Rob Herring wrote: > > On Thu, Feb 18, 2021 at 8:53 PM Lakshmi Ramasubramanian > > wrote: > >> > >> On 2/18/21 5:13 PM, Thiago Jung Bauermann wrote: > >>> > >>> Lakshmi Ramasubramanian writes: > >>> > On

[PATCH] powerpc/mm: Move the linear_mapping_mutex to the ifdef where it is used

2021-02-19 Thread Sebastian Andrzej Siewior
The mutex linear_mapping_mutex is defined at the of the file while its only two user are within the CONFIG_MEMORY_HOTPLUG block. A compile without CONFIG_MEMORY_HOTPLUG set fails on PREEMPT_RT because its mutex implementation is smart enough to realize that it is unused. Move the definition of lin

Re: [PATCH] of: error: 'const struct kimage' has no member named 'arch'

2021-02-19 Thread Lakshmi Ramasubramanian
On 2/19/21 6:16 AM, Rob Herring wrote: On Thu, Feb 18, 2021 at 8:53 PM Lakshmi Ramasubramanian wrote: On 2/18/21 5:13 PM, Thiago Jung Bauermann wrote: Lakshmi Ramasubramanian writes: On 2/18/21 4:07 PM, Mimi Zohar wrote: Hi Mimi, On Thu, 2021-02-18 at 14:33 -0800, Lakshmi Ramasubramani

Re: [PATCH] powerpc/kexec_file: Restore FDT size estimation for kdump kernel

2021-02-19 Thread Lakshmi Ramasubramanian
w doing. Signed-off-by: Thiago Jung Bauermann --- arch/powerpc/include/asm/kexec.h | 2 +- arch/powerpc/kexec/elf_64.c | 2 +- arch/powerpc/kexec/file_load_64.c | 26 -- 3 files changed, 10 insertions(+), 20 deletions(-) Applies on top of next-20210219. diff

Re: [PATCH] of: error: 'const struct kimage' has no member named 'arch'

2021-02-19 Thread Mimi Zohar
On Fri, 2021-02-19 at 11:08 -0300, Thiago Jung Bauermann wrote: > Lakshmi Ramasubramanian writes: > > > On 2/18/21 5:13 PM, Thiago Jung Bauermann wrote: > >> Lakshmi Ramasubramanian writes: > >> > >>> On 2/18/21 4:07 PM, Mimi Zohar wrote: > >>> > >>> Hi Mimi, > >>> > On Thu, 2021-02-18 at

[PATCH] powerpc/kexec_file: Restore FDT size estimation for kdump kernel

2021-02-19 Thread Thiago Jung Bauermann
- 3 files changed, 10 insertions(+), 20 deletions(-) Applies on top of next-20210219. diff --git a/arch/powerpc/include/asm/kexec.h b/arch/powerpc/include/asm/kexec.h index baab158e215c..5a11cc8d2350 100644 --- a/arch/powerpc/include/asm/kexec.h +++ b/arch/powerpc/include/asm/kexe

Re: [PATCH] of: error: 'const struct kimage' has no member named 'arch'

2021-02-19 Thread Rob Herring
On Thu, Feb 18, 2021 at 8:53 PM Lakshmi Ramasubramanian wrote: > > On 2/18/21 5:13 PM, Thiago Jung Bauermann wrote: > > > > Lakshmi Ramasubramanian writes: > > > >> On 2/18/21 4:07 PM, Mimi Zohar wrote: > >> > >> Hi Mimi, > >> > >>> On Thu, 2021-02-18 at 14:33 -0800, Lakshmi Ramasubramanian wrote

Re: [PATCH] of: error: 'const struct kimage' has no member named 'arch'

2021-02-19 Thread Thiago Jung Bauermann
Lakshmi Ramasubramanian writes: > On 2/18/21 5:13 PM, Thiago Jung Bauermann wrote: >> Lakshmi Ramasubramanian writes: >> >>> On 2/18/21 4:07 PM, Mimi Zohar wrote: >>> >>> Hi Mimi, >>> On Thu, 2021-02-18 at 14:33 -0800, Lakshmi Ramasubramanian wrote: > of_kexec_alloc_and_setup_fdt() d

Re: [PATCH v12 13/14] mm/vmalloc: Hugepage vmalloc mappings

2021-02-19 Thread Ding Tianhong
On 2021/2/19 15:45, Nicholas Piggin wrote: > Excerpts from Ding Tianhong's message of February 19, 2021 1:45 pm: >> Hi Nicholas: >> >> I met some problem for this patch, like this: >> >> kva = vmalloc(3*1024k); >> >> remap_vmalloc_range(xxx, kva, xxx) >> >> It failed because that the check for page

Re: [RFC PATCH 1/9] KVM: PPC: Book3S 64: move KVM interrupt entry to a common entry point

2021-02-19 Thread Nicholas Piggin
Excerpts from Daniel Axtens's message of February 19, 2021 3:18 pm: > Hi Nick, > >> +++ b/arch/powerpc/kvm/book3s_64_entry.S >> @@ -0,0 +1,34 @@ >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> + >> +/* >> + * We come here from the first-level interrupt handle