Re: [PATCH v3 05/19] powerpc: interrupt handler wrapper functions

2020-11-29 Thread Aneesh Kumar K.V
Nicholas Piggin writes: . +#endif > +DECLARE_INTERRUPT_HANDLER(emulation_assist_interrupt); > +DECLARE_INTERRUPT_HANDLER_RAW(do_slb_fault); Can we add comments here explaining why some of these handlers need to remain RAW()? > +DECLARE_INTERRUPT_HANDLER(do_bad_slb_fault); > +DECLARE_INTER

Re: [PATCH v3 03/19] powerpc: bad_page_fault, do_break get registers from regs

2020-11-29 Thread Aneesh Kumar K.V
Nicholas Piggin writes: > Similar to the previous patch this makes interrupt handler function > types more regular so they can be wrapped with the next patch. > > bad_page_fault and do_break are not performance critical. > Reviewed-by: Aneesh Kumar K.V > [32s DABR code from Christophe Leroy ]

Re: [PATCH v3 02/19] powerpc: remove arguments from fault handler functions

2020-11-29 Thread Aneesh Kumar K.V
Nicholas Piggin writes: > Make mm fault handlers all just take the pt_regs * argument and load > DAR/DSISR from that. Make those that return a value return long. > > This is done to make the function signatures match other handlers, which > will help with a future patch to add wrappers. Explicit

Re: [PATCH v3 01/19] powerpc/64s: move the last of the page fault handling logic to C

2020-11-29 Thread Aneesh Kumar K.V
Nicholas Piggin writes: > The page fault handling still has some complex logic particularly around > hash table handling, in asm. Implement this in C instead. > Reviewed-by: Aneesh Kumar K.V > Signed-off-by: Nicholas Piggin > --- > arch/powerpc/include/asm/book3s/64/mmu-hash.h | 1 + > arc

Re: [PATCH 2/3] powerpc/pseries/hotplug-cpu: fix memleak in dlpar_cpu_add_by_count

2020-11-29 Thread Qinglang Miao
在 2020/11/30 9:51, Michael Ellerman 写道: Qinglang Miao writes: kfree(cpu_drcs) should be called when it fails to perform of_find_node_by_path("/cpus") in dlpar_cpu_add_by_count, otherwise there would be a memleak. In fact, the patch a0ff72f9f5a7 ought to remove kfree in find_dlpar_cpus_to_ad

Re: [PATCH] powerpc: Allow relative pointers in bug table entries

2020-11-29 Thread Christophe Leroy
Le 30/11/2020 à 02:50, Jordan Niethe a écrit : On Mon, Nov 30, 2020 at 12:42 PM Michael Ellerman wrote: Christophe Leroy writes: Le 27/11/2020 à 04:02, Jordan Niethe a écrit : This enables GENERIC_BUG_RELATIVE_POINTERS on Power so that 32-bit offsets are stored in the bug entries rather

Re: [PATCH 1/8] powerpc/64s/powernv: Fix memory corruption when saving SLB entries on MCE

2020-11-29 Thread Mahesh J Salgaonkar
On 2020-11-28 17:07:21 Sat, Nicholas Piggin wrote: > This can be hit by an HPT guest running on an HPT host and bring down > the host, so it's quite important to fix. > > Fixes: 7290f3b3d3e66 ("powerpc/64s/powernv: machine check dump SLB contents") > Signed-off-by: Nicholas Piggin > --- > arch/p

[PATCH] powerpc/xmon: Fix build failure for 8xx

2020-11-29 Thread Ravi Bangoria
With CONFIG_PPC_8xx and CONFIG_XMON set, kernel build fails with arch/powerpc/xmon/xmon.c:1379:12: error: 'find_free_data_bpt' defined but not used [-Werror=unused-function] Fix it by enclosing find_free_data_bpt() inside #ifndef CONFIG_PPC_8xx. Reported-by: kernel test robot Fixes: 30df74d

Re: [RFC PATCH] KVM: PPC: Book3S HV: Remove support for running HPT guest on RPT host without mixed mode support

2020-11-29 Thread Michael Ellerman
Nicholas Piggin writes: > This reverts much of commit c01015091a770 ("KVM: PPC: Book3S HV: Run HPT > guests on POWER9 radix hosts"), which was required to run HPT guests on > RPT hosts on early POWER9 CPUs without support for "mixed mode", which > meant the host could not run with MMU on while gue

Re: [PATCH 2/3] powerpc/pseries/hotplug-cpu: fix memleak in dlpar_cpu_add_by_count

2020-11-29 Thread Michael Ellerman
Qinglang Miao writes: > kfree(cpu_drcs) should be called when it fails to perform > of_find_node_by_path("/cpus") in dlpar_cpu_add_by_count, > otherwise there would be a memleak. > > In fact, the patch a0ff72f9f5a7 ought to remove kfree in > find_dlpar_cpus_to_add rather than dlpar_cpu_add_by_coun

Re: [PATCH] powerpc: Allow relative pointers in bug table entries

2020-11-29 Thread Jordan Niethe
On Mon, Nov 30, 2020 at 12:42 PM Michael Ellerman wrote: > > Christophe Leroy writes: > > Le 27/11/2020 à 04:02, Jordan Niethe a écrit : > >> This enables GENERIC_BUG_RELATIVE_POINTERS on Power so that 32-bit > >> offsets are stored in the bug entries rather than 64-bit pointers. > >> > >> Signed

[Bug 204789] Boot failure with more than 256G of memory on Power9 with 4K pages & Hash MMU

2020-11-29 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=204789 --- Comment #14 from Michael Ellerman (mich...@ellerman.id.au) --- The fix is: 7746406baa3b ("powerpc/book3s64/hash/4k: Support large linear mapping range with 4K") -- You are receiving this mail because: You are watching the assignee of the b

Re: [PATCH] powerpc: Allow relative pointers in bug table entries

2020-11-29 Thread Michael Ellerman
Christophe Leroy writes: > Le 27/11/2020 à 04:02, Jordan Niethe a écrit : >> This enables GENERIC_BUG_RELATIVE_POINTERS on Power so that 32-bit >> offsets are stored in the bug entries rather than 64-bit pointers. >> >> Signed-off-by: Jordan Niethe >> --- >> arch/powerpc/Kconfig | 4

[Bug 209869] Kernel 5.10-rc1 fails to boot on a PowerMac G4 3,6 at an early stage

2020-11-29 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=209869 Michael Ellerman (mich...@ellerman.id.au) changed: What|Removed |Added Status|RESOLVED|CLOSED --- Co

Re: [PATCH] powerpc: Allow relative pointers in bug table entries

2020-11-29 Thread Jordan Niethe
On Sun, Nov 29, 2020 at 6:00 AM Christophe Leroy wrote: > > > > Le 27/11/2020 à 04:02, Jordan Niethe a écrit : > > This enables GENERIC_BUG_RELATIVE_POINTERS on Power so that 32-bit > > offsets are stored in the bug entries rather than 64-bit pointers. > > > > Signed-off-by: Jordan Niethe > > ---

Re: [PATCH] powerpc: fix the allyesconfig build

2020-11-29 Thread Yunsheng Lin
On 2020/11/29 3:36, Jakub Kicinski wrote: > On Sat, 28 Nov 2020 16:20:54 +1100 Stephen Rothwell wrote: >> On Fri, 27 Nov 2020 17:56:42 -0800 Jakub Kicinski wrote: >>> >>> What's the offending structure in hisilicon? I'd rather have a look >>> packing structs with pointers in 'em sounds questionabl

[PATCH] powerpc/64: Fix an EMIT_BUG_ENTRY in head_64.S

2020-11-29 Thread Jordan Niethe
Commit 63ce271b5e37 ("powerpc/prom: convert PROM_BUG() to standard trap") added an EMIT_BUG_ENTRY for the trap after the branch to start_kernel(). The EMIT_BUG_ENTRY was for the address "0b", however the trap was not labeled with "0". Hence the address used for bug is in relative_toc() where the pr

[net-next PATCH] net: freescale: ucc_geth: remove unused SKB_ALLOC_TIMEOUT

2020-11-29 Thread Chris Packham
This was added in commit ce973b141dfa ("[PATCH] Freescale QE UCC gigabit ethernet driver") but doesn't appear to have been used. Remove it now. Signed-off-by: Chris Packham --- drivers/net/ethernet/freescale/ucc_geth.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/frees

[PATCH v6 5/5] PCI: xgene: Removed unused ".bus_shift" initialisers from pci-xgene.c

2020-11-29 Thread Krzysztof Wilczyński
Removed unused ".bus_shift" initialisers from pci-xgene.c as xgene_pcie_map_bus() did not use these. Suggested-by: Bjorn Helgaas Signed-off-by: Krzysztof Wilczyński --- drivers/pci/controller/pci-xgene.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/pci/controller/pci-xgene.c b/

[PATCH v6 4/5] PCI: vmd: Update type of the __iomem pointers

2020-11-29 Thread Krzysztof Wilczyński
Use "void __iomem" instead "char __iomem" pointer type when working with the accessor functions (with names like readb() or writel(), etc.) to better match a given accessor function signature where commonly the address pointing to an I/O memory region would be a "void __iomem" pointer. Related:

[PATCH v6 3/5] PCI: iproc: Convert to use the new ECAM constants

2020-11-29 Thread Krzysztof Wilczyński
Change interface of the function iproc_pcie_map_ep_cfg_reg() so that use of PCI_SLOT() and PCI_FUNC() macros and most of the local ECAM-specific constants can be dropped, and the new PCIE_ECAM_OFFSET() macro can be used instead. Use the ALIGN_DOWN() macro to ensure that PCI Express ECAM offset is

[PATCH v6 2/5] PCI: thunder-pem: Add constant for custom ".bus_shit" initialiser

2020-11-29 Thread Krzysztof Wilczyński
Add a custom constant for the ".bus_shit" initialiser to capture a non-standard platform-specific ECAM bus shift value. Standard values otherwise defined in the PCI Express Specification are available in the include/linux/pci-ecam.h. Suggested-by: Bjorn Helgaas Signed-off-by: Krzysztof Wilczyńsk

[PATCH v6 0/5] PCI: Unify ECAM constants in native PCI Express drivers

2020-11-29 Thread Krzysztof Wilczyński
Unify ECAM-related constants into a single set of standard constants defining memory address shift values for the byte-level address that can be used when accessing the PCI Express Configuration Space, and then move native PCI Express controller drivers to use newly introduced definitions retiring

[PATCH v6 1/5] PCI: Unify ECAM constants in native PCI Express drivers

2020-11-29 Thread Krzysztof Wilczyński
Add ECAM-related constants to provide a set of standard constants defining memory address shift values to the byte-level address that can be used to access the PCI Express Configuration Space, and then move native PCI Express controller drivers to use the newly introduced definitions retiring drive

Re: [PATCH 6/8] lazy tlb: shoot lazies, a non-refcounting lazy tlb option

2020-11-29 Thread Andy Lutomirski
On Sat, Nov 28, 2020 at 7:54 PM Andy Lutomirski wrote: > > On Sat, Nov 28, 2020 at 8:02 AM Nicholas Piggin wrote: > > > > On big systems, the mm refcount can become highly contented when doing > > a lot of context switching with threaded applications (particularly > > switching between the idle t

Re: [PATCH 8/8] net: ethernet: ibm: ibmvnic: Fix some kernel-doc issues

2020-11-29 Thread Andrew Lunn
On Thu, Nov 26, 2020 at 01:38:53PM +, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > from drivers/net/ethernet/ibm/ibmvnic.c:35: > inlined from ‘handle_vpd_rsp’ at drivers/net/ethernet/ibm/ibmvnic.c:4124:3: > drivers/net/ethernet/ibm/ibmvnic.c:1362: warning: Functio

Re: [PATCH 6/8] net: ethernet: toshiba: ps3_gelic_net: Fix some kernel-doc misdemeanours

2020-11-29 Thread Andrew Lunn
On Thu, Nov 26, 2020 at 01:38:51PM +, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/net/ethernet/toshiba/ps3_gelic_net.c:1107: warning: Function > parameter or member 'irq' not described in 'gelic_card_interrupt' > drivers/net/ethernet/toshiba/ps3_gelic_net

Re: [PATCH 5/8] net: ethernet: ibm: ibmvnic: Fix some kernel-doc misdemeanours

2020-11-29 Thread Andrew Lunn
Hi Lee > /** > * build_hdr_data - creates L2/L3/L4 header data buffer > - * @hdr_field - bitfield determining needed headers > - * @skb - socket buffer > - * @hdr_len - array of header lengths > - * @tot_len - total length of data > + * @hdr_field: bitfield determining needed headers > + * @skb

Re: [PATCH 2/2] powerpc/ps3: make system bus's remove and shutdown callbacks return void

2020-11-29 Thread Uwe Kleine-König
Hello Michael, On Sat, Nov 28, 2020 at 09:48:30AM +0100, Takashi Iwai wrote: > On Thu, 26 Nov 2020 17:59:50 +0100, > Uwe Kleine-König wrote: > > > > The driver core ignores the return value of struct device_driver::remove > > because there is only little that can be done. For the shutdown callbac

Re: Kernel 5.10-rc4 doesn't boot

2020-11-29 Thread Elimar Riesebieter
Hi all, * Christophe Leroy [2020-11-29 08:37 +0100]: [...] > Try following commit: > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=01776f070ffcbf336be3bf1672bd3c589548d6c4 I can confirm that this commit patched at 5.10-rc5 made the kernel boot again :-) Thanks