[PATCH] macintosh: windfarm: Use NULL to compare with pointer-typed value rather than 0

Compare pointer-typed values to NULL rather than 0. Signed-off-by: Xu Wang --- drivers/macintosh/windfarm_pm121.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/macintosh/windfarm_pm121.c b/drivers/macintosh/windfarm_pm121.c index ab467b9c31be..62826844b584 1006

Re: [PATCH 11/25] soc: fsl: qe: qe_common: Fix misnamed function attribute 'addr'

On Thu, 12 Nov 2020, Leo Li wrote: > > > > -Original Message- > > From: Lee Jones > > Sent: Thursday, November 12, 2020 4:33 AM > > To: linux-arm-ker...@lists.infradead.org; linux-ker...@vger.kernel.org; > > Qiang Zhao ; Leo Li ; Scott > > Wood ; act ; Dan Malek > > ; Software, Inc ; Vi

Re: [PATCH v4 01/18] dt-bindings: usb: usb-hcd: Detach generic USB controller properties

On Wed, 2020-11-11 at 12:08 +0300, Serge Semin wrote: > There can be three distinctive types of the USB controllers: USB hosts, > USB peripherals/gadgets and USB OTG, which can switch from one role to > another. In order to have that hierarchy handled in the DT binding files, > we need to collect c

Re: [PATCH net-next 12/12] ibmvnic: Do not replenish RX buffers after every polling loop

On 2020-11-12 11:10, Thomas Falcon wrote: From: "Dwip N. Banerjee" Reduce the amount of time spent replenishing RX buffers by only doing so once available buffers has fallen under a certain threshold, in this case half of the total number of buffers, or if the polling loop exits before the pack

Re: [PATCH net-next 01/12] ibmvnic: Ensure that subCRQ entry reads are ordered

On 2020-11-12 11:09, Thomas Falcon wrote: Ensure that received Subordinate Command-Response Queue entries are properly read in order by the driver. Signed-off-by: Thomas Falcon Acked-by: Dany Madden --- drivers/net/ethernet/ibm/ibmvnic.c | 4 1 file changed, 4 insertions(+) diff --g

Re: [PATCH kernel] vfio_pci_nvlink2: Do not attempt NPU2 setup on old P8's NPU

On 13/11/20 4:06 pm, Alexey Kardashevskiy wrote: We execute certain NPU2 setup code (such as mapping an LPID to a device in NPU2) unconditionally if an Nvlink bridge is detected. However this cannot succeed on P8+ machines as the init helpers return an error other than ENODEV which means the devi

[PATCH kernel] vfio_pci_nvlink2: Do not attempt NPU2 setup on old P8's NPU

We execute certain NPU2 setup code (such as mapping an LPID to a device in NPU2) unconditionally if an Nvlink bridge is detected. However this cannot succeed on P8+ machines as the init helpers return an error other than ENODEV which means the device is there is and setup failed so vfio_pci_enable(

Re: [PATCH 3/3] powerpc: rewrite atomics to use ARCH_ATOMIC

Hi Nicholas, I love your patch! Perhaps something to improve: [auto build test WARNING on powerpc/next] [also build test WARNING on asm-generic/master linus/master v5.10-rc3 next-20201112] [cannot apply to scottwood/next] [If your patch is applied to the wrong git tree, kindly drop us a note

[PATCH kernel] powerpc/powernv/npu: Do not attempt NPU2 setup on old P8's NPU

We execute certain NPU2 setup code (such as mapping an LPID to a device in NPU2) unconditionally if an Nvlink bridge is detected. However this cannot succeed on P8+ machines and errors appear in dmesg. This is harmless as skiboot returns an error and the only place we check it is vfio-pci but that

RE: [PATCH 11/25] soc: fsl: qe: qe_common: Fix misnamed function attribute 'addr'

> -Original Message- > From: Lee Jones > Sent: Thursday, November 12, 2020 4:33 AM > To: linux-arm-ker...@lists.infradead.org; linux-ker...@vger.kernel.org; > Qiang Zhao ; Leo Li ; Scott > Wood ; act ; Dan Malek > ; Software, Inc ; Vitaly > Bordug ; linuxppc-dev@lists.ozlabs.org > Subjec

[PATCH net-next 12/12] ibmvnic: Do not replenish RX buffers after every polling loop

From: "Dwip N. Banerjee" Reduce the amount of time spent replenishing RX buffers by only doing so once available buffers has fallen under a certain threshold, in this case half of the total number of buffers, or if the polling loop exits before the packets processed is less than its budget. Sign

[PATCH net-next 11/12] ibmvnic: Use netdev_alloc_skb instead of alloc_skb to replenish RX buffers

From: "Dwip N. Banerjee" Take advantage of the additional optimizations in netdev_alloc_skb when allocating socket buffers to be used for packet reception. Signed-off-by: Dwip N. Banerjee --- drivers/net/ethernet/ibm/ibmvnic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[PATCH net-next 10/12] ibmvnic: Correctly re-enable interrupts in NAPI polling routine

From: "Dwip N. Banerjee" If the current NAPI polling loop exits without completing it's budget, only re-enable interrupts if there are no entries remaining in the queue and napi_complete_done is successful. If there are entries remaining on the queue that were missed, restart the polling loop. S

[PATCH net-next 06/12] ibmvnic: Clean up TX code and TX buffer data structure

Remove unused and superfluous code and members in existing TX implementation and data structures. Signed-off-by: Thomas Falcon --- drivers/net/ethernet/ibm/ibmvnic.c | 31 +++--- drivers/net/ethernet/ibm/ibmvnic.h | 8 2 files changed, 11 insertions(+), 28 delet

[PATCH net-next 09/12] ibmvnic: Ensure that device queue memory is cache-line aligned

From: "Dwip N. Banerjee" PCI bus slowdowns were observed on IBM VNIC devices as a result of partial cache line writes and non-cache aligned full cache line writes. Ensure that packet data buffers are cache-line aligned to avoid these slowdowns. Signed-off-by: Dwip N. Banerjee --- drivers/net/e

[PATCH net-next 04/12] ibmvnic: Introduce xmit_more support using batched subCRQ hcalls

Include support for the xmit_more feature utilizing the H_SEND_SUB_CRQ_INDIRECT hypervisor call which allows the sending of multiple subordinate Command Response Queue descriptors in one hypervisor call via a DMA-mapped buffer. This update reduces hypervisor calls and thus hypervisor call overhead

[PATCH net-next 02/12] ibmvnic: Introduce indirect subordinate Command Response Queue buffer

This patch introduces the infrastructure to send batched subordinate Command Response Queue descriptors, which are used by the ibmvnic driver to send TX frame and RX buffer descriptors. Signed-off-by: Thomas Falcon --- drivers/net/ethernet/ibm/ibmvnic.c | 19 +++ drivers/net/ethe

[PATCH net-next 01/12] ibmvnic: Ensure that subCRQ entry reads are ordered

Ensure that received Subordinate Command-Response Queue entries are properly read in order by the driver. Signed-off-by: Thomas Falcon --- drivers/net/ethernet/ibm/ibmvnic.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibm

[PATCH net-next 03/12] ibmvnic: Introduce batched RX buffer descriptor transmission

Utilize the H_SEND_SUB_CRQ_INDIRECT hypervisor call to send multiple RX buffer descriptors to the device in one hypervisor call operation. This change will reduce the number of hypervisor calls and thus hypervisor call overhead needed to transmit RX buffer descriptors to the device. Signed-off-by:

[PATCH net-next 07/12] ibmvnic: Clean up TX error handling and statistics tracking

Update error handling code in ibmvnic_xmit to be more readable and remove unused statistics counters. Also record statistics when TX completions are received to improve accuracy. Signed-off-by: Thomas Falcon --- drivers/net/ethernet/ibm/ibmvnic.c | 38 ++ drivers/net/

[PATCH net-next 05/12] ibmvnic: Fix TX completion error handling

When firmware reports that a transmission was not successful, the driver is not correctly processing the completion. It should be freeing the socket buffer and updating the device queue's inflight frame count and BQL structures. Do that now. Fixes: 032c5e82847a ("Driver for IBM System i/p VNIC pro

[PATCH net-next 00/12] ibmvnic: Performance improvements and other updates

First, memory barrier protection of device queue reads to ensure RX and TX buffer completions are not missed. The subsequent three patches utilize a hypervisor call allowing multiple TX and RX buffer replenishment descriptors to be sent in one operation, which significantly reduces hypervisor call

[PATCH net-next 08/12] ibmvnic: Remove send_subcrq function

It is not longer used, so remove it. Signed-off-by: Thomas Falcon --- drivers/net/ethernet/ibm/ibmvnic.c | 34 -- 1 file changed, 34 deletions(-) diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c index 2c24d4774457..b2ca34e94078 10

[PATCH v3] dt-bindings: misc: convert fsl,qoriq-mc from txt to YAML

From: Ionut-robert Aron Convert fsl,qoriq-mc to YAML in order to automate the verification process of dts files. In addition, update MAINTAINERS accordingly and, while at it, add some missing files. Signed-off-by: Ionut-robert Aron [laurentiu.tu...@nxp.com: update MINTAINERS, updates & fixes in

Re: [PATCH 00/25] Rid W=1 warnings in SoC

On Tue, 3 Nov 2020 15:28:13 +, Lee Jones wrote: > This set is part of a larger effort attempting to clean-up W=1 > kernel builds, which are currently overwhelmingly riddled with > niggly little warnings. > > Lee Jones (25): > soc: bcm: brcmstb: pm: pm-arm: Provide prototype for > brcmstb

Re: [patch V3 10/37] ARM: highmem: Switch to generic kmap atomic

On 2020-11-12 09:10:34 [+0100], Marek Szyprowski wrote: > I can do more tests to help fixing this issue. Just let me know what to do. -> https://lkml.kernel.org/r/87y2j6n8mj@nanos.tec.linutronix.de Sebastian

Re: [patch V3 10/37] ARM: highmem: Switch to generic kmap atomic

Marek, On Thu, Nov 12 2020 at 09:10, Marek Szyprowski wrote: > On 03.11.2020 10:27, Thomas Gleixner wrote: > > I can do more tests to help fixing this issue. Just let me know what to do. Just sent out the fix before I saw your report. https://lore.kernel.org/r/87y2j6n8mj@nanos.tec.linut

[PATCH v2 4/4] tty: serial: pmac_zilog: Remove unused disposable variable 'garbage'

Fixes the following W=1 kernel build warning(s): drivers/tty/serial/pmac_zilog.h:365:58: warning: variable ‘garbage’ set but not used [-Wunused-but-set-variable] Cc: Greg Kroah-Hartman Cc: Jiri Slaby Cc: Michael Ellerman Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: linux-ser...@vger.k

[PATCH v2 3/4] powerpc: asm: hvconsole: Move 'hvc_vio_init_early's prototype to shared location

Fixes the following W=1 kernel build warning(s): drivers/tty/hvc/hvc_vio.c:385:13: warning: no previous prototype for ‘hvc_vio_init_early’ [-Wmissing-prototypes] 385 | void __init hvc_vio_init_early(void) | ^~ Cc: Michael Ellerman Cc: Benjamin Herrenschmidt Cc: Paul Mackerra

[PATCH v2 0/4] Rid W=1 issues from TTY

This set is part of a larger effort attempting to clean-up W=1 kernel builds, which are currently overwhelmingly riddled with niggly little warnings. v2: - Remove unused variable completely - Remove unnecessary 'extern' keyword Lee Jones (4): tty: tty_ldisc: Fix some kernel-doc related misdem

Re: [PATCH 11/25] soc: fsl: qe: qe_common: Fix misnamed function attribute 'addr'

On Tue, 03 Nov 2020, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/soc/fsl/qe/qe_common.c:237: warning: Function parameter or member > 'addr' not described in 'cpm_muram_dma' > drivers/soc/fsl/qe/qe_common.c:237: warning: Excess function parameter > 'offset'

Re: [PATCH v4 10/18] dt-bindings: usb: Convert DWC USB3 bindings to DT schema

On Wed, Nov 11, 2020 at 02:14:23PM -0600, Rob Herring wrote: > On Wed, Nov 11, 2020 at 12:08:45PM +0300, Serge Semin wrote: > > DWC USB3 DT node is supposed to be compliant with the Generic xHCI > > Controller schema, but with additional vendor-specific properties, the > > controller-specific refer

[PATCH 3/3] hwmon: ibmpowernv: Silence strncpy() warning

Fixes the following W=1 kernel build warning(s): from drivers/hwmon/ibmpowernv.c:11: In function ‘strncpy’, inlined from ‘get_sensor_index_attr’ at drivers/hwmon/ibmpowernv.c:243:2, inlined from ‘create_device_attrs’ at drivers/hwmon/ibmpowernv.c:280:8: include/linux/string.h:297:30: warning:

[PATCH 0/3] Rid W=1 warnings from HWMON

This set is part of a larger effort attempting to clean-up W=1 kernel builds, which are currently overwhelmingly riddled with niggly little warnings. Lee Jones (3): hwmon: adm1177: Fix kerneldoc attribute formatting hwmon: ina3221: Demote seemingly unintentional kerneldoc header hwmon: ibmpo

Re: [PATCH 1/6] ibmvfc: byte swap login_buf.resp values in attribute show functions

On Wed, Nov 11, 2020 at 07:04:37PM -0600, Tyrel Datwyler wrote: > Both ibmvfc_show_host_(capabilities|npiv_version) functions retrieve > values from vhost->login_buf.resp buffer. This is the MAD response > buffer from the VIOS and as such any multi-byte non-string values are in > big endian format.

Re: [patch V3 10/37] ARM: highmem: Switch to generic kmap atomic

Hi Thomas, On 03.11.2020 10:27, Thomas Gleixner wrote: > No reason having the same code in every architecture. > > Signed-off-by: Thomas Gleixner > Cc: Russell King > Cc: Arnd Bergmann > Cc: linux-arm-ker...@lists.infradead.org This patch landed in linux-next 20201109 as commit 2a15ba82fa6c ("