[PATCH v2] powerpc: pseries/hvconsole: fix stack overread via udbg

2019-06-02 Thread Daniel Axtens
While developing kasan for 64-bit book3s, I hit the following stack over-read. It occurs because the hypercall to put characters onto the terminal takes 2 longs (128 bits/16 bytes) of characters at a time, and so hvc_put_chars would unconditionally copy 16 bytes from the argument buffer, regardles

[RFC PATCH] powerpc/64s: __find_linux_pte synchronization vs pmdp_invalidate

2019-06-02 Thread Nicholas Piggin
The pmd_none check does not catch hugepage collapse, nor does the pmd_present check in pmd_trans_huge, because hugepage collapse sets !_PAGE_PRESENT && _PAGE_INVALID (which results in !pmd_none and pmd_present). Aneesh noticed we might need this check as well. --- arch/powerpc/mm/pgtable.c | 15

Re: [PATCH] powerpc/64s: Fix THP PMD collapse serialisation

2019-06-02 Thread Aneesh Kumar K.V
On 6/3/19 11:35 AM, Nicholas Piggin wrote: Commit 1b2443a547f9 ("powerpc/book3s64: Avoid multiple endian conversion in pte helpers") changed the actual bitwise tests in pte_access_permitted by using pte_write() and pte_present() helpers rather than raw bitwise testing _PAGE_WRITE and _PAGE_PRESEN

[PATCH] powerpc/64s: Fix THP PMD collapse serialisation

2019-06-02 Thread Nicholas Piggin
Commit 1b2443a547f9 ("powerpc/book3s64: Avoid multiple endian conversion in pte helpers") changed the actual bitwise tests in pte_access_permitted by using pte_write() and pte_present() helpers rather than raw bitwise testing _PAGE_WRITE and _PAGE_PRESENT bits. The pte_present change now returns t

Re: [WIP RFC PATCH 0/6] Generic Firmware Variable Filesystem

2019-06-02 Thread Daniel Axtens
Hi Nayna, >> As PowerNV moves towards secure boot, we need a place to put secure >> variables. One option that has been canvassed is to make our secure >> variables look like EFI variables. This is an early sketch of another >> approach where we create a generic firmware variable file system, >> f

Re: [RFC PATCH v2] powerpc/xmon: restrict when kernel is locked down

2019-06-02 Thread Andrew Donnellan
On 24/5/19 10:38 pm, Christopher M. Riedl wrote: Xmon should be either fully or partially disabled depending on the kernel lockdown state. Put xmon into read-only mode for lockdown=integrity and completely disable xmon when lockdown=confidentiality. Xmon checks the lockdown state and takes appro

Re: [PATCH v3 1/3] PCI: Introduce pcibios_ignore_alignment_request

2019-06-02 Thread Alexey Kardashevskiy
On 03/06/2019 12:23, Shawn Anastasio wrote: > > > On 5/30/19 10:56 PM, Alexey Kardashevskiy wrote: >> >> >> On 31/05/2019 08:49, Shawn Anastasio wrote: >>> On 5/29/19 10:39 PM, Alexey Kardashevskiy wrote: On 28/05/2019 17:39, Shawn Anastasio wrote: > > > On 5/28/19 1

Re: [RFC] mm: Generalize notify_page_fault()

2019-06-02 Thread Anshuman Khandual
On 05/31/2019 11:18 PM, Matthew Wilcox wrote: > On Fri, May 31, 2019 at 02:17:43PM +0530, Anshuman Khandual wrote: >> On 05/30/2019 07:09 PM, Matthew Wilcox wrote: >>> On Thu, May 30, 2019 at 05:31:15PM +0530, Anshuman Khandual wrote: On 05/30/2019 04:36 PM, Matthew Wilcox wrote: > The

RE: [next-20190530] Boot failure on PowerPC

2019-06-02 Thread Lili Deng (Wicresoft North America Ltd)
Hi Sachin, I verified below patch against Ubuntu 18.04, didn't hit the kernel panic any more, could you please let know how did you verify? Thanks, Lili -Original Message- From: Sachin Sant Sent: Monday, June 3, 2019 11:12 AM To: Dexuan-Linux Cui Cc: Michael Ellerman ; linuxppc-dev@li

Re: [PATCH] scsi: ibmvscsi: Don't use rc uninitialized in ibmvscsi_do_work

2019-06-02 Thread Nathan Chancellor
Hi Michael, On Sun, Jun 02, 2019 at 08:15:38PM +1000, Michael Ellerman wrote: > Hi Nathan, > > It's always preferable IMHO to keep any initialisation as localised as > possible, so that the compiler can continue to warn about uninitialised > usages elsewhere. In this case that would mean doing th

Re: [next-20190530] Boot failure on PowerPC

2019-06-02 Thread Sachin Sant
> On 31-May-2019, at 11:43 PM, Dexuan-Linux Cui wrote: > > On Fri, May 31, 2019 at 6:52 AM Michael Ellerman wrote: >>> >>> Machine boots till login prompt and then panics few seconds later. >>> >>> Last known next build was May 24th. Will attempt few builds till May 30 to >>> narrow down th

Re: [PATCH kernel] prom_init: Fetch flatten device tree from the system firmware

2019-06-02 Thread Alexey Kardashevskiy
On 03/06/2019 09:23, Segher Boessenkool wrote: > Hi! > > On Fri, May 31, 2019 at 11:03:26AM +1000, Benjamin Herrenschmidt wrote: >> On Thu, 2019-05-30 at 14:37 -0500, Segher Boessenkool wrote: >>> On Thu, May 30, 2019 at 05:09:06PM +1000, Alexey Kardashevskiy wrote: so, it is sort-of nack

Re: [PATCH v3 1/3] PCI: Introduce pcibios_ignore_alignment_request

2019-06-02 Thread Shawn Anastasio
On 5/30/19 10:56 PM, Alexey Kardashevskiy wrote: On 31/05/2019 08:49, Shawn Anastasio wrote: On 5/29/19 10:39 PM, Alexey Kardashevskiy wrote: On 28/05/2019 17:39, Shawn Anastasio wrote: On 5/28/19 1:27 AM, Alexey Kardashevskiy wrote: On 28/05/2019 15:36, Oliver wrote: On Tue, May

Re: [PATCH kernel v3 1/3] powerpc/iommu: Allow bypass-only for DMA

2019-06-02 Thread David Gibson
On Thu, May 30, 2019 at 05:03:53PM +1000, Alexey Kardashevskiy wrote: > POWER8 and newer support a bypass mode which maps all host memory to > PCI buses so an IOMMU table is not always required. However if we fail to > create such a table, the DMA setup fails and the kernel does not boot. > > This

[PATCH BACKPORTv2 4.4] crypto: vmx - ghash: do nosimd fallback manually

2019-06-02 Thread Daniel Axtens
commit 357d065a44cdd77ed5ff35155a989f2a763e96ef upstream. [backported: the VMX driver did not use crypto_simd_usable() until after 5.1, CRYPTO_ALG_TYPE_SHASH was still specified in .options until after 4.14, and the sequence for preparing the kernel to use vmx changed after 4.4.] VMX ghash was

[PATCH BACKPORTv2 4.9, 4.14] crypto: vmx - ghash: do nosimd fallback manually

2019-06-02 Thread Daniel Axtens
commit 357d065a44cdd77ed5ff35155a989f2a763e96ef upstream. [backported: the VMX driver did not use crypto_simd_usable() until after 5.1, CRYPTO_ALG_TYPE_SHASH was still specified in .options until after 4.14] VMX ghash was using a fallback that did not support interleaving simd and nosimd operati

[PATCH BACKPORTv2 4.19, 5.0, 5.1] crypto: vmx - ghash: do nosimd fallback manually

2019-06-02 Thread Daniel Axtens
commit 357d065a44cdd77ed5ff35155a989f2a763e96ef upstream. [backported: the VMX driver did not use crypto_simd_usable() until after 5.1] VMX ghash was using a fallback that did not support interleaving simd and nosimd operations, leading to failures in the extended test suite. If I understood cor

Re: [PATCH BACKPORT 4.19, 5.0, 5.1] crypto: vmx - ghash: do nosimd fallback manually

2019-06-02 Thread Daniel Axtens
Christophe Leroy writes: > Daniel Axtens a écrit : > > Hi > > I think you have to mention the upstream commit Id when submitting a > patch to stable, see > https://elixir.bootlin.com/linux/v5.2-rc1/source/Documentation/process/stable-kernel-rules.rst Argh, right, sorry, still in Canonical

Re: [PATCH] powerpc/nvdimm: Add support for multibyte read/write for metadata

2019-06-02 Thread Oliver
On Sun, Jun 2, 2019 at 2:44 PM Aneesh Kumar K.V wrote: > > SCM_READ/WRITE_MEATADATA hcall supports multibyte read/write. This patch > updates the metadata read/write to use 1, 2, 4 or 8 byte read/write as > mentioned in PAPR document. > > READ/WRITE_METADATA hcall supports the 1, 2, 4, or 8 bytes

Re: [PATCH 1/3] powerpc/pseries: Simplify cpu readd to use drc_index

2019-06-02 Thread Tyrel Datwyler
On 05/20/2019 08:01 AM, Nathan Lynch wrote: > Tyrel Datwyler writes: > >> On 05/16/2019 12:17 PM, Nathan Lynch wrote: >>> Tyrel Datwyler writes: The current dlpar_cpu_readd() takes in a cpu_id and uses that to look up the cpus device_node so that we can get at the ibm,my-drc-index

Re: [PATCH kernel] prom_init: Fetch flatten device tree from the system firmware

2019-06-02 Thread Segher Boessenkool
Hi! On Fri, May 31, 2019 at 11:03:26AM +1000, Benjamin Herrenschmidt wrote: > On Thu, 2019-05-30 at 14:37 -0500, Segher Boessenkool wrote: > > On Thu, May 30, 2019 at 05:09:06PM +1000, Alexey Kardashevskiy wrote: > > > so, it is sort-of nack from David and sort-of ack from Segher, what > > > happe

Re: [GIT PULL] Please pull powerpc/linux.git powerpc-5.2-3 tag

2019-06-02 Thread pr-tracker-bot
The pull request you sent on Sun, 02 Jun 2019 21:05:12 +1000: > https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git > tags/powerpc-5.2-3 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/460b48a0fefce25beb0fc0139e721c5691d65d7f Thank you! -- Deet-doot-do

[GIT PULL] Please pull powerpc/linux.git powerpc-5.2-3 tag

2019-06-02 Thread Michael Ellerman
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Linus, Please pull some more powerpc fixes for 5.2: The following changes since commit a188339ca5a396acc588e5851ed7e19f66b0ebd9: Linux 5.2-rc1 (2019-05-19 15:47:09 -0700) are available in the git repository at: https://git.kernel.org/pub/sc

Re: [PATCH] scsi: ibmvscsi: Don't use rc uninitialized in ibmvscsi_do_work

2019-06-02 Thread Michael Ellerman
Hi Nathan, Nathan Chancellor writes: > clang warns: > > drivers/scsi/ibmvscsi/ibmvscsi.c:2126:7: warning: variable 'rc' is used > uninitialized whenever switch case is taken [-Wsometimes-uninitialized] > case IBMVSCSI_HOST_ACTION_NONE: > ^ > drivers/sc

[Bug 203517] WARNING: inconsistent lock state. inconsistent {SOFTIRQ-ON-W} -> {IN-SOFTIRQ-W} usage.

2019-06-02 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=203517 Michael Ellerman (mich...@ellerman.id.au) changed: What|Removed |Added CC||mich...@ellerm