Re: [PATCH] powerpc: Add missing include

2018-10-17 Thread Mathieu Malaterre
On Thu, Oct 18, 2018 at 6:37 AM Christophe LEROY wrote: > > > > Le 17/10/2018 à 21:25, Mathieu Malaterre a écrit : > > In commit 88b0fe175735 ("powerpc: Add show_user_instructions()") the > > function show_user_instructions was added. > > > > This commit adds an include of header file to provide

[PATCH] powerpc/8xx: add missing header in 8xx_mmu.c

2018-10-17 Thread Christophe Leroy
arch/powerpc/mm/8xx_mmu.c:174:6: error: no previous prototype for ‘set_context’ [-Werror=missing-prototypes] void set_context(unsigned long id, pgd_t *pgd) Signed-off-by: Christophe Leroy --- arch/powerpc/mm/8xx_mmu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/powerpc/mm/8xx_mmu.

[PATCH] powerpc/mm: remove unused variable

2018-10-17 Thread Christophe Leroy
In file included from ./include/linux/hugetlb.h:445:0, from arch/powerpc/kernel/setup-common.c:37: ./arch/powerpc/include/asm/hugetlb.h: In function ‘huge_ptep_clear_flush’: ./arch/powerpc/include/asm/hugetlb.h:154:8: error: variable ‘pte’ set but not used [-Werror=unused-but-set-

Re: MPC8321 boot failure

2018-10-17 Thread Christophe LEROY
Hi, I can now confirm that the boot failure is due to the absence of commit 8183d99f4a22 ("powerpc/lib/feature-fixups: use raw_patch_instruction()") Greg, could you please apply that patch to 4.14 stable ? Thanks Christophe Le 17/10/2018 à 18:36, Christophe LEROY a écrit : Hi, Yes I discov

Re: [PATCH] powerpc: Add missing include

2018-10-17 Thread Christophe LEROY
Le 17/10/2018 à 21:25, Mathieu Malaterre a écrit : In commit 88b0fe175735 ("powerpc: Add show_user_instructions()") the function show_user_instructions was added. This commit adds an include of header file to provide the missing function prototype. Silence the following gcc warning (treated

Re: [PATCH 1/5] powerpc/64s: Kernel Hypervisor Restricted Access Prevention

2018-10-17 Thread Russell Currey
On Wed, 2018-10-17 at 22:30 +1100, Michael Ellerman wrote: > Russell Currey writes: > > diff --git a/arch/powerpc/kernel/entry_64.S > > b/arch/powerpc/kernel/entry_64.S > > index 7b1693adff2a..090f72cbb02d 100644 > > --- a/arch/powerpc/kernel/entry_64.S > > +++ b/arch/powerpc/kernel/entry_64.S > >

Re: [PATCH 1/5] powerpc/64s: Kernel Hypervisor Restricted Access Prevention

2018-10-17 Thread Russell Currey
On Wed, 2018-10-17 at 22:59 +1000, Nicholas Piggin wrote: > On Wed, 17 Oct 2018 17:44:19 +1100 > Russell Currey wrote: > > > Kernel Hypervisor Restricted Access Prevention (KHRAP) utilises a > > feature > > of the Radix MMU which disallows read and write access to userspace > > addresses. By uti

Re: [PATCH kernel v2] powerpc/ioda/npu: Call skiboot's hot reset hook when disabling NPU2

2018-10-17 Thread Alistair Popple
Hi Alexey, > > wouldn't you also need to do that somewhere? Unless the driver > > does it at startup? > > VFIO performs GPU reset so I'd expect the GPUs to flush its caches > without any software interactions. Am I hoping for too much here? Sadly you are. It's not the GPU caches that need flushi

Re: [PATCH kernel 3/3] vfio_pci: Add NVIDIA GV100GL [Tesla V100 SXM2] [10de:1db1] subdriver

2018-10-17 Thread Alexey Kardashevskiy
On 18/10/2018 08:52, Alex Williamson wrote: > On Wed, 17 Oct 2018 12:19:20 +1100 > Alexey Kardashevskiy wrote: > >> On 17/10/2018 06:08, Alex Williamson wrote: >>> On Mon, 15 Oct 2018 20:42:33 +1100 >>> Alexey Kardashevskiy wrote: >>> POWER9 Witherspoon machines come with 4 or 6 V100

Re: [PATCH kernel 3/3] vfio_pci: Add NVIDIA GV100GL [Tesla V100 SXM2] [10de:1db1] subdriver

2018-10-17 Thread Piotr Jaroszyński
On 10/17/18 2:52 PM, Alex Williamson wrote: On Wed, 17 Oct 2018 12:19:20 +1100 Alexey Kardashevskiy wrote: On 17/10/2018 06:08, Alex Williamson wrote: On Mon, 15 Oct 2018 20:42:33 +1100 Alexey Kardashevskiy wrote: POWER9 Witherspoon machines come with 4 or 6 V100 GPUs which are not plug

Re: [PATCH kernel 3/3] vfio_pci: Add NVIDIA GV100GL [Tesla V100 SXM2] [10de:1db1] subdriver

2018-10-17 Thread Alex Williamson
On Wed, 17 Oct 2018 12:19:20 +1100 Alexey Kardashevskiy wrote: > On 17/10/2018 06:08, Alex Williamson wrote: > > On Mon, 15 Oct 2018 20:42:33 +1100 > > Alexey Kardashevskiy wrote: > > > >> POWER9 Witherspoon machines come with 4 or 6 V100 GPUs which are not > >> pluggable PCIe devices but imp

Re: [PATCH v4 01/18] of: overlay: add tests to validate kfrees from overlay removal

2018-10-17 Thread Alan Tull
On Mon, Oct 15, 2018 at 9:39 PM wrote: Hi Frank, > > From: Frank Rowand > > Add checks: > - attempted kfree due to refcount reaching zero before overlay > is removed > - properties linked to an overlay node when the node is removed > - node refcount > one during node removal in a chan

Re: [PATCH v4 00/18] of: overlay: validation checks, subsequent fixes

2018-10-17 Thread Alan Tull
On Tue, Oct 16, 2018 at 10:08 PM Frank Rowand wrote: > > On 10/16/18 02:47, Michael Ellerman wrote: > > frowand.l...@gmail.com writes: > > > >> From: Frank Rowand > >> > >> Add checks to (1) overlay apply process and (2) memory freeing > >> triggered by overlay release. The checks are intended t

[PATCH v07 5/5] migration/memory: Support 'ibm,dynamic-memory-v2'

2018-10-17 Thread Michael Bringmann
migration/memory: This patch adds recognition for changes to the associativity of memory blocks described by 'ibm,dynamic-memory-v2'. If the associativity of an LMB has changed, it should be readded to the system in order to update local and general kernel data structures. This patch builds upon pr

[PATCH v07 4/5] migration/memory: Evaluate LMB assoc changes

2018-10-17 Thread Michael Bringmann
migration/memory: This patch adds code that recognizes changes to the associativity of memory blocks described by the device-tree properties in order to drive equivalent 'hotplug' operations to update local and general kernel data structures to reflect those changes. These differences may include:

[PATCH v07 3/5] migration/memory: Add hotplug READD_MULTIPLE

2018-10-17 Thread Michael Bringmann
migration/memory: This patch adds a new pseries hotplug action for CPU and memory operations, PSERIES_HP_ELOG_ACTION_READD_MULTIPLE. This is a variant of the READD operation which performs the action upon multiple instances of the resource at one time. The operation is to be triggered by device-tr

[PATCH v07 2/5] powerpc/drmem: Add internal_flags feature

2018-10-17 Thread Michael Bringmann
powerpc/drmem: Add internal_flags field to each LMB to allow marking of kernel software-specific operations that need not be exported to other users. For instance, if information about selected LMBs needs to be maintained for subsequent passes through the system, it can be encoded into the LMB arr

[PATCH v07 1/5] powerpc/drmem: Export 'dynamic-memory' loader

2018-10-17 Thread Michael Bringmann
powerpc/drmem: Export many of the functions of DRMEM to parse "ibm,dynamic-memory" and "ibm,dynamic-memory-v2" during hotplug operations and for Post Migration events. Also modify the DRMEM initialization code to allow it to, * Be called after system initialization * Provide a separate user copy

[PATCH v07 0/5] powerpc/migration: Affinity fix for memory

2018-10-17 Thread Michael Bringmann
The migration of LPARs across Power systems affects many attributes including that of the associativity of memory blocks. The patches in this set execute when a system is coming up fresh upon a migration target. They are intended to, * Recognize changes to the associativity of memory recorded in

[PATCH] powerpc: Add missing include

2018-10-17 Thread Mathieu Malaterre
In commit 88b0fe175735 ("powerpc: Add show_user_instructions()") the function show_user_instructions was added. This commit adds an include of header file to provide the missing function prototype. Silence the following gcc warning (treated as error with W=1): arch/powerpc/kernel/process.c:130

Re: MPC8321 boot failure

2018-10-17 Thread Christophe LEROY
Hi, Yes I discovered the same issue today on MPC8321E, I plan to look at it more closely tomorrow morning (Paris Time). I think we are missing commit 8183d99f4a22c2abbc543847a588df3666ef0c0c , I didn't realise it when we applied the serie to 4.14, patch_instruction() is called too early with

Re: [PATCH v06 3/5] migration/memory: Add hotplug READD_MULTIPLE

2018-10-17 Thread Michael Bringmann
On 10/16/2018 07:48 PM, Michael Ellerman wrote: > Michael Bringmann writes: >> On 10/16/2018 02:57 PM, Tyrel Datwyler wrote: >>> On 10/15/2018 05:39 PM, Michael Ellerman wrote: Michael Bringmann writes: > diff --git a/arch/powerpc/platforms/pseries/hotplug-memory.c > b/arch/powerpc/

Re: [PATCH] powerpc/book3e: redefine pte_mkprivileged() and pte_mkuser()

2018-10-17 Thread Aneesh Kumar K.V
On 10/17/18 6:33 PM, Christophe Leroy wrote: Book3e defines both _PAGE_USER and _PAGE_PRIVILEGED, so the nohash default pte_mkprivileged() and pte_mkuser() are not usable. This patch redefines them for book3e. In theorie, only pte_mkprivileged() needs to be redefined because _PAGE_USER includes

[PATCH] powerpc/book3e: redefine pte_mkprivileged() and pte_mkuser()

2018-10-17 Thread Christophe Leroy
Book3e defines both _PAGE_USER and _PAGE_PRIVILEGED, so the nohash default pte_mkprivileged() and pte_mkuser() are not usable. This patch redefines them for book3e. In theorie, only pte_mkprivileged() needs to be redefined because _PAGE_USER includes _PAGE_PRIVILEGED, but it is less confusing to

Re: [PATCH 1/5] powerpc/64s: Kernel Hypervisor Restricted Access Prevention

2018-10-17 Thread Nicholas Piggin
On Wed, 17 Oct 2018 17:44:19 +1100 Russell Currey wrote: > Kernel Hypervisor Restricted Access Prevention (KHRAP) utilises a feature > of the Radix MMU which disallows read and write access to userspace > addresses. By utilising this, the kernel is prevented from accessing > user data from outsi

Re: Crash on FSL Book3E due to pte_pgprot()? (was Re: [PATCH v3 12/24] powerpc/mm: use pte helpers in generic code)

2018-10-17 Thread Aneesh Kumar K.V
On 10/17/18 4:42 PM, Christophe Leroy wrote: On 10/17/2018 10:32 AM, Michael Ellerman wrote: Christophe Leroy writes: On 10/17/2018 12:59 AM, Michael Ellerman wrote: ... The question is what's the right way to fix it? Should pte_pgprot() not be filtering those bits out on book3e? I think

Re: [PATCH v5 21/22] powerpc/nohash32: allow setting GUARDED attribute in the PMD directly

2018-10-17 Thread Christophe LEROY
Le 25/09/2018 à 18:51, Christophe Leroy a écrit : On the 8xx, the GUARDED attribute of the pages is managed in the L1 entry, therefore to avoid having to copy it into L1 entry at each TLB miss, we have to set it in the PMD In order to allow this, this patch splits the VM alloc space in two pa

Re: [PATCH 1/5] powerpc/64s: Kernel Hypervisor Restricted Access Prevention

2018-10-17 Thread Michael Ellerman
Russell Currey writes: > diff --git a/arch/powerpc/kernel/entry_64.S b/arch/powerpc/kernel/entry_64.S > index 7b1693adff2a..090f72cbb02d 100644 > --- a/arch/powerpc/kernel/entry_64.S > +++ b/arch/powerpc/kernel/entry_64.S > @@ -286,6 +286,9 @@ BEGIN_FTR_SECTION > HMT_MEDIUM_LOW > END_FTR_SE

Re: Crash on FSL Book3E due to pte_pgprot()? (was Re: [PATCH v3 12/24] powerpc/mm: use pte helpers in generic code)

2018-10-17 Thread Christophe Leroy
On 10/17/2018 10:32 AM, Michael Ellerman wrote: Christophe Leroy writes: On 10/17/2018 12:59 AM, Michael Ellerman wrote: ... The question is what's the right way to fix it? Should pte_pgprot() not be filtering those bits out on book3e? I think we should not use pte_pggrot() for that then

Re: Crash on FSL Book3E due to pte_pgprot()? (was Re: [PATCH v3 12/24] powerpc/mm: use pte helpers in generic code)

2018-10-17 Thread Michael Ellerman
Christophe Leroy writes: > On 10/17/2018 12:59 AM, Michael Ellerman wrote: ... >> The question is what's the right way to fix it? Should pte_pgprot() not >> be filtering those bits out on book3e? > > I think we should not use pte_pggrot() for that then. What about the > below fix ? Thanks, that

Re: [PATCH 1/5] powerpc/64s: Kernel Hypervisor Restricted Access Prevention

2018-10-17 Thread kbuild test robot
/0day-ci/linux/commits/Russell-Currey/powerpc-64s-Kernel-Hypervisor-Restricted-Access-Prevention/20181017-153543 base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next config: powerpc-storcenter_defconfig (attached as .config) compiler: powerpc-linux-gnu-gcc (Debian 7.2.0-11

Re: [PATCH 2/4] mm: speed up mremap by 500x on large regions (v2)

2018-10-17 Thread Vlastimil Babka
On 10/16/18 9:43 PM, Joel Fernandes wrote: > On Tue, Oct 16, 2018 at 01:29:52PM +0200, Vlastimil Babka wrote: >> On 10/16/18 12:33 AM, Joel Fernandes wrote: >>> On Mon, Oct 15, 2018 at 02:42:09AM -0700, Christoph Hellwig wrote: On Fri, Oct 12, 2018 at 06:31:58PM -0700, Joel Fernandes (Google)

Re: Crash on FSL Book3E due to pte_pgprot()? (was Re: [PATCH v3 12/24] powerpc/mm: use pte helpers in generic code)

2018-10-17 Thread Christophe LEROY
Le 17/10/2018 à 11:39, Aneesh Kumar K.V a écrit : Christophe Leroy writes: On 10/17/2018 12:59 AM, Michael Ellerman wrote: Christophe Leroy writes: Get rid of platform specific _PAGE_ in powerpc common code and use helpers instead. mm/dump_linuxpagetables.c will be handled separate

Re: Crash on FSL Book3E due to pte_pgprot()? (was Re: [PATCH v3 12/24] powerpc/mm: use pte helpers in generic code)

2018-10-17 Thread Aneesh Kumar K.V
Christophe Leroy writes: > On 10/17/2018 12:59 AM, Michael Ellerman wrote: >> Christophe Leroy writes: >> >>> Get rid of platform specific _PAGE_ in powerpc common code and >>> use helpers instead. >>> >>> mm/dump_linuxpagetables.c will be handled separately >>> >>> Reviewed-by: Aneesh Kuma

Re: help

2018-10-17 Thread Madhavan Srinivasan
On Wednesday 17 October 2018 02:03 PM, Lorenzo Chelini wrote: Hi All, I am a PhD at IBM Zurich. I am playing around with the new POWER9 servers. I am interested in plotting a roofline model for a given application, but I need to measure the traffic to and from the memory. Ideally, what I woul

help

2018-10-17 Thread Lorenzo Chelini
Hi All, I am a PhD at IBM Zurich. I am playing around with the new POWER9 servers. I am interested in plotting a roofline model for a given application, but I need to measure the traffic to and from the memory. Ideally, what I would like to measure is the traffic at the memory controller level.

Re: move bus (PCI, PCMCIA, EISA, rapdio) config to drivers/ v2

2018-10-17 Thread Geert Uytterhoeven
Hi Christoph, On Wed, Oct 17, 2018 at 10:03 AM Christoph Hellwig wrote: > currently every architecture that wants to provide on of the common > periphal busses needs to add some boilerplate code and include the > right Kconfig files. This series instead just selects the presence > (when needed)

Re: [PATCH 8/8] kconfig: remove CONFIG_MCA leftovers

2018-10-17 Thread Christoph Hellwig
On Tue, Oct 16, 2018 at 02:20:23PM +0900, Masahiro Yamada wrote: > On Sun, Oct 14, 2018 at 12:11 AM Christoph Hellwig wrote: > > > > Signed-off-by: Christoph Hellwig > > --- > > > Can you use "powerpc:" or something > for the subject line? > > I'd like to see "kconfig:" only for patches > that

move bus (PCI, PCMCIA, EISA, rapdio) config to drivers/ v2

2018-10-17 Thread Christoph Hellwig
Hi all, currently every architecture that wants to provide on of the common periphal busses needs to add some boilerplate code and include the right Kconfig files. This series instead just selects the presence (when needed) and then handles everything in the bus-specific Kconfig file under drive

[PATCH 8/8] kconfig: remove CONFIG_MCA leftovers

2018-10-17 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig Acked-by: Thomas Gleixner --- arch/powerpc/Kconfig | 4 drivers/scsi/Kconfig | 6 +++--- 2 files changed, 3 insertions(+), 7 deletions(-) diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig index f2001fff14d1..f3ec13765639 100644 --- a/arch/powerpc/Kco

[PATCH 3/8] powerpc: PCI_MSI needs PCI

2018-10-17 Thread Christoph Hellwig
Various powerpc boards select the PCI_MSI config option without selecting PCI, resulting in potentially not compilable configurations if the by default enabled PCI option is disabled. Explicitly select PCI to ensure we always have valid configs. Signed-off-by: Christoph Hellwig Acked-by: Thomas

[PATCH 1/8] aha152x: rename the PCMCIA define

2018-10-17 Thread Christoph Hellwig
We plan to enable building the PCMCIA core and drivers, and the non-prefixed PCMCIA name clashes with some arch headers. Signed-off-by: Christoph Hellwig Acked-by: Thomas Gleixner --- drivers/scsi/aha152x.c | 14 +++--- drivers/scsi/pcmcia/aha152x_core.c | 2 +- 2 files cha

[PATCH 4/8] PCI: consolidate PCI config entry in drivers/pci

2018-10-17 Thread Christoph Hellwig
There is no good reason to duplicate the PCI menu in every architecture. Instead provide a selectable HAS_PCI symbol that indicates availability of PCI support and the handle the rest in drivers/pci. Note that for powerpc we now select HAVE_PCI globally instead of the convoluted mess of conditiona

[PATCH 5/8] pcmcia: allow PCMCIA support independent of the architecture

2018-10-17 Thread Christoph Hellwig
There is nothing architecture specific in the PCMCIA core, so allow building it everywhere. The actual host controllers will depend on ISA, PCI or a specific SOC. Signed-off-by: Christoph Hellwig Acked-by: Dominik Brodowski Acked-by: Thomas Gleixner --- arch/alpha/Kconfig | 2 -- arch/arm

[PATCH 6/8] rapidio: consolidate RAPIDIO config entry in drivers/rapidio

2018-10-17 Thread Christoph Hellwig
There is no good reason to duplicate the RAPIDIO menu in various architectures. Instead provide a selectable HAS_RAPIDIO symbol that indicates native availability of RAPIDIO support and the handle the rest in drivers/pci. This also means we now provide support for PCI(e) to Rapidio bridges for ev

[PATCH 2/8] powerpc: remove CONFIG_PCI_QSPAN

2018-10-17 Thread Christoph Hellwig
This option isn't actually used anywhere. Signed-off-by: Christoph Hellwig --- arch/powerpc/Kconfig | 9 - 1 file changed, 9 deletions(-) diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig index a80669209155..e8c8970248bc 100644 --- a/arch/powerpc/Kconfig +++ b/arch/powerpc/Kconfi

[PATCH 7/8] eisa: consolidate EISA Kconfig entry in drivers/eisa

2018-10-17 Thread Christoph Hellwig
Let architectures opt into EISA support by selecting HAS_EISA and handle everything else in drivers/eisa. Signed-off-by: Christoph Hellwig Acked-by: Thomas Gleixner --- arch/alpha/Kconfig | 10 +++--- arch/arm/Kconfig | 16 +--- arch/mips/Kconfig | 31 +---

Re: [PATCH 4.18 086/135] KVM: PPC: Book3S HV: Dont use compound_order to determine host mapping size

2018-10-17 Thread Greg Kroah-Hartman
On Wed, Oct 17, 2018 at 09:32:25AM +1100, Paul Mackerras wrote: > On Tue, Oct 16, 2018 at 07:05:16PM +0200, Greg Kroah-Hartman wrote: > > 4.18-stable review patch. If anyone has any objections, please let me know. > > > > -- > > > > From: Nicholas Piggin > > > > [ Upstream comm

[PATCH 3/5] powerpc/lib: checksum KHRAP support

2018-10-17 Thread Russell Currey
Wrap the checksumming code in KHRAP locks and unlocks. Signed-off-by: Russell Currey --- arch/powerpc/lib/checksum_wrappers.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/lib/checksum_wrappers.c b/arch/powerpc/lib/checksum_wrappers.c index a0cb63fb76a1.

[PATCH 5/5] powerpc/64s: Document that PPC supports nosmap

2018-10-17 Thread Russell Currey
Signed-off-by: Russell Currey --- Documentation/admin-guide/kernel-parameters.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt index a5ad67d5cb16..8f78e75965f0 100644 --- a/Do