Re: move bus (PCI, PCMCIA, EISA, rapdio) config to drivers/

2018-10-14 Thread Masahiro Yamada
On Sun, Oct 14, 2018 at 12:10 AM Christoph Hellwig wrote: > > Hi all, > > currently every architecture that wants to provide on of the common > periphal busses needs to add some boilerplate code and include the > right Kconfig files. This series instead just selects the presence > (when needed)

Re: [PATCH 7/8] eisa: consolidate EISA Kconfig entry in drivers/eisa

2018-10-14 Thread Masahiro Yamada
On Sun, Oct 14, 2018 at 12:11 AM Christoph Hellwig wrote: > > Let architectures opt into EISA support by selecting HAS_EISA and > handle everything else in drivers/eisa. > > Signed-off-by: Christoph Hellwig > --- How about HAVE_EISA ? You forgot to add source "drivers/eisa/Kconfig" to drivers

Re: [PATCH 4/8] pci: consolidate PCI config entry in drivers/pci

2018-10-14 Thread Masahiro Yamada
On Sun, Oct 14, 2018 at 12:11 AM Christoph Hellwig wrote: > > There is no good reason to duplicate the PCI menu in every architecture. > Instead provide a selectable HAS_PCI symbol that indicates availability > of PCI support and the handle the rest in drivers/pci. I think HAVE_ is a preferred p

[PATCH] powerpc/book3s64: fix dump_linuxpagetables "present" flag

2018-10-14 Thread Christophe Leroy
Since commit bd0dbb73e013 ("powerpc/mm/books3s: Add new pte bit to mark pte temporarily invalid."), _PAGE_PRESENT doesn't mean exactly that a page is present. A page is also considered preset when _PAGE_INVALID is set. This patch changes the meaning of "present" and adds a status "valid" associate

Re: [PATCH 2/8] powerpc: simplify CONFIG_PCI_QSPAN Kconfig magic

2018-10-14 Thread Masahiro Yamada
On Sun, Oct 14, 2018 at 12:11 AM Christoph Hellwig wrote: > > The way how CONFIG_PCI_QSPAN selects the CONFIG_PCI default is highly > unusual and gets in the way of moving CONFIG_PCI into > drivers/pci/Kconfig. Simplify it by just having it depend on > CONFIG_PCI. > > Signed-off-by: Christoph Hel

Re: [PATCH 16/33] powerpc/powernv: remove dead npu-dma code

2018-10-14 Thread Christoph Hellwig
On Mon, Oct 15, 2018 at 12:34:02PM +1100, Alexey Kardashevskiy wrote: > > On 10/10/2018 00:24, Christoph Hellwig wrote: > > This code has been unused since it was merged and is in the way of > > cleaning up the DMA code, thus remove it. > > > > This effectively reverts commit 5d2aa710 ("powerpc/p

[PATCH v5 6/6] arm64: dts: add LX2160ARDB board support

2018-10-14 Thread Vabhav Sharma
LX2160A reference design board (RDB) is a high-performance computing, evaluation, and development platform with LX2160A SoC. Signed-off-by: Priyanka Jain Signed-off-by: Sriram Dash Signed-off-by: Vabhav Sharma Signed-off-by: Horia Geanta Signed-off-by: Ran Wang Signed-off-by: Zhang Ying-22455

[PATCH v5 5/6] arm64: dts: add QorIQ LX2160A SoC support

2018-10-14 Thread Vabhav Sharma
LX2160A SoC is based on Layerscape Chassis Generation 3.2 Architecture. LX2160A features an advanced 16 64-bit ARM v8 CortexA72 processor cores in 8 cluster, CCN508, GICv3,two 64-bit DDR4 memory controller, 8 I2C controllers, 3 dspi, 2 esdhc,2 USB 3.0, mmu 500, 3 SATA, 4 PL011 SBSA UARTs etc. Sig

[PATCH v5 4/6] clk: qoriq: Add clockgen support for lx2160a

2018-10-14 Thread Vabhav Sharma
From: Yogesh Gaur Add clockgen support for lx2160a. Added entry for compat 'fsl,lx2160a-clockgen'. Signed-off-by: Tang Yuantian Signed-off-by: Yogesh Gaur Signed-off-by: Vabhav Sharma Acked-by: Stephen Boyd Acked-by: Viresh Kumar --- drivers/clk/clk-qoriq.c | 12 drive

[PATCH v5 3/6] clk: qoriq: increase array size of cmux_to_group

2018-10-14 Thread Vabhav Sharma
From: Yogesh Gaur Increase size of cmux_to_group array, to accomdate entry of -1 termination. Added -1, terminated, entry for 4080_cmux_grpX. Signed-off-by: Yogesh Gaur Signed-off-by: Vabhav Sharma --- drivers/clk/clk-qoriq.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --

[PATCH v5 2/6] soc/fsl/guts: Add definition for LX2160A

2018-10-14 Thread Vabhav Sharma
Adding compatible string "lx2160a-dcfg" to initialize guts driver for lx2160 and SoC die attribute definition for LX2160A Signed-off-by: Vabhav Sharma Signed-off-by: Yinbo Zhu --- drivers/soc/fsl/guts.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/soc/fsl/guts.c b/drivers/s

[PATCH v5 1/6] dt-bindings: arm64: add compatible for LX2160A

2018-10-14 Thread Vabhav Sharma
Add compatible for LX2160A SoC,QDS and RDB board Add lx2160a compatible for clockgen and dcfg Signed-off-by: Vabhav Sharma Reviewed-by: Rob Herring --- Documentation/devicetree/bindings/arm/fsl.txt | 14 +- Documentation/devicetree/bindings/clock/qoriq-clock.txt | 1 + 2

[PATCH v5 0/6] arm64: dts: NXP: add basic dts file for LX2160A SoC

2018-10-14 Thread Vabhav Sharma
Changes for v5: - Updated temperature sensor regulator name in board device tree - Sorted nodes alphabatically and unit-address in SoC/board device tree - Identation, new line update in SoC/board device tree - Updated nodes name as per DT spec generic name recommendation in SoC DT - Updated macro d

[PATCH 09/12] powerpc/prom_init: Move a few remaining statics to appropriate sections

2018-10-14 Thread Benjamin Herrenschmidt
Signed-off-by: Benjamin Herrenschmidt --- arch/powerpc/kernel/prom_init.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/arch/powerpc/kernel/prom_init.c b/arch/powerpc/kernel/prom_init.c index cbd54fe30367..306562d4d818 100644 --- a/arch/powerpc/kernel/prom_init.c

Re: powerpc/xmon: Show the stack protector canary in xmon

2018-10-14 Thread Michael Ellerman
On Mon, 2018-10-15 at 02:23:39 UTC, Michael Ellerman wrote: > This is helpful for debugging stack protector crashes. > > Signed-off-by: Michael Ellerman Applied to powerpc next. https://git.kernel.org/powerpc/c/50530f5eac0c023cfc313d7ed342d4 cheers

Re: [1/6] powerpc/64s/hash: Convert SLB miss handlers to C

2018-10-14 Thread Michael Ellerman
On Sat, 2018-10-13 at 13:18:31 UTC, Michael Ellerman wrote: > From: Nicholas Piggin > > This patch moves SLB miss handlers completely to C, using the standard > exception handler macros to set up the stack and branch to C. > > This can be done because the segment containing the kernel stack is >

Re: [1/3] powerpc: Split user/kernel definitions of struct pt_regs

2018-10-14 Thread Michael Ellerman
On Sat, 2018-10-13 at 10:56:44 UTC, Michael Ellerman wrote: > We use a shared definition for struct pt_regs in uapi/asm/ptrace.h. > That means the layout of the structure is ABI, ie. we can't change it. > > That would be fine if it was only used to describe the user-visible > register state of a p

Re: powerpc/64: properly initialise the stackprotector canary on SMP.

2018-10-14 Thread Michael Ellerman
On Sat, 2018-10-13 at 09:45:12 UTC, Christophe Leroy wrote: > commit 06ec27aea9fc ("powerpc/64: add stack protector support") > doesn't initialise the stack canary on SMP secondary CPU's paca, > leading to the following false positive report from the > stack protector. > > smp: Bringing up seconda

Re: powerpc: Fix stackprotector detection for non-glibc toolchains

2018-10-14 Thread Michael Ellerman
On Fri, 2018-10-12 at 22:58:32 UTC, Michael Ellerman wrote: > If GCC is not built with glibc support then we must explicitly tell it > which register to use for TLS mode stack protector, otherwise it will > error out and the cc-option check will fail. > > Signed-off-by: Michael Ellerman > Reviewe

Re: powerpc: Use SWITCH_FRAME_SIZE for prom and rtas entry

2018-10-14 Thread Michael Ellerman
On Fri, 2018-10-12 at 02:44:06 UTC, Joel Stanley wrote: > Commit 6c1719942e19 ("powerpc/of: Remove useless register save/restore > when calling OF back") removed the saving of srr0 and srr1 when calling > into OpenFirmware. Commit e31aa453bbc4 ("powerpc: Use LOAD_REG_IMMEDIATE > only for constants

Re: [v10, 1/3] powerpc: Detect the presence of big-cores via "ibm, thread-groups"

2018-10-14 Thread Michael Ellerman
On Thu, 2018-10-11 at 05:33:01 UTC, "Gautham R. Shenoy" wrote: > From: "Gautham R. Shenoy" > > On IBM POWER9, the device tree exposes a property array identifed by > "ibm,thread-groups" which will indicate which groups of threads share > a particular set of resources. > > As of today we only hav

Re: [v3] powerpc/Makefile: Fix PPC_BOOK3S_64 ASFLAGS

2018-10-14 Thread Michael Ellerman
On Thu, 2018-10-11 at 02:43:03 UTC, Joel Stanley wrote: > Ever since commit 15a3204d24a3 ("powerpc/64s: Set assembler machine type > to POWER4") we force -mpower4 to be passed to the assembler irrespective > of the CFLAGS used. > > When building a powerpc64 kernel with clang, clang will not add -m

Re: [1/2] powerpc/boot: Expose Kconfig symbols to wrapper

2018-10-14 Thread Michael Ellerman
On Tue, 2018-10-09 at 23:28:02 UTC, Joel Stanley wrote: > Currently the wrapper is built without including anything in > $(src)/include/, which means there are no CONFIG_ symbols defined. This > means the platform specific serial drivers were never enabled. > > We now copy the definitions into the

Re: powerpc/rtasd: Improve unknown error logging

2018-10-14 Thread Michael Ellerman
On Wed, 2018-10-10 at 05:23:02 UTC, Oliver O'Halloran wrote: > Currently when we get an unknown RTAS event it prints the type as > "Unknown" and no other useful information. Add the raw type code to the > log message so that we have something to work off. > > Signed-off-by: Oliver O'Halloran > Re

Re: [1/2] powerpc/boot: Disable vector instructions

2018-10-14 Thread Michael Ellerman
On Wed, 2018-10-10 at 02:45:22 UTC, Joel Stanley wrote: > This will avoid auto-vectorisation when building with higher > optimisation levels. > > We don't know if the machine can support VSX and even if it's present > it's probably not going to be enabled at this point in boot. > > Signed-off-by:

Re: powerpc: remove redundant 'default n' from Kconfig-s

2018-10-14 Thread Michael Ellerman
On Tue, 2018-10-09 at 15:39:46 UTC, Bartlomiej Zolnierkiewicz wrote: > 'default n' is the default value for any bool or tristate Kconfig > setting so there is no need to write it explicitly. > > Also since commit f467c5640c29 ("kconfig: only write '# CONFIG_FOO > is not set' for visible symbols")

Re: [v02] powerpc/mobility: Extend start/stop topology update scope

2018-10-14 Thread Michael Ellerman
On Tue, 2018-10-09 at 20:12:14 UTC, Michael Bringmann wrote: > The PPC mobility code may receive RTAS requests to perform PRRN > topology changes at any time, including during LPAR migration > operations. In some configurations where the affinity of CPUs > or memory is being changed on that platfo

Re: [v3, -next] powerpc/pseries/memory-hotplug: Fix return value type of find_aa_index

2018-10-14 Thread Michael Ellerman
On Tue, 2018-10-09 at 13:59:13 UTC, YueHaibing wrote: > 'aa_index' is defined as an unsigned value, but find_aa_index > may return -1 when dlpar_clone_property fails. So change > find_aa_index return value type to bool, which indicate 'aa_index' > whether found or not. > > Fixes: c05a5a40969e ("p

Re: [v3,01/24] powerpc/32: Add ioremap_wt() and ioremap_coherent()

2018-10-14 Thread Michael Ellerman
On Tue, 2018-10-09 at 13:51:33 UTC, Christophe Leroy wrote: > Other arches have ioremap_wt() to map IO areas write-through. > Implement it on PPC as well in order to avoid drivers using > __ioremap(_PAGE_WRITETHRU) > > Also implement ioremap_coherent() to avoid drivers using > __ioremap(_PAGE_COHE

Re: [v2] powerpc/perf: Quiet IMC PMU registration message

2018-10-14 Thread Michael Ellerman
On Tue, 2018-10-09 at 06:20:38 UTC, Joel Stanley wrote: > On a Power9 box we get a few screens full of these on boot. Drop > them to pr_debug. > > [5.993645] nest_centaur6_imc performance monitor hardware support > registered > [5.993728] nest_centaur7_imc performance monitor hardware sup

Re: [v4,1/3] powerpc/process: fix casting and missing header

2018-10-14 Thread Michael Ellerman
On Sat, 2018-10-06 at 16:51:12 UTC, Christophe Leroy wrote: > This patch fixes the following warnings. The first ones are leftovers > from when __get_user() was replaced by probe_kernel_address(). > > The last one is from when show_user_instructions() was added. > > arch/powerpc/kernel/process.c:

Re: powerpc: signedness bug in update_flash_db()

2018-10-14 Thread Michael Ellerman
On Mon, 2018-10-01 at 16:44:58 UTC, Dan Carpenter wrote: > The "count < sizeof(struct os_area_db)" comparison is type promoted to > size_t so negative values of "count" are treated as very high values and > we accidentally return success instead of a negative error code. > > This doesn't really ch

Re: [v2] powerpc/rtas: Fix a potential race between CPU-Offline & Migration

2018-10-14 Thread Michael Ellerman
On Mon, 2018-10-01 at 10:40:39 UTC, "Gautham R. Shenoy" wrote: > From: "Gautham R. Shenoy" > > Live Partition Migrations require all the present CPUs to execute the > H_JOIN call, and hence rtas_ibm_suspend_me() onlines any offline CPUs > before initiating the migration for this purpose. > > The

Re: [V2, 1/2] powerpc/mm/hash: Rename get_ea_context to get_user_context

2018-10-14 Thread Michael Ellerman
On Thu, 2018-09-20 at 08:33:57 UTC, "Aneesh Kumar K.V" wrote: > We will be adding get_kernel_context later. Update function name to indicate > this handle context allocation user space address. > > Signed-off-by: Aneesh Kumar K.V Series applied to powerpc next, thanks. https://git.kernel.org/po

Re: powerpc: Disable -Wbuiltin-requires-header when setjmp is used

2018-10-14 Thread Michael Ellerman
On Mon, 2018-09-17 at 07:46:21 UTC, Joel Stanley wrote: > The powerpc kernel uses setjmp which causes a warning when building with > clang: > > CC arch/powerpc/xmon/xmon.o > In file included from arch/powerpc/xmon/xmon.c:51: > ./arch/powerpc/include/asm/setjmp.h:15:13: error: declarat

Re: [01/14] powerpc/eeh: Fix possible null deref in eeh_dump_dev_log()

2018-10-14 Thread Michael Ellerman
On Wed, 2018-09-12 at 01:23:20 UTC, Sam Bobroff wrote: > If an error occurs during an unplug operation, it's possible for > eeh_dump_dev_log() to be called when edev->pdn is null, which > currently leads to dereferencing a null pointer. > > Handle this by skipping the error log for those devices.

Re: [1/7] macintosh: Use common code to access RTC

2018-10-14 Thread Michael Ellerman
On Wed, 2018-09-12 at 00:18:44 UTC, Finn Thain wrote: > Now that the 68k Mac port has adopted the via-pmu driver, the same RTC > code can be shared between m68k and powerpc. Replace duplicated code in > arch/powerpc and arch/m68k with common RTC accessors for Cuda and PMU. > > Drop the problematic

Re: [1/2] powerpc/64s/hash: do not use PPC_INVALIDATE_ERAT on CPUs before POWER9

2018-10-14 Thread Michael Ellerman
On Mon, 2018-08-27 at 03:03:01 UTC, Nicholas Piggin wrote: > PPC_INVALIDATE_ERAT is slbia IH=7 which is a new variant introduced > with POWER9, and the result is undefined on earlier CPUs. > > Commits 7b9f71f974 ("powerpc/64s: POWER9 machine check handler") and > d4748276ae ("powerpc/64s: Improve

Re: [RFC,03/11] powerpc/prom_init: Make "default_colors" const

2018-10-14 Thread Michael Ellerman
On Thu, 2018-05-31 at 04:33:41 UTC, Benjamin Herrenschmidt wrote: > It's never modified either > > Signed-off-by: Benjamin Herrenschmidt Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/7f995d3ba6f2bfbe274f5a012f5b54 cheers

Re: [RFC,02/11] powerpc/prom_init: Make "fake_elf" const

2018-10-14 Thread Michael Ellerman
On Thu, 2018-05-31 at 04:33:40 UTC, Benjamin Herrenschmidt wrote: > It is never modified > > Signed-off-by: Benjamin Herrenschmidt Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/30c69ca0486fd73f2e5d40096ee68b cheers

Re: [RFC,01/11] powerpc/prom_init: Make of_workarounds static

2018-10-14 Thread Michael Ellerman
On Thu, 2018-05-31 at 04:33:39 UTC, Benjamin Herrenschmidt wrote: > It's not used anywhere else > > Signed-off-by: Benjamin Herrenschmidt Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/3bad719b495467a7e7023c5b26f0f5 cheers

Re: [PATCH v3 13/18] of: overlay: check prevents multiple fragments touching same property

2018-10-14 Thread Frank Rowand
On 10/14/18 18:55, Joe Perches wrote: > On Sun, 2018-10-14 at 18:52 -0700, Frank Rowand wrote: >> On 10/14/18 18:06, Joe Perches wrote: >>> On Sun, 2018-10-14 at 17:24 -0700, frowand.l...@gmail.com wrote: From: Frank Rowand Add test case of two fragments updating the same property.

RE: [PATCH v4 5/6] arm64: dts: add QorIQ LX2160A SoC support

2018-10-14 Thread Vabhav Sharma
> -Original Message- > From: Shawn Guo > Sent: Monday, October 8, 2018 11:15 AM > To: Vabhav Sharma > Cc: sudeep.ho...@arm.com; o...@buserror.net; linux-ker...@vger.kernel.org; > devicet...@vger.kernel.org; robh...@kernel.org; mark.rutl...@arm.com; > linuxppc-dev@lists.ozlabs.org; linux

[PATCH 10/12] powerpc/prom_init: Move __prombss to it's own section and store it in .bss

2018-10-14 Thread Benjamin Herrenschmidt
This makes __prombss its own section, and for now store it in .bss. This will give us the ability later to store it elsewhere and/or free it after boot (it's about 8KB). Signed-off-by: Benjamin Herrenschmidt --- arch/powerpc/kernel/prom_init.c | 2 +- arch/powerpc/kernel/vmlinux.lds.S | 3 +++

[PATCH 04/12] powerpc/prom_init: Replace __initdata with __prombss when applicable

2018-10-14 Thread Benjamin Herrenschmidt
This replaces all occurrences of __initdata for uninitialized data with a new __prombss Currently __promdata is defined to be __initdata but we'll eventually change that. Signed-off-by: Benjamin Herrenschmidt --- arch/powerpc/kernel/prom_init.c | 55 + 1 file cha

[PATCH 03/12] powerpc/prom_init: Make "default_colors" const

2018-10-14 Thread Benjamin Herrenschmidt
It's never modified either Signed-off-by: Benjamin Herrenschmidt --- arch/powerpc/kernel/prom_init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/kernel/prom_init.c b/arch/powerpc/kernel/prom_init.c index e44f55be64ba..2e1ebf26e8e4 100644 --- a/arch/powerpc/ke

[PATCH 06/12] powerpc/prom_init: Move prom_radix_disable to __prombss

2018-10-14 Thread Benjamin Herrenschmidt
Initialize it dynamically instead of statically Signed-off-by: Benjamin Herrenschmidt --- arch/powerpc/kernel/prom_init.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/arch/powerpc/kernel/prom_init.c b/arch/powerpc/kernel/prom_init.c index 9852cdb8bb9e..70f2bde06ab3 1

[PATCH 08/12] powerpc/prom_init: Move const structures to __initconst

2018-10-14 Thread Benjamin Herrenschmidt
As they are no longer used past the end of prom_init Signed-off-by: Benjamin Herrenschmidt --- arch/powerpc/kernel/prom_init.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/powerpc/kernel/prom_init.c b/arch/powerpc/kernel/prom_init.c index 03b171bb1c29..cbd54fe30

[PATCH 05/12] powerpc/prom_init: Remove support for OPAL v2

2018-10-14 Thread Benjamin Herrenschmidt
We removed support for running under any OPAL version earlier than v3 in 2015 (they never saw the light of day anyway), but we kept some leftovers of this support in prom_init.c, so let's take it out. Signed-off-by: Benjamin Herrenschmidt --- arch/powerpc/kernel/prom_init.c | 125 +++

[PATCH 07/12] powerpc/prom_init: Move ibm_arch_vec to __prombss

2018-10-14 Thread Benjamin Herrenschmidt
Make the existing initialized definition constant and copy it to a __prombss copy Signed-off-by: Benjamin Herrenschmidt --- arch/powerpc/kernel/prom_init.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/arch/powerpc/kernel/prom_init.c b/arch/powerpc/kernel/prom_init.c

[PATCH 12/12] powerpc/prom_init: Generate "phandle" instead of "linux, phandle"

2018-10-14 Thread Benjamin Herrenschmidt
When creating the boot-time FDT from an actual Open Firmware live tree, let's generate "phandle" properties for the phandles instead of the old deprecated "linux,phandle". Signed-off-by: Benjamin Herrenschmidt --- arch/powerpc/kernel/prom_init.c | 12 +--- 1 file changed, 5 insertions(+)

[PATCH 11/12] powerpc: Check prom_init for disallowed sections

2018-10-14 Thread Benjamin Herrenschmidt
prom_init.c must not modify the kernel image outside of the .bss.prominit section. Thus make sure that prom_init.o doesn't have anything in any of these: .data .bss .init.data Signed-off-by: Benjamin Herrenschmidt --- arch/powerpc/kernel/prom_init_check.sh | 16 +

[PATCH 02/12] powerpc/prom_init: Make "fake_elf" const

2018-10-14 Thread Benjamin Herrenschmidt
It is never modified Signed-off-by: Benjamin Herrenschmidt --- arch/powerpc/kernel/prom_init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/kernel/prom_init.c b/arch/powerpc/kernel/prom_init.c index a1ba56e8c917..e44f55be64ba 100644 --- a/arch/powerpc/kernel/p

[PATCH 01/12] powerpc/prom_init: Make of_workarounds static

2018-10-14 Thread Benjamin Herrenschmidt
It's not used anywhere else Signed-off-by: Benjamin Herrenschmidt --- arch/powerpc/kernel/prom_init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/kernel/prom_init.c b/arch/powerpc/kernel/prom_init.c index 9b38a2e5dd35..a1ba56e8c917 100644 --- a/arch/powerpc/k

RE: [PATCH v4 6/6] arm64: dts: add LX2160ARDB board support

2018-10-14 Thread Vabhav Sharma
> -Original Message- > From: linux-kernel-ow...@vger.kernel.org ow...@vger.kernel.org> On Behalf Of Shawn Guo > Sent: Monday, October 8, 2018 11:22 AM > To: Vabhav Sharma > Cc: sudeep.ho...@arm.com; o...@buserror.net; linux-ker...@vger.kernel.org; > devicet...@vger.kernel.org; robh...@

[PATCH] powerpc/xmon: Show the stack protector canary in xmon

2018-10-14 Thread Michael Ellerman
This is helpful for debugging stack protector crashes. Signed-off-by: Michael Ellerman --- arch/powerpc/xmon/xmon.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/powerpc/xmon/xmon.c b/arch/powerpc/xmon/xmon.c index c70d17c9a6ba..d139741f26fe 100644 --- a/arch/powerpc/xmon/xmon.c ++

Re: [PATCH v3 13/18] of: overlay: check prevents multiple fragments touching same property

2018-10-14 Thread Joe Perches
On Sun, 2018-10-14 at 18:52 -0700, Frank Rowand wrote: > On 10/14/18 18:06, Joe Perches wrote: > > On Sun, 2018-10-14 at 17:24 -0700, frowand.l...@gmail.com wrote: > > > From: Frank Rowand > > > > > > Add test case of two fragments updating the same property. After > > > adding the test case, th

Re: [PATCH v3 13/18] of: overlay: check prevents multiple fragments touching same property

2018-10-14 Thread Frank Rowand
On 10/14/18 18:06, Joe Perches wrote: > On Sun, 2018-10-14 at 17:24 -0700, frowand.l...@gmail.com wrote: >> From: Frank Rowand >> >> Add test case of two fragments updating the same property. After >> adding the test case, the system hangs at end of boot, after >> after slub stack dumps from kfre

Re: [PATCH 16/33] powerpc/powernv: remove dead npu-dma code

2018-10-14 Thread Alexey Kardashevskiy
On 10/10/2018 00:24, Christoph Hellwig wrote: > This code has been unused since it was merged and is in the way of > cleaning up the DMA code, thus remove it. > > This effectively reverts commit 5d2aa710 ("powerpc/powernv: Add support > for Nvlink NPUs"). This code is heavily used by the NVIDI

Re: [PATCH v3 13/18] of: overlay: check prevents multiple fragments touching same property

2018-10-14 Thread Joe Perches
On Sun, 2018-10-14 at 17:24 -0700, frowand.l...@gmail.com wrote: > From: Frank Rowand > > Add test case of two fragments updating the same property. After > adding the test case, the system hangs at end of boot, after > after slub stack dumps from kfree() in crypto modprobe code. [] > -static in

Re: [PATCH 2/2] powerpc/pseries: Add driver for PAPR SCM regions

2018-10-14 Thread Michael Ellerman
Dan Williams writes: > On Sat, Oct 13, 2018 at 5:08 AM Michael Ellerman wrote: >> >> Dan Williams writes: >> > On Tue, Oct 9, 2018 at 11:21 PM Oliver O'Halloran wrote: >> >> >> >> Adds a driver that implements support for enabling and accessing PAPR >> >> SCM regions. Unfortunately due to how t

Re: [PATCH v2 12/18] of: overlay: check prevents multiple fragments add or delete same node

2018-10-14 Thread Frank Rowand
On 10/13/18 11:21, Frank Rowand wrote: > On 10/13/18 05:51, Joe Perches wrote: >> On Fri, 2018-10-12 at 21:53 -0700, frowand.l...@gmail.com wrote: >>> From: Frank Rowand >>> >>> Multiple overlay fragments adding or deleting the same node is not >>> supported. Replace code comment of such, with ch

[PATCH v3 18/18] of: unittest: initialize args before calling of_*parse_*()

2018-10-14 Thread frowand . list
From: Frank Rowand Callers of of_irq_parse_one() blindly use the pointer args.np without checking whether of_irq_parse_one() had an error and thus did not set the value of args.np. Initialize args to zero so that using the format "%pOF" to show the value of args.np will show "(null)" when of_irq

[PATCH v3 17/18] of: unittest: find overlays[] entry by name instead of index

2018-10-14 Thread frowand . list
From: Frank Rowand One accessor of overlays[] was using a hard coded index value to find the correct array entry instead of searching for the entry containing the correct name. Signed-off-by: Frank Rowand --- drivers/of/unittest.c | 21 + 1 file changed, 17 insertions(+), 4

[PATCH v3 16/18] of: unittest: allow base devicetree to have symbol metadata

2018-10-14 Thread frowand . list
From: Frank Rowand The overlay metadata nodes in the FDT created from testcases.dts are not handled properly. The __fixups__ and __local_fixups__ node were added to the live devicetree, but should not be. Only the first property in the /__symbols__ node was added to the live devicetree if the l

[PATCH v3 15/18] of: overlay: set node fields from properties when add new overlay node

2018-10-14 Thread frowand . list
From: Frank Rowand Overlay nodes added by add_changeset_node() do not have the node fields name, phandle, and type set. The node passed to __of_attach_node() when the add node changeset entry is processed does not contain any properties. The node's properties are located in add property changes

[PATCH v3 14/18] of: unittest: remove unused of_unittest_apply_overlay() argument

2018-10-14 Thread frowand . list
From: Frank Rowand Argument unittest_nr is not used in of_unittest_apply_overlay(), remove it. Signed-off-by: Frank Rowand --- drivers/of/unittest.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c index efd9c947f192..6d80

[PATCH v3 13/18] of: overlay: check prevents multiple fragments touching same property

2018-10-14 Thread frowand . list
From: Frank Rowand Add test case of two fragments updating the same property. After adding the test case, the system hangs at end of boot, after after slub stack dumps from kfree() in crypto modprobe code. Multiple overlay fragments adding, modifying, or deleting the same property is not suppor

[PATCH v3 12/18] of: overlay: check prevents multiple fragments add or delete same node

2018-10-14 Thread frowand . list
From: Frank Rowand Multiple overlay fragments adding or deleting the same node is not supported. Replace code comment of such, with check to detect the attempt and fail the overlay apply. Devicetree unittest where multiple fragments added the same node was added in the previous patch in the ser

[PATCH v3 11/18] of: overlay: test case of two fragments adding same node

2018-10-14 Thread frowand . list
From: Frank Rowand Multiple overlay fragments adding or deleting the same node is not supported. An attempt to do so results in an incorrect devicetree. The node name will be munged for the second add. After adding this patch, the unittest messages will show: Duplicate name in motor-1, rena

[PATCH v3 10/18] of: overlay: make all pr_debug() and pr_err() messages unique

2018-10-14 Thread frowand . list
From: Frank Rowand Make overlay.c debug and error messages unique so that they can be unambiguously found by grep. Signed-off-by: Frank Rowand --- drivers/of/overlay.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/of/overlay.c b/drivers/of/overlay.c i

[PATCH v3 09/18] of: overlay: validate overlay properties #address-cells and #size-cells

2018-10-14 Thread frowand . list
From: Frank Rowand If overlay properties #address-cells or #size-cells are already in the live devicetree for any given node, then the values in the overlay must match the values in the live tree. If the properties are already in the live tree then there is no need to create a changeset entry to

[PATCH v3 08/18] of: overlay: reorder fields in struct fragment

2018-10-14 Thread frowand . list
From: Frank Rowand Order the fields of struct fragment in the same order as struct of_overlay_notify_data. The order in struct fragment is not significant. If both structs are ordered the same then when examining the data in a debugger or dump the human involved does not have to remember which

[PATCH v3 07/18] of: dynamic: change type of of_{at, de}tach_node() to void

2018-10-14 Thread frowand . list
From: Frank Rowand of_attach_node() and of_detach_node() always return zero, so their return value is meaningless. Change their type to void and fix all callers to ignore return value. Signed-off-by: Frank Rowand --- arch/powerpc/platforms/pseries/dlpar.c| 13 ++--- arch/powerpc/p

[PATCH v3 06/18] of: overlay: do not duplicate properties from overlay for new nodes

2018-10-14 Thread frowand . list
From: Frank Rowand When allocating a new node, add_changeset_node() was duplicating the properties from the respective node in the overlay instead of allocating a node with no properties. When this patch is applied the errors reported by the devictree unittest from patch "of: overlay: add tests

[PATCH v3 05/18] of: overlay: use prop add changeset entry for property in new nodes

2018-10-14 Thread frowand . list
From: Frank Rowand The changeset entry 'update property' was used for new properties in an overlay instead of 'add property'. The decision of whether to use 'update property' was based on whether the property already exists in the subtree where the node is being spliced into. At the top level o

[PATCH v3 04/18] powerpc/pseries: add of_node_put() in dlpar_detach_node()

2018-10-14 Thread frowand . list
From: Frank Rowand "of: overlay: add missing of_node_get() in __of_attach_node_sysfs" added a missing of_node_get() to __of_attach_node_sysfs(). This results in a refcount imbalance for nodes attached with dlpar_attach_node(). The calling sequence from dlpar_attach_node() to __of_attach_node_sy

[PATCH v3 03/18] of: overlay: add missing of_node_get() in __of_attach_node_sysfs

2018-10-14 Thread frowand . list
From: Frank Rowand There is a matching of_node_put() in __of_detach_node_sysfs() Remove misleading comment from function header comment for of_detach_node(). This patch may result in memory leaks from code that directly calls the dynamic node add and delete functions directly instead of using c

[PATCH v3 02/18] of: overlay: add missing of_node_put() after add new node to changeset

2018-10-14 Thread frowand . list
From: Frank Rowand The refcount of a newly added overlay node decrements to one (instead of zero) when the overlay changeset is destroyed. This change will cause the final decrement be to zero. After applying this patch, new validation warnings will be reported from the devicetree unittest duri

[PATCH v3 01/18] of: overlay: add tests to validate kfrees from overlay removal

2018-10-14 Thread frowand . list
From: Frank Rowand Add checks: - attempted kfree due to refcount reaching zero before overlay is removed - properties linked to an overlay node when the node is removed - node refcount > one during node removal in a changeset destroy, if the node was created by the changeset After

[PATCH v3 00/18] of: overlay: validation checks, subsequent fixes

2018-10-14 Thread frowand . list
From: Frank Rowand Add checks to (1) overlay apply process and (2) memory freeing triggered by overlay release. The checks are intended to detect possible memory leaks and invalid overlays. The checks revealed bugs in existing code. Fixed the bugs. While fixing bugs, noted other issues, which

[PATCH] macintosh/windfarm_smu_sat: Fix debug output

2018-10-14 Thread Benjamin Herrenschmidt
There's some antiquated debug output that's trying to do a hand-made hexdump and turning into horrible 1-byte-per-line output these days. Use print_hex_dump() instead Signed-off-by: Benjamin Herrenschmidt --- drivers/macintosh/windfarm_smu_sat.c | 25 +++-- 1 file changed, 7

Re: [PATCH v3 2/2] powerpc/pseries: Add driver for PAPR SCM regions

2018-10-14 Thread Oliver
On Mon, Oct 15, 2018 at 10:44 AM Dan Williams wrote: > > On Sun, Oct 14, 2018 at 4:19 PM Oliver O'Halloran wrote: > > > > Adds a driver that implements support for enabling and accessing PAPR > > SCM regions. Unfortunately due to how the PAPR interface works we can't > > use the existing of_pmem

Re: [PATCH v3 2/2] powerpc/pseries: Add driver for PAPR SCM regions

2018-10-14 Thread Dan Williams
On Sun, Oct 14, 2018 at 4:19 PM Oliver O'Halloran wrote: > > Adds a driver that implements support for enabling and accessing PAPR > SCM regions. Unfortunately due to how the PAPR interface works we can't > use the existing of_pmem driver (yet) because: > > a) The guest is required to use the H_S

[PATCH v3 2/2] powerpc/pseries: Add driver for PAPR SCM regions

2018-10-14 Thread Oliver O'Halloran
Adds a driver that implements support for enabling and accessing PAPR SCM regions. Unfortunately due to how the PAPR interface works we can't use the existing of_pmem driver (yet) because: a) The guest is required to use the H_SCM_BIND_MEM h-call to add add the SCM region to it's physical add

[PATCH v3 1/2] powerpc/pseries: PAPR persistent memory support

2018-10-14 Thread Oliver O'Halloran
This patch implements support for discovering storage class memory devices at boot and for handling hotplug of new regions via RTAS hotplug events. Signed-off-by: Oliver O'Halloran --- v2: Added missing pmem.c v3: no changes --- arch/powerpc/include/asm/firmware.h | 3 +- arch/powerpc/in

Re: [PATCH 2/2] powerpc/pseries: Add driver for PAPR SCM regions

2018-10-14 Thread Oliver
On Sat, Oct 13, 2018 at 9:37 AM Dan Williams wrote: > > On Tue, Oct 9, 2018 at 11:21 PM Oliver O'Halloran wrote: > > > > Adds a driver that implements support for enabling and accessing PAPR > > SCM regions. Unfortunately due to how the PAPR interface works we can't > > use the existing of_pmem d

Re: [PATCH V4 2/15] KVM/MMU: Add tlb flush with range helper function

2018-10-14 Thread Russell King - ARM Linux
On Sun, Oct 14, 2018 at 09:21:23PM +0800, Tianyu Lan wrote: > Sorry to confuse your. I get from CCers from get_maintainer.pl script. Unfortunately you seem to have made a mistake. My email address is 'li...@armlinux.org.uk' not 'li...@armlinux.org'. There is no 'li...@armlinux.org' in MAINTAINER

Re: [PATCH V4 2/15] KVM/MMU: Add tlb flush with range helper function

2018-10-14 Thread Tianyu Lan
Hi Russell: Thanks for your review. On Sun, Oct 14, 2018 at 5:36 PM Russell King - ARM Linux wrote: > > On Sun, Oct 14, 2018 at 10:27:34AM +0100, Russell King - ARM Linux wrote: > > On Sun, Oct 14, 2018 at 10:16:56AM +0200, Thomas Gleixner wrote: > > > On Sun, 14 Oct 2018, Liran Alo

Re: [PATCH V4 2/15] KVM/MMU: Add tlb flush with range helper function

2018-10-14 Thread Tianyu Lan
Hi Liran & Thomas: Thanks for your review. On Sun, Oct 14, 2018 at 5:20 PM Liran Alon wrote: > > > > > On 14 Oct 2018, at 11:16, Thomas Gleixner wrote: > > > > On Sun, 14 Oct 2018, Liran Alon wrote: > >>> On 13 Oct 2018, at 17:53, lantianyu1...@gmail.com wrote: > >>> > >>> + > >>>

Re: [PATCH 1/2] powerpc/time: Use clockevents_register_device(), fixing an issue with large decrementer

2018-10-14 Thread Michael Ellerman
Anton Blanchard writes: > diff --git a/arch/powerpc/kernel/time.c b/arch/powerpc/kernel/time.c > index 70f145e02487..6a1f0a084ca3 100644 > --- a/arch/powerpc/kernel/time.c > +++ b/arch/powerpc/kernel/time.c > @@ -1035,18 +1035,7 @@ static void __init set_decrementer_max(void) > > static void _

Re: [PATCH v3 06/24] powerpc/mm: properly set PAGE_KERNEL flags in ioremap()

2018-10-14 Thread LEROY Christophe
LEROY Christophe a écrit : Michael Ellerman a écrit : Christophe Leroy writes: Set PAGE_KERNEL directly in the caller and do not rely on a hack adding PAGE_KERNEL flags when _PAGE_PRESENT is not set. As already done for PPC64, use pgprot_cache() helpers instead of _PAGE_XXX flags in PPC3

Re: [PATCH v3 06/24] powerpc/mm: properly set PAGE_KERNEL flags in ioremap()

2018-10-14 Thread LEROY Christophe
Michael Ellerman a écrit : Michael Ellerman writes: Christophe Leroy writes: Set PAGE_KERNEL directly in the caller and do not rely on a hack adding PAGE_KERNEL flags when _PAGE_PRESENT is not set. As already done for PPC64, use pgprot_cache() helpers instead of _PAGE_XXX flags in PPC32

Re: [PATCH V4 2/15] KVM/MMU: Add tlb flush with range helper function

2018-10-14 Thread Russell King - ARM Linux
On Sun, Oct 14, 2018 at 10:16:56AM +0200, Thomas Gleixner wrote: > On Sun, 14 Oct 2018, Liran Alon wrote: > > > On 13 Oct 2018, at 17:53, lantianyu1...@gmail.com wrote: > > > > > > From: Lan Tianyu > > > > > > This patch is to add wrapper functions for tlb_remote_flush_with_range > > > callback.

Re: [PATCH V4 2/15] KVM/MMU: Add tlb flush with range helper function

2018-10-14 Thread Russell King - ARM Linux
On Sun, Oct 14, 2018 at 10:27:34AM +0100, Russell King - ARM Linux wrote: > On Sun, Oct 14, 2018 at 10:16:56AM +0200, Thomas Gleixner wrote: > > On Sun, 14 Oct 2018, Liran Alon wrote: > > > > On 13 Oct 2018, at 17:53, lantianyu1...@gmail.com wrote: > > > > > > > > From: Lan Tianyu > > > > > > >

Re: [PATCH V4 2/15] KVM/MMU: Add tlb flush with range helper function

2018-10-14 Thread Liran Alon
> On 14 Oct 2018, at 11:16, Thomas Gleixner wrote: > > On Sun, 14 Oct 2018, Liran Alon wrote: >>> On 13 Oct 2018, at 17:53, lantianyu1...@gmail.com wrote: >>> >>> + >>> +static inline bool kvm_available_flush_tlb_with_range(void) >>> +{ >>> + return kvm_x86_ops->tlb_remote_flush_with_range;

Re: [PATCH V4 2/15] KVM/MMU: Add tlb flush with range helper function

2018-10-14 Thread Thomas Gleixner
On Sun, 14 Oct 2018, Liran Alon wrote: > > On 13 Oct 2018, at 17:53, lantianyu1...@gmail.com wrote: > > > > From: Lan Tianyu > > > > This patch is to add wrapper functions for tlb_remote_flush_with_range > > callback. > > > > Signed-off-by: Lan Tianyu > > --- > > Change sicne V3: > > Rem

Re: [PATCH v05 4/5] migration/memory: Evaluate LMB assoc changes

2018-10-14 Thread kbuild test robot
/commits/Michael-Bringmann/powerpc-migration-Affinity-fix-for-memory/20181014-130402 base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next config: powerpc-defconfig (attached as .config) compiler: powerpc64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0 reproduce: wget https

Re: [PATCH 5/8] pcmcia: allow PCMCIA support independent of the architecture

2018-10-14 Thread Christoph Hellwig
On Sun, Oct 14, 2018 at 07:42:52AM +0200, Dominik Brodowski wrote: > On Sat, Oct 13, 2018 at 05:10:13PM +0200, Christoph Hellwig wrote: > > There is nothing architecture specific in the PCMCIA core, so allow > > building it everywhere. The actual host controllers will depend on ISA, > > PCI or a s

Re: [PATCH v3 06/24] powerpc/mm: properly set PAGE_KERNEL flags in ioremap()

2018-10-14 Thread LEROY Christophe
Michael Ellerman a écrit : Christophe Leroy writes: Set PAGE_KERNEL directly in the caller and do not rely on a hack adding PAGE_KERNEL flags when _PAGE_PRESENT is not set. As already done for PPC64, use pgprot_cache() helpers instead of _PAGE_XXX flags in PPC32 ioremap() derived functions.

  1   2   >