Re: [PATCH v2 08/12] macintosh/via-pmu68k: Don't load driver on unsupported hardware

On Sat, 2018-06-09 at 22:21 +1000, Finn Thain wrote: > In anycase, the "v1" and "v2" scheme is obviously inadequate when you > consider the range of m68k powerbook models. Also, consider the > out-of-tree adaptation of via-pmu by the Nubus-PMac project, which has > this ABI break: > > diff --gi

Re: [PATCH v2 08/12] macintosh/via-pmu68k: Don't load driver on unsupported hardware

On Sat, 9 Jun 2018, Andreas Schwab wrote: > On Jun 09 2018, Finn Thain wrote: > > > There is no ABI issue AFAIK. The value of pmu_kind is visible to userland > > only on powerpc. /dev/pmu and /proc/pmu/* do not exist on m68k. > > Then why are PMU_68K_V1 and PMU_68K_V2 defined in the first plac

Re: [PATCH v2 08/12] macintosh/via-pmu68k: Don't load driver on unsupported hardware

On Jun 09 2018, Finn Thain wrote: > There is no ABI issue AFAIK. The value of pmu_kind is visible to userland > only on powerpc. /dev/pmu and /proc/pmu/* do not exist on m68k. Then why are PMU_68K_V1 and PMU_68K_V2 defined in the first place? Andreas. -- Andreas Schwab, sch...@linux-m68k.org

Re: [PATCH v2 08/12] macintosh/via-pmu68k: Don't load driver on unsupported hardware

> > > Is this enum used by any user space code? If so, perhaps rather > > > leave the PMU_68K_V1 in there to avoid upsetting that? > > > > It also changes the value of PMU_68K_V2, which is an ABI break. > > Yes, that's what I worry about - but do we know of any users of that > particular interf

Re: [PATCH kernel 3/6] KVM: PPC: Make iommu_table::it_userspace big endian

On Fri, Jun 08, 2018 at 03:46:30PM +1000, Alexey Kardashevskiy wrote: > We are going to reuse multilevel TCE code for the userspace copy of > the TCE table and since it is big endian, let's make the copy big endian > too. > > Signed-off-by: Alexey Kardashevskiy Reviewed-by: David Gibson > ---

Re: [PATCH v2 08/12] macintosh/via-pmu68k: Don't load driver on unsupported hardware

Hi Andreas, Am 09.06.2018 um 19:14 schrieb Andreas Schwab: On Jun 09 2018, Michael Schmitz wrote: Hi Finn, Am 08.06.2018 um 14:24 schrieb Finn Thain: Don't load the via-pmu68k driver on early PowerBooks. The M50753 PMU device found in those models was never supported by this driver. Attempt

Re: [PATCH v2 08/12] macintosh/via-pmu68k: Don't load driver on unsupported hardware

On Jun 09 2018, Michael Schmitz wrote: > Hi Finn, > > Am 08.06.2018 um 14:24 schrieb Finn Thain: >> Don't load the via-pmu68k driver on early PowerBooks. The M50753 PMU >> device found in those models was never supported by this driver. >> Attempting to load the driver usually causes a boot hang.