Re: [PATCH 08/11] macintosh/via-pmu: Replace via-pmu68k driver with via-pmu driver

2018-06-05 Thread Finn Thain
On Mon, 4 Jun 2018, Geert Uytterhoeven wrote: > > > Don't call pmu_shutdown() or pmu_restart() on early PowerBooks: the > > PMU device found in these PowerBooks isn't supported. > > Shouldn't that be a separate patch? > > > --- a/arch/m68k/mac/misc.c > > +++ b/arch/m68k/mac/misc.c > > > @@ -4

Re: [PATCH v7 0/5] powerpc/64: memcmp() optimization

2018-06-05 Thread Simon Guo
Hi Naveen, On Wed, Jun 06, 2018 at 12:06:09PM +0530, Naveen N. Rao wrote: > Simon Guo wrote: > >Hi Michael, > >On Tue, Jun 05, 2018 at 12:16:22PM +1000, Michael Ellerman wrote: > >>Hi Simon, > >> > >>wei.guo.si...@gmail.com writes: > >>> From: Simon Guo > >>> > >>> There is some room to optimize m

Re: Problems building ppc images in v4.14.y and v4.16.y using gcc 7.3.0 / 8.1.0 from kernel.org

2018-06-05 Thread Christophe LEROY
Le 05/06/2018 à 21:47, Arnd Bergmann a écrit : On Tue, Jun 5, 2018 at 6:06 PM, Guenter Roeck wrote: On Tue, Jun 05, 2018 at 04:31:00PM +0200, Arnd Bergmann wrote: On Tue, Jun 5, 2018 at 3:52 PM, Guenter Roeck wrote: Hi Arnd, when using the ppc64 compiler from kernel.org, I see the follow

Re: [PATCH v6 2/4] powerpc/64: enhance memcmp() with VMX instruction for long bytes comparision

2018-06-05 Thread Simon Guo
Hi segher, On Wed, May 30, 2018 at 05:03:21PM +0800, Simon Guo wrote: > On Wed, May 30, 2018 at 03:35:40AM -0500, Segher Boessenkool wrote: > > On Wed, May 30, 2018 at 04:14:02PM +0800, Simon Guo wrote: > > > Hi Segher, > > > On Mon, May 28, 2018 at 06:05:59AM -0500, Segher Boessenkool wrote: > > >

Re: [PATCH v7 0/5] powerpc/64: memcmp() optimization

2018-06-05 Thread Naveen N. Rao
Simon Guo wrote: Hi Michael, On Tue, Jun 05, 2018 at 12:16:22PM +1000, Michael Ellerman wrote: Hi Simon, wei.guo.si...@gmail.com writes: > From: Simon Guo > > There is some room to optimize memcmp() in powerpc 64 bits version for > following 2 cases: > (1) Even src/dst addresses are not aligne

Re: [PATCH v7 0/5] powerpc/64: memcmp() optimization

2018-06-05 Thread Simon Guo
Hi Michael, On Tue, Jun 05, 2018 at 12:16:22PM +1000, Michael Ellerman wrote: > Hi Simon, > > wei.guo.si...@gmail.com writes: > > From: Simon Guo > > > > There is some room to optimize memcmp() in powerpc 64 bits version for > > following 2 cases: > > (1) Even src/dst addresses are not aligned wi

[RFC PATCH 4/4] powerpc/pseries: Display machine check error details.

2018-06-05 Thread Mahesh J Salgaonkar
From: Mahesh Salgaonkar Extract the MCE eror details from RTAS extended log and display it to console. With this patch you should now see mce logs like below: [ 822.711745] Severe Machine check interrupt [Recovered] [ 822.711746] Initiator: CPU [ 822.711747] Error type: SLB [Multihit] [

[RFC PATCH 3/4] powerpc/pseries: Dump and flush SLB contents on SLB MCE errors.

2018-06-05 Thread Mahesh J Salgaonkar
From: Mahesh Salgaonkar If we get a machine check exceptions due to SLB errors then dump the current SLB contents which will be very much helpful in debugging the root cause of SLB errors. On pseries, as of today system crashes on SLB errors. These are soft errors and can be fixed by flushing the

[RFC PATCH 2/4] powerpc/pseries: Define MCE error event section.

2018-06-05 Thread Mahesh J Salgaonkar
From: Mahesh Salgaonkar On pseries, the machine check error details are part of RTAS extended event log passed under Machine check exception section. This patch adds the definition of rtas MCE event section and related helper functions. Signed-off-by: Mahesh Salgaonkar --- arch/powerpc/include

[RFC PATCH 1/4] powerpc/pseries: convert rtas_log_buf to linear allocation.

2018-06-05 Thread Mahesh J Salgaonkar
From: Mahesh Salgaonkar rtas_log_buf is a buffer to hold RTAS event data that are communicated to kernel by hypervisor. This buffer is then used to pass RTAS event data to user through proc fs. This buffer is allocated from vmalloc (non-linear mapping) area. On Machine check interrupt, register

[RFC PATCH 0/4] powerpc/pseries: Machien check handler improvements.

2018-06-05 Thread Mahesh J Salgaonkar
This patch series includes some improvement to Machine check handler for pseries. Patch 1 fixes an issue where machine check handler crashes kernel while accessing vmalloc-ed buffer while in nmi context. Patch 3 dumps the SLB contents on SLB MCE errors to improve the debugability. Patch 4 display's

[PATCH V2] crypto/nx: Initialize 842 high and normal RxFIFO control registers

2018-06-05 Thread Haren Myneni
NX increments readOffset by FIFO size in receive FIFO control register when CRB is read. But the index in RxFIFO has to match with the corresponding entry in FIFO maintained by VAS in kernel. Otherwise NX may be processing incorrect CRBs and can cause CRB timeout. VAS FIFO offset is 0 when the r

[PATCH] powerpc/64s/radix: Fix missing ptesync in flush_cache_vmap

2018-06-05 Thread Nicholas Piggin
There is a typo in f1cb8f9beb ("powerpc/64s/radix: avoid ptesync after set_pte and ptep_set_access_flags") config ifdef, which results in the necessary ptesync not being issued after vmalloc. This causes random kernel faults in module load, bpf load, anywhere that vmalloc mappings are used. After

Re: [PATCH QEMU] osdep: powerpc64 align memory to allow 2MB radix THP page tables

2018-06-05 Thread David Gibson
On Sun, May 06, 2018 at 05:29:49PM +1000, Nicholas Piggin wrote: > This allows KVM with the Book3S radix MMU mode to take advantage of > THP and install larger pages in the partition scope page tables (the > host translation). > > Signed-off-by: Nicholas Piggin I've applied this to my ppc-for-3.

Re: Problems building ppc images in v4.14.y and v4.16.y using gcc 7.3.0 / 8.1.0 from kernel.org

2018-06-05 Thread Arnd Bergmann
On Tue, Jun 5, 2018 at 6:06 PM, Guenter Roeck wrote: > On Tue, Jun 05, 2018 at 04:31:00PM +0200, Arnd Bergmann wrote: >> On Tue, Jun 5, 2018 at 3:52 PM, Guenter Roeck wrote: >> > Hi Arnd, >> > >> > when using the ppc64 compiler from kernel.org, I see the following problems >> > when trying to com

Re: Problems building ppc images in v4.14.y and v4.16.y using gcc 7.3.0 / 8.1.0 from kernel.org

2018-06-05 Thread Guenter Roeck
On Tue, Jun 05, 2018 at 04:31:00PM +0200, Arnd Bergmann wrote: > On Tue, Jun 5, 2018 at 3:52 PM, Guenter Roeck wrote: > > Hi Arnd, > > > > when using the ppc64 compiler from kernel.org, I see the following problems > > when trying to compile ppc:allnoconfig in v4.14.y or v4.16.y. > > > > gcc 7.3.0

Re: [-next] ocxl: Fix missing unlock on error in afu_ioctl_enable_p9_wait()

2018-06-05 Thread Michael Ellerman
On Tue, 2018-06-05 at 09:16:21 UTC, Wei Yongjun wrote: > Add the missing unlock before return from function > afu_ioctl_enable_p9_wait() in the error handling case. > > Fixes: e948e06fc63a ("ocxl: Expose the thread_id needed for wait on POWER9") > Signed-off-by: Wei Yongjun > Reviewed-by: Alastai

Re: powerpc: fix build failure by disabling attribute-alias warning in pci_32

2018-06-05 Thread Michael Ellerman
On Tue, 2018-06-05 at 06:57:43 UTC, Christophe Leroy wrote: > Commit 2479bfc9bc600 ("powerpc: Fix build by disabling attribute-alias > warning for SYSCALL_DEFINEx") forgot arch/powerpc/kernel/pci_32.c > > Latest GCC version emit the following warnings > > As arch/powerpc code is built with -Werro

Re: powerpc/powernv: copy/paste - Mask SO bit in CR

2018-06-05 Thread Michael Ellerman
On Mon, 2018-06-04 at 08:33:38 UTC, Michael Ellerman wrote: > NX can set the 3rd bit in CR register for XER[SO] (Summary overflow) > which is not related to paste request. The current paste function > returns failure for a successful request when this bit is set. So mask > this bit and check the pr

Re: cpuidle:powernv: Make the snooze timeout dynamic.

2018-06-05 Thread Michael Ellerman
On Thu, 2018-05-31 at 12:15:09 UTC, "Gautham R. Shenoy" wrote: > From: "Gautham R. Shenoy" > > The commit 78eaa10f027c ("cpuidle: powernv/pseries: Auto-promotion of > snooze to deeper idle state") introduced a timeout for the snooze idle > state so that it could be eventually be promoted to a dee

Re: powerpc-opal: fix spelling mistake "Uniterrupted" -> "Uninterrupted"

2018-06-05 Thread Michael Ellerman
On Sat, 2018-05-26 at 15:15:31 UTC, Colin King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in hmi_error_types text > > Signed-off-by: Colin Ian King > Reviewed-by: Stewart Smith Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/b0c4acb1dd7c653f7839166107

Re: powerpc/pkeys: Detach execute_only key on !PROT_EXEC

2018-06-05 Thread Michael Ellerman
On Fri, 2018-05-04 at 20:01:51 UTC, Ram Pai wrote: > Disassociate the exec_key from a VMA if the VMA permission is not > PROT_EXEC anymore. Otherwise the exec_only key continues to be > associated with the vma, causing unexpected behavior. > > The problem was reported on x86 by Shakeel Butt, > wh

Re: powerpc: fix spelling mistake: "Usupported" -> "Unsupported"

2018-06-05 Thread Michael Ellerman
On Fri, 2018-03-30 at 15:55:53 UTC, Colin King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in bootx_printf message text > > Signed-off-by: Colin Ian King Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/e6536a9f94c00a5e1da0a869ccea07 cheers

Re: Problems building ppc images in v4.14.y and v4.16.y using gcc 7.3.0 / 8.1.0 from kernel.org

2018-06-05 Thread Arnd Bergmann
On Tue, Jun 5, 2018 at 3:52 PM, Guenter Roeck wrote: > Hi Arnd, > > when using the ppc64 compiler from kernel.org, I see the following problems > when trying to compile ppc:allnoconfig in v4.14.y or v4.16.y. > > gcc 7.3.0: Compilation of kernel.cpu.o hangs > > The problem goes away if I apply the

Re: [PATCH 09/10] dpaa_eth: add support for hardware timestamping

2018-06-05 Thread Richard Cochran
On Tue, Jun 05, 2018 at 03:35:28AM +, Y.b. Lu wrote: > [Y.b. Lu] Actually these timestamping codes affected DPAA networking > performance in our previous performance test. > That's why we used ifdef for it. How much does time stamping hurt performance? If the time stamping is compiled in but

Re: [PATCH -next] ocxl: Fix missing unlock on error in afu_ioctl_enable_p9_wait()

2018-06-05 Thread Frederic Barrat
Le 05/06/2018 à 11:16, Wei Yongjun a écrit : Add the missing unlock before return from function afu_ioctl_enable_p9_wait() in the error handling case. Fixes: e948e06fc63a ("ocxl: Expose the thread_id needed for wait on POWER9") Signed-off-by: Wei Yongjun --- drivers/misc/ocxl/file.c | 4 ++

Re: [RFC PATCH for 4.18 10/16] powerpc: Wire up restartable sequences system call

2018-06-05 Thread Mathieu Desnoyers
- On Jun 5, 2018, at 1:18 AM, Michael Ellerman m...@ellerman.id.au wrote: > Mathieu Desnoyers writes: > >> From: Boqun Feng >> >> Wire up the rseq system call on powerpc. >> >> This provides an ABI improving the speed of a user-space getcpu >> operation on powerpc by skipping the getcpu sys

Re: [RFC PATCH for 4.18 09/16] powerpc: Add syscall detection for restartable sequences

2018-06-05 Thread Mathieu Desnoyers
- On Jun 5, 2018, at 1:21 AM, Michael Ellerman m...@ellerman.id.au wrote: > Mathieu Desnoyers writes: >> From: Boqun Feng >> >> Syscalls are not allowed inside restartable sequences, so add a call to >> rseq_syscall() at the very beginning of system call exiting path for >> CONFIG_DEBUG_RSEQ

Re: [v3] powerpc: fix build failure by disabling attribute-alias warning

2018-06-05 Thread Michael Ellerman
Christophe LEROY writes: > Le 04/06/2018 à 16:11, Michael Ellerman a écrit : >> On Tue, 2018-05-29 at 16:06:41 UTC, Christophe Leroy wrote: >>> Latest GCC version emit the following warnings >>> >>> As arch/powerpc code is built with -Werror, this breaks build with >>> GCC 8.1 >>> >>> >>> Sig

Re: [PATCH] cpuidle:powernv: Make the snooze timeout dynamic.

2018-06-05 Thread Michael Ellerman
Gautham R Shenoy writes: > Hello Michael, > > On Mon, Jun 04, 2018 at 09:27:40PM +1000, Michael Ellerman wrote: >> "Gautham R. Shenoy" writes: >> >> > From: "Gautham R. Shenoy" >> > >> > The commit 78eaa10f027c ("cpuidle: powernv/pseries: Auto-promotion of >> > snooze to deeper idle state") int

RE: [PATCH -next] ocxl: Fix missing unlock on error in afu_ioctl_enable_p9_wait()

2018-06-05 Thread Alastair D'Silva
> -Original Message- > From: Wei Yongjun > Sent: Tuesday, 5 June 2018 7:16 PM > To: Frederic Barrat ; Andrew Donnellan > ; Arnd Bergmann ; > Greg Kroah-Hartman ; Alastair D'Silva > > Cc: Wei Yongjun ; linuxppc- > d...@lists.ozlabs.org; linux-ker...@vger.kernel.org; kernel- > janit...@vger

[PATCH -next] ocxl: Fix missing unlock on error in afu_ioctl_enable_p9_wait()

2018-06-05 Thread Wei Yongjun
Add the missing unlock before return from function afu_ioctl_enable_p9_wait() in the error handling case. Fixes: e948e06fc63a ("ocxl: Expose the thread_id needed for wait on POWER9") Signed-off-by: Wei Yongjun --- drivers/misc/ocxl/file.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)

Re: [PATCH v2] cpuidle/powernv : Add Description for cpuidle state

2018-06-05 Thread Akshay Adiga
On Tue, Jun 05, 2018 at 02:24:39PM +0530, Abhishek wrote: > > > On 06/04/2018 05:15 PM, Akshay Adiga wrote: > > On Mon, Jun 04, 2018 at 07:04:14PM +1000, Benjamin Herrenschmidt wrote: > > > Is this a new property ? I'm not fan of adding yet another of those > > > silly arrays. > > > > > > I woul

Re: [PATCH v2] cpuidle/powernv : Add Description for cpuidle state

2018-06-05 Thread Abhishek
On 06/04/2018 05:15 PM, Akshay Adiga wrote: On Mon, Jun 04, 2018 at 07:04:14PM +1000, Benjamin Herrenschmidt wrote: Is this a new property ? I'm not fan of adding yet another of those silly arrays. I would say this is the right time now to switch over to a node per state instead, as we discu

Re: [PATCH] cpuidle:powernv: Make the snooze timeout dynamic.

2018-06-05 Thread Gautham R Shenoy
Hello Michael, On Mon, Jun 04, 2018 at 09:27:40PM +1000, Michael Ellerman wrote: > "Gautham R. Shenoy" writes: > > > From: "Gautham R. Shenoy" > > > > The commit 78eaa10f027c ("cpuidle: powernv/pseries: Auto-promotion of > > snooze to deeper idle state") introduced a timeout for the snooze idle

Re: [v3] powerpc: fix build failure by disabling attribute-alias warning

2018-06-05 Thread Christophe LEROY
Le 04/06/2018 à 16:11, Michael Ellerman a écrit : On Tue, 2018-05-29 at 16:06:41 UTC, Christophe Leroy wrote: Latest GCC version emit the following warnings As arch/powerpc code is built with -Werror, this breaks build with GCC 8.1 This patch inhibits those warnings CC arch/powerpc