On Thu, 5 Apr 2018 15:53:07 +1000
Balbir Singh wrote:
> On Thu, 5 Apr 2018 15:04:05 +1000
> Nicholas Piggin wrote:
>
> > On Wed, 4 Apr 2018 20:00:52 -0700
> > Dan Williams wrote:
> >
> > > [ adding Matthew, Christoph, and Tony ]
> > >
> > > On Wed, Apr 4, 2018 at 4:57 PM, Nicholas Piggin
POWER8 restores AMOR when waking from deep sleep, but POWER9 does not,
because it does not go through the subcore restore.
Have POWER9 restore it in core restore.
Cc: Vaidyanathan Srinivasan
Signed-off-by: Nicholas Piggin
---
Do we need this guy after waking from deep sleep?
This code is a li
The CPU_FTR_POWER9_DD2_1 flag is intended to be set for DD2.1 and
above (which is what the dt_cpu_ftrs setup does). Fix cputable for
DD2.2 to match.
This came about due to patches b5af4f279323 ("powerpc: Add CPU feature
bits for TM bug workarounds on POWER9 v2.2"), and 9e9626ed3a4a
("powerpc/64s:
The pkey code added a CPU_FTR_PKEY bit, but did not add it to the
dt_cpu_ftrs feature set. Although capability is supported by all
processors in the base dt_cpu_ftrs set for 64s, it's a significant
and sufficiently well defined feature to make it optional. So add
it as a quirk for now, which can be
These are a couple of differences between cputable and dt_cpu_ftrs
I noticed with CPU_FTR bits. We have to be a bit careful now to keep
them in sync when we change one or the other.
Nicholas Piggin (2):
powerpc/64s: Fix pkey support in dt_cpu_ftrs, add CPU_FTR_PKEY bit
powerpc/64s: Fix POWER9
LEROY Christophe writes:
> Mathieu Malaterre a écrit :
>
>> Add gcc attribute unused for two variables. Fix warnings treated as errors
>> with W=1:
>>
>> arch/powerpc/kernel/prom_init.c:1388:8: error: variable ‘path’ set
>> but not used [-Werror=unused-but-set-variable]
>>
>> Suggested-by: C
On Thu, 5 Apr 2018 15:04:05 +1000
Nicholas Piggin wrote:
> On Wed, 4 Apr 2018 20:00:52 -0700
> Dan Williams wrote:
>
> > [ adding Matthew, Christoph, and Tony ]
> >
> > On Wed, Apr 4, 2018 at 4:57 PM, Nicholas Piggin wrote:
> > > On Thu, 5 Apr 2018 09:19:42 +1000
> > > Balbir Singh wrote
Presently the dt_cpu_ftrs restore_cpu will only add bits to the LPCR
for secondaries, but some bits must be removed (e.g., UPRT for HPT).
Not clearing these bits on secondaries causes checkstops when booting
with disable_radix.
restore_cpu can not just set LPCR, because it is also called by the
id
On Wed, 4 Apr 2018 20:00:52 -0700
Dan Williams wrote:
> [ adding Matthew, Christoph, and Tony ]
>
> On Wed, Apr 4, 2018 at 4:57 PM, Nicholas Piggin wrote:
> > On Thu, 5 Apr 2018 09:19:42 +1000
> > Balbir Singh wrote:
> >
> >> The pmem infrastructure uses memcpy_mcsafe in the pmem
> >> laye
On 04/04/2018 12:56 AM, Hari Bathini wrote:
> Mahesh, I think we should explicitly document that production and
> capture kernel
> versions should be same. For changes like below, older/newer production
> kernel vs
> capture kernel is bound to fail. Of course, production and capture
> kernel versio
On Wed, 4 Apr 2018 07:21:32 -0700
Dan Williams wrote:
> On Wed, Apr 4, 2018 at 7:04 AM, Oliver wrote:
> > On Wed, Apr 4, 2018 at 10:07 PM, Balbir Singh
> > wrote:
> >> On Tue, 3 Apr 2018 10:37:51 -0700
> >> Dan Williams wrote:
> >>
> >>> On Tue, Apr 3, 2018 at 7:24 AM, Oliver O'Halloran
[ adding Matthew, Christoph, and Tony ]
On Wed, Apr 4, 2018 at 4:57 PM, Nicholas Piggin wrote:
> On Thu, 5 Apr 2018 09:19:42 +1000
> Balbir Singh wrote:
>
>> The pmem infrastructure uses memcpy_mcsafe in the pmem
>> layer so as to convert machine check excpetions into
>> a return value on fail
On Thu, 5 Apr 2018 09:49:00 +1000
Nicholas Piggin wrote:
> On Thu, 5 Apr 2018 09:19:41 +1000
> Balbir Singh wrote:
>
> > The code currently assumes PAGE_SHIFT as the shift value of
> > the pfn, this works correctly (mostly) for user space pages,
> > but the correct thing to do is
>
> It wou
On Thu, 5 Apr 2018 09:19:42 +1000
Balbir Singh wrote:
> The pmem infrastructure uses memcpy_mcsafe in the pmem
> layer so as to convert machine check excpetions into
> a return value on failure in case a machine check
> exception is encoutered during the memcpy.
>
> This patch largely borrows f
On Thu, 5 Apr 2018 09:19:41 +1000
Balbir Singh wrote:
> The code currently assumes PAGE_SHIFT as the shift value of
> the pfn, this works correctly (mostly) for user space pages,
> but the correct thing to do is
It would be good to actually explain the problem in the
changelog. I would have tho
Add a blocking notifier callback to be called in real-mode
on machine check exceptions for UE (ld/st) errors only.
The patch registers a callback on boot to be notified
of machine check exceptions and returns a NOTIFY_STOP when
a page of interest is seen as the source of the machine
check exception
The pmem infrastructure uses memcpy_mcsafe in the pmem
layer so as to convert machine check excpetions into
a return value on failure in case a machine check
exception is encoutered during the memcpy.
This patch largely borrows from the copyuser_power7
logic and does not add the VMX optimizations,
The code currently assumes PAGE_SHIFT as the shift value of
the pfn, this works correctly (mostly) for user space pages,
but the correct thing to do is
1. Extrace the shift value returned via the pte-walk API's
2. Use the shift value to access the instruction address.
Note, the final physical add
memcpy_mcsafe() is an API currently used by the pmem subsystem to convert
errors while doing a memcpy (machine check exception errors) to a return
value. This patchset consists of three patches
1. The first patch is a bug fix to handle machine check errors correctly
while walking the page tables i
On Wed, Apr 04, 2018 at 06:26:44PM +0200, Laurent Dufour wrote:
>
>
> On 03/04/2018 21:39, Jerome Glisse wrote:
> > On Tue, Mar 13, 2018 at 06:59:45PM +0100, Laurent Dufour wrote:
> >> When dealing with the speculative fault path we should use the VMA's field
> >> cached value stored in the vm_fa
On Wed, 4 Apr 2018, Laurent Dufour wrote:
> > I also think the following is needed:
> >
> > diff --git a/fs/exec.c b/fs/exec.c
> > --- a/fs/exec.c
> > +++ b/fs/exec.c
> > @@ -312,6 +312,10 @@ static int __bprm_mm_init(struct linux_binprm *bprm)
> > vma->vm_flags = VM_SOFTDIRTY | VM_STACK_FLAG
Hello Ram,
Ram Pai writes:
> Applications need the ability to associate an address-range with some
> key and latter revert to its initial default key. Pkey-0 comes close to
> providing this function but falls short, because the current
> implementation disallows applications to explicitly assoc
On Thu, Mar 29, 2018 at 6:07 PM, LEROY Christophe
wrote:
> Mathieu Malaterre a écrit :
>
>
>> Since the value of x is never intended to be read, declare it with gcc
>> attribute as unused. Fix warning treated as error with W=1:
>>
>> arch/powerpc/platforms/powermac/bootx_init.c:471:21: error: v
On Thu, Mar 29, 2018 at 6:02 PM, LEROY Christophe
wrote:
> Mathieu Malaterre a écrit :
>
>
>> On Fri, Mar 23, 2018 at 1:20 PM, christophe leroy
>> wrote:
>>>
>>>
>>>
>>> Le 22/03/2018 à 21:20, Mathieu Malaterre a écrit :
Add one missing prototype for function rh_dump_blk. Fix warn
These functions can all be static, make it so. Fix warnings treated as
errors with W=1:
arch/powerpc/platforms/chrp/pci.c:34:5: error: no previous prototype for
‘gg2_read_config’ [-Werror=missing-prototypes]
arch/powerpc/platforms/chrp/pci.c:61:5: error: no previous prototype for
‘gg2_write_
The pmac_pfunc_base_install prototype was declared in powermac/smp.c since
function was used there, move it to pmac_pfunc.h header to be visible in
pfunc_base.c. Fix a warning treated as error with W=1:
arch/powerpc/platforms/powermac/pfunc_base.c:330:12: error: no previous
prototype for ‘pmac_
Add a missing prototype for function `note_bootable_part` to silence a
warning treated as error with W=1:
arch/powerpc/platforms/powermac/setup.c:361:12: error: no previous prototype
for ‘note_bootable_part’ [-Werror=missing-prototypes]
Suggested-by: Christophe Leroy
Signed-off-by: Mathieu Ma
The function prototypes were declared within a `#ifdef CONFIG_PPC_LITE5200`
block which would prevent them from being visible when compiling
`mpc52xx_pm.c`. Move the prototypes outside of the `#ifdef` block to fix
the following warnings treated as errors with W=1:
arch/powerpc/platforms/52xx/mpc
Add one missing prototype for function rh_dump_blk. Fix warning treated as
error in W=1:
arch/powerpc/lib/rheap.c:740:6: error: no previous prototype for
‘rh_dump_blk’ [-Werror=missing-prototypes]
Suggested-by: Christophe Leroy
Signed-off-by: Mathieu Malaterre
---
v3: remove extern keyword
v
Some function prototypes and body for Thermal Assist Units were not in
sync. Update the function definition to match the existing function
declaration found in `setup-common.c`, changing an `int` return type to a
`u32` return type. Move the prototypes to a header file. Fix the following
warnings, t
Remove variable declaration idu_size and associated code since not used.
These functions can all be static, make it so. Fix warnings treated as
errors with W=1:
arch/powerpc/platforms/chrp/setup.c:97:6: error: no previous prototype for
‘chrp_show_cpuinfo’ [-Werror=missing-prototypes]
arch/po
Add gcc attribute unused for two variables. Fix warnings treated as errors
with W=1:
arch/powerpc/kernel/prom_init.c:1388:8: error: variable ‘path’ set but not
used [-Werror=unused-but-set-variable]
Suggested-by: Christophe Leroy
Signed-off-by: Mathieu Malaterre
---
v3: really move path with
Since the value of x is never intended to be read, declare it with gcc
attribute as unused. Fix warning treated as error with W=1:
arch/powerpc/platforms/powermac/bootx_init.c:471:21: error: variable ‘x’ set
but not used [-Werror=unused-but-set-variable]
Suggested-by: Christophe Leroy
Signed-
FADump capture kernel boots in a restricted memory environment saving the
context of previous kernel to capture vmcore. Having hugepages support in
such environment would make things unnecessarily complicated, as hugepages
need memory set aside for them and this would mean too much memory wasted
in
From: Mahesh Salgaonkar
The second kernel, during early boot after the crash, reserves rest of
the memory above boot memory size to make sure it does not touch any of the
dump memory area. It uses memblock_reserve() that reserves the specified
memory region irrespective of memory holes present wi
On 03/04/2018 21:39, Jerome Glisse wrote:
> On Tue, Mar 13, 2018 at 06:59:45PM +0100, Laurent Dufour wrote:
>> When dealing with the speculative fault path we should use the VMA's field
>> cached value stored in the vm_fault structure.
>>
>> Currently vm_normal_page() is using the pointer to the
On 03/04/2018 01:18, David Rientjes wrote:
> On Tue, 13 Mar 2018, Laurent Dufour wrote:
>
>> diff --git a/include/linux/mm.h b/include/linux/mm.h
>> index a84ddc218bbd..73b8b99f482b 100644
>> --- a/include/linux/mm.h
>> +++ b/include/linux/mm.h
>> @@ -1263,8 +1263,11 @@ struct zap_details {
>>
On 03/04/2018 01:12, David Rientjes wrote:
> On Tue, 13 Mar 2018, Laurent Dufour wrote:
>
>> diff --git a/include/linux/mm.h b/include/linux/mm.h
>> index dfa81a638b7c..a84ddc218bbd 100644
>> --- a/include/linux/mm.h
>> +++ b/include/linux/mm.h
>> @@ -684,13 +684,18 @@ void free_compound_page(stru
On 03/04/2018 00:24, David Rientjes wrote:
> On Tue, 13 Mar 2018, Laurent Dufour wrote:
>
>> diff --git a/include/linux/mm.h b/include/linux/mm.h
>> index ef6ef0627090..dfa81a638b7c 100644
>> --- a/include/linux/mm.h
>> +++ b/include/linux/mm.h
>> @@ -359,6 +359,12 @@ struct vm_fault {
>>
The disabling informational messages on the PCI subsystem should be deleted
since they do not represent any real value for the system logs.
These messages are either not presented, or presented for all PCI devices
(e.g., powerpc now realigns all PCI devices to its page size). Thus, they
are floodi
On Wed, 2018-04-04 at 10:41:16 UTC, "Naveen N. Rao" wrote:
> We get the below warning if we try to use kexec on P9:
> kexec_core: Starting new kernel
> WARNING: CPU: 0 PID: 1223 at arch/powerpc/kernel/process.c:826
> __set_breakpoint+0xb4/0x140
> [snip]
> NIP [c001bf44] __s
On Tue, 2018-04-03 at 13:54:02 UTC, Frederic Barrat wrote:
> cxllib_handle_fault() is called by an external driver when it needs to
> have the host resolve page faults for a buffer. The buffer can cover
> several pages and VMAs. The function iterates over all the pages used
> by the buffer, based o
On Sun, 2018-04-01 at 10:36:13 UTC, Nicholas Piggin wrote:
> Use the NMI IPI rather than smp_call_function for smp_send_stop.
> Have stopped CPUs hard disable interrupts rather than just soft
> disable.
>
> This function is used in crash/panic/shutdown paths to bring other
> CPUs down as quickly a
On Sun, 2018-04-01 at 05:48:55 UTC, Nicholas Piggin wrote:
> When stop is executed with EC=ESL=0, it appears to execute like a
> normal instruction (resuming from NIP when woken by interrupt). So all
> the save/restore handling can be avoided completely. In particular NV
> GPRs do not have to be sa
On Sun, 2018-04-01 at 05:38:13 UTC, Nicholas Piggin wrote:
> PSSCR value is not stored to PACA_REQ_PSSCR in case the CPU does
> not have the XER[SO] bug.
>
> Fix this by storing up-front, outside the workaround code. The
> initial test is not required because it is a slow path.
>
> The workaround
On Fri, 2018-03-30 at 12:09:01 UTC, "Aneesh Kumar K.V" wrote:
> From: "Aneesh Kumar K.V"
>
> kernel parameter disable_radix takes different options
> disable_radix=yes|no|1|0 or just disable_radix. When using the later format
> we get below error.
>
> `Malformed early option 'disable_radix'`
>
On Fri, 2018-03-30 at 12:04:08 UTC, "Aneesh Kumar K.V" wrote:
> From: "Aneesh Kumar K.V"
>
> With 64k page size, we have hugetlb pte entries at the pmd and pud level for
> book3s64. We don't need to create a separate page table cache for that. With
> 4k
> we need to make sure hugepd page table c
On Thu, 2018-03-22 at 08:43:50 UTC, "Aneesh Kumar K.V" wrote:
> Right now we use only 4K out of the 64k page allocated for the level 4 page
> table. W.r.t the performance impact due to lock contention, with ebizzy
>
> 256 threads:
> without patch (10 runs of ./ebizzy -m -n 1000 -s 131072 -S 100)
On Wed, 2018-03-07 at 13:36:45 UTC, "Aneesh Kumar K.V" wrote:
> No functionality change in this patch. Adds more code comments. We also remove
> an unnecessary pkey check after we check for pkey error in this patch.
>
> Signed-off-by: Aneesh Kumar K.V
Applied to powerpc next, thanks.
https://gi
On Wed, Apr 4, 2018 at 7:04 AM, Oliver wrote:
> On Wed, Apr 4, 2018 at 10:07 PM, Balbir Singh wrote:
>> On Tue, 3 Apr 2018 10:37:51 -0700
>> Dan Williams wrote:
>>
>>> On Tue, Apr 3, 2018 at 7:24 AM, Oliver O'Halloran wrote:
>>> > Add device-tree binding documentation for the nvdimm region driv
On Wed, Apr 4, 2018 at 10:07 PM, Balbir Singh wrote:
> On Tue, 3 Apr 2018 10:37:51 -0700
> Dan Williams wrote:
>
>> On Tue, Apr 3, 2018 at 7:24 AM, Oliver O'Halloran wrote:
>> > Add device-tree binding documentation for the nvdimm region driver.
>> >
>> > Cc: devicet...@vger.kernel.org
>> > Sign
Le 03/04/2018 à 17:31, Aneesh Kumar K.V a écrit :
On 04/03/2018 08:10 PM, Aneesh Kumar K.V wrote:
On 04/03/2018 03:13 PM, Frederic Barrat wrote:
cxllib_handle_fault() is called by an external driver when it needs to
have the host process page faults for a buffer which may cover several
pages.
On Friday 30 March 2018 06:47 AM, Pingfan Liu wrote:
Some user space tools such as kexec-tools resort to the event
add/remove to decide whether rebuilding dtb or not.
So if a new core added and a crash happens on one of its thread,
then kexec fails to bring up the 2nd kernel since lacking the i
Nicholas Piggin writes:
> On Wed, 4 Apr 2018 02:03:18 +1000 (AEST)
> Michael Ellerman wrote:
>> On Fri, 2017-11-17 at 14:08:05 UTC, Nicholas Piggin wrote:
>> > Implement a new function to invoke stop, power9_offline_stop, which is
>> > like power9_idle_stop but used by the cpu hotplug code.
>> >
Anshuman Khandual writes:
> Even though SWIOTLB slab gets allocated and initialized on powerpc with
> swiotlb_init() called during mem_init(), it gets released away again on
> POWER platform because 'ppc_swiotlb_enable' never gets set. The function
> swiotlb_detect_4g() checks for 4GB memory and t
On Wed, 4 Apr 2018 00:24:15 +1000
Oliver O'Halloran wrote:
> Scan the devicetree for an nvdimm-bus compatible and create
> a platform device for them.
>
> Signed-off-by: Oliver O'Halloran
> ---
Acked-by: Balbir Singh
On Tue, 3 Apr 2018 10:37:51 -0700
Dan Williams wrote:
> On Tue, Apr 3, 2018 at 7:24 AM, Oliver O'Halloran wrote:
> > Add device-tree binding documentation for the nvdimm region driver.
> >
> > Cc: devicet...@vger.kernel.org
> > Signed-off-by: Oliver O'Halloran
> > ---
> > v2: Changed name from
On Wed, 4 Apr 2018 00:24:12 +1000
Oliver O'Halloran wrote:
> We want to be able to cross reference the region and bus devices
> with the device tree node that they were spawned from. libNVDIMM
> handles creating the actual devices for these internally, so we
> need to pass in a pointer to the re
We get the below warning if we try to use kexec on P9:
kexec_core: Starting new kernel
WARNING: CPU: 0 PID: 1223 at arch/powerpc/kernel/process.c:826
__set_breakpoint+0xb4/0x140
[snip]
NIP [c001bf44] __set_breakpoint+0xb4/0x140
LR [c0061268] kexec_prepare_cpus_w
On 04/04/2018 03:03, David Rientjes wrote:
> On Tue, 3 Apr 2018, David Rientjes wrote:
>
> I found the root cause of this lockdep warning.
>
> In mmap_region(), unmap_region() may be called while vma_link() has not
> been
> called. This happens during the error path if call_
On 04/04/2018 02:48, David Rientjes wrote:
> On Wed, 28 Mar 2018, Laurent Dufour wrote:
>
>> On 26/03/2018 00:10, David Rientjes wrote:
>>> On Wed, 21 Mar 2018, Laurent Dufour wrote:
>>>
I found the root cause of this lockdep warning.
In mmap_region(), unmap_region() may be called
On 03/04/2018 21:10, Jerome Glisse wrote:
> On Tue, Mar 13, 2018 at 06:59:36PM +0100, Laurent Dufour wrote:
>> pte_unmap_same() is making the assumption that the page table are still
>> around because the mmap_sem is held.
>> This is no more the case when running a speculative page fault and
>> a
On 03/04/2018 23:57, David Rientjes wrote:
> On Wed, 28 Mar 2018, Laurent Dufour wrote:
>
diff --git a/include/linux/mm.h b/include/linux/mm.h
index 4d02524a7998..2f3e98edc94a 100644
--- a/include/linux/mm.h
+++ b/include/linux/mm.h
@@ -300,6 +300,7 @@ extern pgprot_t pr
On Wed, Apr 04, 2018 at 06:36:25AM +0300, Yury Norov wrote:
> On Tue, Apr 03, 2018 at 02:48:32PM +0100, Mark Rutland wrote:
> > On Sun, Apr 01, 2018 at 02:11:08PM +0300, Yury Norov wrote:
> > > @@ -840,8 +861,10 @@ el0_svc:
> > > mov wsc_nr, #__NR_syscalls
> > > el0_svc_naked:
On 28/03/2018 23:21, David Rientjes wrote:
> On Wed, 28 Mar 2018, Laurent Dufour wrote:
>
@@ -326,7 +336,10 @@ static unsigned long move_vma(struct vm_area_struct
*vma,
mremap_userfaultfd_prep(new_vma, uf);
arch_remap(mm, old_addr, old_addr + old_len,
>
Hi Jerome,
Thanks for reviewing this series.
On 03/04/2018 22:37, Jerome Glisse wrote:
> On Tue, Mar 13, 2018 at 06:59:30PM +0100, Laurent Dufour wrote:
>> This is a port on kernel 4.16 of the work done by Peter Zijlstra to
>> handle page fault without holding the mm semaphore [1].
>>
>> The idea
66 matches
Mail list logo
