Re: [PATCH] powerpc/44x: mask and shift to zero bug

2017-08-26 Thread Benjamin Herrenschmidt
On Fri, 2017-08-25 at 13:33 +0300, Dan Carpenter wrote: > My static checker complains that 0x1800 >> 13 is zero. Looking at > the context, it seems like a copy and paste bug from the line below and > probably 0x3 << 13 or 0x6000 was intended. > > Fixes: 2af59f7d5c3e ("[POWERPC] 4xx: Add 4

Re: [PATCH v2 14/20] mm: Provide speculative fault infrastructure

2017-08-26 Thread Kirill A. Shutemov
On Fri, Aug 18, 2017 at 12:05:13AM +0200, Laurent Dufour wrote: > +/* > + * vm_normal_page() adds some processing which should be done while > + * hodling the mmap_sem. > + */ > +int handle_speculative_fault(struct mm_struct *mm, unsigned long address, > + unsigned int flag

Re: [PATCH v2 01/10] powerpc: Handle most loads and stores in instruction emulation code

2017-08-26 Thread Segher Boessenkool
Hi Paul, On Fri, Aug 25, 2017 at 03:41:53PM +1000, Paul Mackerras wrote: > diff --git a/arch/powerpc/lib/ldstfp.S b/arch/powerpc/lib/ldstfp.S > index a58777c..6840911 100644 > --- a/arch/powerpc/lib/ldstfp.S > +++ b/arch/powerpc/lib/ldstfp.S > @@ -178,10 +178,10 @@ _GLOBAL(do_stfd) > EX_TABL