Re: [PATCH] cxl: Fix error handling

2016-10-30 Thread Andrew Donnellan
On 31/10/16 08:40, Christophe JAILLET wrote: 'cxl_dev_context_init()' returns an error pointer in case of error, not NULL. So test it with IS_ERR. Signed-off-by: Christophe JAILLET Reviewed-by: Andrew Donnellan --- un-compiled because I don't have the required cross build environment. B

Re: [PATCH] cxl: Fix error handling

2016-10-30 Thread Andrew Donnellan
On 31/10/16 08:34, Christophe JAILLET wrote: 'cxl_dev_context_init()' returns an error pointer in case of error, not NULL. So test it with IS_ERR. Signed-off-by: Christophe JAILLET Reviewed-by: Andrew Donnellan --- un-compiled because I don't have the required cross build environment. B

Re: [PATCH] cxl: Fix memory allocation failure test

2016-10-30 Thread Andrew Donnellan
On 31/10/16 06:35, Christophe JAILLET wrote: 'cxl_context_alloc()' does not return an error pointer. It is just a shortcut for a call to 'kzalloc' with 'sizeof(struct cxl_context)' as the size parameter. So its return value should be compared with NULL. While fixing it, simplify a bit the code.

Re: [PATCH 08/15] powerpc/iommu: use permission-specific DEVICE_ATTR variants

2016-10-30 Thread Michael Ellerman
Julia Lawall writes: > diff --git a/arch/powerpc/kernel/iommu.c b/arch/powerpc/kernel/iommu.c > index 5f202a5..32f18b5 100644 > --- a/arch/powerpc/kernel/iommu.c > +++ b/arch/powerpc/kernel/iommu.c > @@ -127,8 +127,7 @@ static ssize_t fail_iommu_store(struct device *dev, > return count; >

Re: [PATCH V2 2/2] powerpc/kvm: Update kvmppc_set_arch_compat() for ISA v3.00

2016-10-30 Thread Paul Mackerras
On Mon, Oct 31, 2016 at 11:28:23AM +1100, Suraj Jitindar Singh wrote: > The function kvmppc_set_arch_compat() is used to determine the value of the > processor compatibility register (PCR) for a guest running in a given > compatibility mode. There is currently no support for v3.00 of the ISA. > >

Re: [PATCH] cxl: Fix error handling

2016-10-30 Thread Michael Ellerman
Christophe JAILLET writes: > 'cxl_dev_context_init()' returns an error pointer in case of error, not > NULL. So test it with IS_ERR. > > Signed-off-by: Christophe JAILLET > --- > un-compiled because I don't have the required cross build environment. Do you run Ubuntu or Fedora? If so it's just

Re: [PATCH] console: use first console if stdout-path device doesn't appear

2016-10-30 Thread Michael Ellerman
Andreas Schwab writes: > Any news? We discovered it also breaks VGA on qemu, which presumably is not the type of news you were hoping for. To reproduce you just need to build a ppc64le kernel: $ apt-get install gcc-powerpc64le-linux-gnu $ make ARCH=powerpc CROSS_COMPILE=powerpc64le-linux-gnu-

Re: [PATCH kernel v4 4/4] powerpc/mm/iommu, vfio/spapr: Put pages on VFIO container shutdown

2016-10-30 Thread David Gibson
On Mon, Oct 31, 2016 at 03:13:21PM +1100, Alexey Kardashevskiy wrote: > On 31/10/16 14:13, David Gibson wrote: > > On Tue, Oct 25, 2016 at 03:55:56PM +1100, Alexey Kardashevskiy wrote: > >> On 25/10/16 15:44, David Gibson wrote: > >>> On Mon, Oct 24, 2016 at 05:53:10PM +1100, Alexey Kardashevskiy w

Re: [PATCH kernel v4 4/4] powerpc/mm/iommu, vfio/spapr: Put pages on VFIO container shutdown

2016-10-30 Thread Alexey Kardashevskiy
On 31/10/16 14:13, David Gibson wrote: > On Tue, Oct 25, 2016 at 03:55:56PM +1100, Alexey Kardashevskiy wrote: >> On 25/10/16 15:44, David Gibson wrote: >>> On Mon, Oct 24, 2016 at 05:53:10PM +1100, Alexey Kardashevskiy wrote: At the moment the userspace tool is expected to request pinning of

Re: Linux 4.9: Reported regressions as of Sunday, 2016-10-30

2016-10-30 Thread Benjamin Herrenschmidt
On Sun, 2016-10-30 at 14:20 +0100, Thorsten Leemhuis wrote: > > Desc: PPC32: fails to boot on my PowerBook G4 Aluminum; bisected to > commit 05fd007e4629 > Repo: 2016-10-20 https://www.mail-archive.com/linux-kernel@vger.kerne > l.org/msg1253391.html > Stat: 2016-10-22 https://www.mail-archive.com/

Re: [PATCH kernel v4 4/4] powerpc/mm/iommu, vfio/spapr: Put pages on VFIO container shutdown

2016-10-30 Thread David Gibson
On Tue, Oct 25, 2016 at 03:55:56PM +1100, Alexey Kardashevskiy wrote: > On 25/10/16 15:44, David Gibson wrote: > > On Mon, Oct 24, 2016 at 05:53:10PM +1100, Alexey Kardashevskiy wrote: > >> At the moment the userspace tool is expected to request pinning of > >> the entire guest RAM when VFIO IOMMU

[PATCH 2/2] Revert "powerpc: Load Monitor Register Support"

2016-10-30 Thread Michael Neuling
Load monitored is no longer supported on POWER9 so let's remove the code. This reverts commit bd3ea317fddfd0f2044f94bed294b90c4bc8e69e. Signed-off-by: Michael Neuling --- arch/powerpc/include/asm/processor.h | 2 -- arch/powerpc/include/asm/reg.h | 5 - arch/powerpc/kernel/process.c

[PATCH 1/2] Revert "selftests/powerpc: Load Monitor Register Tests"

2016-10-30 Thread Michael Neuling
Load monitored won't be supported in POWER9, so PPC_FEATURE2_ARCH_3_00 (in HWCAP2) will no longer imply Load monitor support. These Load monitored tests are enabled by PPC_FEATURE2_ARCH_3_00 so they are now bogus and need to be removed. This reverts commit 16c19a2e983346c547501795aadffde1977b058d

[PATCH] powerpc/powernv: de-deuplicate OPAL call wrappers

2016-10-30 Thread Oliver O'Halloran
Currently the code to perform an OPAL call is duplicated between the normal path and path taken when tracepoints are enabled. There's no real need for this and combining them makes opal_tracepoint_entry considerably easier to understand. Signed-off-by: Oliver O'Halloran --- arch/powerpc/platform

[PATCH V2 2/2] powerpc/kvm: Update kvmppc_set_arch_compat() for ISA v3.00

2016-10-30 Thread Suraj Jitindar Singh
The function kvmppc_set_arch_compat() is used to determine the value of the processor compatibility register (PCR) for a guest running in a given compatibility mode. There is currently no support for v3.00 of the ISA. Add support for v3.00 of the ISA which adds an ISA v2.07 compatilibity mode to t

[PATCH V2 1/2] powerpc: Define new ISA v3.00 logical PVR value and PCR register value

2016-10-30 Thread Suraj Jitindar Singh
ISA 3.00 adds the logical PVR value 0x0f05, so add a definition for this. Define PCR_ARCH_207 to reflect ISA 2.07 compatibility mode in the processor compatibility register (PCR). Signed-off-by: Suraj Jitindar Singh --- arch/powerpc/include/asm/reg.h | 2 ++ 1 file changed, 2 insertions(+)

[PATCH V2 0/2] powerpc: add support for ISA v2.07 compat level

2016-10-30 Thread Suraj Jitindar Singh
Version v3.00 of the ISA added a new compat level to the processor compatibility register (PCR), an ISA v2.07 compatibility mode. Upstream QEMU already supports this so it may as well go into the kernel now. Change Log: V1 -> V2: - Reworked logic to set and mask the PCR, no functional change Su

Re: [PATCH 1/3] ABI: fix some syntax issues at the ABI database

2016-10-30 Thread Jonathan Cameron
On 28/10/16 13:19, Mauro Carvalho Chehab wrote: > On those three files, the ABI representation described at > README are violated. > > - at sysfs-bus-iio-proximity-as3935: > a ':' character is missing after "What" > > - at sysfs-class-devfreq: > there's a typo at Description > > - at

[PATCH] cxl: Fix error handling

2016-10-30 Thread Christophe JAILLET
'cxl_dev_context_init()' returns an error pointer in case of error, not NULL. So test it with IS_ERR. Signed-off-by: Christophe JAILLET --- un-compiled because I don't have the required cross build environment. --- drivers/misc/cxl/pci.c | 2 +- drivers/misc/cxl/phb.c | 2 +- 2 files changed, 2

[PATCH] cxl: Fix error handling

2016-10-30 Thread Christophe JAILLET
'cxl_dev_context_init()' returns an error pointer in case of error, not NULL. So test it with IS_ERR. Signed-off-by: Christophe JAILLET --- un-compiled because I don't have the required cross build environment. --- drivers/misc/cxl/api.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) di

Re: [PATCH] cxl: Fix memory allocation failure test

2016-10-30 Thread walter harms
Am 30.10.2016 20:35, schrieb Christophe JAILLET: > 'cxl_context_alloc()' does not return an error pointer. It is just a > shortcut for a call to 'kzalloc' with 'sizeof(struct cxl_context)' as the > size parameter. > > So its return value should be compared with NULL. > While fixing it, simplify

[PATCH] cxl: Fix memory allocation failure test

2016-10-30 Thread Christophe JAILLET
'cxl_context_alloc()' does not return an error pointer. It is just a shortcut for a call to 'kzalloc' with 'sizeof(struct cxl_context)' as the size parameter. So its return value should be compared with NULL. While fixing it, simplify a bit the code. Signed-off-by: Christophe JAILLET --- un-comp

Re: [PATCH v2 02/16] scsi: don't use fc_bsg_job::request and fc_bsg_job::reply directly

2016-10-30 Thread Johannes Thumshirn
On Fri, Oct 28, 2016 at 11:53:46AM +0200, Steffen Maier wrote: [...] > > > > > > > @@ -3937,6 +3944,7 @@ fc_bsg_request_handler(struct request_queue *q, > > > > struct Scsi_Host *shost, > > > > struct request *req; > > > > struct fc_bsg_job *job; > > > > enum fc_dispatch

Re: [PATCH v6 02/11] locking/osq: Drop the overload of osq_lock()

2016-10-30 Thread Pan Xinhui
在 2016/10/30 00:52, Davidlohr Bueso 写道: On Fri, 28 Oct 2016, Pan Xinhui wrote: /* * If we need to reschedule bail... so we can block. + * Use vcpu_is_preempted to detech lock holder preemption issue ^^ detect ok. thanks for

Linux 4.9: Reported regressions as of Sunday, 2016-10-30

2016-10-30 Thread Thorsten Leemhuis
Hi! Here is my second regression report for Linux 4.9. It lists 14 regressions I'm aware of. 4 of them are new; 3 got fixed since last weeks report. As always: Are you aware of any other regressions? Then please let me know (simply CC regressi...@leemhuis.info). And please tell me if there is any

Re: [PATCH] console: use first console if stdout-path device doesn't appear

2016-10-30 Thread Andreas Schwab
Any news? Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."