Re: [PATCH v3 2/2] powerpc: add support for csum_add()

2015-05-22 Thread Segher Boessenkool
On Fri, May 22, 2015 at 02:32:42PM -0500, Scott Wood wrote: > > I'd also have thought that the 64bit C version above would be generally > > 'good'. > > It doesn't generate the addc/addze sequence. At least with GCC 4.8.2, > it does something like: > > mr tmp0, csum > li tm

Re: [PATCH v3 2/2] powerpc: add support for csum_add()

2015-05-22 Thread Scott Wood
On Fri, 2015-05-22 at 16:39 -0500, Segher Boessenkool wrote: > On Fri, May 22, 2015 at 02:32:42PM -0500, Scott Wood wrote: > > > I'd also have thought that the 64bit C version above would be generally > > > 'good'. > > > > It doesn't generate the addc/addze sequence. At least with GCC 4.8.2, > >

Re: [PATCH 2/4] perf: jevents: Program to convert JSON file to C style file

2015-05-22 Thread Andi Kleen
> Sure, but shouldn't we allow JSON files to be in subdirs > > pmu-events/arch/x86/HSX/Haswell_core.json > > and this could go to arbitrary levels? I used a flat hierarchy. Should be good enough. -Andi -- a...@linux.intel.com -- Speaking for myself only _

Re: [PATCH v3 2/2] powerpc: add support for csum_add()

2015-05-22 Thread Scott Wood
On Fri, 2015-05-22 at 15:57 +, David Laight wrote: > From: Linuxppc-dev Christophe Leroy > > Sent: 19 May 2015 16:19 > ... > > diff --git a/arch/powerpc/include/asm/checksum.h > > b/arch/powerpc/include/asm/checksum.h > > index 5e43d2d..e8d9ef4 100644 > > --- a/arch/powerpc/include/asm/checksu

Re: [PATCH 2/4] perf: jevents: Program to convert JSON file to C style file

2015-05-22 Thread Sukadev Bhattiprolu
Andi Kleen [a...@linux.intel.com] wrote: | > pmu-events.c depends only on JSON files relevant to the arch perf is | > being built on and there could be several JSON files per arch. So it | > would complicate the Makefiles. | | Could just use a wildcard dependency on */$(ARCH)/*.json Sure, but sh

Re: [PATCH 2/4] perf: jevents: Program to convert JSON file to C style file

2015-05-22 Thread Andi Kleen
> pmu-events.c depends only on JSON files relevant to the arch perf is > being built on and there could be several JSON files per arch. So it > would complicate the Makefiles. Could just use a wildcard dependency on */$(ARCH)/*.json Also it would be good to move the generated file into the objec

Re: [PATCH 2/4] perf: jevents: Program to convert JSON file to C style file

2015-05-22 Thread Jiri Olsa
On Fri, May 22, 2015 at 08:58:22AM -0700, Sukadev Bhattiprolu wrote: SNIP > | > | there's no concetion (yet) in the new build system to trigger > | another binery build as a dependency for object file.. I'd > | rather do this the framework way, please check attached patch > | > | also currently

Re: [PATCH 2/4] perf: jevents: Program to convert JSON file to C style file

2015-05-22 Thread Sukadev Bhattiprolu
Jiri Olsa [jo...@redhat.com] wrote: | On Tue, May 19, 2015 at 05:02:08PM -0700, Sukadev Bhattiprolu wrote: | | SNIP | | > +int main(int argc, char *argv[]) | > +{ | > + int rc; | > + int flags; | | SNIP | | > + | > + rc = uname(&uts); | > + if (rc < 0) { | > + printf("%s: unam

RE: [PATCH v3 2/2] powerpc: add support for csum_add()

2015-05-22 Thread David Laight
From: Linuxppc-dev Christophe Leroy > Sent: 19 May 2015 16:19 ... > diff --git a/arch/powerpc/include/asm/checksum.h > b/arch/powerpc/include/asm/checksum.h > index 5e43d2d..e8d9ef4 100644 > --- a/arch/powerpc/include/asm/checksum.h > +++ b/arch/powerpc/include/asm/checksum.h > @@ -130,6 +130,22 @

Re: [PATCH 2/4] perf: jevents: Program to convert JSON file to C style file

2015-05-22 Thread Sukadev Bhattiprolu
Jiri Olsa [jo...@redhat.com] wrote: | On Tue, May 19, 2015 at 05:02:08PM -0700, Sukadev Bhattiprolu wrote: | | SNIP | | > --- | > tools/perf/Build |1 + | > tools/perf/Makefile.perf |4 +- | > tools/perf/pmu-events/Build| 38 ++ | > tools/perf/pmu-ev

Re: [PATCH 2/4] perf: jevents: Program to convert JSON file to C style file

2015-05-22 Thread Jiri Olsa
On Tue, May 19, 2015 at 05:02:08PM -0700, Sukadev Bhattiprolu wrote: SNIP > +int main(int argc, char *argv[]) > +{ > + int rc; > + int flags; SNIP > + > + rc = uname(&uts); > + if (rc < 0) { > + printf("%s: uname() failed: %s\n", argv[0], strerror(errno)); > +

Re: [PATCH 2/4] perf: jevents: Program to convert JSON file to C style file

2015-05-22 Thread Jiri Olsa
On Tue, May 19, 2015 at 05:02:08PM -0700, Sukadev Bhattiprolu wrote: SNIP > --- > tools/perf/Build |1 + > tools/perf/Makefile.perf |4 +- > tools/perf/pmu-events/Build| 38 ++ > tools/perf/pmu-events/README | 67 > tools/perf/pmu-events

Re: [PATCH kernel] commit 4fbdf9cb ("lpfc: Fix for lun discovery issue with saturn adapter.")

2015-05-22 Thread Sebastian Herbszt
Alexey Kardashevskiy wrote: > On 05/06/2015 07:46 AM, Sebastian Herbszt wrote: > > James Smart wrote: > >> > >> Reviewed-By: James Smart > >> > >> > >> Alexey, Sebastian, > >> > >> Yes - this section needs to be reverted. This patch is good. > >> > >> -- james s > > > > Reviewed-by: Sebastian Her