Re: [PATCH] [RFC] powerpc/vphn: fix endian issue in NUMA device node code

2014-10-02 Thread Greg Kurz
On Thu, 2 Oct 2014 16:43:41 -0700 Nishanth Aravamudan wrote: > On 02.10.2014 [23:59:15 +0200], Greg Kurz wrote: > > The associativity domain numbers are obtained from the hypervisor through > > registers and written into memory by the guest: the packed array passed to > > vphn_unpack_associativit

Re: [1/4] powerpc/powernv: Sync header with firmware

2014-10-02 Thread Gavin Shan
On Fri, Oct 03, 2014 at 03:30:31PM +1000, Stewart Smith wrote: >Michael Ellerman writes: >>> + OpalEjtIoaDmaWriteMemTarget = 19, >>> +}; >> >> I realise these come from the skiboot source, but they're just too ugly. >> >> Please use kernel style naming, like most of the rest of the file, eg:

Re: [1/4] powerpc/powernv: Sync header with firmware

2014-10-02 Thread Stewart Smith
Michael Ellerman writes: >> +OpalEjtIoaDmaWriteMemTarget = 19, >> +}; > > I realise these come from the skiboot source, but they're just too ugly. > > Please use kernel style naming, like most of the rest of the file, eg: > > OPAL_ERR_INJECT_IOA_BUS_ERR You know what, I think I'd fe

Re: [PATCH v2 3/4] sound/radeon: Move 64-bit MSI quirk from arch to driver

2014-10-02 Thread Benjamin Herrenschmidt
On Wed, 2014-10-01 at 22:13 -0400, Alex Deucher wrote: > The attached updated patch only flags the affected asics. I need formal (email :-) permission to add your s-o-b (and From: while at it since you wrote most of it) for this patch. I'll then include it in my new series. Cheers, Ben. __

[PATCH] powerpc/eeh: Block CFG upon frozen Shiner adapter

2014-10-02 Thread Gavin Shan
The Broadcom Shiner 2-ports 10G ethernet adapter has same problem commit 6f20bda0 ("powerpc/eeh: Block PCI config access upon frozen PE") fixes. Put it to the black list as well. # lspci -s 0004:01:00.0 0004:01:00.0 Ethernet controller: Broadcom Corporation \ NetXtreme II BCM

Re: [PATCH 00/20] powerpc: Convert power off logic to pm_power_off

2014-10-02 Thread Michael Ellerman
On Wed, 2014-10-01 at 15:27 +0200, Alexander Graf wrote: > The generic Linux framework to power off the machine is a function pointer > called pm_power_off. The trick about this pointer is that device drivers can > potentially implement it rather than board files. > > Today on PowerPC we set pm_po

Re: [PATCH v3] powerpc/iommu/ddw: Fix endianness

2014-10-02 Thread Anton Blanchard
Hi Alexey, > rtas_call() accepts and returns values in CPU endianness. > The ddw_query_response and ddw_create_response structs members are > defined and treated as BE but as they are passed to rtas_call() as > (u32 *) and they get byteswapped automatically, the data is > CPU-endian. This fixes dd

[PATCH 3/3] tools/perf: Fix error reporting

2014-10-02 Thread Sukadev Bhattiprolu
If user explicitly specifies a vmlinux or kallsyms file on the command line and the specified file doesn't yield any symbols, print a warning message. $ perf report -kallsyms No kernel symbols in the vmlinux 'allsyms'? Failed to load symbols for DSO [kernel.kallsyms], conti

[PATCH 2/3] tools/perf: Rename variables for clarity

2014-10-02 Thread Sukadev Bhattiprolu
The dso__load* functions return the number symbols they were able to load or -1 in case of error. But it is a bit confusing to determine 'if (err > 0)' indicates success or failure and we have to step several functions deep to find that out. Rename the variable 'err' so it is hopefully easier to

[PATCH 1/3] tools/perf: Fix error message

2014-10-02 Thread Sukadev Bhattiprolu
Sometimes, eg: with a stripped vmlinux, we can open the file but cannot load any symbols from it. Update error message accordingly so the users can better understand the error. Signed-off-by: Sukadev Bhattiprolu --- tools/perf/util/map.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) dif

Re: [RFC PATCH v3 1/3] powerpc: Fix warning reported by verify_cpu_node_mapping()

2014-10-02 Thread Michael Ellerman
On Thu, 2014-10-02 at 14:13 -0700, Nishanth Aravamudan wrote: > Ben & Michael, > > What's the status of these patches? Been in my next for a week :) https://git.kernel.org/cgit/linux/kernel/git/mpe/linux.git/log/?h=next cheers ___ Linuxppc-dev maili

Re: [PATCH] [RFC] powerpc/vphn: fix endian issue in NUMA device node code

2014-10-02 Thread Nishanth Aravamudan
On 02.10.2014 [23:59:15 +0200], Greg Kurz wrote: > The associativity domain numbers are obtained from the hypervisor through > registers and written into memory by the guest: the packed array passed to > vphn_unpack_associativity() is then native-endian, unlike what was assumed > in the following c

Re: [PATCH V7 00/17] Enable SRIOV on POWER8

2014-10-02 Thread Gavin Shan
On Thu, Oct 02, 2014 at 09:59:43AM -0600, Bjorn Helgaas wrote: >On Wed, Aug 20, 2014 at 11:35:46AM +0800, Wei Yang wrote: >> On Tue, Aug 19, 2014 at 10:12:27PM -0500, Bjorn Helgaas wrote: >> >On Tue, Aug 19, 2014 at 9:34 PM, Wei Yang >> >wrote: >> >> On Tue, Aug 19, 2014 at 03:19:42PM -0600, Bjor

Re: [RFC PATCH v3 1/3] powerpc: Fix warning reported by verify_cpu_node_mapping()

2014-10-02 Thread Benjamin Herrenschmidt
On Thu, 2014-10-02 at 14:53 -0700, Nishanth Aravamudan wrote: > On 03.10.2014 [07:28:19 +1000], Benjamin Herrenschmidt wrote: > > On Thu, 2014-10-02 at 14:13 -0700, Nishanth Aravamudan wrote: > > > Ben & Michael, > > > > > > What's the status of these patches? > > > > Waiting for somebody to revi

Re: [PATCH v2 2/4] gpu/radeon: Move 64-bit MSI quirk from arch to driver

2014-10-02 Thread Benjamin Herrenschmidt
On Thu, 2014-10-02 at 15:44 -0600, Bjorn Helgaas wrote: > On Thu, Oct 2, 2014 at 3:02 PM, Benjamin Herrenschmidt > wrote: > > On Thu, 2014-10-02 at 09:34 -0600, Bjorn Helgaas wrote: > >> On Thu, Oct 02, 2014 at 10:34:22AM +1000, Benjamin Herrenschmidt wrote: > >> > > >> > A number of radeon cards

[PATCH] [RFC] powerpc/vphn: fix endian issue in NUMA device node code

2014-10-02 Thread Greg Kurz
The associativity domain numbers are obtained from the hypervisor through registers and written into memory by the guest: the packed array passed to vphn_unpack_associativity() is then native-endian, unlike what was assumed in the following commit: commit b08a2a12e44eaec5024b2b969f4fcb98169d1ca3 A

Re: [RFC PATCH v3 1/3] powerpc: Fix warning reported by verify_cpu_node_mapping()

2014-10-02 Thread Nishanth Aravamudan
On 03.10.2014 [07:28:19 +1000], Benjamin Herrenschmidt wrote: > On Thu, 2014-10-02 at 14:13 -0700, Nishanth Aravamudan wrote: > > Ben & Michael, > > > > What's the status of these patches? > > Waiting for somebody to review them ? :-) Heh, I acked them about a month ago, I can give a stronger Re

Re: [PATCH v2 1/4] pci/msi: Move "no_64bit_msi" flag from powerpc to generic pci_dev

2014-10-02 Thread Bjorn Helgaas
On Thu, Oct 2, 2014 at 3:01 PM, Benjamin Herrenschmidt wrote: > On Thu, 2014-10-02 at 09:31 -0600, Bjorn Helgaas wrote: > >> > So this moves the flag to struct pci_dev instead and adjusts the >> > corresponding arch/powerpc code to look for it there. At this point, >> > there is no attempt at maki

Re: [PATCH v2 2/4] gpu/radeon: Move 64-bit MSI quirk from arch to driver

2014-10-02 Thread Bjorn Helgaas
On Thu, Oct 2, 2014 at 3:02 PM, Benjamin Herrenschmidt wrote: > On Thu, 2014-10-02 at 09:34 -0600, Bjorn Helgaas wrote: >> On Thu, Oct 02, 2014 at 10:34:22AM +1000, Benjamin Herrenschmidt wrote: >> > >> > A number of radeon cards have a HW limitation causing them to be >> > unable to generate the

Re: [PATCH] powerpc: fix sys_call_table declaration

2014-10-02 Thread Benjamin Herrenschmidt
On Thu, 2014-10-02 at 15:41 +0100, Romeo Cane wrote: > Declaring sys_call_table as a pointer causes the compiler to generate the > wrong lookup code in arch_syscall_addr Care to elaborate ? Ben. > Signed-off-by: Romeo Cane > --- > arch/powerpc/include/asm/syscall.h | 2 +- > 1 file changed, 1

[PATCH] powerpc: fix sys_call_table declaration

2014-10-02 Thread Romeo Cane
Declaring sys_call_table as a pointer causes the compiler to generate the wrong lookup code in arch_syscall_addr Signed-off-by: Romeo Cane --- arch/powerpc/include/asm/syscall.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/include/asm/syscall.h b/arch/powerp

Re: [RFC PATCH v3 1/3] powerpc: Fix warning reported by verify_cpu_node_mapping()

2014-10-02 Thread Benjamin Herrenschmidt
On Thu, 2014-10-02 at 14:13 -0700, Nishanth Aravamudan wrote: > Ben & Michael, > > What's the status of these patches? Waiting for somebody to review them ? :-) Cheers, Ben. > Thanks, > Nish > > On 27.08.2014 [17:33:59 +0800], Li Zhong wrote: > > With commit 2fabf084b6ad ("powerpc: reorder per

Re: [RFC PATCH v3 1/3] powerpc: Fix warning reported by verify_cpu_node_mapping()

2014-10-02 Thread Nishanth Aravamudan
Ben & Michael, What's the status of these patches? Thanks, Nish On 27.08.2014 [17:33:59 +0800], Li Zhong wrote: > With commit 2fabf084b6ad ("powerpc: reorder per-cpu NUMA information's > initialization"), during boottime, cpu_numa_callback() is called > earlier(before their online) for each cpu,

Re: [PATCH v2 2/4] gpu/radeon: Move 64-bit MSI quirk from arch to driver

2014-10-02 Thread Benjamin Herrenschmidt
On Thu, 2014-10-02 at 09:34 -0600, Bjorn Helgaas wrote: > On Thu, Oct 02, 2014 at 10:34:22AM +1000, Benjamin Herrenschmidt wrote: > > > > A number of radeon cards have a HW limitation causing them to be > > unable to generate the full 64-bit of address bits for MSIs. This > > breaks MSIs on some p

Re: [PATCH v2 1/4] pci/msi: Move "no_64bit_msi" flag from powerpc to generic pci_dev

2014-10-02 Thread Benjamin Herrenschmidt
On Thu, 2014-10-02 at 09:31 -0600, Bjorn Helgaas wrote: > > So this moves the flag to struct pci_dev instead and adjusts the > > corresponding arch/powerpc code to look for it there. At this point, > > there is no attempt at making other architectures honor it just yet, > > though it appears that

Re: [PATCH v2 0/3] powernv/cpuidle: Fastsleep workaround and fixes

2014-10-02 Thread Shreyas B Prabhu
On Thursday 02 October 2014 02:16 AM, Rafael J. Wysocki wrote: > On Wednesday, October 01, 2014 01:15:57 PM Shreyas B. Prabhu wrote: >> Fast sleep is an idle state, where the core and the L1 and L2 >> caches are brought down to a threshold voltage. This also means that >> the communication betwee

Re: [PATCH v2 2/3] powerpc/kvm/book3s_hv: Enable CPUs to run guest after waking up from fast-sleep

2014-10-02 Thread Shreyas B Prabhu
CCing Rafael J. Wysocki and linux...@vger.kernel.org On Wednesday 01 October 2014 01:15 PM, Shreyas B. Prabhu wrote: > When guests have to be launched, the secondary threads which are offline > are woken up to run the guests. Today these threads wake up from nap > and check if they have to run gue

Re: [PATCH V7 00/17] Enable SRIOV on POWER8

2014-10-02 Thread Bjorn Helgaas
On Wed, Aug 20, 2014 at 11:35:46AM +0800, Wei Yang wrote: > On Tue, Aug 19, 2014 at 10:12:27PM -0500, Bjorn Helgaas wrote: > >On Tue, Aug 19, 2014 at 9:34 PM, Wei Yang wrote: > >> On Tue, Aug 19, 2014 at 03:19:42PM -0600, Bjorn Helgaas wrote: > >>>On Thu, Jul 24, 2014 at 02:22:10PM +0800, Wei Yang

Re: [PATCH v2 2/4] gpu/radeon: Move 64-bit MSI quirk from arch to driver

2014-10-02 Thread Bjorn Helgaas
On Thu, Oct 02, 2014 at 10:34:22AM +1000, Benjamin Herrenschmidt wrote: > > A number of radeon cards have a HW limitation causing them to be > unable to generate the full 64-bit of address bits for MSIs. This > breaks MSIs on some platforms such as POWER machines. > > We used to have a powerpc sp

Re: [PATCH v2 1/4] pci/msi: Move "no_64bit_msi" flag from powerpc to generic pci_dev

2014-10-02 Thread Bjorn Helgaas
On Thu, Oct 02, 2014 at 10:34:12AM +1000, Benjamin Herrenschmidt wrote: > > Some devices have broken 64-bit MSI support which only support some > address bits (40 to 48 typically). This doesn't work on some platforms > such as POWER servers, so we need a quirk. > > Currently we keep a flag in a p

Re: [PATCH v2] powerpc: Speed up clear_page by unrolling it

2014-10-02 Thread Segher Boessenkool
On Thu, Oct 02, 2014 at 03:44:21PM +1000, Anton Blanchard wrote: > This assumes cacheline sizes won't grow beyond 512 bytes or > page sizes wont drop below 1kB, Or a combination of those. > Michael found that some versions of gcc produce quite bad code > (all multiplies), so we give gcc a hand by

[PATCH] powerpc/boot: Makefile cleanup

2014-10-02 Thread Michal Marek
The $(image-n) variable will never exist, because unset Kconfig options are '' and not 'n'. Signed-off-by: Michal Marek --- arch/powerpc/boot/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/boot/Makefile b/arch/powerpc/boot/Makefile index ccc25ed..c456d0

Re: [PATCH v2 15/17] cxl: Userspace header file.

2014-10-02 Thread Benjamin Herrenschmidt
On Thu, 2014-10-02 at 20:28 +1000, Ian Munsie wrote: > Hey Michael, > > Excerpts from Michael Ellerman's message of 2014-10-02 16:02:37 +1000: > > > +/* ioctls */ > > > +struct cxl_ioctl_start_work { > > > +__u64 wed; > > > +__u64 amr; > > > +__u64 reserved1; > > > +__u32 reserved2

Re: [PATCH v2 3/4] sound/radeon: Move 64-bit MSI quirk from arch to driver

2014-10-02 Thread Benjamin Herrenschmidt
On Thu, 2014-10-02 at 09:59 +0200, Takashi Iwai wrote: > > The attached updated patch only flags the affected asics. > > Alex's patch looks more comprehensive. For either patch, > > Reviewed-by: Takashi Iwai Absolutely. I'll give it a spin tomorrow to be 100% sure. From there, it will need th

Re: [PATCH v2 15/17] cxl: Userspace header file.

2014-10-02 Thread Ian Munsie
Hey Michael, Excerpts from Michael Ellerman's message of 2014-10-02 16:02:37 +1000: > > +/* ioctls */ > > +struct cxl_ioctl_start_work { > > +__u64 wed; > > +__u64 amr; > > +__u64 reserved1; > > +__u32 reserved2; > > +__s16 num_interrupts; /* -1 = use value from afu descriptor

Re: [PATCH v2 3/4] sound/radeon: Move 64-bit MSI quirk from arch to driver

2014-10-02 Thread Takashi Iwai
At Wed, 1 Oct 2014 22:13:38 -0400, Alex Deucher wrote: > > On Wed, Oct 1, 2014 at 8:34 PM, Benjamin Herrenschmidt > wrote: > > > > A number of radeon cards have a HW limitation causing them to be > > unable to generate the full 64-bit of address bits for MSIs. This > > breaks MSIs on some platfor

Re: [PATCH v2 09/17] powerpc/mm: Add new hash_page_mm()

2014-10-02 Thread Michael Neuling
On Thu, 2014-10-02 at 13:48 +1000, Michael Ellerman wrote: > On Tue, 2014-30-09 at 10:34:58 UTC, Michael Neuling wrote: > > From: Ian Munsie > > > > This adds a new function hash_page_mm() based on the existing hash_page(). > > This version allows any struct mm to be passed in, rather than assumi

Re: powerpc: Print instruction when logging unhandled exceptions

2014-10-02 Thread Michael Ellerman
On Thu, 2014-25-09 at 05:05:45 UTC, Anton Blanchard wrote: > It is often useful to see the instruction that caused an unhandled > exception. > > diff --git a/arch/powerpc/kernel/traps.c b/arch/powerpc/kernel/traps.c > index 0dc43f9..27e30c8 100644 > --- a/arch/powerpc/kernel/traps.c > +++ b/arch/p

Re: [PATCH v2 09/17] powerpc/mm: Add new hash_page_mm()

2014-10-02 Thread Michael Neuling
On Wed, 2014-10-01 at 15:13 +0530, Aneesh Kumar K.V wrote: > Michael Neuling writes: > > > From: Ian Munsie > > > > This adds a new function hash_page_mm() based on the existing hash_page(). > > This version allows any struct mm to be passed in, rather than assuming > > current. This is useful

Re: [PATCH v2 14/17] cxl: Driver code for powernv PCIe based cards for userspace access

2014-10-02 Thread Michael Ellerman
On Tue, 2014-30-09 at 10:35:03 UTC, Michael Neuling wrote: > From: Ian Munsie > > This is the core of the cxl driver. > > It adds support for using cxl cards in the powernv environment only (no guest > support). Which means on bare metal on power8 for the peanut gallery. > It allows access to