Re: [PATCH 1/2] powerpc: Add VM_FAULT_HWPOISON handling to powerpc page fault handler

2014-09-23 Thread Stephen Rothwell
Hi Anton, On Wed, 24 Sep 2014 10:27:06 +1000 Anton Blanchard wrote: > > - if (user_mode(regs)) { > - current->thread.trap_nr = BUS_ADRERR; > - info.si_signo = SIGBUS; > - info.si_errno = 0; > - info.si_code = BUS_ADRERR; > - info.si_

Re: [PATCH 3/3] powerpc/kdump: crash_dump.c needs to include io.h

2014-09-23 Thread Stephen Rothwell
Hi Michael, On Wed, 24 Sep 2014 15:57:12 +1000 Michael Ellerman wrote: > > For __ioremap(). So does that mean that you really want this patch before 2/3 so that you don't introduce an unnecessary bisection breakage in ppc64_defconfig? -- Cheers, Stephen Rothwells...@canb.au

Re: [PATCH 1/3] powerpc: Don't build powernv for other platform defconfigs

2014-09-23 Thread Stephen Rothwell
Hi Michael, On Wed, 24 Sep 2014 15:57:10 +1000 Michael Ellerman wrote: > > Because powernv arrived after these other platforms, the defconfigs > didn't have PPC_POWERNV disabled, and being default y it gets turned on. Well, that raises the question of why PPC_POWERNV is default y at all? -- Ch

[PATCH 3/3] powerpc/kdump: crash_dump.c needs to include io.h

2014-09-23 Thread Michael Ellerman
For __ioremap(). Signed-off-by: Michael Ellerman --- arch/powerpc/kernel/crash_dump.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/powerpc/kernel/crash_dump.c b/arch/powerpc/kernel/crash_dump.c index 7a13f378ca2c..c78e6dac4d7d 100644 --- a/arch/powerpc/kernel/crash_dump.c +++ b/arch/

[PATCH 2/3] powerpc: Enable CONFIG_CRASH_DUMP=y for ppc64_defconfig

2014-09-23 Thread Michael Ellerman
It pulls in more code, including causing us to build a relocatable kernel, which is good for testing. The resulting kernel is still usable as a non-crash dump kernel. Signed-off-by: Michael Ellerman --- arch/powerpc/configs/ppc64_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arc

[PATCH 1/3] powerpc: Don't build powernv for other platform defconfigs

2014-09-23 Thread Michael Ellerman
Because powernv arrived after these other platforms, the defconfigs didn't have PPC_POWERNV disabled, and being default y it gets turned on. If we're going to bother having defconfigs for the specific platforms then they should only build the code required for those platforms. The grab bag of eve

Re: [PATCH v1 00/21] Use MSI chip to configure MSI/MSI-X in all platforms

2014-09-23 Thread Yijing Wang
On 2014/9/24 5:09, Bjorn Helgaas wrote: > On Fri, Sep 05, 2014 at 06:09:45PM +0800, Yijing Wang wrote: >> This series is based Bjorn's pci-next branch + Alexander Gordeev's two >> patches >> "Remove arch_msi_check_device()" link: https://lkml.org/lkml/2014/7/12/41 >> >> Currently, there are a lot

[PATCH v4 1/3] MSI/powerpc: Use __read_msi_msg() instead of read_msi_msg()

2014-09-23 Thread Yijing Wang
Read_msi_msg() only be called in rtas_setup_msi_irqs(), use __read_msi_msg() instead of read_msi_msg for simplification. Signed-off-by: Yijing Wang Acked-by: Michael Ellerman CC: Benjamin Herrenschmidt CC: linuxppc-dev@lists.ozlabs.org --- arch/powerpc/platforms/pseries/msi.c |2 +- 1 file

Re: [PATCH 3/3] powerpc/ftrace: simplify prepare_ftrace_return

2014-09-23 Thread Steven Rostedt
On Wed, 24 Sep 2014 12:33:07 +1000 Anton Blanchard wrote: > Hi Ben, > > > > I'll drop that patch and respin. > > > > Or maybe do a toolchain check / or enable it in LE ? > > We are scratching our heads trying to remember details of the issue > right now. In retrospect we should have linked the

Re: [PATCH 3/3] powerpc/ftrace: simplify prepare_ftrace_return

2014-09-23 Thread Anton Blanchard
Hi Ben, > > I'll drop that patch and respin. > > Or maybe do a toolchain check / or enable it in LE ? We are scratching our heads trying to remember details of the issue right now. In retrospect we should have linked the gcc bugzilla or gcc commit details in the kernel commit message :) Steve:

Re: [PATCH 3/3] powerpc/ftrace: simplify prepare_ftrace_return

2014-09-23 Thread Benjamin Herrenschmidt
On Wed, 2014-09-24 at 12:22 +1000, Anton Blanchard wrote: > Hi Steve, > > > > This could be broken from the earlier patches, I haven't run just > > > this test. I probably should on them. > > > > I went back and tested, and it breaks under the first patch. > > Thanks for testing. It looks like s

Re: [2/4] powerpc/eeh: Introduce eeh_ops::err_inject

2014-09-23 Thread Michael Ellerman
On Tue, 2014-26-08 at 07:56:17 UTC, Gavin Shan wrote: > From: Mike Qiu > > + > + /* Firmware supports error injection ? */ > + ret = opal_check_token(OPAL_PCI_ERR_INJCT); > + if (ret != OPAL_TOKEN_PRESENT) { > + pr_warn("%s: Firmware not support error injection (%lld)\n",

Re: [PATCH 3/3] powerpc/ftrace: simplify prepare_ftrace_return

2014-09-23 Thread Anton Blanchard
Hi Steve, > > This could be broken from the earlier patches, I haven't run just > > this test. I probably should on them. > > I went back and tested, and it breaks under the first patch. Thanks for testing. It looks like some toolchains have issues other than the -fno-no-omit-frame-pointer one,

[PATCH 2/2] powerpc: Fill in si_addr_lsb siginfo field

2014-09-23 Thread Anton Blanchard
Fill in the si_addr_lsb siginfo field so the hwpoison code can pass to userspace the length of memory that has been corrupted. Signed-off-by: Anton Blanchard --- arch/powerpc/mm/fault.c | 8 1 file changed, 8 insertions(+) diff --git a/arch/powerpc/mm/fault.c b/arch/powerpc/mm/fault.c

[PATCH 1/2] powerpc: Add VM_FAULT_HWPOISON handling to powerpc page fault handler

2014-09-23 Thread Anton Blanchard
do_page_fault was missing knowledge of HWPOISON, and we would oops if userspace tried to access a poisoned page: kernel BUG at arch/powerpc/mm/fault.c:180! Signed-off-by: Anton Blanchard --- arch/powerpc/mm/fault.c | 36 +--- 1 file changed, 21 insertions(+), 15

Re: [PATCH 3/3] powerpc/ftrace: simplify prepare_ftrace_return

2014-09-23 Thread Steven Rostedt
On Tue, 23 Sep 2014 19:46:04 -0400 Steven Rostedt wrote: > This could be broken from the earlier patches, I haven't run just this > test. I probably should on them. I went back and tested, and it breaks under the first patch. -- Steve ___ Linuxppc-d

Re: [PATCH 3/3] powerpc/ftrace: simplify prepare_ftrace_return

2014-09-23 Thread Steven Rostedt
On Wed, 17 Sep 2014 17:07:04 +1000 Anton Blanchard wrote: > Instead of passing in the stack address of the link register > to be modified, just pass in the old value and return the > new value and rely on ftrace_graph_caller to do the > modification. > > This removes the exception handling aroun

Re: [PATCH 2/3] powerpc/ftrace: Remove mod_return_to_handler

2014-09-23 Thread Steven Rostedt
On Wed, 17 Sep 2014 17:07:03 +1000 Anton Blanchard wrote: > mod_return_to_handler is the same as return_to_handler, except > it handles the change of the TOC (r2). Add this into > return_to_handler and remove mod_return_to_handler. Adding this patch actually gave me some more output. Funny that?

Re: [PATCH 1/3] powerpc: Remove -mno-sched-epilog workaround

2014-09-23 Thread Steven Rostedt
I'm running my ftrace tests on my PAsemi box with your patches and things are not going so well. Just this patch alone causes my first stress test to lock up, and things don't go so well after that. INFO: rcu_sched detected stalls on CPUs/tasks: {} (detected by 1, t=5253 jiffies, g=3603, c=3602,

Re: [PATCH v2 13/13] vfio: powerpc/spapr: Enable Dynamic DMA windows

2014-09-23 Thread Alex Williamson
On Tue, 2014-09-23 at 13:01 +1000, Alexey Kardashevskiy wrote: > This defines and implements VFIO IOMMU API which lets the userspace > create and remove DMA windows. > > This updates VFIO_IOMMU_SPAPR_TCE_GET_INFO to return the number of > available windows and page mask. > > This adds VFIO_IOMMU_

Re: [PATCH v1 00/21] Use MSI chip to configure MSI/MSI-X in all platforms

2014-09-23 Thread Bjorn Helgaas
On Fri, Sep 05, 2014 at 06:09:45PM +0800, Yijing Wang wrote: > This series is based Bjorn's pci-next branch + Alexander Gordeev's two patches > "Remove arch_msi_check_device()" link: https://lkml.org/lkml/2014/7/12/41 > > Currently, there are a lot of weak arch functions in MSI code. > Thierry Red

Re: [PATCH v2 0/3] PCI/MSI: Remove arch_msi_check_device()

2014-09-23 Thread Bjorn Helgaas
On Sun, Sep 07, 2014 at 08:57:52PM +0200, Alexander Gordeev wrote: > Hello, > > This is a cleanup effort to get rid of arch_msi_check_device() function. > > I am sending v2 series, since kbuild for v1 reports compile errors on > ppc4xx and Armada 370. Still, I have not checked the fixes on these

Re: [PATCH v2 04/13] powerpc/powernv: Convert/move set_bypass() callback to take_ownership()

2014-09-23 Thread Alex Williamson
On Tue, 2014-09-23 at 13:00 +1000, Alexey Kardashevskiy wrote: > At the moment the iommu_table struct has a set_bypass() which enables/ > disables DMA bypass on IODA2 PHB. This is exposed to POWERPC IOMMU code > which calls this callback when external IOMMU users such as VFIO are > about to get ove

Re: [PATCH v2 3/3] PCI/MSI: Remove arch_msi_check_device()

2014-09-23 Thread Bjorn Helgaas
On Sun, Sep 07, 2014 at 08:57:55PM +0200, Alexander Gordeev wrote: > There are no archs that override arch_msi_check_device() > hook. Remove it as it is completely redundant. > > If an arch would need to check MSI/MSI-X possibility for a > device it should make it within arch_setup_msi_irqs() hook

Re: [PATCH v2 03/13] powerpc/spapr: vfio: Implement spapr_tce_iommu_ops

2014-09-23 Thread Alex Williamson
On Tue, 2014-09-23 at 13:00 +1000, Alexey Kardashevskiy wrote: > Modern IBM POWERPC systems support multiple IOMMU tables per PE > so we need a more reliable way (compared to container_of()) to get > a PE pointer from the iommu_table struct pointer used in IOMMU functions. > > At the moment IOMMU

Re: bit fields && data tearing

2014-09-23 Thread One Thousand Gnomes
> > Yes - because if you think about it that tells you that nobody is hitting > > it with the old code and it probably doesn't matter. > > I don't understand this reply. It's a matter of priorities. There are hundreds of potential security holes turned up by scanners, 2,500+ filed bugs in kernel

Re: bit fields && data tearing

2014-09-23 Thread Peter Hurley
On 09/14/2014 07:24 PM, One Thousand Gnomes wrote: >> So a problem that no one has ever complained about on _any_ arch is suddenly >> a problem on a subset of Alpha cpus, but a problem I know exists on Alpha >> isn't important because no one's filed a bug about it? > > Yes - because if you think a

Re: Pull request: scottwood/linux.git next

2014-09-23 Thread Bob Cochran
On 09/23/2014 01:45 AM, Scott Wood wrote: On Mon, 2014-09-22 at 23:52 -0400, Bob Cochran wrote: On 09/22/2014 06:21 PM, Scott Wood wrote: Highlights include DMA32 zone support (SATA, USB, etc now works on 64-bit FSL kernels), MSI changes, 8xx optimizations and cleanup, t104x board support, and

Re: [PATCH v5 1/1] powerpc/perf: Adjust callchain based on DWARF debug info

2014-09-23 Thread Sukadev Bhattiprolu
Aaro Koskinen [aaro.koski...@iki.fi] wrote: | Hi, | | On Wed, Jun 25, 2014 at 08:49:03AM -0700, Sukadev Bhattiprolu wrote: | > powerpc/perf: Adjust callchain based on DWARF debug info | > | > When saving the callchain on Power, the kernel conservatively saves excess | > entries in the callchain.

[PATCH 3/5] powerpc: Set CONFIG_NET=y in defconfigs

2014-09-23 Thread Michal Marek
Commit 5d6be6a5 ("scsi_netlink : Make SCSI_NETLINK dependent on NET instead of selecting NET") removed what happened to be the only instance of 'select NET'. Defconfigs that were relying on the select now lack networking support. Reported-by: Stephen Rothwell Cc: linuxppc-dev@lists.ozlabs.org Sig

Re: [3/5] pseries: Create device hotplug entry point

2014-09-23 Thread Nathan Fontenot
On 09/22/2014 08:15 PM, Tyrel Datwyler wrote: > On 09/17/2014 12:15 PM, Nathan Fontenot wrote: >> On 09/17/2014 02:07 AM, Michael Ellerman wrote: >>> >>> On Mon, 2014-09-15 at 15:31 -0500, Nathan Fontenot wrote: For pseries system the kernel will be notified of hotplug requests in the for

Re: Pull request: scottwood/linux.git next

2014-09-23 Thread Scott Wood
On Tue, 2014-09-23 at 12:47 +0200, Joakim Tjernlund wrote: > "Linuxppc-dev" > > wrote on 2014/09/23 07:45:06: > > > > On Mon, 2014-09-22 at 23:52 -0400, Bob Cochran wrote: > > > On 09/22/2014 06:21 PM, Scott Wood wrote: > > > > Highlights include DMA32 zone support (SATA, USB, etc now works on

Re: Pull request: scottwood/linux.git next

2014-09-23 Thread Joakim Tjernlund
"Linuxppc-dev" wrote on 2014/09/23 07:45:06: > > On Mon, 2014-09-22 at 23:52 -0400, Bob Cochran wrote: > > On 09/22/2014 06:21 PM, Scott Wood wrote: > > > Highlights include DMA32 zone support (SATA, USB, etc now works on 64-bit > > > FSL kernels), MSI changes, 8xx optimizations and cleanup, t

Re: [PATCH v2] PowerPC: boot: Parse chosen/cmdline-timeout parameter

2014-09-23 Thread Michael Ellerman
On Tue, 2014-09-23 at 10:56 +0200, Simon Kågström wrote: > Hi again! > > On Tue, 9 Sep 2014 16:40:06 +0200 > Simon Kågström wrote: > > > A 5 second timeout during boot might be too long, so make it > > configurable. Run the loop at least once to let the user stop the boot > > by holding a key pr

Re: [PATCH v2] PowerPC: boot: Parse chosen/cmdline-timeout parameter

2014-09-23 Thread Simon Kågström
Hi again! On Tue, 9 Sep 2014 16:40:06 +0200 Simon Kågström wrote: > A 5 second timeout during boot might be too long, so make it > configurable. Run the loop at least once to let the user stop the boot > by holding a key pressed. > > The property is added to the chosen node, e.g., > > ch

Re: Build regressions/improvements in v3.17-rc6 (take two)

2014-09-23 Thread Geert Uytterhoeven
On Tue, Sep 23, 2014 at 10:31 AM, Geert Uytterhoeven wrote: > JFYI, when comparing v3.17-rc6[1] to v3.17-rc5[3], the summaries are: > - build errors: +9/-10 + /scratch/kisskb/src/drivers/net/ethernet/amd/lance.c: error: implicit declaration of function 'isa_bus_to_virt' [-Werror=implicit-fun

Re: [PATCH v2] powerpc/iommu/ddw: Fix endianness

2014-09-23 Thread Anton Blanchard
Hi Alexey, > ddw_avail is a pointer to the "ibm,ddw-applicable" property which > contains 3 cells which are big-endian as it is a device tree. > rtas_call() accepts a RTAS token in CPU-endian. This converts RTAS > tokens from big-endian to CPU-endian. Since every token is used once > till guest i

[PATCHv4] clk: ppc-corenet: rename to ppc-qoriq and add CLK_OF_DECLARE support

2014-09-23 Thread Jingchang Lu
The IP is shared by PPC and ARM, this renames it to qoriq for better represention, and this also adds the CLK_OF_DECLARE support for being initialized by of_clk_init() on ARM. Signed-off-by: Jingchang Lu --- changes in v4: remove "corenet" literals omitted in v3 remove. changes in v3: generate

Re: [PATCH v5 1/1] powerpc/perf: Adjust callchain based on DWARF debug info

2014-09-23 Thread Jiri Olsa
On Tue, Sep 23, 2014 at 12:33:45AM +0300, Aaro Koskinen wrote: > Hi, > > On Wed, Jun 25, 2014 at 08:49:03AM -0700, Sukadev Bhattiprolu wrote: > > powerpc/perf: Adjust callchain based on DWARF debug info > > > > When saving the callchain on Power, the kernel conservatively saves excess > > entries