Re: [PATCH] powerpc: Revert removing of _INIT_GLOBAL(), _STATIC() and _INIT_STATIC()

2014-07-21 Thread Benjamin Herrenschmidt
On Mon, 2014-07-21 at 14:56 -0400, Steven Rostedt wrote: > > Weird ... what are your gcc and binutils versions ? Smells like a > > toolchain issue to me but I need to dig a bit more. Doesn't hit any > > of my test configs here. > > > > Can you test the attached config with this toolchain and see

Re: [PATCH 2/2] powerpc: thp: invalidate old 64K based hash page mapping before insert

2014-07-21 Thread Benjamin Herrenschmidt
On Tue, 2014-07-15 at 20:22 +0530, Aneesh Kumar K.V wrote: > If we changed base page size of the segment, either via sub_page_protect > or via remap_4k_pfn, we do a demote_segment which doesn't flush the hash > table entries. We do that when inserting a new hash pte by checking the > _PAGE_COMBO fl

Re: [PATCH] powerpc: thp: Add write barrier after updating the valid bit

2014-07-21 Thread Benjamin Herrenschmidt
On Tue, 2014-07-15 at 20:22 +0530, Aneesh Kumar K.V wrote: > With hugepages, we store the hpte valid information in the pte page > whose address is stored in the second half of the PMD. Use a > write barrier to make sure that clearing pmd busy bit and updating > hpte valid info are ordered properly

Re: [PATCH v1 2/3] powerpc/powernv: Support PCI error injection

2014-07-21 Thread Mike Qiu
On 07/22/2014 11:26 AM, Gavin Shan wrote: On Tue, Jul 22, 2014 at 11:10:42AM +0800, Mike Qiu wrote: On 07/22/2014 06:49 AM, Benjamin Herrenschmidt wrote: On Mon, 2014-07-21 at 16:06 +0800, Mike Qiu wrote: I don't like this. I much prefer have dedicated error injection files in their respective

Re: [PATCH v1 2/3] powerpc/powernv: Support PCI error injection

2014-07-21 Thread Gavin Shan
On Tue, Jul 22, 2014 at 11:10:42AM +0800, Mike Qiu wrote: >On 07/22/2014 06:49 AM, Benjamin Herrenschmidt wrote: >>On Mon, 2014-07-21 at 16:06 +0800, Mike Qiu wrote: I don't like this. I much prefer have dedicated error injection files in their respective locations, something for PCI under

Re: [PATCH v1 2/3] powerpc/powernv: Support PCI error injection

2014-07-21 Thread Benjamin Herrenschmidt
On Tue, 2014-07-22 at 11:10 +0800, Mike Qiu wrote: > On 07/22/2014 06:49 AM, Benjamin Herrenschmidt wrote: > > On Mon, 2014-07-21 at 16:06 +0800, Mike Qiu wrote: > >>> I don't like this. I much prefer have dedicated error injection files > >>> in their respective locations, something for PCI under

Re: [PATCH v1 2/3] powerpc/powernv: Support PCI error injection

2014-07-21 Thread Mike Qiu
On 07/22/2014 06:49 AM, Benjamin Herrenschmidt wrote: On Mon, 2014-07-21 at 16:06 +0800, Mike Qiu wrote: I don't like this. I much prefer have dedicated error injection files in their respective locations, something for PCI under the corresponding PCI bridge etc... So PowerNV error injection wi

Re: [PATCH v2 7/7] memory-hotplug: tile: suitable memory should go to ZONE_MOVABLE

2014-07-21 Thread Wang Nan
Hi Andrew, Please drop patch 7/7 from -mm tree and keep other 6 patches. arch_add_memory() in tile is different from others: no nid parameter. Patch 7/7 will block compiling. I cc this mail to Chris Metcalf and hope he can look at this issue. Other 6 patches looks good. On 2014/7/21 11:46, Wan

Re: [RFC PATCH 2/3] topology: support node_numa_mem() for determining the fallback node

2014-07-21 Thread David Rientjes
On Mon, 21 Jul 2014, Nishanth Aravamudan wrote: > Sorry for bringing up this old thread again, but I had a question for > you, David. node_to_mem_node(), which does seem like a useful API, > doesn't seem like it can just node_distance() solely, right? Because > that just tells us the relative cost

Re: [RFC PATCH 2/3] topology: support node_numa_mem() for determining the fallback node

2014-07-21 Thread Nishanth Aravamudan
On 10.02.2014 [10:09:36 +0900], Joonsoo Kim wrote: > On Sat, Feb 08, 2014 at 01:57:39AM -0800, David Rientjes wrote: > > On Fri, 7 Feb 2014, Joonsoo Kim wrote: > > > > > > It seems like a better approach would be to do this when a node is > > > > brought > > > > online and determine the fallback

Re: [PATCH v1 2/3] powerpc/powernv: Support PCI error injection

2014-07-21 Thread Benjamin Herrenschmidt
On Mon, 2014-07-21 at 16:06 +0800, Mike Qiu wrote: > > I don't like this. I much prefer have dedicated error injection files > > in their respective locations, something for PCI under the corresponding > > PCI bridge etc... > > So PowerNV error injection will be designed rely on debugfs been > co

Re: [PATCH v2 5/7] powerpc/corenet: Add MDIO bus muxing support to the board device tree(s)

2014-07-21 Thread Scott Wood
On Wed, 2014-07-16 at 15:17 -0500, Shruti Kanetkar wrote: > Based on prior work by Andy Fleming > > Signed-off-by: Shruti Kanetkar > --- What changed from v2? > + mdio@fc000 { > + phy_sgmii_1e: ethernet-phy@1e { > +

Re: [PATCH v2 3/7] powerpc/corenet: Create the dts components for the DPAA FMan

2014-07-21 Thread Scott Wood
On Wed, 2014-07-16 at 15:17 -0500, Shruti Kanetkar wrote: > '761743e net/fsl_pq_mdio: add support for the Fman 1G MDIO controller' > introduced driver support for the FMan MDIO controller. Now add the DT > description for the MDIO controller from all FMan revisions > > Note that the FMan v3 MDIO c

[PATCH 16/43] powerpc: Use get_signal() signal_setup_done()

2014-07-21 Thread Richard Weinberger
From: Richard Weinberger Use the more generic functions get_signal() signal_setup_done() for signal delivery. This inverts also the return codes of setup_*frame() to follow the kernel convention. Signed-off-by: Richard Weinberger --- arch/powerpc/kernel/signal.c| 31 +++

[PATCH 43/43] powerpc: Use sigsp()

2014-07-21 Thread Richard Weinberger
From: Richard Weinberger Use sigsp() instead of the open coded variant. Signed-off-by: Richard Weinberger --- arch/powerpc/kernel/signal.c| 10 ++ arch/powerpc/kernel/signal_32.c | 4 ++-- arch/powerpc/kernel/signal_64.c | 2 +- 3 files changed, 5 insertions(+), 11 deletions(-)

Re: [PATCH v2 1/7] memory-hotplug: add zone_for_memory() for selecting zone for new memory

2014-07-21 Thread Sergei Shtylyov
Hello. On 07/21/2014 07:46 AM, Wang Nan wrote: Some grammar nitpicking. This patch introduces a zone_for_memory function in arch independent code for arch_add_memory() using. s/ using/'s use/. Many arch_add_memory() function simply selects ZONE_HIGHMEM or Plural needed with "man

RE: [PATCH 1/6 v2] KVM: PPC: Book3E: Use common defines for SPE/FP/AltiVec int numbers

2014-07-21 Thread mihai.cara...@freescale.com
> -Original Message- > From: Alexander Graf [mailto:ag...@suse.de] > Sent: Thursday, July 03, 2014 3:21 PM > To: Caraman Mihai Claudiu-B02008; kvm-...@vger.kernel.org > Cc: k...@vger.kernel.org; linuxppc-dev@lists.ozlabs.org > Subject: Re: [PATCH 1/6 v2] KVM: PPC: Book3E: Use common defines

RE: [PATCH v5 4/5] KVM: PPC: Alow kvmppc_get_last_inst() to fail

2014-07-21 Thread mihai.cara...@freescale.com
> -Original Message- > From: Linuxppc-dev [mailto:linuxppc-dev- > bounces+mihai.caraman=freescale@lists.ozlabs.org] On Behalf Of > mihai.cara...@freescale.com > Sent: Friday, July 18, 2014 12:06 PM > To: Alexander Graf; kvm-...@vger.kernel.org > Cc: linuxppc-dev@lists.ozlabs.org; k...@v

[PATCH powerpc] use _GLOBAL_TOC for memmove

2014-07-21 Thread Li Zhong
memmove may be called from module code copy_pages(btrfs), and it may call memcpy, which may call back to C code, so it needs to use _GLOBAL_TOC to set up r2 correctly. This fixes following error when I tried to boot an le guest: Vector: 300 (Data Access) at [c00073f97210] pc: c00

RE: [PATCH] powerpc : dma-mapping : Check null condition for dev->archdata.dma_ops

2014-07-21 Thread nikhil.bad...@freescale.com
> -Original Message- > From: Denis Kirjanov [mailto:kirja...@gmail.com] > Sent: Friday, July 18, 2014 7:21 PM > To: Badola Nikhil-B46172 > Cc: linuxppc-dev@lists.ozlabs.org > Subject: Re: [PATCH] powerpc : dma-mapping : Check null condition for dev- > >archdata.dma_ops > > On 7/18/14, Nikh

Re: [PATCH v1 2/3] powerpc/powernv: Support PCI error injection

2014-07-21 Thread Mike Qiu
On 06/25/2014 11:19 AM, Benjamin Herrenschmidt wrote: On Wed, 2014-06-25 at 11:05 +0800, Mike Qiu wrote: Here maybe "/sys/kernel/debug/powerpc/errinjct" is better, because it will supply "PCI_domain_nr" in parameters, so no need supply errinjct for each PCI domain. Another reason is error inje