Re: [RFC][PATCH 2/2] powerpc/booke: revert PTRACE_SINGLEBLOCK to BookE behavior

2013-07-05 Thread James Yang
On Sat, 6 Jul 2013, Benjamin Herrenschmidt wrote: > On Fri, 2013-07-05 at 17:11 -0500, James Yang wrote: > > A BookE branch taken debug exception followed by a single step does not > > accurately simulate Server's branch execute debug exception. BookE's > > branch taken debug exception stops befo

[PATCH] hashtable: add hash_for_each_possible_rcu_notrace()

2013-07-05 Thread Alexey Kardashevskiy
This adds hash_for_each_possible_rcu_notrace() which is basically a notrace clone of hash_for_each_possible_rcu() which cannot be used in real mode due to its tracing/debugging capability. Signed-off-by: Alexey Kardashevskiy --- include/linux/hashtable.h | 15 +++ 1 file changed, 15

Re: [RFC][PATCH 2/2] powerpc/booke: revert PTRACE_SINGLEBLOCK to BookE behavior

2013-07-05 Thread Benjamin Herrenschmidt
On Fri, 2013-07-05 at 17:11 -0500, James Yang wrote: > A BookE branch taken debug exception followed by a single step does not > accurately simulate Server's branch execute debug exception. BookE's > branch taken debug exception stops before the branch is to be executed > and only happens if the b

Re: [PATCH 1/8] PCI: Add pcibios_stop_dev()

2013-07-05 Thread Benjamin Herrenschmidt
On Fri, 2013-07-05 at 16:49 -0600, Bjorn Helgaas wrote: > I know we have paths where we save config space, do a reset, and > restore config space. I don't like those because some quirks aren't > applied and I don't believe restoring config space is sufficient to > make the device safe to use. The

Re: [PATCH 1/8] PCI: Add pcibios_stop_dev()

2013-07-05 Thread Bjorn Helgaas
On Fri, Jul 5, 2013 at 4:36 PM, Benjamin Herrenschmidt wrote: > On Fri, 2013-07-05 at 12:49 -0600, Bjorn Helgaas wrote: >> We already have pcibios_release_device() (just merged for v3.11). >> Would that work for you? I haven't seen your whole series, so I can't >> tell whether you need something

Re: [PATCH 1/8] PCI: Add pcibios_stop_dev()

2013-07-05 Thread Benjamin Herrenschmidt
On Fri, 2013-07-05 at 12:49 -0600, Bjorn Helgaas wrote: > We already have pcibios_release_device() (just merged for v3.11). > Would that work for you? I haven't seen your whole series, so I can't > tell whether you need something different. Maybe... Gavin's original hook applies when the device i

[RFC][PATCH 1/2] powerpc/booke: extend PTRACE_SINGLEBLOCK for BookE Branch Taken Debug

2013-07-05 Thread James Yang
A BookE branch taken debug exception followed by a single step does not accurately simulate Server's branch execute debug exception. BookE's branch taken debug exception stops before the branch is to be executed and only happens if the branch will actually be taken. Server's branch execute trace

[RFC][PATCH 2/2] powerpc/booke: revert PTRACE_SINGLEBLOCK to BookE behavior

2013-07-05 Thread James Yang
A BookE branch taken debug exception followed by a single step does not accurately simulate Server's branch execute debug exception. BookE's branch taken debug exception stops before the branch is to be executed and only happens if the branch will actually be taken. Server's branch execute trace

[RFC][PATCH 0/2] powerpc/booke: PTRACE_SINGLEBLOCK support for BookE

2013-07-05 Thread James Yang
PTRACE_SINGLEBLOCK support for BookE currently stops on the instruction after taken branches. This is different from the behavior on Server where it stops after all branches. BookE was made to simulate Server by taking a single step after the branch taken exception. It is understood that the r

Re: [PATCHv4 03/11] pci: remove ARCH_SUPPORTS_MSI kconfig option

2013-07-05 Thread Thomas Petazzoni
Dear Bjorn Helgaas, On Fri, 5 Jul 2013 15:37:33 -0600, Bjorn Helgaas wrote: > Acked-by: Bjorn Helgaas > > Again, please update the subject line to "PCI: Remove ..." > > I doubt that you'll get explicit acks from all the arches you touched, > but I think it's reasonable to put at least patches

Re: [PATCHv4 02/11] pci: use weak functions for MSI arch-specific functions

2013-07-05 Thread Thomas Petazzoni
Dear Bjorn Helgaas, On Fri, 5 Jul 2013 15:34:10 -0600, Bjorn Helgaas wrote: > On Fri, Jul 5, 2013 at 3:32 PM, Bjorn Helgaas wrote: > > > Acked-by: Bjorn Helgaas > > But please update your subject line to use consistent capitalization, e.g., > > PCI: Use weak ... Sure, will do. Would it be p

Re: [PATCHv4 03/11] pci: remove ARCH_SUPPORTS_MSI kconfig option

2013-07-05 Thread Bjorn Helgaas
On Mon, Jul 1, 2013 at 7:42 AM, Thomas Petazzoni wrote: > Now that we have weak versions for each of the PCI MSI architecture > functions, we can actually build the MSI support for all platforms, > regardless of whether they provide or not architecture-specific > versions of those functions. For t

Re: [PATCHv4 02/11] pci: use weak functions for MSI arch-specific functions

2013-07-05 Thread Bjorn Helgaas
On Fri, Jul 5, 2013 at 3:32 PM, Bjorn Helgaas wrote: > Acked-by: Bjorn Helgaas But please update your subject line to use consistent capitalization, e.g., PCI: Use weak ... ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozl

Re: [PATCHv4 02/11] pci: use weak functions for MSI arch-specific functions

2013-07-05 Thread Bjorn Helgaas
On Mon, Jul 1, 2013 at 7:42 AM, Thomas Petazzoni wrote: > Until now, the MSI architecture-specific functions could be overloaded > using a fairly complex set of #define and compile-time > conditionals. In order to prepare for the introduction of the msi_chip > infrastructure, it is desirable to sw

[PATCH] powerpc/booke: clear DBCR0_BT in user_disable_single_step()

2013-07-05 Thread James Yang
BookE version of user_disable_single_step() clears DBCR0_IC for the instruction completion debug, but did not also clear DBCR0_BT for the branch taken exception. This behavior was lost by the 2/2010 patch. Signed-off-by: James Yang --- arch/powerpc/kernel/ptrace.c |2 +- 1 files changed, 1

Re: [PATCH 4/8] PCI/hotplug: Needn't remove EEH cache again

2013-07-05 Thread Bjorn Helgaas
On Thu, Jul 4, 2013 at 8:57 PM, Gavin Shan wrote: > Since pci_stop_and_remove_bus_device() has removed the EEH cache, > we needn't do that again. > > Cc: Bjorn Helgaas > Cc: linux-...@vger.kernel.org > Signed-off-by: Gavin Shan Acked-by: Bjorn Helgaas Please merge this along with the rest of

Re: [PATCH 1/8] PCI: Add pcibios_stop_dev()

2013-07-05 Thread Bjorn Helgaas
On Thu, Jul 4, 2013 at 8:57 PM, Gavin Shan wrote: > When stopping and removing one specific PCI device, the platform > might need take some actions. One example is that EEH already had > eeh cache and eeh device attached to the PCI device, and we need > release eeh cache and device during the time

Re: [PATCH 8/8] powerpc/perf: Add power8 EBB support

2013-07-05 Thread Adhemerval Zanella
On 04-07-2013 23:54, Michael Ellerman wrote: > On Thu, Jul 04, 2013 at 03:58:01PM -0300, Adhemerval Zanella wrote: >> Hi Michael, >> >> I believe you forgot to add the cpu_user_features2 bit to announce the EBB >> support >> for P8, patch following: > Hi Adhemerval, > > You're right, I haven't add

Re: [PATCH v2 2/2] perf tools: Make Power7 events available for perf

2013-07-05 Thread Ingo Molnar
* Peter Zijlstra wrote: > On Thu, Jul 04, 2013 at 10:52:18PM +1000, Michael Ellerman wrote: > > I don't think it even needs libpfm4, just some csv files in tools/perf > > would do the trick. > > Right; I think Stephane and Jiri are in favour of creating a 'new' > project that includes just the