Re: [PATCHv4 1/2] ppc64: perform proper max_bus_speed detection

2013-05-02 Thread Tony Breeds
On Thu, May 02, 2013 at 12:21:37PM -0300, Kleber Sacilotto de Souza wrote: > Hi Tony, > > It seems Lucas' change is a bit incomplete and is not handling the reference > counter to > the device_node correctly. Is the following change what you had in mind? Ahh Sorry I expected there would be a fo

Re: [PATCH 1/1] powerpc: mpc512x_dma: add support for data transfers between memory and i/o memory

2013-05-02 Thread Alexander Popov
Hello Vinod, Thanks for the review. I will return with improved and tested version 2. Best regards, Alexander ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH -V7 10/10] powerpc: disable assert_pte_locked

2013-05-02 Thread David Gibson
On Mon, Apr 29, 2013 at 01:21:51AM +0530, Aneesh Kumar K.V wrote: > From: "Aneesh Kumar K.V" > > With THP we set pmd to none, before we do pte_clear. Hence we can't > walk page table to get the pte lock ptr and verify whether it is locked. > THP do take pte lock before calling pte_clear. So we do

Re: [PATCH -V7 09/10] powerpc: Optimize hugepage invalidate

2013-05-02 Thread David Gibson
On Mon, Apr 29, 2013 at 01:21:50AM +0530, Aneesh Kumar K.V wrote: > From: "Aneesh Kumar K.V" > > Hugepage invalidate involves invalidating multiple hpte entries. > Optimize the operation using H_BULK_REMOVE on lpar platforms. > On native, reduce the number of tlb flush. > > Signed-off-by: Aneesh

Re: [PATCH -V7 02/10] powerpc/THP: Implement transparent hugepages for ppc64

2013-05-02 Thread David Gibson
On Mon, Apr 29, 2013 at 01:21:43AM +0530, Aneesh Kumar K.V wrote: > From: "Aneesh Kumar K.V" > > We now have pmd entries covering 16MB range and the PMD table double its > original size. > We use the second half of the PMD table to deposit the pgtable (PTE page). > The depoisted PTE page is furt

Re: [PATCH -V7 06/10] powerpc: Update gup_pmd_range to handle transparent hugepages

2013-05-02 Thread David Gibson
On Mon, Apr 29, 2013 at 01:21:47AM +0530, Aneesh Kumar K.V wrote: > From: "Aneesh Kumar K.V" > > Signed-off-by: Aneesh Kumar K.V Reviewed-by: David Gibson -- David Gibson| I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NO

Re: [PATCH -V7 07/10] powerpc/THP: Add code to handle HPTE faults for large pages

2013-05-02 Thread David Gibson
On Mon, Apr 29, 2013 at 01:21:48AM +0530, Aneesh Kumar K.V wrote: > From: "Aneesh Kumar K.V" > > The deposted PTE page in the second half of the PMD table is used to > track the state on hash PTEs. After updating the HPTE, we mark the > coresponding slot in the deposted PTE page valid. > > Signe

Re: [PATCH -V7 04/10] powerpc: Update find_linux_pte_or_hugepte to handle transparent hugepages

2013-05-02 Thread David Gibson
On Mon, Apr 29, 2013 at 01:21:45AM +0530, Aneesh Kumar K.V wrote: > From: "Aneesh Kumar K.V" What's the difference in meaning between pmd_huge() and pmd_large()? > > Signed-off-by: Aneesh Kumar K.V > --- > arch/powerpc/mm/hugetlbpage.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH -V7 08/10] powerpc/THP: Enable THP on PPC64

2013-05-02 Thread David Gibson
On Mon, Apr 29, 2013 at 01:21:49AM +0530, Aneesh Kumar K.V wrote: > From: "Aneesh Kumar K.V" > > We enable only if the we support 16MB page size. > > Signed-off-by: Aneesh Kumar K.V > --- > arch/powerpc/include/asm/pgtable-ppc64.h | 3 +-- > arch/powerpc/mm/pgtable_64.c | 28 +

Re: [PATCH -V7 05/10] powerpc: Replace find_linux_pte with find_linux_pte_or_hugepte

2013-05-02 Thread David Gibson
On Mon, Apr 29, 2013 at 01:21:46AM +0530, Aneesh Kumar K.V wrote: > From: "Aneesh Kumar K.V" > > Replace find_linux_pte with find_linux_pte_or_hugepte and explicitly > document why we don't need to handle transparent hugepages at callsites. > > Signed-off-by: Aneesh Kumar K.V > --- > arch/powe

RE: pci overmapping

2013-05-02 Thread Sethi Varun-B16395
> -Original Message- > From: Wood Scott-B07421 > Sent: Thursday, May 02, 2013 11:50 PM > To: Sethi Varun-B16395 > Cc: Wood Scott-B07421; Yoder Stuart-B08248; ga...@kernel.crashing.org; > linuxppc-dev@lists.ozlabs.org > Subject: Re: pci overmapping > > On 05/02/2013 01:09:53 PM, Sethi Var

Re: [PATCH -V7 01/10] powerpc/THP: Double the PMD table size for THP

2013-05-02 Thread David Gibson
On Mon, Apr 29, 2013 at 01:21:42AM +0530, Aneesh Kumar K.V wrote: > From: "Aneesh Kumar K.V" > > THP code does PTE page allocation along with large page request and deposit > them > for later use. This is to ensure that we won't have any failures when we split > hugepages to regular pages. > >

RE: [PATCH 2/2 V8] powerpc/85xx: Add machine check handler to fix PCIe erratum on mpc85xx

2013-05-02 Thread Jia Hongtao-B38951
> -Original Message- > From: Wood Scott-B07421 > Sent: Friday, May 03, 2013 1:04 AM > To: Jia Hongtao-B38951 > Cc: linuxppc-dev@lists.ozlabs.org; ga...@kernel.crashing.org; Wood Scott- > B07421; seg...@kernel.crashing.org; Li Yang-R58472; Jia Hongtao-B38951 > Subject: Re: [PATCH 2/2 V8] p

RE: [PATCH v3 1/4] powerpc/mpic: add irq_set_wake support

2013-05-02 Thread Wang Dongsheng-B40534
Hi Kumar, Could you apply these patches? Thanks. > -Original Message- > From: Wang Dongsheng-B40534 > Sent: Tuesday, April 23, 2013 6:10 PM > To: ga...@kernel.crashing.org > Cc: linuxppc-dev@lists.ozlabs.org; Wood Scott-B07421 > Subject: RE: [PATCH v3 1/4] powerpc/mpic: add irq_set_wake

[PATCH] powerpc/tm: Fix null pointer deference in flush_hash_page

2013-05-02 Thread Michael Neuling
Make sure that current->thread.reg exists before we deference it in flush_hash_page. Signed-off-by: Michael Neuling Reported-by: John J Miller Cc: diff --git a/arch/powerpc/mm/hash_utils_64.c b/arch/powerpc/mm/hash_utils_64.c index 3e4c4ed..88ac0ee 100644 --- a/arch/powerpc/mm/hash_utils_64.c

Re: [PATCH net-next] af_unix: fix a fatal race with bit fields

2013-05-02 Thread Alan Modra
On Tue, Apr 30, 2013 at 10:04:32PM -0700, Eric Dumazet wrote: > These kind of errors are pretty hard to find, its a pity to spend time > on them. Well, yes. From the first comment in gcc PR52080. "For the following testcase we generate a 8 byte RMW cycle on IA64 which causes locking problems in

[PATCH 3/3] powerpc/perf: Add e6500 PMU driver

2013-05-02 Thread Lijun Pan
e6500 core performance monitors has the following features: - 6 performance monitor counters - 512 events supported - no threshold events e6500 PMU has more specific events (Data L1 cache misses, Instruction L1 cache misses, etc ) than e500 PMU (which only had Data L1 cache reloads, etc). Where av

[PATCH 2/3] powerpc/perf: add 2 additional performance monitor counters for e6500 core

2013-05-02 Thread Lijun Pan
There are 6 counters in e6500 core instead of 4 in e500 core. Signed-off-by: Lijun Pan --- arch/powerpc/include/asm/reg_fsl_emb.h | 12 arch/powerpc/kernel/cputable.c |2 +- arch/powerpc/oprofile/op_model_fsl_emb.c | 30 ++ arch/powerp

[PATCH 1/3] powerpc/perf: correct typos in counter enumeration

2013-05-02 Thread Lijun Pan
Signed-off-by: Lijun Pan --- arch/powerpc/include/asm/reg_fsl_emb.h |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/powerpc/include/asm/reg_fsl_emb.h b/arch/powerpc/include/asm/reg_fsl_emb.h index 77bb71c..1cf8ab0 100644 --- a/arch/powerpc/include/asm/reg_fsl_

Re: [PATCH net-next] af_unix: fix a fatal race with bit fields

2013-05-02 Thread Benjamin Herrenschmidt
On Wed, 2013-05-01 at 08:10 -0700, Stephen Hemminger wrote: > > These kind of errors are pretty hard to find, its a pity to spend > time > > on them. > > There is a checkbin target inside arch/powerpc/Makefile > Shouldn't a check be added there to block building kernel with known > bad GCC version

Re: pci overmapping

2013-05-02 Thread Scott Wood
On 05/02/2013 01:09:53 PM, Sethi Varun-B16395 wrote: > -Original Message- > From: Wood Scott-B07421 > Sent: Thursday, May 02, 2013 10:44 PM > To: Yoder Stuart-B08248 > Cc: ga...@kernel.crashing.org; Sethi Varun-B16395; linuxppc- > d...@lists.ozlabs.org > Subject: Re: pci overmapping > >

RE: pci overmapping

2013-05-02 Thread Sethi Varun-B16395
> -Original Message- > From: Wood Scott-B07421 > Sent: Thursday, May 02, 2013 10:44 PM > To: Yoder Stuart-B08248 > Cc: ga...@kernel.crashing.org; Sethi Varun-B16395; linuxppc- > d...@lists.ozlabs.org > Subject: Re: pci overmapping > > On 05/02/2013 12:05:42 PM, Yoder Stuart-B08248 wrote:

Re: [PATCH 1/1] powerpc: mpc512x_dma: add support for data transfers between memory and i/o memory

2013-05-02 Thread Vinod Koul
On Wed, May 01, 2013 at 03:28:09PM +0400, Alexander Popov wrote: > The initial version of this driver supports only memory to memory > data transfers. > > Data transfers between memory and i/o memory require more delicate TCD > (Transfer Control Descriptor) configuration and DMA channel service re

Re: pci overmapping

2013-05-02 Thread Scott Wood
On 05/02/2013 12:05:42 PM, Yoder Stuart-B08248 wrote: Kumar, In fsl_pci.c there is a change you made a while back: "powerpc/fsl: Setup PCI inbound window based on actual amount of memory" ...and there is this comment in the code: /* PCIe can overmap inbound & outbound since RX & TX ar

pci overmapping

2013-05-02 Thread Yoder Stuart-B08248
Kumar, In fsl_pci.c there is a change you made a while back: "powerpc/fsl: Setup PCI inbound window based on actual amount of memory" ...and there is this comment in the code: /* PCIe can overmap inbound & outbound since RX & TX are separated */ if (early_find_capability(hose, 0, 0, PC

Re: [PATCH 2/2 V8] powerpc/85xx: Add machine check handler to fix PCIe erratum on mpc85xx

2013-05-02 Thread Scott Wood
On 04/28/2013 12:20:08 AM, Jia Hongtao wrote: A PCIe erratum of mpc85xx may causes a core hang when a link of PCIe goes down. when the link goes down, Non-posted transactions issued via the ATMU requiring completion result in an instruction stall. At the same time a machine-check exception is gen

Re: [PATCH net-next] af_unix: fix a fatal race with bit fields

2013-05-02 Thread Scott Wood
On 04/30/2013 10:54:25 PM, Alan Modra wrote: On Tue, Apr 30, 2013 at 07:24:20PM -0700, Eric Dumazet wrote: >li 11,1 >ld 0,0(9) >rldimi 0,11,31,32 >std 0,0(9) >blr >.ident "GCC: (GNU) 4.6.3" > > You can see "ld 0,0(9)" is used : its a 64 bit load. Yup. This is not a powe

Re: [PATCHv4 1/2] ppc64: perform proper max_bus_speed detection

2013-05-02 Thread Kleber Sacilotto de Souza
On 04/25/2013 02:34 PM, Lucas Kannebley Tavares wrote: > On 04/24/2013 08:48 PM, Tony Breeds wrote: >>> diff --git a/arch/powerpc/platforms/pseries/pci.c >>> b/arch/powerpc/platforms/pseries/pci.c >>> index 0b580f4..7f9c956 100644 >>> --- a/arch/powerpc/platforms/pseries/pci.c >>> +++ b/arch/powerp

[PATCH 2/2] powerpc/512x: DMA via LocalPlus Bus testing driver

2013-05-02 Thread Alexander Popov
This module tests Direct Memory Access to some device on LocalPlus Bus for Freescale MPC512x. In other words it tests the bundle of mpc512x_lpbfifo and mpc512x_dma drivers. This testing driver was multiply used with static RAM (CY62167EV30LL-45ZXI) which lives on LocalPlus Bus on our board. This t

[PATCH 1/2] powerpc/512x: add LocalPlus Bus FIFO device driver

2013-05-02 Thread Alexander Popov
This is SCLPC device driver for the Freescale MPC512x. It is needed for Direct Memory Access to the devices on LocalPlus Bus. Signed-off-by: Alexander Popov --- arch/powerpc/boot/dts/mpc5121.dtsi| 8 +- arch/powerpc/include/asm/mpc5121.h| 32 ++ arch/powerpc/platforms/

RE: [PATCH 1/2 v15] iommu/fsl: Add additional iommu attributes required by the PAMU driver.

2013-05-02 Thread Sethi Varun-B16395
> -Original Message- > From: j...@8bytes.org [mailto:j...@8bytes.org] > Sent: Thursday, May 02, 2013 3:46 PM > To: Sethi Varun-B16395 > Cc: io...@lists.linux-foundation.org; linuxppc-dev@lists.ozlabs.org; > linux-ker...@vger.kernel.org; ga...@kernel.crashing.org; > b...@kernel.crashing.or

Re: [PATCH -next] kvm/ppc/mpic: fix missing unlock in set_base_addr()

2013-05-02 Thread Alexander Graf
On 02.05.2013, at 07:17, Wei Yongjun wrote: > From: Wei Yongjun > > Add the missing unlock before return from function set_base_addr() > when disables the mapping. > > Introduced by commit 5df554ad5b7522ea62b0ff9d5be35183494efc21 > (kvm/ppc/mpic: in-kernel MPIC emulation) > > Signed-off-by: W

Re: [PATCH 1/2 v15] iommu/fsl: Add additional iommu attributes required by the PAMU driver.

2013-05-02 Thread j...@8bytes.org
On Tue, Apr 30, 2013 at 05:09:32PM +, Sethi Varun-B16395 wrote: > Would you take this patchset for 3.10 merge? Not this time. The final patch came in very late and is pretty big too. For code of that size I would like to have a few weeks more testing in next and probably also a non-Freescale R

[PATCH] powerpc/powernv: defer OPAL exception handler registration

2013-05-02 Thread Jeremy Kerr
Currently, the OPAL exception vectors are registered before the feature fixups are processed. This means that the now-firmware-owned vectors will likely be overwritten by the kernel. This change moves the exception registration code to an early initcall, rather than at machine_init time. Signed-o

[git pull] Please pull powerpc.git next branch

2013-05-02 Thread Benjamin Herrenschmidt
Hi Linus ! Here's the next pack of powerpc changes ! The main highlights this time around are: - A pile of addition POWER8 bits and nits, such as updated performance counter support (Michael Ellerman), new branch history buffer support (Anshuman Khandual), base support for the new PCI host brid

RE: [PATCH 2/2 V7] powerpc/85xx: Add machine check handler to fix PCIe erratum on mpc85xx

2013-05-02 Thread Jia Hongtao-B38951
> -Original Message- > From: Wood Scott-B07421 > Sent: Tuesday, April 30, 2013 4:30 AM > To: Jia Hongtao-B38951 > Cc: Wood Scott-B07421; Segher Boessenkool; linuxppc-dev@lists.ozlabs.org; > ga...@kernel.crashing.org > Subject: Re: [PATCH 2/2 V7] powerpc/85xx: Add machine check handler to