Re: [RFC PATCH v2 01/12] Add sys_hotplug.h for system device hotplug framework

2013-01-31 Thread Greg KH
On Thu, Jan 31, 2013 at 06:32:18PM -0700, Toshi Kani wrote: > This is already done for PCI host bridges and platform devices and I don't > > see why we can't do that for the other types of devices too. > > > > The only missing piece I see is a way to handle the "eject" problem, i.e. > > when we t

Re: [RFC PATCH v2 01/12] Add sys_hotplug.h for system device hotplug framework

2013-01-31 Thread Greg KH
On Thu, Jan 31, 2013 at 09:54:51PM +0100, Rafael J. Wysocki wrote: > > > But, again, I'm going to ask why you aren't using the existing cpu / > > > memory / bridge / node devices that we have in the kernel. Please use > > > them, or give me a _really_ good reason why they will not work. > > > > W

Re: [PATCH v6 00/15] memory-hotplug: hot-remove physical memory

2013-01-31 Thread Tang Chen
Hi Simon, On 02/01/2013 11:06 AM, Simon Jeons wrote: How can distinguish map and use? I mean how can confirm memory is used by kernel instead of map? If the page is free, for example, it is in the buddy system, it is not in use. Even if it is direct mapped by kernel, the kernel logic should

Re: [PATCH v6 00/15] memory-hotplug: hot-remove physical memory

2013-01-31 Thread Simon Jeons
On Fri, 2013-02-01 at 09:32 +0800, Jianguo Wu wrote: > On 2013/1/31 18:38, Simon Jeons wrote: > > > Hi Tang, > > On Thu, 2013-01-31 at 17:44 +0800, Tang Chen wrote: > >> Hi Simon, > >> > >> On 01/31/2013 04:48 PM, Simon Jeons wrote: > >>> Hi Tang, > >>> On Thu, 2013-01-31 at 15:10 +0800, Tang Chen

Re: [PATCH v6 00/15] memory-hotplug: hot-remove physical memory

2013-01-31 Thread Simon Jeons
Hi Tang, On Fri, 2013-02-01 at 10:42 +0800, Tang Chen wrote: I confuse! > Hi Simon, > > On 02/01/2013 10:17 AM, Simon Jeons wrote: > >> For example: > >> > >> 64TB, what ever > >> xxxTB, what ever > >> logic address space: > >> |_kernel_

Re: [PATCH] powerpc: kernel/kgdb.c: fix memory leakage

2013-01-31 Thread Jason Wessel
On 01/14/2013 11:26 AM, Cong Ding wrote: > the variable backup_current_thread_info isn't freed before existing the > function. > > Signed-off-by: Cong Ding > --- > arch/powerpc/kernel/kgdb.c |5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/arch/powerpc/kernel/kgd

Re: [PATCH v6 00/15] memory-hotplug: hot-remove physical memory

2013-01-31 Thread Simon Jeons
Hi Tang, On Fri, 2013-02-01 at 09:57 +0800, Tang Chen wrote: > On 02/01/2013 09:36 AM, Simon Jeons wrote: > > On Fri, 2013-02-01 at 09:32 +0800, Jianguo Wu wrote: > >>> > >>> So if config NUMA, kernel memory will not be linear mapping anymore? For > >>> example, > >>> > >>> Node 0 Node 1 > >>> > >

Re: [PATCH v6 00/15] memory-hotplug: hot-remove physical memory

2013-01-31 Thread Tang Chen
Hi Simon, On 02/01/2013 10:17 AM, Simon Jeons wrote: For example: 64TB, what ever xxxTB, what ever logic address space: |_kernel___|_user_| \ \ / /

Re: [PATCH v6 00/15] memory-hotplug: hot-remove physical memory

2013-01-31 Thread Jianguo Wu
On 2013/2/1 10:06, Simon Jeons wrote: > Hi Jianguo, > On Fri, 2013-02-01 at 09:57 +0800, Jianguo Wu wrote: >> On 2013/2/1 9:36, Simon Jeons wrote: >> >>> On Fri, 2013-02-01 at 09:32 +0800, Jianguo Wu wrote: On 2013/1/31 18:38, Simon Jeons wrote: > Hi Tang, > On Thu, 2013-01-31 at

Re: [PATCH v6 00/15] memory-hotplug: hot-remove physical memory

2013-01-31 Thread Simon Jeons
Hi Jianguo, On Fri, 2013-02-01 at 09:57 +0800, Jianguo Wu wrote: > On 2013/2/1 9:36, Simon Jeons wrote: > > > On Fri, 2013-02-01 at 09:32 +0800, Jianguo Wu wrote: > >> On 2013/1/31 18:38, Simon Jeons wrote: > >> > >>> Hi Tang, > >>> On Thu, 2013-01-31 at 17:44 +0800, Tang Chen wrote: > Hi Sim

Re: [PATCH v6 00/15] memory-hotplug: hot-remove physical memory

2013-01-31 Thread Jianguo Wu
On 2013/2/1 9:36, Simon Jeons wrote: > On Fri, 2013-02-01 at 09:32 +0800, Jianguo Wu wrote: >> On 2013/1/31 18:38, Simon Jeons wrote: >> >>> Hi Tang, >>> On Thu, 2013-01-31 at 17:44 +0800, Tang Chen wrote: Hi Simon, On 01/31/2013 04:48 PM, Simon Jeons wrote: > Hi Tang, > On

Re: [PATCH v6 00/15] memory-hotplug: hot-remove physical memory

2013-01-31 Thread Tang Chen
On 02/01/2013 09:36 AM, Simon Jeons wrote: On Fri, 2013-02-01 at 09:32 +0800, Jianguo Wu wrote: So if config NUMA, kernel memory will not be linear mapping anymore? For example, Node 0 Node 1 0 ~ 10G 11G~14G It has nothing to do with linear mapping, I think. kernel memory only at Node 0

Re: [RFC PATCH v2 01/12] Add sys_hotplug.h for system device hotplug framework

2013-01-31 Thread Toshi Kani
On Thu, 2013-01-31 at 21:54 +0100, Rafael J. Wysocki wrote: > On Wednesday, January 30, 2013 07:57:45 PM Toshi Kani wrote: > > On Tue, 2013-01-29 at 23:58 -0500, Greg KH wrote: > > > On Thu, Jan 10, 2013 at 04:40:19PM -0700, Toshi Kani wrote: : > > > > +}; > > > > + > > > > +struct shp_device { >

Re: [PATCH v6 00/15] memory-hotplug: hot-remove physical memory

2013-01-31 Thread Jianguo Wu
On 2013/1/31 18:38, Simon Jeons wrote: > Hi Tang, > On Thu, 2013-01-31 at 17:44 +0800, Tang Chen wrote: >> Hi Simon, >> >> On 01/31/2013 04:48 PM, Simon Jeons wrote: >>> Hi Tang, >>> On Thu, 2013-01-31 at 15:10 +0800, Tang Chen wrote: >>> >>> 1. IIUC, there is a button on machine which supports ho

Re: [RFC PATCH v2 01/12] Add sys_hotplug.h for system device hotplug framework

2013-01-31 Thread Rafael J. Wysocki
On Wednesday, January 30, 2013 07:57:45 PM Toshi Kani wrote: > On Tue, 2013-01-29 at 23:58 -0500, Greg KH wrote: > > On Thu, Jan 10, 2013 at 04:40:19PM -0700, Toshi Kani wrote: > > > +/* > > > + * Hot-plug device information > > > + */ > > > > Again, stop it with the "generic" hotplug term here, a

[PATCH 22/25] perf: Make EVENT_ATTR global

2013-01-31 Thread Arnaldo Carvalho de Melo
From: Sukadev Bhattiprolu Rename EVENT_ATTR() to PMU_EVENT_ATTR() and make it global so it is available to all architectures. Further to allow architectures flexibility, have PMU_EVENT_ATTR() pass in the variable name as a parameter. Changelog[v2] - [Jiri Olsa] No need to define PMU_EVE

[PATCH 21/25] perf/Power7: Use macros to identify perf events

2013-01-31 Thread Arnaldo Carvalho de Melo
From: Sukadev Bhattiprolu Define and use macros to identify perf events codes This would make it easier and more readable when these event codes need to be used in more than one place. Signed-off-by: Sukadev Bhattiprolu Acked-by: Jiri Olsa Cc: Andi Kleen Cc: Anton Blanchard Cc: Ingo Molnar

[PATCH 23/25] perf/POWER7: Make generic event translations available in sysfs

2013-01-31 Thread Arnaldo Carvalho de Melo
From: Sukadev Bhattiprolu Make the generic perf events in POWER7 available via sysfs. $ ls /sys/bus/event_source/devices/cpu/events branch-instructions branch-misses cache-misses cache-references cpu-cycles instructions stalled-cycl

[GIT PULL 00/25] perf/core improvements and fixes

2013-01-31 Thread Arnaldo Carvalho de Melo
Hi Ingo, Please consider pulling, - Arnaldo The following changes since commit 152fefa921535665f95840c08062844ab2f5593e: Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2013-01-31 10:20:14 +0100) are available in the git r

[PATCH 25/25] perf: Document the ABI of perf sysfs entries

2013-01-31 Thread Arnaldo Carvalho de Melo
From: Sukadev Bhattiprolu This patchset addes two new sets of files to sysfs for POWER architecture. - perf event config format in /sys/devices/cpu/format/event - generic and POWER-specific perf events in /sys/devices/cpu/events/ The format of the first file is already documente

[PATCH 24/25] perf/POWER7: Make some POWER7 events available in sysfs

2013-01-31 Thread Arnaldo Carvalho de Melo
From: Sukadev Bhattiprolu Make some POWER7-specific perf events available in sysfs. $ /bin/ls -1 /sys/bus/event_source/devices/cpu/events/ branch-instructions branch-misses cache-misses cache-references cpu-cycles instructions PM_BR

Re: [PATCH 1/5] KVM: PPC: e500: Move VCPU's MMUCFG register initialization earlier

2013-01-31 Thread Scott Wood
On 01/31/2013 09:26:20 AM, Caraman Mihai Claudiu-B02008 wrote: > -Original Message- > From: Alexander Graf [mailto:ag...@suse.de] > Sent: Thursday, January 31, 2013 4:58 PM > To: Caraman Mihai Claudiu-B02008 > Cc: kvm-...@vger.kernel.org; k...@vger.kernel.org; linuxppc- > d...@lists.ozlab

RE: [PATCH 1/5] KVM: PPC: e500: Move VCPU's MMUCFG register initialization earlier

2013-01-31 Thread Caraman Mihai Claudiu-B02008
> -Original Message- > From: Alexander Graf [mailto:ag...@suse.de] > Sent: Thursday, January 31, 2013 4:58 PM > To: Caraman Mihai Claudiu-B02008 > Cc: kvm-...@vger.kernel.org; k...@vger.kernel.org; linuxppc- > d...@lists.ozlabs.org > Subject: Re: [PATCH 1/5] KVM: PPC: e500: Move VCPU's MMUC

RE: [PATCH 4/5] KVM: PPC: e500: Emulate EPTCFG register

2013-01-31 Thread Caraman Mihai Claudiu-B02008
> -Original Message- > From: Alexander Graf [mailto:ag...@suse.de] > Sent: Thursday, January 31, 2013 3:31 PM > To: Caraman Mihai Claudiu-B02008 > Cc: kvm-...@vger.kernel.org; k...@vger.kernel.org; linuxppc- > d...@lists.ozlabs.org > Subject: Re: [PATCH 4/5] KVM: PPC: e500: Emulate EPTCFG r

Re: [PATCH 1/5] KVM: PPC: e500: Move VCPU's MMUCFG register initialization earlier

2013-01-31 Thread Alexander Graf
On 31.01.2013, at 15:56, Caraman Mihai Claudiu-B02008 wrote: >> -Original Message- >> From: Alexander Graf [mailto:ag...@suse.de] >> Sent: Thursday, January 31, 2013 3:21 PM >> To: Caraman Mihai Claudiu-B02008 >> Cc: kvm-...@vger.kernel.org; k...@vger.kernel.org; linuxppc- >> d...@lists.o

RE: [PATCH 1/5] KVM: PPC: e500: Move VCPU's MMUCFG register initialization earlier

2013-01-31 Thread Caraman Mihai Claudiu-B02008
> -Original Message- > From: Alexander Graf [mailto:ag...@suse.de] > Sent: Thursday, January 31, 2013 3:21 PM > To: Caraman Mihai Claudiu-B02008 > Cc: kvm-...@vger.kernel.org; k...@vger.kernel.org; linuxppc- > d...@lists.ozlabs.org > Subject: Re: [PATCH 1/5] KVM: PPC: e500: Move VCPU's MMUC

Re: [RFC PATCH v2 01/12] Add sys_hotplug.h for system device hotplug framework

2013-01-31 Thread Toshi Kani
On Thu, 2013-01-31 at 05:24 +, Greg KH wrote: > On Wed, Jan 30, 2013 at 06:15:12PM -0700, Toshi Kani wrote: > > > Please make it a "real" pointer, and not a void *, those shouldn't be > > > used at all if possible. > > > > How about changing the "void *handle" to acpi_dev_node below? > > >

Re: [PATCH 2/5] KVM: PPC: e500: Emulate TLBnPS registers

2013-01-31 Thread Alexander Graf
On 31.01.2013, at 14:24, Alexander Graf wrote: > > On 30.01.2013, at 14:29, Mihai Caraman wrote: > >> Emulate TLBnPS registers which are available in MMU Architecture Version >> (MAV) 2.0. >> >> Signed-off-by: Mihai Caraman >> --- >> arch/powerpc/include/asm/kvm_host.h |1 + >> arch/powerp

Re: [PATCH 5/5] KVM: PPC: e500mc: Enable e6500 cores

2013-01-31 Thread Alexander Graf
On 30.01.2013, at 14:29, Mihai Caraman wrote: > Extend processor compatibility names to e6500 cores. > > Signed-off-by: Mihai Caraman Looks good to me. Reviewed-by: Alexander Graf Alex > --- > arch/powerpc/kvm/e500mc.c |2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff

Re: [PATCH 4/5] KVM: PPC: e500: Emulate EPTCFG register

2013-01-31 Thread Alexander Graf
On 30.01.2013, at 14:29, Mihai Caraman wrote: > EPTCFG register defined by E.PT is accessed unconditionally by Linux guests > in the presence of MAV 2.0. Emulate EPTCFG register now. > > Signed-off-by: Mihai Caraman > --- > arch/powerpc/include/asm/kvm_host.h |1 + > arch/powerpc/kvm/e500.h

Re: [PATCH 3/5] KVM: PPC: e500: Remove E.PT category from VCPUs

2013-01-31 Thread Alexander Graf
On 30.01.2013, at 14:29, Mihai Caraman wrote: > Embedded.Page Table (E.PT) category in VMs requires indirect tlb entries > emulation which is not supported yet. Configure TLBnCFG to remove E.PT > category from VCPUs. > > Signed-off-by: Mihai Caraman Please do this in a separate function that y

Re: [PATCH 2/5] KVM: PPC: e500: Emulate TLBnPS registers

2013-01-31 Thread Alexander Graf
On 30.01.2013, at 14:29, Mihai Caraman wrote: > Emulate TLBnPS registers which are available in MMU Architecture Version > (MAV) 2.0. > > Signed-off-by: Mihai Caraman > --- > arch/powerpc/include/asm/kvm_host.h |1 + > arch/powerpc/kvm/e500.h |5 + > arch/powerpc/kvm/e500_

Re: [PATCH 1/5] KVM: PPC: e500: Move VCPU's MMUCFG register initialization earlier

2013-01-31 Thread Alexander Graf
On 30.01.2013, at 14:29, Mihai Caraman wrote: > VCPU's MMUCFG register initialization should not depend on KVM_CAP_SW_TLB > ioctl call. Move it earlier into tlb initalization phase. Quite the contrary. The fact that there is an mfspr() in e500_mmu.c already tells us that the code is broken. The

Re: [PATCH v6 00/15] memory-hotplug: hot-remove physical memory

2013-01-31 Thread Simon Jeons
Hi Tang, On Thu, 2013-01-31 at 17:44 +0800, Tang Chen wrote: > Hi Simon, > > On 01/31/2013 04:48 PM, Simon Jeons wrote: > > Hi Tang, > > On Thu, 2013-01-31 at 15:10 +0800, Tang Chen wrote: > > > > 1. IIUC, there is a button on machine which supports hot-remove memory, > > then what's the differenc

Re: [PATCH v6 00/15] memory-hotplug: hot-remove physical memory

2013-01-31 Thread Tang Chen
Hi Simon, On 01/31/2013 04:48 PM, Simon Jeons wrote: Hi Tang, On Thu, 2013-01-31 at 15:10 +0800, Tang Chen wrote: 1. IIUC, there is a button on machine which supports hot-remove memory, then what's the difference between press button and echo to /sys? No important difference, I think. Since I

Re: [PATCH v6 00/15] memory-hotplug: hot-remove physical memory

2013-01-31 Thread Simon Jeons
Hi Tang, On Thu, 2013-01-31 at 15:10 +0800, Tang Chen wrote: 1. IIUC, there is a button on machine which supports hot-remove memory, then what's the difference between press button and echo to /sys? 2. Since kernel memory is linear mapping(I mean direct mapping part), why can't put kernel direct m

Re: [GIT PULL 00/21] perf/core improvements and fixes

2013-01-31 Thread Ingo Molnar
* Arnaldo Carvalho de Melo wrote: > Hi Ingo, > > Please consider pulling. > > Namhyung, Jiri, the 'group report' patches are at acme/perf/group, > will send a pull req later if it survives further testing. > > - Arnaldo > > The following changes since commit a2d28d0c198b65fac28ea

Re: [PATCH v6 00/15] memory-hotplug: hot-remove physical memory

2013-01-31 Thread Simon Jeons
Hi Tang, On Thu, 2013-01-31 at 15:10 +0800, Tang Chen wrote: > On 01/31/2013 02:19 PM, Simon Jeons wrote: > > Hi Tang, > > On Thu, 2013-01-31 at 11:31 +0800, Tang Chen wrote: > >> Hi Simon, > >> > >> Please see below. :) > >> > >> On 01/31/2013 09:22 AM, Simon Jeons wrote: > >>> > >>> Sorry, I stil