RE: [PATCH V4 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-06 Thread Jia Hongtao-B38951
> -Original Message- > From: Wood Scott-B07421 > Sent: Monday, August 06, 2012 11:16 PM > To: Jia Hongtao-B38951 > Cc: Wood Scott-B07421; Kumar Gala; linuxppc-dev@lists.ozlabs.org; Li > Yang-R58472 > Subject: Re: [PATCH V4 3/3] powerpc/fsl-pci: Unify pci/pcie > initialization code > > On 0

Re: [RFC PATCH V6 13/19] memory-hotplug: check page type in get_page_bootmem

2012-08-06 Thread Wen Congyang
At 08/03/2012 03:49 PM, we...@cn.fujitsu.com Wrote: > From: Yasuaki Ishimatsu > > There is a possibility that get_page_bootmem() is called to the same page many > times. So when get_page_bootmem is called to the same page, the function only > increments page->_count. > > CC: David Rientjes > CC

Re: [RFC PATCH V6 16/19] memory-hotplug: free memmap of sparse-vmemmap

2012-08-06 Thread Wen Congyang
At 08/03/2012 03:49 PM, we...@cn.fujitsu.com Wrote: > From: Wen Congyang This line is wrong. This patch is from Yasuaki Ishimatsu > > All pages of virtual mapping in removed memory cannot be freed, since some > pages > used as PGD/PUD includes not only removed memory but also other memory. S

Re: [PATCH V5 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-06 Thread Li Yang
On Mon, Aug 6, 2012 at 11:09 PM, Scott Wood wrote: > On 08/05/2012 10:07 PM, Jia Hongtao-B38951 wrote: >> >> >>> -Original Message- >>> From: Wood Scott-B07421 >>> Sent: Saturday, August 04, 2012 12:28 AM >>> To: Jia Hongtao-B38951 >>> Cc: linuxppc-dev@lists.ozlabs.org; ga...@kernel.crashi

Re: [RFC PATCH V6 15/19] memory-hotplug: implement register_page_bootmem_info_section of sparse-vmemmap

2012-08-06 Thread Wen Congyang
At 08/03/2012 03:49 PM, we...@cn.fujitsu.com Wrote: > From: Yasuaki Ishimatsu > > For removing memmap region of sparse-vmemmap which is allocated bootmem, > memmap region of sparse-vmemmap needs to be registered by get_page_bootmem(). > So the patch searches pages of virtual mapping and registers

RE: [PATCH v2] PCI: use dev->irq instead of dev->pin to enable non MSI/INTx interrupt

2012-08-06 Thread Zang Roy-R61911
> -Original Message- > From: Linuxppc-dev [mailto:linuxppc-dev-bounces+tie- > fei.zang=freescale@lists.ozlabs.org] On Behalf Of Liu Shengzhou-B36685 > Sent: Thursday, July 26, 2012 11:45 AM > To: bhelg...@google.com; linux-...@vger.kernel.org; akpm@linux- > foundation.org > Cc: Wood S

RE: [PATCH v6 0/8] Raid: enable talitos xor offload for improving performance

2012-08-06 Thread Liu Qiang-B32616
> -Original Message- > From: Phillips Kim-R1AAHA > Sent: Tuesday, August 07, 2012 9:35 AM > To: Liu Qiang-B32616 > Cc: linux-cry...@vger.kernel.org; vinod.k...@intel.com; > dan.j.willi...@intel.com; herb...@gondor.hengli.com.au; a...@arndb.de; > gre...@linuxfoundation.org; linuxppc-dev@list

RE: [PATCH v6 5/8] fsl-dma: change release process of dma descriptor for supporting async_tx

2012-08-06 Thread Liu Qiang-B32616
> -Original Message- > From: Ira W. Snyder [mailto:i...@ovro.caltech.edu] > Sent: Tuesday, August 07, 2012 1:51 AM > To: Liu Qiang-B32616 > Cc: linux-cry...@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; > dan.j.willi...@intel.com; linux-ker...@vger.kernel.org; > dan.j.willi...@gmail.com;

RE: [PATCH v6 6/8] fsl-dma: use spin_lock_bh to instead of spin_lock_irqsave

2012-08-06 Thread Liu Qiang-B32616
> -Original Message- > From: Arnd Bergmann [mailto:a...@arndb.de] > Sent: Monday, August 06, 2012 7:57 PM > To: Liu Qiang-B32616 > Cc: linux-cry...@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; > dan.j.willi...@intel.com; linux-ker...@vger.kernel.org; > dan.j.willi...@gmail.com; vinod.k..

Re: [v2 PATCH 1/1] booke/wdt: some ioctls do not return values properly

2012-08-06 Thread Tabi Timur-B04825
On Mon, Aug 6, 2012 at 8:59 PM, Tiejun Chen wrote: > Fix some booke wdt ioctls return value error. > > Signed-off-by: Tiejun Chen It's not the greatest patch description, but it'll do. Acked-by: Timur Tabi -- Timur Tabi Linux kernel developer at Freescale

[v2 PATCH 1/1] booke/wdt: some ioctls do not return values properly

2012-08-06 Thread Tiejun Chen
Fix some booke wdt ioctls return value error. Signed-off-by: Tiejun Chen --- drivers/watchdog/booke_wdt.c |7 +++ 1 files changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/watchdog/booke_wdt.c b/drivers/watchdog/booke_wdt.c index 3fe82d0..5b06d31 100644 --- a/drivers/watchdo

Re: [PATCH 1/1] booke/wdt: fix incorrect WDIOC_GETSUPPORT return path

2012-08-06 Thread tiejun.chen
On 08/07/2012 09:19 AM, Tabi Timur-B04825 wrote: > On Mon, Aug 6, 2012 at 2:12 PM, Tabi Timur-B04825 > wrote: >> On Mon, Jul 30, 2012 at 3:15 AM, Tiejun Chen >> wrote: >>> We miss that correct WDIOC_GETSUPPORT return path when perform >>> copy_to_user() properly. >> >> Thanks for catching this.

Re: [PATCH v6 0/8] Raid: enable talitos xor offload for improving performance

2012-08-06 Thread Kim Phillips
On Mon, 6 Aug 2012 18:10:15 +0800 wrote: > Changes in v6: > - swap the order of original patch 3/6 and 4/6; > - merge Ira's patch to reduce the size of original patch; > - merge Ira's patch of carma in 8/8; > - update documents and descriptions according to Ira's advice;

Re: [PATCH 1/1] booke/wdt: fix incorrect WDIOC_GETSUPPORT return path

2012-08-06 Thread Tabi Timur-B04825
On Mon, Aug 6, 2012 at 2:12 PM, Tabi Timur-B04825 wrote: > On Mon, Jul 30, 2012 at 3:15 AM, Tiejun Chen > wrote: >> We miss that correct WDIOC_GETSUPPORT return path when perform >> copy_to_user() properly. > > Thanks for catching this. I'm amazed that this driver still has bugs like > this.

Re: [PATCH 1/1] booke/wdt: fix incorrect WDIOC_GETSUPPORT return path

2012-08-06 Thread Tabi Timur-B04825
On Mon, Jul 30, 2012 at 3:15 AM, Tiejun Chen wrote: > We miss that correct WDIOC_GETSUPPORT return path when perform > copy_to_user() properly. Thanks for catching this. I'm amazed that this driver still has bugs like this. > diff --git a/drivers/watchdog/booke_wdt.c b/drivers/watchdog/booke_wd

Re: [PATCH v6 5/8] fsl-dma: change release process of dma descriptor for supporting async_tx

2012-08-06 Thread Ira W. Snyder
On Mon, Aug 06, 2012 at 06:14:33PM +0800, qiang@freescale.com wrote: > From: Qiang Liu > > Fix the potential risk when enable config NET_DMA and ASYNC_TX. > Async_tx is lack of support in current release process of dma descriptor, > all descriptors will be released whatever is acked or no-ack

Threads inheriting debug state from parent threads

2012-08-06 Thread Luis Gustavo
*re-sending after subscribing to the list* Hi, I'm actually chasing a problem with GDB and hw watchpoints for embedded ppc targets. If a thread X creates thread Y, is it expected that thread Y will inherit all the debug state from thread X? Including, for example, any hardware watchpoints/b

RE: [PATCH 2/4] powerpc/booke: Merge the 32 bit e5500/e500mc cpu setup code.

2012-08-06 Thread Sethi Varun-B16395
> -Original Message- > From: Kumar Gala [mailto:ga...@kernel.crashing.org] > Sent: Monday, August 06, 2012 9:28 PM > To: Sethi Varun-B16395 > Cc: ag...@suse.de; b...@kernel.crashing.org; linuxppc- > d...@lists.ozlabs.org; kvm-...@vger.kernel.org > Subject: Re: [PATCH 2/4] powerpc/booke: M

RE: [PATCH 3/3 v4] powerpc/mpic: FSL MPIC error interrupt support.

2012-08-06 Thread Sethi Varun-B16395
> -Original Message- > From: Kumar Gala [mailto:ga...@kernel.crashing.org] > Sent: Monday, August 06, 2012 9:23 PM > To: Sethi Varun-B16395 > Cc: linuxppc-dev@lists.ozlabs.org; Hamciuc Bogdan-BHAMCIU1 > Subject: Re: [PATCH 3/3 v4] powerpc/mpic: FSL MPIC error interrupt > support. > > >

Re: [PATCH 1/1] booke/wdt: fix incorrect WDIOC_GETSUPPORT return path

2012-08-06 Thread Kumar Gala
On Aug 5, 2012, at 10:10 PM, tiejun.chen wrote: > On 07/30/2012 04:15 PM, Tiejun Chen wrote: >> We miss that correct WDIOC_GETSUPPORT return path when perform >> copy_to_user() properly. > > Any comments? > > Thanks > Tiejun Adding Timur, as he's touched watchdog last. - k >> Signed-off-by:

Re: [PATCH 2/4] powerpc/booke: Merge the 32 bit e5500/e500mc cpu setup code.

2012-08-06 Thread Kumar Gala
On Aug 4, 2012, at 1:31 PM, Sethi Varun-B16395 wrote: > > >> -Original Message- >> From: Kumar Gala [mailto:ga...@kernel.crashing.org] >> Sent: Friday, August 03, 2012 10:04 PM >> To: Sethi Varun-B16395 >> Cc: ag...@suse.de; b...@kernel.crashing.org; linuxppc- >> d...@lists.ozlabs.org;

Re: [PATCH 3/3 v4] powerpc/mpic: FSL MPIC error interrupt support.

2012-08-06 Thread Kumar Gala
On Aug 6, 2012, at 7:44 AM, Varun Sethi wrote: > All SOC device error interrupts are muxed and delivered to the core > as a single MPIC error interrupt. Currently all the device drivers > requiring access to device errors have to register for the MPIC error > interrupt as a shared interrupt. > >

Re: [PATCH V4 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-06 Thread Scott Wood
On 08/05/2012 09:39 PM, Jia Hongtao-B38951 wrote: > > >> -Original Message- >> From: Wood Scott-B07421 >> Sent: Saturday, August 04, 2012 12:04 AM >> To: Jia Hongtao-B38951 >> Cc: Kumar Gala; linuxppc-dev@lists.ozlabs.org; Wood Scott-B07421; Li >> Yang-R58472 >> Subject: Re: [PATCH V4 3/3

Re: [PATCH V5 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-06 Thread Scott Wood
On 08/05/2012 10:07 PM, Jia Hongtao-B38951 wrote: > > >> -Original Message- >> From: Wood Scott-B07421 >> Sent: Saturday, August 04, 2012 12:28 AM >> To: Jia Hongtao-B38951 >> Cc: linuxppc-dev@lists.ozlabs.org; ga...@kernel.crashing.org; Li Yang- >> R58472; Wood Scott-B07421 >> Subject: R

Re: [PATCH V4 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-06 Thread Scott Wood
On 08/05/2012 11:11 PM, Tabi Timur-B04825 wrote: > On Fri, Aug 3, 2012 at 11:09 AM, Scott Wood wrote: > >> p1022ds OTOH is weird enough that it deserves its own board file. > > What's so weird about the P1022DS? The localbus muxing. > Also, why do we need a default PCI bus if one isn't specifi

[PATCH 3/6] powerpc/booke64: add DO_KVM kernel hooks

2012-08-06 Thread Mihai Caraman
Hook DO_KVM macro into 64-bit booke for KVM integration. Extend interrupt handlers' parameter list with interrupt vector numbers to accomodate the macro. Only the bolted version of tlb miss handers is addressed now. Signed-off-by: Mihai Caraman --- arch/powerpc/kernel/exceptions-64e.S | 93 +++

[PATCH 2/6] powerpc/booke64: use GSRR registers in Guest Doorbell interrupts

2012-08-06 Thread Mihai Caraman
Guest Doorbell interrupts use guest save and restore registers. Add a new Guest Doorbell exception type to accommodate GSRR0/1 SPRs usage in exception prolog and fix the exception handler. Signed-off-by: Mihai Caraman --- arch/powerpc/include/asm/exception-64e.h |1 + arch/powerpc/include/as

[PATCH 5/6] powerpc/booke64: use SPRG0/3 scratch for bolted TLB miss & crit int

2012-08-06 Thread Mihai Caraman
Embedded.Hypervisor category defines GSPRG0..3 physical registers for guests. Avoid SPRG4-7 usage as scratch in host exception handlers, otherwise guest SPRG4-7 registers will be clobbered. For bolted TLB miss exception handlers, which is the version currently supported by KVM, use SPRN_SPRG_GEN_SC

[PATCH 1/6] powerpc/booke64: fix machine check handler to use the right prolog

2012-08-06 Thread Mihai Caraman
Machine check exception handler was using a wrong prolog. Hypervisors like KVM which are called early from the exception handler rely on the interrupt source. Signed-off-by: Mihai Caraman --- arch/powerpc/kernel/exceptions-64e.S |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff -

[PATCH 6/6] powerpc/booke64: restore VDSO information on critical exception

2012-08-06 Thread Mihai Caraman
Critical exception handler on 64-bit booke uses user-visible SPRG3 as scratch. Restore VDSO information in SPRG3 on exception prolog. Signed-off-by: Mihai Caraman --- arch/powerpc/include/asm/paca.h |3 +++ arch/powerpc/kernel/asm-offsets.c|1 + arch/powerpc/kernel/exceptions-64

[PATCH 4/6] powerpc/booke64: remove mfspr srr1 duplicate in exception prolog

2012-08-06 Thread Mihai Caraman
Refactor exception prolog to get rid of mfspr srr1 duplicate. This was introduced by KVM integration, with DO_KVM macro logic expecting srr1 value earlier in r11. Reserve r11 to hold srr1's value also required at the end of the prolog and free up r10 to serve as spare in addition macros. For syscal

[PATCH 0/6] powerpc/booke64: add core support for KVM

2012-08-06 Thread Mihai Caraman
These patches add core support for KVM on 64-bit Book3E PowerPC, mainly integrating the DO_KVM macro. KVM arch specific patches will follow shortly. Mihai Caraman (6): powerpc/booke64: fix machine check handler to use the right prolog powerpc/booke64: use GSRR registers in Guest Doorbell inter

[PATCH 3/3 v4] powerpc/mpic: FSL MPIC error interrupt support.

2012-08-06 Thread Varun Sethi
All SOC device error interrupts are muxed and delivered to the core as a single MPIC error interrupt. Currently all the device drivers requiring access to device errors have to register for the MPIC error interrupt as a shared interrupt. With this patch we add interrupt demuxing capability in the

Re: [PATCH v6 6/8] fsl-dma: use spin_lock_bh to instead of spin_lock_irqsave

2012-08-06 Thread Arnd Bergmann
On Monday 06 August 2012, qiang@freescale.com wrote: > > From: Qiang Liu > > The use of spin_lock_irqsave() is a stronger locking mechanism than is > required throughout the driver. The minimum locking required should be > used instead. Interrupts will be turned off and context will be saved

[PATCH v6 6/8] fsl-dma: use spin_lock_bh to instead of spin_lock_irqsave

2012-08-06 Thread qiang.liu
From: Qiang Liu The use of spin_lock_irqsave() is a stronger locking mechanism than is required throughout the driver. The minimum locking required should be used instead. Interrupts will be turned off and context will be saved, there is needless to use irqsave. Change all instances of spin_lock

RE: [PATCH 6/8] fsl-dma: use spin_lock_bh to instead of spin_lock_irqsave

2012-08-06 Thread Liu Qiang-B32616
Hi all, Please ignore this one. Thanks. > -Original Message- > From: Liu Qiang-B32616 > Sent: Monday, August 06, 2012 6:15 PM > To: linux-cry...@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; > dan.j.willi...@intel.com; linux-ker...@vger.kernel.org; > dan.j.willi...@gmail.com; vinod.k...

[PATCH v6 8/8] carma: remove unnecessary DMA_INTERRUPT capability

2012-08-06 Thread qiang.liu
From: Qiang Liu These drivers set the DMA_INTERRUPT capability bit when requesting a DMA controller channel. This was historical, and is no longer needed. Recent changes to the drivers/dma/fsldma.c driver have removed support for this flag. This makes the carma drivers unable to find a DMA chann

[PATCH v6 7/8] fsl-dma: fix a warning of unitialized cookie

2012-08-06 Thread qiang.liu
From: Qiang Liu Fix a warning of unitialized value when compile with -Wuninitialized. Cc: Dan Williams Cc: Dan Williams Cc: Vinod Koul Cc: Li Yang Signed-off-by: Qiang Liu Reported-by: Kim Phillips Acked-by: Ira W. Snyder --- drivers/dma/fsldma.c |2 +- 1 files changed, 1 insertions(

[PATCH 6/8] fsl-dma: use spin_lock_bh to instead of spin_lock_irqsave

2012-08-06 Thread qiang.liu
From: Qiang Liu The use of spin_lock_irqsave() is a stronger locking mechanism than is required throughout the driver. The minimum locking required should be used instead. Interrupts will be turned off and context will be saved, there is needless to use irqsave. Change all instances of spin_lock

[PATCH v6 5/8] fsl-dma: change release process of dma descriptor for supporting async_tx

2012-08-06 Thread qiang.liu
From: Qiang Liu Fix the potential risk when enable config NET_DMA and ASYNC_TX. Async_tx is lack of support in current release process of dma descriptor, all descriptors will be released whatever is acked or no-acked by async_tx, so there is a potential race condition when dma engine is uesd by o

[PATCH v6 4/8] fsl-dma: move functions to avoid forward declarations

2012-08-06 Thread qiang.liu
From: Qiang Liu These functions will be modified in the next patch in the series. By moving the function in a patch separate from the changes, it will make review easier. Cc: Dan Williams Cc: Dan Williams Cc: Vinod Koul Cc: Li Yang Signed-off-by: Ira W. Snyder Signed-off-by: Qiang Liu ---

[PATCH v6 3/8] fsl-dma: add fsl_dma_free_descriptor() to reduce code duplication

2012-08-06 Thread qiang.liu
From: Qiang Liu There are several places where descriptors are freed using identical code. Put this code into a function to reduce code duplication. Cc: Dan Williams Cc: Dan Williams Cc: Vinod Koul Signed-off-by: Ira W. Snyder --- drivers/dma/fsldma.c | 38

[PATCH v6 2/8] fsl-dma: remove attribute DMA_INTERRUPT of dmaengine

2012-08-06 Thread qiang.liu
From: Qiang Liu Delete attribute DMA_INTERRUPT because fsl-dma doesn't support this function, exception will be thrown if talitos is used to offload xor at the same time. Cc: Dan Williams Cc: Dan Williams Cc: Vinod Koul Cc: Li Yang Signed-off-by: Qiang Liu Acked-by: Ira W. Snyder --- driv

[PATCH v6 1/8] Talitos: Support for async_tx XOR offload

2012-08-06 Thread qiang.liu
From: Qiang Liu Expose Talitos's XOR functionality to be used for RAID parity calculation via the Async_tx layer. Cc: Herbert Xu Cc: David S. Miller Signed-off-by: Dipen Dudhat Signed-off-by: Maneesh Gupta Signed-off-by: Kim Phillips Signed-off-by: Vishnu Suresh Signed-off-by: Qiang Liu -

[PATCH v6 0/8] Raid: enable talitos xor offload for improving performance

2012-08-06 Thread qiang.liu
Hi all, The following 8 patches enabling fsl-dma and talitos offload raid operations for improving raid performance and balancing CPU load. These patches include talitos, fsl-dma and carma module (caram uses some features of fsl-dma). Write performance will be improved by 25-30% tested by iozone

Re: mpc8xxx PCIe hotplug needs fixing, some clues ..

2012-08-06 Thread Joakim Tjernlund
> > Joakim Tjernlund/Transmode wrote on 2012/07/21 18:11:32: > > > > Kumar Gala wrote on 2012/07/20 20:53:10: > > > > > > > > > On Jul 20, 2012, at 2:17 AM, Joakim Tjernlund wrote: > > > > > > > > > > > Hi Guys > > > > > > > > I see that you have been hacking Freescale PCI before so I send this to

Re: how to implement platform specific per process parameter?

2012-08-06 Thread Anshuman Khandual
> There are 4 options: > 1. [not a kernel interface] use ptrace to execute the register changing > command inside the specified pid. The next context switch saves the new > value in the thread_struct. Dirty hack. > > 2. Add a new syscall which would receive pid + register value and do the > job.