RE: [PATCH] PCI: use dev->irq instead of dev->pin to enable non MSI/INTx interrupt

2012-07-17 Thread Liu Shengzhou-B36685
> -Original Message- > From: Wood Scott-B07421 > Sent: Wednesday, July 18, 2012 1:42 AM > To: Liu Shengzhou-B36685 > Cc: bhelg...@google.com; linux-...@vger.kernel.org; linuxppc- > d...@lists.ozlabs.org > Subject: Re: [PATCH] PCI: use dev->irq instead of dev->pin to enable non > MSI/INTx i

[PATCH v2] PCI: use dev->irq instead of dev->pin to enable non MSI/INTx interrupt

2012-07-17 Thread Shengzhou Liu
On some platforms, root port has neither MSI/MSI-X nor INTx interrupt generated in RC mode. In this case, we have to use other interrupt(e.g. system shared interrupt) for port service irq to have AER, Hot-plug, etc, services to work. Signed-off-by: Shengzhou Liu --- drivers/pci/pcie/portdrv_core

Re: [PATCH 05/15] pci: resource assignment based on p2p alignment

2012-07-17 Thread Ram Pai
On Wed, Jul 18, 2012 at 09:07:46AM +0800, Gavin Shan wrote: > 4. Either "b_res->flags & mask" or "type" to be used for window_alignment(), >I don't think it's big deal because "b_res->flags & mask == type" for >current implementation. However, I'm not sure I still need change it >to "ty

Re: [PATCH 05/15] pci: resource assignment based on p2p alignment

2012-07-17 Thread Ram Pai
On Tue, Jul 17, 2012 at 08:38:18PM +1000, Benjamin Herrenschmidt wrote: > On Tue, 2012-07-17 at 18:03 +0800, Ram Pai wrote: > > Lets say we passed that 'type' flag to size the minimum > > alignment constraints for that b_res. And window_alignment(bus, > > type) of your plat

Re: [PATCH 05/15] pci: resource assignment based on p2p alignment

2012-07-17 Thread Ram Pai
On Tue, Jul 17, 2012 at 11:14:51AM -0600, Bjorn Helgaas wrote: > On Tue, Jul 17, 2012 at 4:38 AM, Benjamin Herrenschmidt > wrote: > > On Tue, 2012-07-17 at 18:03 +0800, Ram Pai wrote: > >> Lets say we passed that 'type' flag to size the minimum > >> alignment constraints for that b

RE: [PATCH v3 3/4] fsl-dma: change release process of dma descriptor for supporting async_tx

2012-07-17 Thread Liu Qiang-B32616
Hi Ira, My comments inline. Hi Ira and Dan, Here is a introduction about my scenario of this case. My case is use async_tx API to offload raid5, Use fsl-talitos to compute parity calculation, fsl-dma to process memcpy. What bug occurred to me? Exception is thrown by BUG_ON(async_tx_ack_test(de

Re: [PATCH] of: require a match on all fields of of_device_id

2012-07-17 Thread Rob Herring
On 07/17/2012 08:11 PM, Scott Wood wrote: > Commit 107a84e61cdd3406c842a0e4be7efffd3a05dba6 ("of: match by compatible > property first") breaks the gianfar ethernet driver found on various > Freescale PPC chips. You do know this is reverted, right? > > There are, for unfortunate historical reaso

Re: [PATCH] of: require a match on all fields of of_device_id

2012-07-17 Thread Tabi Timur-B04825
On Tue, Jul 17, 2012 at 8:11 PM, Scott Wood wrote: > Commit 107a84e61cdd3406c842a0e4be7efffd3a05dba6 ("of: match by compatible > property first") breaks the gianfar ethernet driver found on various > Freescale PPC chips. > > There are, for unfortunate historical reasons, two nodes with a > compati

[PATCH] of: require a match on all fields of of_device_id

2012-07-17 Thread Scott Wood
Commit 107a84e61cdd3406c842a0e4be7efffd3a05dba6 ("of: match by compatible property first") breaks the gianfar ethernet driver found on various Freescale PPC chips. There are, for unfortunate historical reasons, two nodes with a compatible of "gianfar". One has a device_type of "network" and the o

Re: [PATCH] PCI: use dev->irq instead of dev->pin to enable non MSI/INTx interrupt

2012-07-17 Thread Scott Wood
On 07/16/2012 09:35 PM, Shengzhou Liu wrote: > On some platforms, root port has neither MSI/MSI-X nor INTx interrupt > generated in RC mode. In this case, we have to use other interrupt(i.e. > system shared interrupt) for port service irq to have AER, Hot-plug, etc, > services to work. > > Signed-

Re: [PATCH 05/15] pci: resource assignment based on p2p alignment

2012-07-17 Thread Bjorn Helgaas
On Tue, Jul 17, 2012 at 4:38 AM, Benjamin Herrenschmidt wrote: > On Tue, 2012-07-17 at 18:03 +0800, Ram Pai wrote: >> Lets say we passed that 'type' flag to size the minimum >> alignment constraints for that b_res. And window_alignment(bus, >> type) of your platform used

Re: [PATCH v3 3/4] fsl-dma: change release process of dma descriptor for supporting async_tx

2012-07-17 Thread Ira W. Snyder
On Tue, Jul 17, 2012 at 07:06:33AM +, Liu Qiang-B32616 wrote: > > -Original Message- > > From: Ira W. Snyder [mailto:i...@ovro.caltech.edu] > > Sent: Tuesday, July 17, 2012 4:01 AM > > To: Liu Qiang-B32616 > > Cc: linux-cry...@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; Phillips > >

Re: [linuxppc-release] [PATCH v3 4/4] fsl-dma: use spin_lock_bh to instead of spin_lock_irqsave

2012-07-17 Thread Timur Tabi
Liu Qiang-B32616 wrote: > I attached the test result in v3 0/4, performance is improved by 2%. > For my understanding, there is not any place to access descriptor lists > in fsl-dma interrupt service handler except its tasklet, spin_lock_bh() > is born for this. Interrupts will be turned off and co

Re: [PATCH] powerpc/85xx: p1022ds: disable the NAND flash node if video is enabled

2012-07-17 Thread Kumar Gala
On Jul 13, 2012, at 2:28 PM, Timur Tabi wrote: > The Freescale P1022 has a unique pin muxing "feature" where the DIU video > controller's video signals are muxed with 24 of the local bus address signals. > When the DIU is enabled, the bulk of the local bus is disabled, preventing > access to memo

Re: [PATCH] powerpc/85xx: remove P1020RDB and P2020RDB CAMP device trees

2012-07-17 Thread Kumar Gala
On Jul 13, 2012, at 5:40 PM, Timur Tabi wrote: > We only need two examples of CAMP device trees in the upstream kernel. > > Co-operative Asymmetric Multi-Processing (CAMP) is a technique where two > or more operating systems (typically multiple copies of the same Linux kernel) > are loaded into

Re: [PATCH] powerpc/p3041: change espi input-clock from 40MHz to 35MHz

2012-07-17 Thread Kumar Gala
On Jul 17, 2012, at 2:18 AM, Shaohui Xie wrote: > Default CCB on P3041 is 750MHz, but espi cannot work at 40MHz with this CCB, > so we need to slow down the clock rate of espi to 35MHz to make it work stable > with the CCB. > > Signed-off-by: Shaohui Xie > --- > arch/powerpc/boot/dts/p3041ds.dt

RE: [PATCH v7 2/5] powerpc/85xx: add HOTPLUG_CPU support

2012-07-17 Thread Zhao Chenhui-B35336
> -Original Message- > From: Kumar Gala [mailto:ga...@kernel.crashing.org] > Sent: Friday, July 13, 2012 8:15 PM > To: Zhao Chenhui-B35336 > Cc: linuxppc-dev@lists.ozlabs.org; Wood Scott-B07421; > linux-ker...@vger.kernel.org; Li Yang-R58472 > Subject: Re: [PATCH v7 2/5] powerpc/85xx: add

Re: [PATCH 05/15] pci: resource assignment based on p2p alignment

2012-07-17 Thread Benjamin Herrenschmidt
On Tue, 2012-07-17 at 18:03 +0800, Ram Pai wrote: > Lets say we passed that 'type' flag to size the minimum > alignment constraints for that b_res. And window_alignment(bus, > type) of your platform used that 'type' information to > determine whether to use the ali

Re: [PATCH 05/15] pci: resource assignment based on p2p alignment

2012-07-17 Thread Ram Pai
On Tue, Jul 17, 2012 at 07:16:59PM +1000, Benjamin Herrenschmidt wrote: > On Tue, 2012-07-17 at 13:57 +0800, Ram Pai wrote: > > Hmm.. this code is not about determining what kind of segment the > > platform is returning. This code is about using the right alignment > > constraints for the type of s

Re: [PATCH 05/15] pci: resource assignment based on p2p alignment

2012-07-17 Thread Benjamin Herrenschmidt
On Tue, 2012-07-17 at 13:57 +0800, Ram Pai wrote: > Hmm.. this code is not about determining what kind of segment the > platform is returning. This code is about using the right alignment > constraints for the type of segment from which resource will be > allocated. right? > > b_res is the resourc

[PATCH] powerpc/p3041: change espi input-clock from 40MHz to 35MHz

2012-07-17 Thread Shaohui Xie
Default CCB on P3041 is 750MHz, but espi cannot work at 40MHz with this CCB, so we need to slow down the clock rate of espi to 35MHz to make it work stable with the CCB. Signed-off-by: Shaohui Xie --- arch/powerpc/boot/dts/p3041ds.dts |2 +- 1 files changed, 1 insertions(+), 1 deletions(-)

RE: [PATCH v3 3/4] fsl-dma: change release process of dma descriptor for supporting async_tx

2012-07-17 Thread Liu Qiang-B32616
> -Original Message- > From: Ira W. Snyder [mailto:i...@ovro.caltech.edu] > Sent: Tuesday, July 17, 2012 4:01 AM > To: Liu Qiang-B32616 > Cc: linux-cry...@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; Phillips > Kim-R1AAHA; herb...@gondor.hengli.com.au; da...@davemloft.net; Dan > Williams