Re: [PATCH 1/2] mtd/nand : don't free the global data fsl_lbc_ctrl_dev->nand in fsl_elbc_chip_remove()

2011-07-05 Thread Artem Bityutskiy
On Tue, 2011-06-28 at 09:50 +0800, b35...@freescale.com wrote: > From: Liu Shuo > > The global data fsl_lbc_ctrl_dev->nand don't have to be freed in > fsl_elbc_chip_remove(). The right place to do that is in > fsl_elbc_nand_remove() > if elbc_fcm_ctrl->counter is zero. > > Signed-off-by: Liu Sh

[PATCH] sm501: When registering the GPIO, turn on the GPIO unit's power

2011-07-05 Thread Josh Triplett
When attempting to use GPIO via the sm501 unit on the TQM5200 board, GPIO operations would only function if during the same boot u-boot's "fkt led" command had initialized the sm501. Comparing the sm501's registers with and without running the "fkt led" command turned up one significant difference

Re: pci_pcie_cap invalid on AER/EEH enabled PPC?

2011-07-05 Thread Benjamin Herrenschmidt
On Tue, 2011-07-05 at 17:14 -0700, Richard A Lary wrote: > I applied the debug patches mentioned above along with the lpfc patch > http://marc.info/?l=linux-scsi&m=130919648513685&w=2 > to linux 3.0-rc6 kernel. > > The debug patches show that pci_dev members "is_pcie, pci_cap and pcie_type" > ar

Re: pci_pcie_cap invalid on AER/EEH enabled PPC?

2011-07-05 Thread Benjamin Herrenschmidt
> On Power PC platforms, set_pcie_port_type() is not called. On Power PC, > pci_dev structure is initialized by of_create_pci_dev(). However, the > structure member pcie_cap is NOT computed nor set in this function. Just a quick correction here, please don't say "On Power PC platforms" such gen

Re: pci_pcie_cap invalid on AER/EEH enabled PPC?

2011-07-05 Thread Richard A Lary
On 7/5/2011 1:34 PM, Richard A Lary wrote: On 7/5/2011 10:22 AM, Richard A Lary wrote: On 7/5/2011 9:18 AM, Jon Mason wrote: On Tue, Jul 5, 2011 at 10:41 AM, Richard A Lary wrote: On 7/1/2011 1:00 PM, Richard A Lary wrote: On 7/1/2011 12:02 PM, Jon Mason wrote: On Fri, Jul 1, 2011 at 1:30

[PATCH v3] mtd: eLBC NAND: remove elbc_fcm_ctrl->oob_poi

2011-07-05 Thread Matthew L. Creech
From: Mike Hench The eLBC NAND driver currently follows up each program/write operation with a read-back of the page, in order to [ostensibly] fill in ECC data for the caller. However, the page address used for this read is always -1, so the read will never work correctly. Remove this useless (a

Re: [PATCH v2] mtd: eLBC NAND: remove elbc_fcm_ctrl->oob_poi

2011-07-05 Thread Matthew L. Creech
On Tue, Jul 5, 2011 at 7:01 PM, Scott Wood wrote: > > Just noticed, full_page can come out as well. > > Otherwise, ACK > Oh right, didn't notice that - thanks. -- Matthew L. Creech ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://li

Re: [PATCH v2] mtd: eLBC NAND: remove elbc_fcm_ctrl->oob_poi

2011-07-05 Thread Scott Wood
On Tue, 5 Jul 2011 18:35:02 -0400 "Matthew L. Creech" wrote: > From: Mike Hench > > The eLBC NAND driver currently follows up each program/write operation with a > read-back of the page, in order to [ostensibly] fill in ECC data for the > caller. However, the page address used for this read is

Re: [RFC] virtio: expose for non-virtualization users too

2011-07-05 Thread H. Peter Anvin
On 07/05/2011 07:06 AM, Ohad Ben-Cohen wrote: > virtio has been so far used only in the context of virtualization, > and the virtio Kconfig was sourced directly by the relevant arch > Kconfigs when VIRTUALIZATION was selected. > > Now that we start using virtio for inter-processor communications,

[PATCH v2] mtd: eLBC NAND: remove elbc_fcm_ctrl->oob_poi

2011-07-05 Thread Matthew L. Creech
From: Mike Hench The eLBC NAND driver currently follows up each program/write operation with a read-back of the page, in order to [ostensibly] fill in ECC data for the caller. However, the page address used for this read is always -1, so the read will never work correctly. Remove this useless (a

Re: pci_pcie_cap invalid on AER/EEH enabled PPC?

2011-07-05 Thread Richard A Lary
On 7/5/2011 10:22 AM, Richard A Lary wrote: On 7/5/2011 9:18 AM, Jon Mason wrote: On Tue, Jul 5, 2011 at 10:41 AM, Richard A Lary wrote: On 7/1/2011 1:00 PM, Richard A Lary wrote: On 7/1/2011 12:02 PM, Jon Mason wrote: On Fri, Jul 1, 2011 at 1:30 PM, Richard A Lary wrote: On 7/1/2011 8:2

Re: [PATCH] mtd: eLBC NAND: remove bogus ECC read-back

2011-07-05 Thread Scott Wood
On Tue, 5 Jul 2011 15:59:57 -0400 "Matthew L. Creech" wrote: > From: Mike Hench > > The eLBC NAND driver currently follows up each program/write operation with a > read-back of the page, in order to [ostensibly] fill in ECC data for the > caller. However, the page address used for this read is

[PATCH] mtd: eLBC NAND: remove bogus ECC read-back

2011-07-05 Thread Matthew L. Creech
From: Mike Hench The eLBC NAND driver currently follows up each program/write operation with a read-back of the page, in order to [ostensibly] fill in ECC data for the caller. However, the page address used for this read is always -1, so the read will never work correctly. Remove this useless (a

Re: NAND BBT corruption on MPC83xx

2011-07-05 Thread Matthew L. Creech
On Fri, Jun 17, 2011 at 5:34 PM, Scott Wood wrote: > > It seems that the generic code always passes -1 with PAGEPROG, and only > provides the actual page address on SEQIN. > > I don't think the ECC readback is needed, and the fact that it looks like > it has always been broken would seem to confir

Re: [PATCH] spi/fsl_spi: fix CPM spi driver

2011-07-05 Thread Grant Likely
On Tue, Jul 05, 2011 at 04:31:50PM +0200, Holger Brunck wrote: > Hi Grant, > is this patch in your eyes ok to be scheduled for the next linux merge window > or > is something missing? Or should it go through the powerpc tree and not through > your spi tree? No, I just hadn't gotten to it yet. So

Re: [PATCH] spi/fsl_spi: fix CPM spi driver

2011-07-05 Thread Grant Likely
On Mon, Jun 20, 2011 at 06:31:57PM +0200, Holger Brunck wrote: > This patch fixes the freescale spi driver for CPM. Without this > patch SPI on CPM failed because cpm_muram_alloc_fixed tries to > allocate muram in an preserved area. The error reported was: > > mpc8xxx_spi f0011a80.spi: can't alloc

Re: pci_pcie_cap invalid on AER/EEH enabled PPC?

2011-07-05 Thread Richard A Lary
On 7/5/2011 9:18 AM, Jon Mason wrote: On Tue, Jul 5, 2011 at 10:41 AM, Richard A Lary wrote: On 7/1/2011 1:00 PM, Richard A Lary wrote: On 7/1/2011 12:02 PM, Jon Mason wrote: On Fri, Jul 1, 2011 at 1:30 PM, Richard A Lary wrote: On 7/1/2011 8:24 AM, Jon Mason wrote: I recently sent out

Re: pci_pcie_cap invalid on AER/EEH enabled PPC?

2011-07-05 Thread Richard A Lary
On 7/1/2011 1:00 PM, Richard A Lary wrote: On 7/1/2011 12:02 PM, Jon Mason wrote: On Fri, Jul 1, 2011 at 1:30 PM, Richard A Lary wrote: On 7/1/2011 8:24 AM, Jon Mason wrote: I recently sent out a number of patches to migrate drivers calling `pci_find_capability(pdef, PCI_CAP_ID_EXP)` to pci_p

Re: pci_pcie_cap invalid on AER/EEH enabled PPC?

2011-07-05 Thread Jon Mason
On Tue, Jul 5, 2011 at 10:41 AM, Richard A Lary wrote: > On 7/1/2011 1:00 PM, Richard A Lary wrote: >> >> On 7/1/2011 12:02 PM, Jon Mason wrote: >>> >>> On Fri, Jul 1, 2011 at 1:30 PM, Richard A Lary >>> wrote: On 7/1/2011 8:24 AM, Jon Mason wrote: > > I recently sent out a numbe

Re: [PATCH] spi/fsl_spi: fix CPM spi driver

2011-07-05 Thread Holger Brunck
Hi Grant, is this patch in your eyes ok to be scheduled for the next linux merge window or is something missing? Or should it go through the powerpc tree and not through your spi tree? Please let me know your opinion. Best regards Holger Brunck On 06/20/2011 06:31 PM, Holger Brunck wrote: > This

[RFC] [PATCH] hvc_console: improve tty/console put_chars handling

2011-07-05 Thread Hendrik Brueckner
Hi folks, On Tue, Jul 05, 2011 at 04:22:43PM +1000, Benjamin Herrenschmidt wrote: > On Tue, 2011-07-05 at 04:17 +, Tabi Timur-B04825 wrote: > > On Mon, Jul 4, 2011 at 9:24 AM, Hendrik Brueckner > > wrote: > > > > I started that thread. After much soul searching, we came to the > > conclusio

Analysing a kernel panic

2011-07-05 Thread Guillaume Dargaud
Hello all, one of my drivers is causing a kernel panic and I _think_ it happens in the 1st call to the interrupt routine. What kind of information can I extract from the following ? Is it like a core dump that I can load with the executable in the debugger to know exactly what happened (I doubt i

[RFC] virtio: expose for non-virtualization users too

2011-07-05 Thread Ohad Ben-Cohen
virtio has been so far used only in the context of virtualization, and the virtio Kconfig was sourced directly by the relevant arch Kconfigs when VIRTUALIZATION was selected. Now that we start using virtio for inter-processor communications, we need to source the virtio Kconfig outside of the virt

Re: hvc_console change results in corrupt oops output

2011-07-05 Thread Tabi Timur-B04825
Benjamin Herrenschmidt wrote: > That is a fun conclusion considering that hvc has been written for the > pseries hypervisor which ... can return BUSY on writes :-) Go read the original thread. The problem is that tty writes and console writes are treated the same by the hvc client driver. If a

Re: [PATCH 2/6] hw_breakpoints: Migrate breakpoint conditional build under new config

2011-07-05 Thread Frederic Weisbecker
On Mon, Jul 04, 2011 at 11:14:16PM +0530, K.Prasad wrote: > On Mon, Jul 04, 2011 at 03:29:14PM +0200, Frederic Weisbecker wrote: > > On Mon, Jul 04, 2011 at 06:57:46PM +0530, K.Prasad wrote: > > > On Tue, May 24, 2011 at 11:52:23PM +0200, Frederic Weisbecker wrote: > > > > Migrate conditional hw_br

Re: [PATCH 3/3] eSDHC: fix incorrect default value of the capabilities register on P4080

2011-07-05 Thread Anton Vorontsov
On Tue, Jul 05, 2011 at 12:19:03PM +0800, Roy Zang wrote: > P4080 eSDHC errata 12 describes incorrect default value of the > the host controller capabilities register. > > The default value of the VS18 and VS30 fields in the host controller > capabilities register (HOSTCAPBLT) are incorrect. The d

Re: [PATCH 2/3] eSDHC: Fix errors when booting kernel with fsl esdhc

2011-07-05 Thread S, Venkatraman
On Tue, Jul 5, 2011 at 9:49 AM, Roy Zang wrote: > From: Xu lei > > When esdhc module was enabled in p5020, there were following errors: > > mmc0: Timeout waiting for hardware interrupt. > mmc0: error -110 whilst initialising SD card > mmc0: Unexpected interrupt 0x0200. > mmc0: Timeout waiting