Re: [PATCH 3/7] fault-injection: notifier error injection

2011-07-03 Thread Akinobu Mita
2011/7/4 Pavel Machek : > >> +     for (action = enb->actions; action->name; action++) { >> +             struct dentry *file = debugfs_create_int(action->name, mode, >> +                                             enb->dir, &action->error); >> + >> +             if (!file) { >> +                

Re: [BUG?]3.0-rc4+ftrace+kprobe: set kprobe at instruction 'stwu' lead to system crash/freeze

2011-07-03 Thread Yong Zhang
On Fri, Jul 1, 2011 at 6:03 PM, tiejun.chen wrote: >> root@unknown:/root> insmod kprobe_example.ko func=show_interrupts >> Planted kprobe at c009be18 >> root@unknown:/root> cat /proc/interrupts >> pre_handler: p->addr = 0xc009be18, nip = 0xc009be18, msr = 0x29000 >> post_handler: p->addr = 0xc009b

Re: [PATCH] powerpc: enable access to HT Host-Bridge on Maple

2011-07-03 Thread Dmitry Eremin-Solenikov
On 7/3/11, Segher Boessenkool wrote: CPC925/CPC945 use special window to access host bridge functionality of u3-ht. Provide a way to access this device. >>> >>> Why? Is anything going to use it? >> >> Hmmm. Why not? > > Because if nothing uses it it is essentially dead code. 1) It

Re: linux tqm8260

2011-07-03 Thread Wolfgang Denk
Dear bourkeb idir, In message <1309510675.9518.yahoomail...@web29503.mail.ird.yahoo.com> you wrote: > i'm trying to port linux in a tqm8260 fresscale card with an mpc8260 > cpu .i've already ported u-boot and it seems working but now i'm > trying to cross compile a linux kernel 2.4.4 (which have

Re: [PATCH 3/7] fault-injection: notifier error injection

2011-07-03 Thread Pavel Machek
> + for (action = enb->actions; action->name; action++) { > + struct dentry *file = debugfs_create_int(action->name, mode, > + enb->dir, &action->error); > + > + if (!file) { > + debugfs_remove_recursive(en

[PATCH 7/7] powerpc: pSeries reconfig notifier error injection

2011-07-03 Thread Akinobu Mita
This provides the ability to inject artifical errors to pSeries reconfig notifier chain callbacks. It is controlled through debugfs interface under /sys/kernel/debug/pSeries-reconfig-notifier-error-inject/ Each of the files in the directory represents an event which can be failed and contains the

[PATCH 3/7] fault-injection: notifier error injection

2011-07-03 Thread Akinobu Mita
The notifier error injection provides the ability to inject artifical errors to specified notifier chain callbacks. It is useful to test the error handling of notifier call chain failures. This adds common basic functions to define which type of events can be fail and to initialize the debugfs int

Re: [RFC PATCH 17/17] KVM: PPC: Add an ioctl for userspace to select which platform to emulate

2011-07-03 Thread Avi Kivity
On 07/03/2011 12:09 PM, Alexander Graf wrote: > > Right. The idea is that if KVM_FLAG_BLAH implies a field kvm_struct::blah, then either both are present in the headers, or none of them. Yup, makes sense. I like the idea :). Gets rid of all the useless paddings and reserved fields. We could

Re: [RFC PATCH 17/17] KVM: PPC: Add an ioctl for userspace to select which platform to emulate

2011-07-03 Thread Alexander Graf
On 03.07.2011, at 11:05, Avi Kivity wrote: > On 07/03/2011 12:00 PM, Alexander Graf wrote: >> >> } >> >> >> >> Otherwise we might write over data the user expected. And that logic >> >> that tells to copy_to_user how much data it actually takes to put all the >> >> information in is n

Re: [RFC PATCH 17/17] KVM: PPC: Add an ioctl for userspace to select which platform to emulate

2011-07-03 Thread Avi Kivity
On 07/03/2011 12:00 PM, Alexander Graf wrote: >> } >> >> Otherwise we might write over data the user expected. And that logic that tells to copy_to_user how much data it actually takes to put all the information in is not there today and would have to be added. You can even verify tha

Re: [RFC PATCH 17/17] KVM: PPC: Add an ioctl for userspace to select which platform to emulate

2011-07-03 Thread Alexander Graf
On 03.07.2011, at 10:56, Avi Kivity wrote: > On 07/03/2011 11:34 AM, Alexander Graf wrote: >> >> >> >> Yup, which requires knowledge in the code on what actually fits :). >> >> Logic we don't have today. >> > >> > I don't follow. What knowledge is required? Please give an example. >> >> Sur

Re: [RFC PATCH 17/17] KVM: PPC: Add an ioctl for userspace to select which platform to emulate

2011-07-03 Thread Avi Kivity
On 07/03/2011 11:34 AM, Alexander Graf wrote: >> >> Yup, which requires knowledge in the code on what actually fits :). Logic we don't have today. > > I don't follow. What knowledge is required? Please give an example. Sure. Let's take an easy example Currently we have for get_pvinfo:

Re: [RFC PATCH 17/17] KVM: PPC: Add an ioctl for userspace to select which platform to emulate

2011-07-03 Thread Alexander Graf
On 03.07.2011, at 10:15, Avi Kivity wrote: > On 06/30/2011 07:33 PM, Alexander Graf wrote: >> On 30.06.2011, at 18:00, Avi Kivity wrote: >> >> > On 06/30/2011 06:22 PM, Alexander Graf wrote: >> >>> Regarding that. There's another option - the ioctl code embeds the >> >>> structure size. So

Re: [RFC PATCH 17/17] KVM: PPC: Add an ioctl for userspace to select which platform to emulate

2011-07-03 Thread Avi Kivity
On 06/30/2011 07:33 PM, Alexander Graf wrote: On 30.06.2011, at 18:00, Avi Kivity wrote: > On 06/30/2011 06:22 PM, Alexander Graf wrote: >>> Regarding that. There's another option - the ioctl code embeds the structure size. So if we extend the ioctl parsing to pad up (or truncate down) fro