Re: [PATCH] Add support for PowerMac3,5 in snd-aoa ALSA sound module

2011-02-21 Thread Benjamin Herrenschmidt
On Mon, 2011-02-21 at 09:37 +0100, Takashi Iwai wrote: > At Sun, 20 Feb 2011 22:38:28 +0100, > Linux User #330250 wrote: > > > > Hello again! > > > > Sorry for sending the patch three times. (This is the fourth...) > > > > About the sign-off: I use the name I've been using since I started > > pa

[PATCH][v2] driver/FSL SATA:Fix wrong Device Error Register usage

2011-02-21 Thread Prabhakar Kushwaha
When a single device error is detected, the device under the error is indicated by the error bit set in the DER. There is a one to one mapping between register bit and devices on Port multiplier(PMP) i.e. bit 0 represents PMP device 0 and bit 1 represents PMP device 1 etc. Current implementation t

RE: [PATCH][v1] driver/FSL SATA:Fix wrong Device Error Register usage

2011-02-21 Thread David Laight
The patch changes the code to: > if (ap->nr_pmp_links) { > + int dev_num; > dereg = ioread32(hcr_base + DE); ... > + dev_num = ffs(dereg)-1; > + if (dev_num < ap->nr_pmp_links) { > +

Re: [PATCH] Add support for PowerMac3,5 in snd-aoa ALSA sound module

2011-02-21 Thread Takashi Iwai
At Sun, 20 Feb 2011 22:38:28 +0100, Linux User #330250 wrote: > > Hello again! > > Sorry for sending the patch three times. (This is the fourth...) > > About the sign-off: I use the name I've been using since I started > participating. The document $LINUX/Documentation/SubmittingPatches clearly