[PATCH v2] gianfar: Fall back to software tcp/udp checksum on older controllers

2011-01-27 Thread Alex Dubov
As specified by errata eTSEC49 of MPC8548 and errata eTSEC12 of MPC83xx, older revisions of gianfar controllers will be unable to calculate a TCP/UDP packet checksum for some alignments of the appropriate FCB. This patch checks for FCB alignment on such controllers and falls back to software checks

AUTO: Michael Barry is out of the office (returning 08/02/2011)

2011-01-27 Thread Michael Barry
I am out of the office until 08/02/2011. Note: This is an automated response to your message "Linuxppc-dev Digest, Vol 77, Issue 92" sent on 27/1/11 20:32:14. This is the only notification you will receive while this person is away. ___ Linuxppc-d

Re: [PATCH] gianfar: Fall back to software tcp/udp checksum on older controllers

2011-01-27 Thread Alex Dubov
> > -        > gfar_tx_checksum(skb, fcb); > > +        switch > (unlikely(gfar_has_errata(priv, GFAR_ERRATA_12)) > > +        >     ? 1 : 0) { > > The switch construction is quite bizarre. ;-) Why not > My testing shows that even on broken chips unaligned packets are quite rare (only some SYN p

Re: [PATCH 1/2] powerpc: document the MPIC device tree binding

2011-01-27 Thread Meador Inge
On 01/20/2011 09:50 AM, Yoder Stuart-B08248 wrote: -Original Message- From: Meador Inge [mailto:meador_i...@mentor.com] Sent: Wednesday, January 19, 2011 6:08 PM To: Yoder Stuart-B08248 Cc: Wood Scott-B07421; linuxppc-dev@lists.ozlabs.org; devicetree- disc...@lists.ozlabs.org; Blanchar

Re: [PATCH] gianfar: Fall back to software tcp/udp checksum on older controllers

2011-01-27 Thread David Miller
Please CC: netdev on future submissions of this patch, otherwise I won't see it in my queue. ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

[PATCH] powerpc: fix memory limits when starting at a non-zero address

2011-01-27 Thread Scott Wood
memblock_enforce_memory_limit() takes the desired maximum quantity of memory to end up with, not an address above which memory will not be used. Signed-off-by: Scott Wood --- arch/powerpc/kernel/prom.c |2 +- arch/powerpc/mm/init_32.c |2 +- 2 files changed, 2 insertions(+), 2 deletions

Re: [PATCH 2/7] PowerPC: add unlikely() to BUG_ON()

2011-01-27 Thread David Daney
On 01/27/2011 12:04 PM, Scott Wood wrote: On Thu, 27 Jan 2011 09:57:39 -0800 David Daney wrote: On 01/27/2011 04:12 AM, Coly Li wrote: diff --git a/arch/powerpc/include/asm/bug.h b/arch/powerpc/include/asm/bug.h index 065c590..10889a6 100644 --- a/arch/powerpc/include/asm/bug.h +++ b/arch/pow

[PATCH] powerpc: fix pfn_valid() when memory starts at a non-zero address

2011-01-27 Thread Scott Wood
max_mapnr is a pfn, not an index innto mem_map[]. So don't add ARCH_PFN_OFFSET a second time. Signed-off-by: Scott Wood --- arch/powerpc/include/asm/page.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/powerpc/include/asm/page.h b/arch/powerpc/include/asm/page.h

[PATCH] powerpc/book3e: protect complex macro args in mmu-book3e.h with parens

2011-01-27 Thread Scott Wood
Signed-off-by: Scott Wood --- Ran into trouble with this when working on some KVM code. arch/powerpc/include/asm/mmu-book3e.h |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/powerpc/include/asm/mmu-book3e.h b/arch/powerpc/include/asm/mmu-book3e.h index 8eaed

Re: [PATCH 2/7] PowerPC: add unlikely() to BUG_ON()

2011-01-27 Thread Scott Wood
On Thu, 27 Jan 2011 09:57:39 -0800 David Daney wrote: > On 01/27/2011 04:12 AM, Coly Li wrote: > > diff --git a/arch/powerpc/include/asm/bug.h b/arch/powerpc/include/asm/bug.h > > index 065c590..10889a6 100644 > > --- a/arch/powerpc/include/asm/bug.h > > +++ b/arch/powerpc/include/asm/bug.h > > @

Re: [PATCH 2/7] PowerPC: add unlikely() to BUG_ON()

2011-01-27 Thread David Daney
Why not also CC the PPC maintainers as well? I am not certain, but I think they may be reached at: linuxppc-dev@lists.ozlabs.org On 01/27/2011 04:12 AM, Coly Li wrote: Current BUG_ON() arch/powerpc/include/asm/bug.h does not use unlikely(), in order to get better branch predict result, sourc

Re: FSL DMA engine transfer to PCI memory

2011-01-27 Thread Ira W. Snyder
On Thu, Jan 27, 2011 at 10:32:19AM +0200, Felix Radensky wrote: > Hi Ira, > > On 01/25/2011 06:29 PM, Ira W. Snyder wrote: > > On Tue, Jan 25, 2011 at 04:32:02PM +0200, Felix Radensky wrote: > >> Hi Ira, > >> > >> On 01/25/2011 02:18 AM, Ira W. Snyder wrote: > >>> On Tue, Jan 25, 2011 at 01:39:39A

[PATCH -mm 2/6] powerpc: convert little-endian bitops macros to static inline functions

2011-01-27 Thread Akinobu Mita
(This patch is intended to be folded into the patch in -mm: powerpc-introduce-little-endian-bitops.patch) The little-endian bitops on powerpc are written as preprocessor macros with the cast to "unsigned long *". This means that even non-pointers will be accepted without an error, and that is a Ve

Re: [PATCH] gianfar: Fall back to software tcp/udp checksum on older controllers

2011-01-27 Thread Anton Vorontsov
Hello Alex, On Thu, Jan 27, 2011 at 12:14:21AM -0800, Alex Dubov wrote: > As specified by errata eTSEC49 of MPC8548 and errata eTSEC12 of MPC83xx, > older revisions of gianfar controllers will be unable to calculate a TCP/UDP > packet checksum for some aligments of the appropriate FCB. This patch

Re: FSL DMA engine transfer to PCI memory

2011-01-27 Thread Felix Radensky
Hi Ira, On 01/25/2011 06:29 PM, Ira W. Snyder wrote: On Tue, Jan 25, 2011 at 04:32:02PM +0200, Felix Radensky wrote: Hi Ira, On 01/25/2011 02:18 AM, Ira W. Snyder wrote: On Tue, Jan 25, 2011 at 01:39:39AM +0200, Felix Radensky wrote: Hi Ira, Scott On 01/25/2011 12:26 AM, Ira W. Snyder wrote

[PATCH] gianfar: Fall back to software tcp/udp checksum on older controllers

2011-01-27 Thread Alex Dubov
As specified by errata eTSEC49 of MPC8548 and errata eTSEC12 of MPC83xx, older revisions of gianfar controllers will be unable to calculate a TCP/UDP packet checksum for some aligments of the appropriate FCB. This patch checks for FCB alignment on such controllers and falls back to software checksu