RE: [PATCH v3] ppc44x:PHY fixup for USB on canyonlands board

2010-11-26 Thread Benjamin Herrenschmidt
On Fri, 2010-11-26 at 21:02 +0530, Rupjyoti Sarmah wrote: > Hi Wolfgang, > > >> This results in a mix of "amcc," and "apm," strings. > >> Are there any plans to unify this? > We can make all as apm, but right now I believe there is no plan to do so. > > >>Earlier versions of the patch included a

RE: [PATCH v3] ppc44x:PHY fixup for USB on canyonlands board

2010-11-26 Thread Rupjyoti Sarmah
Hi Wolfgang, >> This results in a mix of "amcc," and "apm," strings. >> Are there any plans to unify this? We can make all as apm, but right now I believe there is no plan to do so. >>Earlier versions of the patch included a delay after the clrbits8() >>call as well. Is it intentional that you dr

Re: [PATCH v3] ppc44x:PHY fixup for USB on canyonlands board

2010-11-26 Thread Wolfgang Denk
Dear Rupjyoti Sarmah, In message <201011261110.oaqbanzl012...@amcc.com> you wrote: > > + c...@2,0 { > + #address-cells = <1>; > + #size-cells = <1>; > + compatibl

[PATCH v3] ppc44x:PHY fixup for USB on canyonlands board

2010-11-26 Thread Rupjyoti Sarmah
This fix is a reset for USB PHY that requires some amount of time for power to be stable on Canyonlands. Signed-off-by: Rupjyoti Sarmah --- changes from previous version: - moved a Macro from header file to the source file - corrected & updated comments - replaced the out_be32 calls by setbits3

[PATCH] ucc_geth: fix ucc halt problem in half duplex mode

2010-11-26 Thread Li Yang
In commit 58933c64(ucc_geth: Fix the wrong the Rx/Tx FIFO size), the UCC_GETH_UTFTT_INIT is set to 512 based on the recommendation of the QE Reference Manual. But that will sometimes cause tx halt while working in half duplex mode. According to errata draft QE_GENERAL-A003(High Tx Virtual FIFO th