Re: [PATCH v1] ppc44x:PHY fixup for USB on canyonlands board

2010-11-23 Thread Stefan Roese
On Wednesday 24 November 2010 05:55:03 Rupjyoti Sarmah wrote: > >> +#define BCSR_USB_EN 0x11 > > > >This define is wrong here. Its not common for all 44x platforms but > > Canyonlands specific. > > So, do you suggest to move this macro to the canyonlands.c ? Or introduce > canyonlands.h ?

RE: [PATCH v1] ppc44x:PHY fixup for USB on canyonlands board

2010-11-23 Thread Rupjyoti Sarmah
>> >> +#define BCSR_USB_EN 0x11 >This define is wrong here. Its not common for all 44x platforms but Canyonlands specific. So, do you suggest to move this macro to the canyonlands.c ? Or introduce canyonlands.h ? Regards, Rup ___ Linuxppc-dev mailing li

Re: [PATCH v1] ppc44x:PHY fixup for USB on canyonlands board

2010-11-23 Thread Benjamin Herrenschmidt
> > + setbits8(&bcsr[7], BCSR_USB_EN); > > + udelay(10); > > + > > + clrbits8(&bcsr[7], BCSR_USB_EN); > > + udelay(10); > > Thats a total bootup delay of 200ms. Is this really needed? In addition, so large delays should use msleep() if possible (depends how early we are here). C

[PATCH][v2] Fixing the garbage collector problem after NAND-flash image record in u-boot

2010-11-23 Thread Sergej.Stepanov
This patch should fix the following problem: 1. the jffs2-image update in the u-boot was ok 2. first restart and first mount of the NAND-flash-partition was also ok 3. before the restart of controller there are no any activity on NAND-flash except of the jffs2_gcd_mtdX-process ... 4. BUT afte

Resend: Re: [PATCH] Fixing the garbage collector problem after NAND-flash image record in u-boot

2010-11-23 Thread Sergej.Stepanov
Sorry Scott, i resend the email also to linuxppc-dev Am Dienstag, den 23.11.2010, 11:18 -0600 schrieb Scott Wood: > > It only makes a difference on small-page NAND. Our board has a large page NAND > > > I'll resend the patch. > > Please include linux-...@lists.infradead.org and David Woodhous

Re: [PATCH] Fixing the garbage collector problem after NAND-flash image record in u-boot

2010-11-23 Thread Scott Wood
On Tue, 23 Nov 2010 16:10:54 +0100 wrote: > This patch should fix the following problem: > 1. the jffs2-image update in the u-boot was ok > 2. first restart and first mount of the NAND-flash-partition was also ok > 3. before the restart of controller there are no any activity on NAND-flash

[PATCH] Fixing the garbage collector problem after NAND-flash image record in u-boot

2010-11-23 Thread Sergej.Stepanov
This patch should fix the following problem: 1. the jffs2-image update in the u-boot was ok 2. first restart and first mount of the NAND-flash-partition was also ok 3. before the restart of controller there are no any activity on NAND-flash except of the jffs2_gcd_mtdX-process ... 4. BUT aft

Re: [PATCH] MPC5200: Eliminate duplicate include of of_device.h

2010-11-23 Thread Mark Brown
On Mon, Nov 22, 2010 at 10:54:03PM +0100, Jesper Juhl wrote: > > Eliminate duplicate #include from > sound/soc/fsl/mpc5200_dma.c Applied, thanks. ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-

Re: Change in PCI behaviour

2010-11-23 Thread Gary Thomas
On 11/22/2010 01:26 PM, Benjamin Herrenschmidt wrote: On Mon, 2010-11-22 at 03:01 -0700, Gary Thomas wrote: I have a bit more information on this. I'm pretty sure that the failures are only happening in my SCSI (SATA actually) code. My board (8347ea) has a PCI bus with a SIL SATA controller.

[PATCH v3 02/22] bitops: rename generic little-endian bitops functions

2010-11-23 Thread Akinobu Mita
As a preparation for providing little-endian bitops for all architectures, This removes generic_ prefix from little-endian bitops function names in asm-generic/bitops/le.h. s/generic_find_next_le_bit/find_next_le_bit/ s/generic_find_next_zero_le_bit/find_next_zero_le_bit/ s/generic_find_first_zero

Re: [PATCH v1] ppc44x:PHY fixup for USB on canyonlands board

2010-11-23 Thread Stefan Roese
Hi Rup, On Tuesday 23 November 2010 13:56:53 Rupjyoti Sarmah wrote: > This fix is a reset for USB PHY that requires some amount of time for power > to be stable on Canyonlands. Since this is version 2 of your patch, "[PATCH v2]" would have been a bit better in the subject line. Its also a good p

[PATCH v1] ppc44x:PHY fixup for USB on canyonlands board

2010-11-23 Thread Rupjyoti Sarmah
This fix is a reset for USB PHY that requires some amount of time for power to be stable on Canyonlands. Signed-off-by: Rupjyoti Sarmah --- arch/powerpc/boot/dts/canyonlands.dts | 13 +++ arch/powerpc/platforms/44x/44x.h |5 + arch/powerpc/platforms/44x/Makefile|