[ adding Greg ]
On Thu, Sep 30, 2010 at 5:16 PM, Tirumala Marri wrote:
>> Where iop_adma_alloc_slots() is implemented differently between
>> iop13xx and iop3xx. In this case why does ppc440spe-adma.h exist? If
>> it has code specific to ppe440spe it should just live in the ppe440spe
>> C file.
> On Thu, Sep 30, 2010 at 12:08 PM, Wolfgang Denk wrote:
> [snip other valid review comments]
> >
> > This is a header file, yet you add here literally thousands of lines
> of
> > code.
>
> Yes, these functions are entirely too large to be inlined. It looks
> like you are trying to borrow too hea
>
> When reposting a patch, please always indicate that this is new
> version by using something like "[PATCH v2]" in the Subject line.
[Marri] I know, but this patch is not modification of previous patch.
It is complete brand new from scratch again. In that case isn't this
will be first version ?
On Thu, Sep 30, 2010 at 12:08 PM, Wolfgang Denk wrote:
[snip other valid review comments]
>
> This is a header file, yet you add here literally thousands of lines of
> code.
Yes, these functions are entirely too large to be inlined. It looks
like you are trying to borrow too heavily from the iop
Now that the generic DMAEngine API has support for scatterlist to
scatterlist copying, the device_prep_slave_sg() portion of the
DMA_SLAVE API is no longer necessary and has been removed.
However, the device_control() portion of the DMA_SLAVE API is still
useful to control device specific paramete
Now that the DMAEngine API has support for scatterlist to scatterlist
copy, implement support for the STE DMA40 DMA controller.
Cc: Linus Walleij
Cc: Per Fridén
Signed-off-by: Ira W. Snyder
---
drivers/dma/ste_dma40.c | 17 +
1 files changed, 17 insertions(+), 0 deletions(-)
This series adds support for scatterlist to scatterlist copies to the
generic DMAEngine API. Both the fsldma and ste_dma40 drivers currently
implement a similar API using different, non-generic methods. This series
converts both of them to the new, standardized API.
By doing this as part of the co
This adds support for scatterlist to scatterlist DMA transfers. A
similar interface is exposed by the fsldma driver (through the DMA_SLAVE
API) and by the ste_dma40 driver (through an exported function).
This patch paves the way for making this type of copy operation a part
of the generic DMAEngin
Now that the DMAEngine API has support for scatterlist to scatterlist
copy, implement support for the Freescale DMA controller.
Signed-off-by: Ira W. Snyder
---
drivers/dma/fsldma.c | 128 -
1 files changed, 125 insertions(+), 3 deletions(-)
diff
Hmmm for some reason the previous replies didn't get picked up by
patchwork, so I'm replying with my comment again for the public
record.
In this case the eSPI controller driver is buggy and needs to be
fixed. If the hardware can only support small transfers, then it is
the responsibilty of t
On Thu, Sep 30, 2010 at 5:00 PM, Mingkai Hu wrote:
> Signed-off-by: Mingkai Hu
> ---
> v3:
> - Move the SPI flash partition code to the probe function.
>
> drivers/mtd/devices/m25p80.c | 39 +++
> 1 files changed, 27 insertions(+), 12 deletions(-)
>
> diff
On Wed, Sep 29, 2010 at 11:42 PM, Jean Delvare wrote:
> On Wed, 29 Sep 2010 00:20:54 +0100, Ben Dooks wrote:
>> On Fri, Sep 24, 2010 at 04:14:53PM -0600, Grant Likely wrote:
>> > Commit 959e85f7, "i2c: add OF-style registration and binding" caused a
>> > module dependency loop where of_i2c.c calls
On Fri, Oct 1, 2010 at 12:06 AM, Anton Vorontsov wrote:
> On Thu, Sep 30, 2010 at 11:41:40PM +0900, Grant Likely wrote:
>> On Thu, Sep 30, 2010 at 11:16 PM, Grant Likely
>> wrote:
>> > On Thu, Sep 30, 2010 at 7:46 PM, David Brownell
>> > wrote:
>> >>
>> >> --- On Thu, 9/30/10, Mingkai Hu wrote
Dear tma...@apm.com,
In message <1285865736-32074-1-git-send-email-tma...@apm.com> you wrote:
> From: Tirumala Marri
>
> This patch separates the SoC specific functions and moved
> to different files.
>
> The reason for ppc440spe-adma.h is to define in-line functions which
> are called by both
On Wed, Sep 29, 2010 at 02:28:30PM -0500, Robin Holt wrote:
> On Tue, Sep 28, 2010 at 01:17:33PM -0500, Nathan Fontenot wrote:
...
> My next task is to implement a x86_64 SGI UV specific chunk of code
> to memory_block_size_bytes(). Would you consider adding that to your
> patch set? I expect to
On 09/29/2010 02:28 PM, Robin Holt wrote:
> On Tue, Sep 28, 2010 at 01:17:33PM -0500, Nathan Fontenot wrote:
>> On 09/28/2010 07:38 AM, Robin Holt wrote:
>>> I was tasked with looking at a slowdown in similar sized SGI machines
>>> booting x86_64. Jack Steiner had already looked into the memory_de
On Thu, Sep 30, 2010 at 11:41:40PM +0900, Grant Likely wrote:
> On Thu, Sep 30, 2010 at 11:16 PM, Grant Likely
> wrote:
> > On Thu, Sep 30, 2010 at 7:46 PM, David Brownell wrote:
> >>
> >> --- On Thu, 9/30/10, Mingkai Hu wrote:
> >>
> >>> From: Mingkai Hu
> >>> Subject: [PATCH v3 6/7] mtd: m25p
On Thu, Sep 30, 2010 at 11:16 PM, Grant Likely
wrote:
> On Thu, Sep 30, 2010 at 7:46 PM, David Brownell wrote:
>>
>> --- On Thu, 9/30/10, Mingkai Hu wrote:
>>
>>> From: Mingkai Hu
>>> Subject: [PATCH v3 6/7] mtd: m25p80: add a read function to read page by
>>> page
>>
>> NAK.
>>
>> We went ove
On Thu, Sep 30, 2010 at 7:46 PM, David Brownell wrote:
>
> --- On Thu, 9/30/10, Mingkai Hu wrote:
>
>> From: Mingkai Hu
>> Subject: [PATCH v3 6/7] mtd: m25p80: add a read function to read page by page
>
> NAK.
>
> We went over this before.
Yes, I agree with David on this. If large transfers do
--- On Thu, 9/30/10, Mingkai Hu wrote:
> From: Mingkai Hu
> Subject: [PATCH v3 6/7] mtd: m25p80: add a read function to read page by page
NAK.
We went over this before.
The bug is in your SPI master controller driver,
and the fix there involves mapping large reads
into multiple smaller re
Signed-off-by: Mingkai Hu
---
v3:
- Add "spi-quirk-trans-len-limit" property to the board's dts.
Documentation/powerpc/dts-bindings/fsl/spi.txt |3 +++
arch/powerpc/boot/dts/mpc8536ds.dts|1 +
arch/powerpc/boot/dts/p4080ds.dts |1 +
3 files changed, 5 insert
Add eSPI controller support based on the library code spi_fsl_lib.c.
The eSPI controller is newer controller 85xx/Pxxx devices supported.
There're some differences comparing to the SPI controller:
1. Has different register map and different bit definition
So leave the code operated the registe
Refactor the common code in file spi_fsl_spi.c to spi_fsl_lib.c used
by SPI/eSPI controller driver as a library, and leave the QE/CPM SPI
controller code in the SPI controller driver spi_fsl_spi.c.
Because the register map of the SPI controller and eSPI controller
is so different, also leave the c
For Freescale's eSPI controller, the max transaction length one time
is limitted by the SPCOM[TRANSLEN] field which is 0x. When used
mkfs.ext2 command to create ext2 filesystem on the flash, the read
length will exceed the max value of the SPCOM[TRANSLEN] field, so
change the read function to r
Signed-off-by: Mingkai Hu
---
v3:
- Move the SPI flash partition code to the probe function.
drivers/mtd/devices/m25p80.c | 39 +++
1 files changed, 27 insertions(+), 12 deletions(-)
diff --git a/drivers/mtd/devices/m25p80.c b/drivers/mtd/devices/m25p80.c
Also modifiy the document of cell-index in SPI controller. Add the
SPI flash(s25fl128p01) support on p4080ds and mpc8536ds board.
Signed-off-by: Mingkai Hu
---
v3:
- Add "fsl,p4080-espi" compatible property.
Documentation/powerpc/dts-bindings/fsl/spi.txt | 24 ++-
arch/powerpc/boot/d
This patchset refactor the file spi_mpc8xxx.c to abstract some common
code as a lib used by the SPI/eSPI controller driver, move the SPI
controller driver code to spi_fsl_spi.c, and add the eSPI controller
support with spi_fsl_espi.c.
Tested on P4080DS and MPC8536DS board based on latest Linux
On 09/29/2010 11:19 PM, Dan Williams wrote:
> On Mon, Sep 27, 2010 at 3:57 PM, Ira W. Snyder wrote:
>> Now that the DMAEngine API has support for scatterlist to scatterlist
>> copy, implement support for the STE DMA40 DMA controller.
>>
>> Cc: Linus Walleij
>> Cc: Per Fridén
>> Signed-off-by: Ir
28 matches
Mail list logo
