Re: [PATCH] powerpc: inline ppc64_runlatch_off

2010-08-05 Thread Anton Blanchard
Hi, > remind me why we need to do that runlatch thing on these CPUs at all ? The PMU uses it so events can be constructed that count only non idle cycles. I think the power management hardware on POWER6 and POWER7 also use the runlatch state to determine how busy a CPU is. Anton ___

Re: [PATCH] powerpc: inline ppc64_runlatch_off

2010-08-05 Thread Benjamin Herrenschmidt
On Fri, 2010-08-06 at 15:56 +1000, Anton Blanchard wrote: > Unfortunately we still need to prevent continual writes to it with a per > thread > flag because on some CPUs a write to the SPR in low priority mode will stall > another SMT thread. So we could get rid of the cpu feature comparison but >

Re: [PATCH] powerpc: inline ppc64_runlatch_off

2010-08-05 Thread Anton Blanchard
Hi Ben, > > I'm sick of seeing ppc64_runlatch_off in our profiles, so inline the > > heavily used part of it into the callers. To avoid a mess of circular > > includes I didn't add it as an inline function. > > Considering that it's just an asm instruction or two, should we make it > inline asm

Re: [PATCH] powerpc: inline ppc64_runlatch_off

2010-08-05 Thread Benjamin Herrenschmidt
On Fri, 2010-08-06 at 14:53 +1000, Anton Blanchard wrote: > I'm sick of seeing ppc64_runlatch_off in our profiles, so inline the > heavily used part of it into the callers. To avoid a mess of circular includes > I didn't add it as an inline function. Considering that it's just an asm instruction o

Re: [PATCH][RFC] preempt_count corruption across H_CEDE call with CONFIG_PREEMPT on pseries

2010-08-05 Thread Vaidyanathan Srinivasan
* Darren Hart [2010-08-05 19:19:00]: > On 07/22/2010 10:09 PM, Benjamin Herrenschmidt wrote: > > On Thu, 2010-07-22 at 21:44 -0700, Darren Hart wrote: > > > >> suggestion I updated the instrumentation to display the > >> local_save_flags and irqs_disabled_flags: > > > >> Jul 22 23:36:58 igoor

[PATCH] powerpc: inline ppc64_runlatch_off

2010-08-05 Thread Anton Blanchard
I'm sick of seeing ppc64_runlatch_off in our profiles, so inline the heavily used part of it into the callers. To avoid a mess of circular includes I didn't add it as an inline function. Signed-off-by: Anton Blanchard --- Index: powerpc.git/arch/powerpc/include/asm/reg.h ===

[PATCH 2/3][MTD] P4080/nand: Only make elbc nand driver detect nand flash partitions

2010-08-05 Thread Roy Zang
From: Lan Chunhe-B25806 The former driver had the two functions: 1. detecting nand flash partitions; 2. registering elbc interrupt. Now, second function is removed to fsl_lbc.c. Signed-off-by: Lan Chunhe-B25806 Signed-off-by: Roy Zang --- drivers/mtd/nand/Kconfig |1 + drivers/m

[PATCH 1/3][MTD] P4080/eLBC: Make Freescale elbc interrupt common to elbc devices

2010-08-05 Thread Roy Zang
From: Lan Chunhe-B25806 Move Freescale elbc interrupt from nand dirver to elbc driver. Then all elbc devices can use the interrupt instead of ONLY nand. Signed-off-by: Lan Chunhe-B25806 Signed-off-by: Roy Zang --- send the patch to linux-...@lists.infradead.org it has been posted to linuxppc-.

[PATCH 3/3][MTD] P4080/nand: Fix the freescale lbc issue with 36bit mode

2010-08-05 Thread Roy Zang
From: Lan Chunhe-B25806 When system uses 36bit physical address, res.start is 36bit physical address. But the function of in_be32 returns 32bit physical address. Then both of them compared each other is wrong. So by converting the address of res.start into the right format fixes this issue. Sign

Re: [PATCH][RFC] preempt_count corruption across H_CEDE call with CONFIG_PREEMPT on pseries

2010-08-05 Thread Darren Hart
On 07/22/2010 10:09 PM, Benjamin Herrenschmidt wrote: > On Thu, 2010-07-22 at 21:44 -0700, Darren Hart wrote: > >> suggestion I updated the instrumentation to display the >> local_save_flags and irqs_disabled_flags: > >> Jul 22 23:36:58 igoort1 kernel: local flags: 0, irqs disabled: 1 >> Jul 22

Re: Relocating bootwrapper causes kernel panic

2010-08-05 Thread Scott Wood
On Thu, 5 Aug 2010 11:33:44 -0700 Shawn Jin wrote: > >> > Before the flat tree was accessed, I checked the DTLB and didn't find > >> > any entry related to 0xc0be4300. After the exception, I found the > >> > following DTLBs. > >> > > >> > 30 : 02  c0be4000   4KB -- -> > >> > 31 : 00

Re: Relocating bootwrapper causes kernel panic

2010-08-05 Thread Shawn Jin
>> > Before the flat tree was accessed, I checked the DTLB and didn't find >> > any entry related to 0xc0be4300. After the exception, I found the >> > following DTLBs. >> > >> > 30 : 02  c0be4000   4KB -- -> >> > 31 : 00  fa00   8MB VI-S-M -> fa00 >> > >> > The DTLB#30 doesn't

RE: [PATCH v2 5/7] powerpc/85xx: Add MChk handler for SRIO port

2010-08-05 Thread Bounine, Alexandre
> I'm looking at this now and wondering what we added the mcheck handler for in the first place and what > its trying to accomplish. > > - k This protects system from hanging if RIO link fails or enters error state. In some situations following maintenance read may initiate link recovery from err

Re: [PATCH 1/3] driver core: Add ability for arch code to setup pdev_archdata

2010-08-05 Thread Greg KH
On Fri, Aug 06, 2010 at 01:43:51AM +1000, Stephen Rothwell wrote: > Hi Kumar, > > On Thu, 5 Aug 2010 10:15:45 -0500 Kumar Gala > wrote: > > > > --- a/drivers/base/platform.c > > +++ b/drivers/base/platform.c > > @@ -19,6 +19,7 @@ > > #include > > #include > > #include > > +#include > >

Re: [PATCH v2 1/4] fsl_rio: fix compile errors

2010-08-05 Thread Kumar Gala
On Aug 5, 2010, at 12:54 PM, Scott Wood wrote: > On Thu, 5 Aug 2010 12:39:48 -0500 > Kumar Gala wrote: > >> >> On Jun 18, 2010, at 1:24 AM, Li Yang wrote: >> >>> Fixes the following compile problem on E500 platforms: >>> arch/powerpc/sysdev/fsl_rio.c: In function 'fsl_rio_mcheck_exception': >

Re: [PATCH v2 1/4] fsl_rio: fix compile errors

2010-08-05 Thread Scott Wood
On Thu, 5 Aug 2010 12:39:48 -0500 Kumar Gala wrote: > > On Jun 18, 2010, at 1:24 AM, Li Yang wrote: > > > Fixes the following compile problem on E500 platforms: > > arch/powerpc/sysdev/fsl_rio.c: In function 'fsl_rio_mcheck_exception': > > arch/powerpc/sysdev/fsl_rio.c:248: error: 'MCSR_MASK' u

Re: [PATCH v2 5/7] powerpc/85xx: Add MChk handler for SRIO port

2010-08-05 Thread Kumar Gala
On Aug 5, 2010, at 12:25 PM, Bounine, Alexandre wrote: > Below is a copy of Leo's message with pointers to the patches. > > Alex. > >> Subject: [PATCH] RapidIO,powerpc/85xx: remove MCSR_MASK in fsl_rio >> >> Fixes compile problem caused by MCSR_MASK removal from book-E > definitions. > > Hi A

[PATCH] Correct smt_enabled=X boot option for > 2 threads per core

2010-08-05 Thread Nathan Fontenot
The 'smt_enabled=X' boot option does not handle values of X > 2. For Power 7 processors with smt modes of 0,1,2,3, and 4 this does not work. This patch allows the smt_enabled option to be set to any value limited to a max equal to the number of threads per core. Signed-off-by: Nathan Fontenot --

Re: [PATCH v2 1/4] fsl_rio: fix compile errors

2010-08-05 Thread Kumar Gala
On Jun 18, 2010, at 1:24 AM, Li Yang wrote: > Fixes the following compile problem on E500 platforms: > arch/powerpc/sysdev/fsl_rio.c: In function 'fsl_rio_mcheck_exception': > arch/powerpc/sysdev/fsl_rio.c:248: error: 'MCSR_MASK' undeclared (first use > in this function) > > Also fixes the comp

Re: Relocating bootwrapper causes kernel panic

2010-08-05 Thread Scott Wood
On Thu, 5 Aug 2010 00:23:17 -0700 Shawn Jin wrote: > >> The flat tree located at 0xbe4300 as the kerne message showed. Why > >> cannot the kernel access this area? No TLB set for this area? > >> > >> <1>Unable to handle kernel paging request for data at address 0xc0be4308 > >> <1>Faulting instruc

Re: [PATCH 01/27] KVM: PPC: Introduce shared page

2010-08-05 Thread Hollis Blanchard
On 07/29/2010 05:47 AM, Alexander Graf wrote: For transparent variable sharing between the hypervisor and guest, I introduce a shared page. This shared page will contain all the registers the guest can read and write safely without exiting guest context. This patch only implements the stubs requ

RE: [PATCH v2 5/7] powerpc/85xx: Add MChk handler for SRIO port

2010-08-05 Thread Bounine, Alexandre
Below is a copy of Leo's message with pointers to the patches. Alex. >Subject: [PATCH] RapidIO,powerpc/85xx: remove MCSR_MASK in fsl_rio > >Fixes compile problem caused by MCSR_MASK removal from book-E definitions. Hi Alex, Only with your patch, there will still be problem on SRIO platforms ot

Re: [PATCH 17/27] KVM: PPC: KVM PV guest stubs

2010-08-05 Thread Hollis Blanchard
On 07/29/2010 05:47 AM, Alexander Graf wrote: We will soon start and replace instructions from the text section with other, paravirtualized versions. To ease the readability of those patches I split out the generic looping and magic page mapping code out. This patch still only contains stubs. Bu

Re: [linux-next] build failure

2010-08-05 Thread John Fastabend
divya wrote: Yestersday's linux-next(2.6.35_next_20100802) build fails with the following error on both system p and x. drivers/net/ixgbe/ixgbe_main.c: In function 'ixgbe_select_queue': drivers/net/ixgbe/ixgbe_main.c:6159: error: 'struct ixgbe_fcoe' has no member named 'up' drivers/n

Re: [PATCH 1/3] driver core: Add ability for arch code to setup pdev_archdata

2010-08-05 Thread Kumar Gala
On Aug 5, 2010, at 10:43 AM, Stephen Rothwell wrote: > Hi Kumar, > > On Thu, 5 Aug 2010 10:15:45 -0500 Kumar Gala > wrote: >> >> --- a/drivers/base/platform.c >> +++ b/drivers/base/platform.c >> @@ -19,6 +19,7 @@ >> #include >> #include >> #include >> +#include >> >> #include "base.h" >

Re: [PATCH 2/3] powerpc: implement arch_setup_pdev_archdata

2010-08-05 Thread Kumar Gala
On Aug 5, 2010, at 10:44 AM, Stephen Rothwell wrote: > Hi Kumar, > > On Thu, 5 Aug 2010 10:15:46 -0500 Kumar Gala > wrote: >> >> +static inline void arch_setup_pdev_archdata(struct platform_device *pdev) >> +{ >> +pdev->dev.dma_mask = &pdev->archdata.dma_mask; >> + >> +return; >> +}

Re: [PATCH 2/3] powerpc: implement arch_setup_pdev_archdata

2010-08-05 Thread Stephen Rothwell
Hi Kumar, On Thu, 5 Aug 2010 10:15:46 -0500 Kumar Gala wrote: > > +static inline void arch_setup_pdev_archdata(struct platform_device *pdev) > +{ > + pdev->dev.dma_mask = &pdev->archdata.dma_mask; > + > + return; > +} The blank line and "return;" don't add anything. -- Cheers, Stephen

Re: [PATCH 1/3] driver core: Add ability for arch code to setup pdev_archdata

2010-08-05 Thread Stephen Rothwell
Hi Kumar, On Thu, 5 Aug 2010 10:15:45 -0500 Kumar Gala wrote: > > --- a/drivers/base/platform.c > +++ b/drivers/base/platform.c > @@ -19,6 +19,7 @@ > #include > #include > #include > +#include > > #include "base.h" > > @@ -170,6 +171,9 @@ struct platform_device *platform_device_alloc

[PATCH 0/3] driver core: Add ability for arch code to setup pdev_archdata

2010-08-05 Thread Kumar Gala
On PPC we need to set the dma_mask pointer for platform_devices to point to the pdev_archdata. We can't wait for a bus_notifier as we need the dma_mask setup before the platform_device_add happens so that the bus_notifiers can check the dma_mask to determine if we need things like the SWIOTLB dma_

[PATCH 1/3] driver core: Add ability for arch code to setup pdev_archdata

2010-08-05 Thread Kumar Gala
On some architectures we need to setup pdev_archdata before we add the device. Waiting til a bus_notifier is too late since we might need the pdev_archdata in the bus notifier. One example is setting up of dma_mask pointers such that it can be used in a bus_notifier. We add ARCH_HAS_PDEV_ARCHDAT

[PATCH 3/3] powerpc: Dont require a dma_ops struct to set dma mask

2010-08-05 Thread Kumar Gala
The only reason to require a dma_ops struct is to see if it has implemented set_dma_mask. If not we can fall back to setting the mask directly. This resolves an issue with how to sequence the setting of a DMA mask for platform devices. Before we had an issue in that we have no way of setting the

[PATCH 2/3] powerpc: implement arch_setup_pdev_archdata

2010-08-05 Thread Kumar Gala
We have a long standing issues with platform devices not have a valid dma_mask pointer. This hasn't been an issue to date as no platform device has tried to set its dma_mask value to a non-default value. Signed-off-by: Kumar Gala --- arch/powerpc/include/asm/platform_device.h | 16 +++

Re: [PATCH] asoc/multi-component: fsl: add support for disabled SSI nodes

2010-08-05 Thread Kumar Gala
On Aug 4, 2010, at 5:51 PM, Timur Tabi wrote: > Add support for adding "status = disabled" to an SSI node to incidate that it > is not wired on the board. This replaces the not-so-intuitive previous method > of omitting a codec-handle property. > > Signed-off-by: Timur Tabi > --- > > Kumar, w

Re: Commit 3da34aa brakes MSI support on MPC8308 (possibly all MPC83xx) [REPOST]

2010-08-05 Thread Kumar Gala
On Aug 5, 2010, at 3:24 AM, Ilya Yanok wrote: > Hi Kumar, > > 05.08.2010 11:01, Kumar Gala пишет: >> I have a fix, can you test? > > Surely. Where can I find it? > > Thanks. > > Regards, Ilya. http://patchwork.ozlabs.org/patch/60934/ - k ___ Linu

Re: [PATCH] powerpc: ONLINE to OFFLINE CPU state transition during removal

2010-08-05 Thread Vaidyanathan Srinivasan
* Nathan Fontenot [2010-07-26 14:13:35]: > On 07/22/2010 11:13 PM, Vaidyanathan Srinivasan wrote: > > * Robert Jennings [2010-07-22 21:43:44]: > > > >> If a CPU remove is attempted using the 'release' interface on hardware > >> which supports extended cede, the CPU will be put in the INACTIVE s

RE: [PATCH 0/2 v3] mpc5200 ac97 gpio reset

2010-08-05 Thread Eric Millbrandt
> -Original Message- > From: linuxppc-dev-bounces+emillbrandt=dekaresearch@lists.ozlabs.org > [mailto:linuxppc-dev- > bounces+emillbrandt=dekaresearch@lists.ozlabs.org] On Behalf Of Mark > Brown > Sent: Tuesday, August 03, 2010 01:52 > To: Grant Likely > Cc: linuxppc-dev@lists.ozlab

Re: [PATCH] powerpc: Add vmcoreinfo symbols to allow makdumpfile to filter core files properly

2010-08-05 Thread Neil Horman
On Thu, Aug 05, 2010 at 12:04:26PM +1000, Benjamin Herrenschmidt wrote: > On Wed, 2010-08-04 at 10:49 -0400, Neil Horman wrote: > > Ping yet again. Ben, This needs review/acceptance from you or Paul > > Neil > > Isn't it already in powerpc-next about to be pulled by Linus ? > Yes, there it is.

Re: [alsa-devel] [PATCH] asoc/multi-component: fsl: add support for disabled SSI nodes

2010-08-05 Thread Liam Girdwood
On Thu, 2010-08-05 at 12:42 +0100, Mark Brown wrote: > On Wed, Aug 04, 2010 at 05:51:08PM -0500, Timur Tabi wrote: > > Add support for adding "status = disabled" to an SSI node to incidate that > > it > > is not wired on the board. This replaces the not-so-intuitive previous > > method > > of om

Re: [PATCH][RFC] preempt_count corruption across H_CEDE call with CONFIG_PREEMPT on pseries

2010-08-05 Thread Thomas Gleixner
On Thu, 5 Aug 2010, Vaidyanathan Srinivasan wrote: > * Darren Hart [2010-08-04 21:45:51]: > > > On 07/23/2010 12:07 AM, Vaidyanathan Srinivasan wrote: > > >* Benjamin Herrenschmidt [2010-07-23 15:11:00]: > > > > > >>On Fri, 2010-07-23 at 10:38 +0530, Vaidyanathan Srinivasan wrote: > > >>>Yes.

Re: [PATCH] asoc/multi-component: fsl: add support for disabled SSI nodes

2010-08-05 Thread Mark Brown
On Wed, Aug 04, 2010 at 05:51:08PM -0500, Timur Tabi wrote: > Add support for adding "status = disabled" to an SSI node to incidate that it > is not wired on the board. This replaces the not-so-intuitive previous method > of omitting a codec-handle property. > > Signed-off-by: Timur Tabi Acked-

Re: [PATCH][RFC] preempt_count corruption across H_CEDE call with CONFIG_PREEMPT on pseries

2010-08-05 Thread Vaidyanathan Srinivasan
* Darren Hart [2010-08-04 21:45:51]: > On 07/23/2010 12:07 AM, Vaidyanathan Srinivasan wrote: > >* Benjamin Herrenschmidt [2010-07-23 15:11:00]: > > > >>On Fri, 2010-07-23 at 10:38 +0530, Vaidyanathan Srinivasan wrote: > >>>Yes. extended_cede_processor() will return with interrupts enabled in >

Re: [PATCH v4 1/2] powerpc: cleanup APIs for cpu/thread/core mappings

2010-08-05 Thread Vaidyanathan Srinivasan
* Benjamin Herrenschmidt [2010-08-03 14:44:13]: > On Thu, 2010-07-22 at 06:27 +0530, Vaidyanathan Srinivasan wrote: > > These APIs take logical cpu number as input > > Change cpu_first_thread_in_core() to cpu_leftmost_thread_sibling() > > Change cpu_last_thread_in_core() to cpu_rightmost_thread_s

Re: [PATCH 00/27] KVM PPC PV framework v3

2010-08-05 Thread Avi Kivity
On 07/29/2010 03:47 PM, Alexander Graf wrote: On PPC we run PR=0 (kernel mode) code in PR=1 (user mode) and don't use the hypervisor extensions. While that is all great to show that virtualization is possible, there are quite some cases where the emulation overhead of privileged instructions is

Re: Commit 3da34aa brakes MSI support on MPC8308 (possibly all MPC83xx) [REPOST]

2010-08-05 Thread Ilya Yanok
Hi Kumar, 05.08.2010 11:01, Kumar Gala пишет: I have a fix, can you test? Surely. Where can I find it? Thanks. Regards, Ilya. ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH 00/27] KVM PPC PV framework v3

2010-08-05 Thread Avi Kivity
On 08/05/2010 11:01 AM, Alexander Graf wrote: Shall I take this as an ACK? Hollis wanted to take a look at it too. But given the fact that I have another ~10 patches lying here I'd appreciate if things could get committed. If changes are so dramatic that they'd render things incompatible, w

[PATCH] powerpc/fsl-pci: Fix MSI support on 83xx platforms

2010-08-05 Thread Kumar Gala
The following commit broke 83xx because it assumed the 83xx platforms exposed the "IMMR" address in BAR0 like the 85xx/86xx/QoriQ devices do: commit 3da34aae03d498ee62f75aa7467de93cce3030fd Author: Kumar Gala Date: Tue May 12 15:51:56 2009 -0500 powerpc/fsl: Support unique MSI addresses pe

Re: [PATCH 00/27] KVM PPC PV framework v3

2010-08-05 Thread Alexander Graf
On 05.08.2010, at 09:57, Avi Kivity wrote: > On 08/03/2010 07:16 PM, Scott Wood wrote: >> On Sun, 1 Aug 2010 22:21:37 +0200 >> Alexander Graf wrote: >> >>> On 01.08.2010, at 16:02, Avi Kivity wrote: >>> Looks reasonable. Since it's fair to say I understand nothing about powerpc, I'

[PATCH] powerpc/85xx: Fix compile error in mpc85xx_mds.c

2010-08-05 Thread Kumar Gala
arch/powerpc/platforms/85xx/mpc85xx_mds.c: In function 'mpc85xx_mds_setup_arch': arch/powerpc/platforms/85xx/mpc85xx_mds.c:367: error: 'np' undeclared (first use in this function) arch/powerpc/platforms/85xx/mpc85xx_mds.c:367: error: (Each undeclared identifier is reported only once arch/powerpc/

Re: [PATCH 00/27] KVM PPC PV framework v3

2010-08-05 Thread Avi Kivity
On 08/03/2010 07:16 PM, Scott Wood wrote: On Sun, 1 Aug 2010 22:21:37 +0200 Alexander Graf wrote: On 01.08.2010, at 16:02, Avi Kivity wrote: Looks reasonable. Since it's fair to say I understand nothing about powerpc, I'd like someone who does to review it and ack, please, with an emphasi

Re: Relocating bootwrapper causes kernel panic

2010-08-05 Thread Shawn Jin
>> The flat tree located at 0xbe4300 as the kerne message showed. Why >> cannot the kernel access this area? No TLB set for this area? >> >> <1>Unable to handle kernel paging request for data at address 0xc0be4308 >> <1>Faulting instruction address: 0xc01fdabc >> <4>Oops: Kernel access of bad area,

Re: Commit 3da34aa brakes MSI support on MPC8308 (possibly all MPC83xx) [REPOST]

2010-08-05 Thread Kumar Gala
On Jul 22, 2010, at 4:11 PM, Ilya Yanok wrote: > 23.07.2010 1:09, Ilya Yanok wrote: >> I hope to disturb you but I haven't got any reply for my first posting... > > I shouldn't be working at night... It's 'hate' not 'hope'... > > Regards, Ilya. I have a fix, can you test? - k