Re: perf top broken on ppc64

2010-04-20 Thread Ian Munsie
Excerpts from Alexander Graf's message of Wed Apr 21 09:21:36 +1000 2010: > Hi, > > While trying to find out performance bottlenecks in KVM for PowerPC I > figured I'd try and use "perf top" to see what's going on in the > system. This works great on my G4, but doesn't on the Powerstation > (970MP

Re: [Bug #15589] 2.6.34-rc1: Badness at fs/proc/generic.c:316

2010-04-20 Thread Rafael J. Wysocki
On Wednesday 21 April 2010, Michael Ellerman wrote: > On Wed, 2010-04-21 at 18:55 +0300, Alexey Dobriyan wrote: > > On Tue, Apr 20, 2010 at 10:18:18PM +1000, Michael Ellerman wrote: > > > On Mon, 2010-04-19 at 23:45 -0700, Christian Kujau wrote: > > > --- a/fs/proc/proc_devtree.c > > > +++ b/fs/pro

Re: U-boot support for MPC85xx eSPI

2010-04-20 Thread Hillery, Nathan
Well, of course!-). Thanks for the helpful pointer & re-post. Sent from my iPad On Apr 21, 2010, at 12:15 AM, "Kumar Gala" wrote: > > On Apr 20, 2010, at 1:24 PM, Hillery, Nathan wrote: > >> I’m looking for U-boot support for the embedded SPI driver on the MPC8536 to >> access a SPI flash

Re: U-boot support for MPC85xx eSPI

2010-04-20 Thread Kumar Gala
On Apr 20, 2010, at 1:24 PM, Hillery, Nathan wrote: > I’m looking for U-boot support for the embedded SPI driver on the MPC8536 to > access a SPI flash device (Numonyx [ex-STmicro] M25P16). The eSPI can read > the SPI flash (that’s how U-boot gets loaded into RAM) and I can read/write > from

U-boot support for MPC85xx eSPI

2010-04-20 Thread Hillery, Nathan
I'm looking for U-boot support for the embedded SPI driver on the MPC8536 to access a SPI flash device (Numonyx [ex-STmicro] M25P16). The eSPI can read the SPI flash (that's how U-boot gets loaded into RAM) and I can read/write from linux using the mtdblock driver. I see code that appears to supp

Re: [PATCH 1/1] powerpc: Ignore IPIs to offline CPUs

2010-04-20 Thread Brian King
On 04/20/2010 09:04 PM, Michael Neuling wrote: > In message <201004210154.o3l1sxar001...@d01av04.pok.ibm.com> you wrote: >> >> Since there is nothing to stop an IPI from occurring to an >> offline CPU, rather than printing a warning to the logs, >> just ignore the IPI. This was seen while stress te

Re: [PATCH 1/2] ehea: error handling improvement

2010-04-20 Thread David Miller
From: Thomas Klein Date: Mon, 19 Apr 2010 14:08:11 +0200 > Reset a port's resources only if they're actually in an error state > > Signed-off-by: Thomas Klein > --- > > Patch created against 2.6.34-rc4 There are several problems with these patches: 1) They are corrupted by your email client,

Re: [PATCH 1/1] powerpc: Ignore IPIs to offline CPUs

2010-04-20 Thread Michael Neuling
In message <201004210154.o3l1sxar001...@d01av04.pok.ibm.com> you wrote: > > Since there is nothing to stop an IPI from occurring to an > offline CPU, rather than printing a warning to the logs, > just ignore the IPI. This was seen while stress testing > SMT enable/disable. This seems like a recip

[PATCH 1/1] powerpc: Ignore IPIs to offline CPUs

2010-04-20 Thread Brian King
Since there is nothing to stop an IPI from occurring to an offline CPU, rather than printing a warning to the logs, just ignore the IPI. This was seen while stress testing SMT enable/disable. Signed-off-by: Brian King --- arch/powerpc/platforms/pseries/xics.c |3 ++- 1 file changed, 2 inse

Re: Badness in xics_ipi_dispatch

2010-04-20 Thread Michael Ellerman
On Tue, 2010-04-20 at 17:17 -0500, Brian King wrote: > In stress testing enabling and disabling of SMT, we are regularly > seeing the badness warning below. Looking through the cpu offline > path, this is what I see: > > 1. stop_cpu: IRQ's get disabled > 2. pseries_cpu_disable: set cpu offline (no

Re: [Bug #15589] 2.6.34-rc1: Badness at fs/proc/generic.c:316

2010-04-20 Thread Michael Ellerman
On Tue, 2010-04-20 at 11:15 -0700, Christian Kujau wrote: > On Tue, 20 Apr 2010 at 22:18, Michael Ellerman wrote: > > Try this 100% unbuilt, 100% untested patch. > > I added GFP_KERNEL to kstrdup to make the compile error go away: > > fs/proc/proc_devtree.c: In function ‘unslash_name’: > fs/proc/

Re: [Bug #15589] 2.6.34-rc1: Badness at fs/proc/generic.c:316

2010-04-20 Thread Michael Ellerman
On Wed, 2010-04-21 at 18:55 +0300, Alexey Dobriyan wrote: > On Tue, Apr 20, 2010 at 10:18:18PM +1000, Michael Ellerman wrote: > > On Mon, 2010-04-19 at 23:45 -0700, Christian Kujau wrote: > > --- a/fs/proc/proc_devtree.c > > +++ b/fs/proc/proc_devtree.c > > @@ -175,6 +175,24 @@ retry: > > r

perf top broken on ppc64

2010-04-20 Thread Alexander Graf
Hi, While trying to find out performance bottlenecks in KVM for PowerPC I figured I'd try and use "perf top" to see what's going on in the system. This works great on my G4, but doesn't on the Powerstation (970MP). The only weird thing I can imagine about this setup is that I'm running 32 bit

Badness in xics_ipi_dispatch

2010-04-20 Thread Brian King
In stress testing enabling and disabling of SMT, we are regularly seeing the badness warning below. Looking through the cpu offline path, this is what I see: 1. stop_cpu: IRQ's get disabled 2. pseries_cpu_disable: set cpu offline (no barriers after this) 3. xics_migrate_irqs_away: Remove ourselves

Re: [Bug #15589] 2.6.34-rc1: Badness at fs/proc/generic.c:316

2010-04-20 Thread Andreas Schwab
Christian Kujau writes: > + while ((p = strstr(p, "/"))) You want to use strchr. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." ___

Re: [Bug #15589] 2.6.34-rc1: Badness at fs/proc/generic.c:316

2010-04-20 Thread Christian Kujau
On Tue, 20 Apr 2010 at 22:18, Michael Ellerman wrote: > Try this 100% unbuilt, 100% untested patch. I added GFP_KERNEL to kstrdup to make the compile error go away: fs/proc/proc_devtree.c: In function ‘unslash_name’: fs/proc/proc_devtree.c:183: error: too few arguments to function ‘kstrdup’ make[

Re: [PATCH v4 2/2] perf probe: Add PowerPC DWARF register number mappings

2010-04-20 Thread Masami Hiramatsu
Ian Munsie wrote: > From: Ian Munsie > > This patch adds mappings from the register numbers from DWARF to the > register names used in the PowerPC Regs and Stack Access API. This > allows perf probe to be used to record variable contents on PowerPC. > > This patch depends on functionality in the

Re: [PATCH v4 1/2] perf: Move arch specific code into separate arch directory

2010-04-20 Thread Masami Hiramatsu
Hi Ian, Please feel free to add my ack. :) Acked-by: Masami Hiramatsu Ingo, I think this one is important enhancement for perf to port it on other archs. Thank you, Ian Munsie wrote: > From: Ian Munsie > > The perf userspace tool included some architecture specific code to map > registers f

Re: [PATCH] [RFC] Xilinx MPMC SDMA subsystem

2010-04-20 Thread Steven J. Magnani
Hi Sergey, I've only just started using this in earnest, sorry for not getting back to you sooner. It's a nice encapsulation of the MPMC/SDMA functionality, thanks for posting it. In order to integrate this into my system, I refactored the bus attachment code and added hooks for platform bus. I a

Re: [Bug #15589] 2.6.34-rc1: Badness at fs/proc/generic.c:316

2010-04-20 Thread Alexey Dobriyan
On Tue, Apr 20, 2010 at 10:18:18PM +1000, Michael Ellerman wrote: > On Mon, 2010-04-19 at 23:45 -0700, Christian Kujau wrote: > --- a/fs/proc/proc_devtree.c > +++ b/fs/proc/proc_devtree.c > @@ -175,6 +175,24 @@ retry: > return fixed_name; > } > > +static const char *unslash_name(const ch

Re: [PATCH v2 2/5] fsl_msi: enable msi allocation in all banks

2010-04-20 Thread Michael Ellerman
On Tue, 2010-04-20 at 20:20 +0800, Li Yang wrote: > Put all fsl_msi banks in a linked list. The list of banks then can be > traversed when allocating new msi interrupts. Also fix failing path > of fsl_setup_msi_irqs(). > > Signed-off-by: Zhao Chenhui > Signed-off-by: Li Yang > --- > arch/power

Re: [Bug #15589] 2.6.34-rc1: Badness at fs/proc/generic.c:316

2010-04-20 Thread Michael Ellerman
On Mon, 2010-04-19 at 23:45 -0700, Christian Kujau wrote: > On Tue, 20 Apr 2010 at 05:19, Rafael J. Wysocki wrote: > > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15589 > > Subject : 2.6.34-rc1: Badness at fs/proc/generic.c:316 > > Submitter : Christian Kujau > > Date

[PATCH v2 5/5] fsl_msi: add remove path and probe failing path

2010-04-20 Thread Li Yang
Also cleanup the probe function. Signed-off-by: Li Yang --- arch/powerpc/sysdev/fsl_msi.c | 35 +-- arch/powerpc/sysdev/fsl_msi.h |1 + 2 files changed, 30 insertions(+), 6 deletions(-) diff --git a/arch/powerpc/sysdev/fsl_msi.c b/arch/powerpc/sysdev/fsl_ms

[PATCH v2 4/5] mpc8572ds: change camp dtses for MSI sharing

2010-04-20 Thread Li Yang
Enable the sharing of MSI interrupt through AMP OSes in the mpc8572ds dtses. Signed-off-by: Zhao Chenhui Signed-off-by: Li Yang --- arch/powerpc/boot/dts/mpc8572ds_camp_core0.dts | 15 +-- arch/powerpc/boot/dts/mpc8572ds_camp_core1.dts |7 ++- 2 files changed, 15 insertion

[PATCH v2 3/5] fsl_msi: enable msi sharing through AMP OSes

2010-04-20 Thread Li Yang
Make a single PCIe MSI bank shareable through CAMP OSes. The number of MSI used by each core can be configured by dts file. Signed-off-by: Zhao Chenhui Signed-off-by: Li Yang --- arch/powerpc/sysdev/fsl_msi.c |8 +++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/arch/p

[PATCH v2 2/5] fsl_msi: enable msi allocation in all banks

2010-04-20 Thread Li Yang
Put all fsl_msi banks in a linked list. The list of banks then can be traversed when allocating new msi interrupts. Also fix failing path of fsl_setup_msi_irqs(). Signed-off-by: Zhao Chenhui Signed-off-by: Li Yang --- arch/powerpc/sysdev/fsl_msi.c | 16 +--- arch/powerpc/sysdev/f

[PATCH v2 1/5] fsl_msi: fix the conflict of virt_msir's chip_data

2010-04-20 Thread Li Yang
In fsl_of_msi_probe(), the virt_msir's chip_data have been stored the pointer to struct mpic. We add a struct fsl_msi_cascade_data to store the pointer to struct fsl_msi and msir_index in hanler_data. Otherwise, the pointer to struct mpic will be over-written, and will cause problem when calling eo

Re: [PATCH v4] perf: Split out arch specific code & improve PowerPC perf probe support

2010-04-20 Thread Ian Munsie
Excerpts from Ian Munsie's message of Tue Apr 20 16:58:31 +1000 2010: > Here's the 4th version of the perf probe PowerPC support and perf arch > specific > infrastructure patches rebased on top of tip/perf/core. That should read "rebased on top of tip/master". Cheers, -Ian __

[PATCH v4 2/2] perf probe: Add PowerPC DWARF register number mappings

2010-04-20 Thread Ian Munsie
From: Ian Munsie This patch adds mappings from the register numbers from DWARF to the register names used in the PowerPC Regs and Stack Access API. This allows perf probe to be used to record variable contents on PowerPC. This patch depends on functionality in the powerpc/next tree, though it wi