Re: [PATCH 1/3] Fix Unlikely(x) == y

On Sat, Feb 16, 2008 at 09:42:26AM -0800, Arjan van de Ven wrote: > On Sat, 16 Feb 2008 18:33:16 +0100 > Willy Tarreau <[EMAIL PROTECTED]> wrote: > > > On Sat, Feb 16, 2008 at 09:25:52AM -0800, Arjan van de Ven wrote: > > > On Sat, 16 Feb 2008 17:08:01 +0100 > > > Roel Kluin <[EMAIL PROTECTED]> wr

Re: [PATCH 1/3] Fix Unlikely(x) == y

On Sat, Feb 16, 2008 at 09:25:52AM -0800, Arjan van de Ven wrote: > On Sat, 16 Feb 2008 17:08:01 +0100 > Roel Kluin <[EMAIL PROTECTED]> wrote: > > > The patch below was not yet tested. If it's correct as it is, please > > comment. --- > > Fix Unlikely(x) == y > > > > you found a great set of bug

Re: [PATCH 2/2] i2c-ibm_iic driver

Jean Delvare wrote: > Hi Sean, > > On Fri, 15 Feb 2008 23:11:12 -0500, Sean MacLennan wrote: > >> Here is the of platform patch. I removed the retries and removed the spaces >> used for spacing. >> >> Cheers, >>Sean >> >> Signed-off-by: Sean MacLennan <[EMAIL PROTECTED]> >> > > First o

Re: [PATCH 1/3] Fix Unlikely(x) == y

On 02/16/2008 08:08 AM, Roel Kluin wrote: > The patch below was not yet tested. If it's correct as it is, please comment. > - if (unlikely(plug) == NO_IRQ) { > + if (unlikely(plug == NO_IRQ)) { A good catch! I'll put it in with some other 2.6.25 bug fixes. -Geoff __

Re: [PATCH 1/3] Fix Unlikely(x) == y

On Sat, 16 Feb 2008 10:31:26 -0800 Geoff Levand <[EMAIL PROTECTED]> wrote: > On 02/16/2008 09:42 AM, Arjan van de Ven wrote: > > On Sat, 16 Feb 2008 18:33:16 +0100 > > Willy Tarreau <[EMAIL PROTECTED]> wrote: > > > >> On Sat, Feb 16, 2008 at 09:25:52AM -0800, Arjan van de Ven wrote: > >> > On Sat

Re: [PATCH 1/3] Fix Unlikely(x) == y

On 02/16/2008 09:42 AM, Arjan van de Ven wrote: > On Sat, 16 Feb 2008 18:33:16 +0100 > Willy Tarreau <[EMAIL PROTECTED]> wrote: > >> On Sat, Feb 16, 2008 at 09:25:52AM -0800, Arjan van de Ven wrote: >> > On Sat, 16 Feb 2008 17:08:01 +0100 >> > Roel Kluin <[EMAIL PROTECTED]> wrote: >> > >> > > The

Re: [PATCH 1/3] Fix Unlikely(x) == y

On Sat, 16 Feb 2008 18:58:49 +0100 > > If you think unlikely() means something else, we should fix what it > > maps to towards gcc ;) (to.. be empty ;) > > eventhough the gcc docs say it's just a hint to help the compiler > optimize the branch it takes by default, I too have noticed that it > more

Re: [PATCH 1/3] Fix Unlikely(x) == y

On Sat, 16 Feb 2008 18:33:16 +0100 Willy Tarreau <[EMAIL PROTECTED]> wrote: > On Sat, Feb 16, 2008 at 09:25:52AM -0800, Arjan van de Ven wrote: > > On Sat, 16 Feb 2008 17:08:01 +0100 > > Roel Kluin <[EMAIL PROTECTED]> wrote: > > > > > The patch below was not yet tested. If it's correct as it is,

[PATCH]2.6.25-rc2-mm1 - Build Failure at security/keys/compat.c on powerpc

Hi Andrew, The 2.6.25-rc2-mm1 kernel build fails on the powerpc(s) CC security/keys/compat.o security/keys/compat.c: In function ‘compat_sys_keyctl’: security/keys/compat.c:83: error: implicit declaration of function ‘keyctl_get_security’ make[2]: *** [security/keys/compat.o] Error 1 mak

Re: [PATCH 1/3] Fix Unlikely(x) == y

On Sat, 16 Feb 2008 17:08:01 +0100 Roel Kluin <[EMAIL PROTECTED]> wrote: > The patch below was not yet tested. If it's correct as it is, please > comment. --- > Fix Unlikely(x) == y > you found a great set of bugs.. but to be honest... I suspect it's just best to remove unlikely altogether for

[PATCH 1/3] Fix Unlikely(x) == y

The patch below was not yet tested. If it's correct as it is, please comment. --- Fix Unlikely(x) == y Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> --- diff --git a/arch/powerpc/platforms/ps3/interrupt.c b/arch/powerpc/platforms/ps3/interrupt.c index 3a6db04..a14e5cd 100644 --- a/arch/powerpc/pl

Re: [BUID_FAILURE] next-20080215 Build failure caused by ide: rework PowerMac media-bay support

On Friday 15 February 2008, Kamalesh Babulal wrote: > The linux-next-20080215 kernel build fails on the powerpc with > following error > > CC arch/powerpc/platforms/powermac/setup.o > In file included from arch/powerpc/platforms/powermac/setup.c:66: > include/asm/mediabay.h:29: error: synt

Please pull 'for-2.6.25' branch of 4xx tree

Hi Paul, Please pull from: master.kernel.org:/pub/scm/linux/kernel/git/jwboyer/powerpc-4xx.git for-2.6.25 to pick up a few fixes and some defconfig cleanups for .25. The netdev patch was Acked by Ben and Jeff asked we take it through the powerpc tree. The diffstat is bloated from the defconfi

Re: [PATCH 1/2] fb: add support for foreign endianness

On Tue, 2008-02-05 at 18:44 +0300, Anton Vorontsov wrote: > This patch adds support for the framebuffers with non-native > endianness. This is done via FBINFO_FOREIGN_ENDIAN flag that will > be used by the drivers. Depending on the host endianness this flag > will be overwritten by FBINFO_BE_MATH

Re: [PATCH] prom.c: Fix dt_mem_next_cell() to read the full mem cells

On Fri, 2008-02-15 at 12:17 -0600, Becky Bruce wrote: > dt_mem_next_cell() currently does of_read_ulong(). This does > not allow for the case where #size-cells and/or #address-cells = 2 on > a 32-bit system, as it will end up reading 32 bits instead of the > expected 64. Change it to use of_read_

Re: [PATCH 2/2] i2c-ibm_iic driver

Hi Sean, On Fri, 15 Feb 2008 23:11:12 -0500, Sean MacLennan wrote: > Here is the of platform patch. I removed the retries and removed the spaces > used for spacing. > > Cheers, >Sean > > Signed-off-by: Sean MacLennan <[EMAIL PROTECTED]> First of all: please run scripts/checkpatch.pl on you

Re: [PATCH 1/2] i2c-ibm_iic driver

On Fri, 15 Feb 2008 23:07:21 -0500, Sean MacLennan wrote: > Jean Delvare wrote: > > Please split your patch into logical parts: > > * Whitespace and coding-style cleanups > > * Other cleanups (e.g. changing the log levels) > > * Add OF support > > > Here is the first patch with everything except