Yoann Padioleau writes:
> When comparing a pointer, it's clearer to compare it to NULL than to 0.
As other people have said, if you're going to spend time on this,
testing (!buf) is more idiomatic in the kernel than (buf == NULL).
Paul.
___
Linuxppc-de
On Sat, 28 Jul 2007 08:26:47 +1000
Benjamin Herrenschmidt <[EMAIL PROTECTED]> wrote:
> On Sat, 2007-07-28 at 00:11 +0200, Rutger Nijlunsing wrote:
> > > Kim
> > >
> > > p.s. should the stable team be notified to fix 2.6.22 for
> > > Lombard-nvram-style machines?
> >
> > Logically, yes.
> >
>
On Thu, 26 Jul 2007 19:04:17 -0500
Kim Phillips wrote:
> On Wed, 25 Jul 2007 21:43:12 +0400
> Vitaly Bordug <[EMAIL PROTECTED]> wrote:
>
> >
> > Gianfar driver is now able to work without real phy subnode,
> > that is necessary to cope with fixed-link situation, when
> > SoC is connected to the
On Fri, 27 Jul 2007 13:24:59 -0500
Jon Loeliger wrote:
> Signed-off-by: Jon Loeliger <[EMAIL PROTECTED]>
Acked-by: Vitaly Bordug <[EMAIL PROTECTED]>
--
Sincerely, Vitaly
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman
On Sat, 2007-07-28 at 00:11 +0200, Rutger Nijlunsing wrote:
> > Kim
> >
> > p.s. should the stable team be notified to fix 2.6.22 for
> > Lombard-nvram-style machines?
>
> Logically, yes.
>
> Practically it does not matter that much it seems. I've got the
> feeling the Lombard-users-group-size
On Fri, Jul 27, 2007 at 01:25:09PM -0500, Jon Loeliger wrote:
> Signed-off-by: Jon Loeliger <[EMAIL PROTECTED]>
FWIW for the prpmc2800 part...
Acked-by: Mark A. Greer <[EMAIL PROTECTED]>
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozla
> Kim
>
> p.s. should the stable team be notified to fix 2.6.22 for
> Lombard-nvram-style machines?
Logically, yes.
Practically it does not matter that much it seems. I've got the
feeling the Lombard-users-group-size is about one person which is
going to drop to zero if he doesn't get any furth
Jan-Bernd Themann wrote:
> On Wednesday 25 July 2007 19:17, Andrew Gallatin wrote:
>> 3) Padded frames.
>>
>> I may be missing something, but I don't see where you
>> either strip padding from frames or reject padded frames.
>> (see the pskb_trim_rcsum() in net/ipv4/ip_input.c:ip_rcv()
>>
Grant Likely wrote:
> Mild question; What the [EMAIL PROTECTED] are you doing trying to backport to
> a
> 2 year old kernel?!? :-)
That's what happens in the embedded space. It's the current version
from our distro vendor. It's also the version that all our different
board suppliers could a
Signed-off-by: Jon Loeliger <[EMAIL PROTECTED]>
---
arch/powerpc/platforms/embedded6xx/holly.c | 12
arch/powerpc/platforms/embedded6xx/prpmc2800.c |7 ---
2 files changed, 0 insertions(+), 19 deletions(-)
diff --git a/arch/powerpc/platforms/embedded6xx/holly.c
b/arch/
Signed-off-by: Jon Loeliger <[EMAIL PROTECTED]>
---
arch/powerpc/platforms/8xx/mpc86xads_setup.c | 14 --
arch/powerpc/platforms/8xx/mpc885ads_setup.c | 14 --
2 files changed, 0 insertions(+), 28 deletions(-)
diff --git a/arch/powerpc/platforms/8xx/mpc86xads_setup.c
Signed-off-by: Jon Loeliger <[EMAIL PROTECTED]>
---
arch/powerpc/platforms/52xx/lite5200.c | 13 ++---
1 files changed, 2 insertions(+), 11 deletions(-)
diff --git a/arch/powerpc/platforms/52xx/lite5200.c
b/arch/powerpc/platforms/52xx/lite5200.c
index 5c46e89..84bd3da 100644
--- a/arch
Signed-off-by: Jon Loeliger <[EMAIL PROTECTED]>
---
arch/powerpc/platforms/85xx/mpc85xx_ads.c | 13 -
arch/powerpc/platforms/85xx/mpc85xx_cds.c | 13 -
arch/powerpc/platforms/85xx/mpc85xx_mds.c | 11 ---
3 files changed, 0 insertions(+), 37 deletions(-)
diff
Signed-off-by: Jon Loeliger <[EMAIL PROTECTED]>
---
Note -- This is a rebased version of an earlier patch
from July 17. That one can be dropped.
arch/powerpc/platforms/86xx/mpc86xx_hpcn.c | 14 ++
1 files changed, 2 insertions(+), 12 deletions(-)
diff --git a/arch/power
This patch series removes lingering jiffies initialization
code from several platforms. Note that the first patch in
this series for the 86xx has been rebased to current top of
Paul's repository and replaces an earlier version.
arch/powerpc/platforms/52xx/lite5200.c | 13 ++---
Alexandros Kostopoulos wrote:
> Thanks for your reply, Scott,
>
> one question though: I am NOT using the bootwrapper, I'm instead
> feeding dtb and uImage directly to u-boot. This probably means that
> I should fill in lots of stuff manually into dts, right?
No, u-boot should fill in the same
Thanks for your reply, Scott,
one question though: I am NOT using the bootwrapper, I'm instead feeding
dtb and uImage directly to u-boot. This probably means that I should fill
in lots of stuff manually into dts, right? But, (and please forgive my
ignorance) who does actually fill in stuff (
On Fri, Jul 27, 2007 at 03:24:08PM +0300, Alexandros Kostopoulos wrote:
> In your patch for the pq2fads support, the device tree seems to be missing
> a memory node, for which dtc complains loudly. Is this board tested to
> boot with these patches (because I'm now using this as a template for m
On Fri, Jul 27, 2007 at 03:45:59PM +0400, Anton Vorontsov wrote:
> Sure, technically nothing prevents this. But, QE specs names
> SPIs by these ids. Plus, from the kernel side spi name will be
> not pretty, it will be spi1216.1. Reg value making little sense
> to the userspace (or kernel-side SPI l
> > This patch fixes arch/ppc kernels, at least for prep subarch, after
> > build-id addition. Without the patch, kernels were 3 times the size and
> > bootloader refused to load them. Now they are back to normal again.
>
> I just built an ARCH=ppc kernel for the prep subarch and the vmlinux
> s
On Jul 27, 2007, at 6:45 AM, Anton Vorontsov wrote:
> On Fri, Jul 27, 2007 at 03:14:06AM -0500, Kumar Gala wrote:
>>
>> On Jul 26, 2007, at 8:57 AM, Anton Vorontsov wrote:
> [...]
>>>
>>> @@ -207,20 +222,36 @@
>>>
>>> [EMAIL PROTECTED] {
>>> device_type = "spi";
>>
On Fri, Jul 27, 2007 at 01:32:27AM -0500, Kumar Gala wrote:
>
> On Jul 26, 2007, at 8:13 AM, Anton Vorontsov wrote:
>
>> Documentation clearly states, that mode should not be changed
>> till SPMODE_ENABLE bit set. I've seen hangs w/o this patch.
>
> Out of interest what board/part do you see the ha
On Thu, Jul 26, 2007 at 08:07:07PM -0700, David Brownell wrote:
> On Thursday 26 July 2007, Anton Vorontsov wrote:
> > Loopback mode is supported by various controllers, this mode
> > is useful for testing, especially in conjunction with spidev
> > driver.
>
> ISTR that Stephen Street provided a l
Just to chime in...
In general, I like where this LRO effort is going, and I really
appreciate you guys working on it.
Jeff
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
Hi Drew,
thanks a lot for your good feedback. See comments below.
I'll try to provide an updated version next week. It would
be nice if you could post a patch for your driver once
we have addressed the issues you mentioned. Then we would
have the eHEA driver for the SKB interface, and your driver
Hello Scott and all,
In your patch for the pq2fads support, the device tree seems to be missing
a memory node, for which dtc complains loudly. Is this board tested to
boot with these patches (because I'm now using this as a template for my
board - with your patchset applied to Paul's git)
t
When comparing a pointer, it's clearer to compare it to NULL than to 0.
Here is an excerpt of the semantic patch:
@@
expression *E;
@@
E ==
- 0
+ NULL
@@
expression *E;
@@
E !=
- 0
+ NULL
Signed-off-by: Yoann Padioleau <[EMAIL PROTECTED]>
Cc: [EMAIL PROTECTED]
Cc: linuxppc-dev@ozlabs.or
David Brownell wrote:
> On Thursday 26 July 2007, Anton Vorontsov wrote:
>> Loopback mode is supported by various controllers, this mode
>> is useful for testing, especially in conjunction with spidev
>> driver.
>
> ISTR that Stephen Street provided a loopback mode for debug
> in his pxa2xx_spi co
On Fri, Jul 27, 2007 at 03:14:06AM -0500, Kumar Gala wrote:
>
> On Jul 26, 2007, at 8:57 AM, Anton Vorontsov wrote:
[...]
>>
>> @@ -207,20 +222,36 @@
>>
>> [EMAIL PROTECTED] {
>> device_type = "spi";
>> +device-id = <1>;
>
> Can we just use the
On Thu, Jul 26, 2007 at 11:45:08AM -0500, Scott Wood wrote:
> On Thu, Jul 26, 2007 at 05:56:55PM +0400, Anton Vorontsov wrote:
> > +void (*fsl_spi_activate_cs)(u8 cs, u8 polarity) = NULL;
> > +EXPORT_SYMBOL(fsl_spi_activate_cs);
> > +void (*fsl_spi_deactivate_cs)(u8 cs, u8 polarity) = NULL;
> > +EX
On Fri, Jul 27, 2007 at 12:54:50PM +0200, Hoang-Nam Nguyen wrote:
> >From b5d0336089b5ebe5b18acb94b2c94c2026cb95ee Mon Sep 17 00:00:00 2001
> From: Hoang-Nam Nguyen
> Date: Fri, 27 Jul 2007 10:24:49 +0200
> Subject: [PATCH] remove checkpatch.pl's warnings "externs should be avoided
> in .c files"
>From a2794450cbee597cefd7b6e159257583c459d358 Mon Sep 17 00:00:00 2001
From: Hoang-Nam Nguyen
Date: Fri, 27 Jul 2007 10:26:40 +0200
Subject: [PATCH] correction include order according kernel coding style
Signed-off-by: Hoang-Nam Nguyen <[EMAIL PROTECTED]>
---
drivers/infiniband/hw/ehca/ehca_mrm
>From b5d0336089b5ebe5b18acb94b2c94c2026cb95ee Mon Sep 17 00:00:00 2001
From: Hoang-Nam Nguyen
Date: Fri, 27 Jul 2007 10:24:49 +0200
Subject: [PATCH] remove checkpatch.pl's warnings "externs should be avoided in
.c files"
Signed-off-by: Hoang-Nam Nguyen <[EMAIL PROTECTED]>
---
drivers/infiniban
Hello Roland!
This small patch set fixes some coding-style related issues for ehca:
[1/2] remove checkpatch.pl's warnings "externs should be avoided in .c files"
[2/2] correction include order according kernel coding style
Thanks
Nam
___
Linuxppc-dev mai
On Thu, Jul 26, 2007 at 11:48:33AM -0500, Scott Wood wrote:
> On Thu, Jul 26, 2007 at 06:01:39PM +0400, Anton Vorontsov wrote:
> > If CONFIG_PCI undefined, np will be used uninitialized, thereby
> > find_node_by_name(np, "par_io") will fail.
>
> This is the wrong fix -- you should be passing NULL
Hi, Kumar,
> + RapidIO is a definition of a system interconnect. This node add
> > + the support for RapidIO processor in kernel. The node name is
> > + suggested to be 'rapidio'.
> > +
> > + Required properties:
> > +
> > +- compatible : Using "fsl,rapidio-delta" for Freescale PowerPC
Hi, Kumar,
> -Original Message-
> From: Kumar Gala [mailto:[EMAIL PROTECTED]
> On Jul 26, 2007, at 3:42 AM, Zhang Wei wrote:
>
> > This patch adds the RapidIO support to the powerpc architecture.
> > Some files are moved from ppc. OF-tree and OF-device supports are
> > added.
> > New
On Jul 26, 2007, at 8:56 AM, Anton Vorontsov wrote:
> Signed-off-by: Anton Vorontsov <[EMAIL PROTECTED]>
> ---
> arch/powerpc/sysdev/fsl_soc.c | 76 ++
> +++
> arch/powerpc/sysdev/fsl_soc.h |3 ++
> 2 files changed, 79 insertions(+), 0 deletions(-)
The
On Jul 26, 2007, at 3:42 AM, Zhang Wei wrote:
> Add the explanation and a sample of RapidIO OF node to the document
> of booting-without-of.txt file.
>
> Signed-off-by: Zhang Wei <[EMAIL PROTECTED]>
> ---
> Documentation/powerpc/booting-without-of.txt | 37 +++
> +++
> 1
On Jul 26, 2007, at 3:42 AM, Zhang Wei wrote:
> These patches are the version 3 patches for RapidIO with dts update
> and some minor fixups.
>
> These patches are used for supporting RapidIO controllers of
> Freescale. I ported them from ppc architecture to powerpc
> architecture and added
On Jul 26, 2007, at 3:42 AM, Zhang Wei wrote:
> This patch adds the RapidIO support to the powerpc architecture.
> Some files are moved from ppc. OF-tree and OF-device supports are
> added.
> New silicons such as MPC8548, MPC8641 with serial RapidIO
> controller are
> all supported.
> Memory
On Jul 26, 2007, at 8:57 AM, Anton Vorontsov wrote:
> mmc_spi already tested to work. When it will hit mainline
> the only change that would be needed is replacing "spidev"
> by "mmc_spi", and adding trivial platform data to mmc_spi
> driver.
>
> Signed-off-by: Anton Vorontsov <[EMAIL PROTECTED]>
On Thu, 26 Jul 2007 16:42:51 +0800 Zhang Wei <[EMAIL PROTECTED]> wrote:
>
> +
> +#include <../sysdev/fsl_rio.h>
This can just be if it is only built on 32bit.
--
Cheers,
Stephen Rothwell[EMAIL PROTECTED]
http://www.canb.auug.org.au/~sfr/
pgpL5SvXHQwYf.pgp
Description: PGP
On Thu, 26 Jul 2007 16:42:50 +0800 Zhang Wei <[EMAIL PROTECTED]> wrote:
>
> +#include
> +#include
These should now be and
--
Cheers,
Stephen Rothwell[EMAIL PROTECTED]
http://www.canb.auug.org.au/~sfr/
pgpCKN1ECtg5T.pgp
Description: PGP signature
On Jul 26, 2007, at 2:40 PM, Joakim Tjernlund wrote:
>
>
>> -Original Message-
>> From: Anton Vorontsov [mailto:[EMAIL PROTECTED]
>> Sent: den 26 juli 2007 17:48
>> To: Joakim Tjernlund
>> Cc: linuxppc-dev@ozlabs.org
>> Subject: Re: [RFC][PATCH] MPC832x_RDB: update dts to use spi,
>> regi
On Jul 26, 2007, at 12:05 PM, Vitaly Bordug wrote:
> On Thu, 26 Jul 2007 11:45:08 -0500
> Scott Wood <[EMAIL PROTECTED]> wrote:
>
>> On Thu, Jul 26, 2007 at 05:56:55PM +0400, Anton Vorontsov wrote:
>>> +void (*fsl_spi_activate_cs)(u8 cs, u8 polarity) = NULL;
>>> +EXPORT_SYMBOL(fsl_spi_activate_cs
On Fri, 2007-07-27 at 01:46 -0500, Kumar Gala wrote:
> On Jul 27, 2007, at 1:36 AM, Nicolas Mederle wrote:
>
> > Hi,
> >
> >I want to know how the kernel switch the task. Because my
> > kernel
> > start very well, and it launch the init.d. With the log, i can see
> > that
> > the kern
On Thu, 2007-07-26 at 21:22 -0700, Andrew Morton wrote:
>
> > Merged a fixed version:
> >
> > f5d834fc34e61f1a40435981062000e5d2b2baa8
> >
> > (In linus tree as of now)
>
> I hope so. Alan's patch looks rather different from what you have
> now:
> fall back to of_find_node_by_name() if of_find
48 matches
Mail list logo
