On Thu, 19 Jul 2007 03:38:04 +0400 Vitaly Bordug <[EMAIL PROTECTED]> wrote:
>
> device_bind_driver() error code returning has been fixed.
> release() function has been written, so that to free resources
> in correct way; the release path is now clean.
>
> Before the rework, it used to cause
On Fri, 20 Jul 2007 07:58:38 +0200 Segher Boessenkool <[EMAIL PROTECTED]> wrote:
>
> ...since it modifies it (when it sets the OF_DETACHED flag).
http://patchwork.ozlabs.org/linuxppc/patch?q=Stephen%20Rothwell&id=12212
--
Cheers,
Stephen Rothwell[EMAIL PROTECTED]
http://www.c
Hi Linus,
Please pull the Open Firmware device tree consolidation patches from the
master branch of
git://git.kernel.org/pub/scm/linux/kernel/git/sfr/ofcons.git master
The intention here is that there should be no behavioural changes and
minimal code changes (apart from movement of the code to
...since it modifies it (when it sets the OF_DETACHED flag).
Signed-off-by: Segher Boessenkool <[EMAIL PROTECTED]>
---
arch/powerpc/kernel/prom.c |2 +-
include/asm-powerpc/prom.h |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/kernel/prom.c b/arch/power
From: Stephen Rothwell <[EMAIL PROTECTED]>
Date: Fri, 20 Jul 2007 01:20:32 +1000
> and populate it with the common parts from PowerPC and Sparc[64].
>
> Signed-off-by: Stephen Rothwell <[EMAIL PROTECTED]>
Acked-by: David S. Miller <[EMAIL PROTECTED]>
All tested on SunBlade1500.
Please push thi
From: Stephen Rothwell <[EMAIL PROTECTED]>
Date: Fri, 20 Jul 2007 01:19:25 +1000
> Move common stuff from asm-powerpc/of_platform.h to here and
> move the common bits from asm-sparc*/of_device.h here as well.
>
> Create asm-sparc*/of_platform.h and move appropriate parts of
> of_device.h to them.
From: Stephen Rothwell <[EMAIL PROTECTED]>
Date: Fri, 20 Jul 2007 01:17:08 +1000
> This just moves the common stuff from the arch of_device.h files to
> linux/of_device.h.
>
> Signed-off-by: Stephen Rothwell <[EMAIL PROTECTED]>
Acked-by: David S. Miller <[EMAIL PROTECTED]>
Tested on SunBlade150
From: Stephen Rothwell <[EMAIL PROTECTED]>
Date: Fri, 20 Jul 2007 01:16:12 +1000
> This moves all the common parts for the Sparc, Sparc64 and PowerPC
> of_device.c files into drivers/of/device.c.
>
> Apart from the simple move, Sparc gains of_match_node() and a call to
> of_node_put in of_release
From: Stephen Rothwell <[EMAIL PROTECTED]>
Date: Fri, 20 Jul 2007 01:14:50 +1000
> This consolidates the routines of_find_node_by_path, of_find_node_by_name,
> of_find_node_by_type and of_find_compatible_device. Again, the comparison
> of strings are done differently by Sparc and PowerPC and also
On Jul 19, 2007, at 10:11 PM, Josh Boyer wrote:
> The recent signal rework broke ARCH=ppc builds with the following
> error:
>
> CC arch/powerpc/kernel/signal.o
> arch/powerpc/kernel/signal.c: In function ‘do_signal’:
> arch/powerpc/kernel/signal.c:142: error: implicit declaration of
> f
>From ehea_start_xmit in ehea_main.c we have:
if (unlikely(atomic_read(&pr->swqe_avail) <= 1)) {
spin_lock_irqsave(&pr->netif_queue, flags);
if (unlikely(atomic_read(&pr->swqe_avail) <= 1)) {
pr->p_stats.queue_stopped++;
netif_sto
The recent signal rework broke ARCH=ppc builds with the following error:
CC arch/powerpc/kernel/signal.o
arch/powerpc/kernel/signal.c: In function ‘do_signal’:
arch/powerpc/kernel/signal.c:142: error: implicit declaration of function
‘set_dabr’
make[1]: *** [arch/powerpc/kernel/signal.o] Err
Scott Wood wrote:
> Kim Phillips wrote:
>> the old FLAT_TREE u-boot fdt fixup code renames any existing chosen
>> node out of the way, and adds its fixed up version as /chosen.
Not in my experience. My experience is that it blindly created a second
/chosen node.
>> The LIBFDT implementation rep
From: Stephen Rothwell <[EMAIL PROTECTED]>
Date: Fri, 20 Jul 2007 01:13:48 +1000
> This adds a read_lock around the child/next accesses on Sparc.
>
> Signed-off-by: Stephen Rothwell <[EMAIL PROTECTED]>
Acked-by: David S. Miller <[EMAIL PROTECTED]>
Tested on SunBlade1500.
___
From: Stephen Rothwell <[EMAIL PROTECTED]>
Date: Fri, 20 Jul 2007 01:12:35 +1000
> This requires creating dummy of_node_{get,put} routines for sparc and
> sparc64. It also adds a read_lock around the parent accesses.
>
> Signed-off-by: Stephen Rothwell <[EMAIL PROTECTED]>
Acked-by: David S. Mil
From: Stephen Rothwell <[EMAIL PROTECTED]>
Date: Fri, 20 Jul 2007 01:11:27 +1000
> The only change here is that a readlock is taken while the property list
> is being traversed on Sparc where it was not taken previously.
>
> Also, Sparc uses strcasecmp to compare property names while PowerPC
> us
From: Stephen Rothwell <[EMAIL PROTECTED]>
Date: Fri, 20 Jul 2007 01:10:12 +1000
> The only difference here is that Sparc uses strncmp to match compatibility
> names while PowerPC uses strncasecmp.
>
> Signed-off-by: Stephen Rothwell <[EMAIL PROTECTED]>
Acked-by: David S. Miller <[EMAIL PROTECTE
Segher Boessenkool writes:
> Should you really be testing VM_READ|VM_WRITE, or should it just
> be VM_READ?
We test VM_READ | VM_WRITE | VM_EXEC in the read case below, and that
is because we have no HPTE encoding to say "writable but not readable"
or "executable but not readable". Similarly we
Stephen Rothwell writes:
> This creates linux/of.h and includes asm/prom.h from it.
>
> We also include linux/of.h from asm/prom.h while we transition.
>
> Signed-off-by: Stephen Rothwell <[EMAIL PROTECTED]>
Acked-by: Paul Mackerras <[EMAIL PROTECTED]>
for all 12 of the series.
___
From: Stephen Rothwell <[EMAIL PROTECTED]>
Date: Fri, 20 Jul 2007 01:09:11 +1000
> This creates drivers/of/base.c (depending on CONFIG_OF) and puts
> the first trivially common bits from the prom.c files into it.
>
> Signed-off-by: Stephen Rothwell <[EMAIL PROTECTED]>
Acked-by: David S. Miller <
On Thu, 19 Jul 2007, Stefan Richter wrote:
> Geert Uytterhoeven wrote:
> > On Wed, 18 Jul 2007, Jan Engelhardt wrote:
> >> Add some help texts to recently-introduced kconfig items
> >>
> >> Index: linux-2.6.23/drivers/macintosh/Kconfig
> >> ==
From: Stephen Rothwell <[EMAIL PROTECTED]>
Date: Fri, 20 Jul 2007 01:07:42 +1000
> This creates linux/of.h and includes asm/prom.h from it.
>
> We also include linux/of.h from asm/prom.h while we transition.
>
> Signed-off-by: Stephen Rothwell <[EMAIL PROTECTED]>
Acked-by: David S. Miller <[EMA
On Jul 19, 2007, at 4:30 PM, Andrew Morton wrote:
> On Thu, 19 Jul 2007 16:04:38 -0500
> Kumar Gala <[EMAIL PROTECTED]> wrote:
>
Andrew,
Are you sending this to linus directly or should this go via
paul and
me?
>>>
>>> I queued it up for Paul. I can send it over t
Kumar Gala wrote:
> On Jul 19, 2007, at 4:47 PM, Geoff Levand wrote:
>
>> The PS3 bootwrapper files use instructions only available on
>> 64-bit CPUs. Add the code generation directive '.machine "ppc64"'
>> for toolchains configured for 32-bit CPUs.
>>
>> Signed-off-by: Geoff Levand <[EMAIL PROTE
On Thu, Jul 19, 2007 at 11:50:49PM +0200, Christoph Hellwig wrote:
>
> Signed-off-by: Christoph Hellwig <[EMAIL PROTECTED]>
Acked-by: Mark A. Greer <[EMAIL PROTECTED]>
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/list
* Andrew Morton ([EMAIL PROTECTED]) wrote:
> On Thu, 19 Jul 2007 16:04:38 -0500
> Kumar Gala <[EMAIL PROTECTED]> wrote:
>
> > >> Andrew,
> > >>
> > >> Are you sending this to linus directly or should this go via paul and
> > >> me?
> > >>
> > >
> > > I queued it up for Paul. I can send it over to
On Thu, 19 Jul 2007 16:44:27 -0500
Scott Wood <[EMAIL PROTECTED]> wrote:
> Kim Phillips wrote:
> > the old FLAT_TREE u-boot fdt fixup code renames any existing chosen
> > node out of the way, and adds its fixed up version as /chosen.
> >
> > The LIBFDT implementation replaces any existing /chosen
On 7/19/07, Geoff Levand <[EMAIL PROTECTED]> wrote:
> The PS3 bootwrapper files use instructions only available on
> 64-bit CPUs. Add the code generation directive '.machine "ppc64"'
> for toolchains configured for 32-bit CPUs.
>
> Signed-off-by: Geoff Levand <[EMAIL PROTECTED]>
Acked-by: Grant Li
On 7/19/07, Kim Phillips <[EMAIL PROTECTED]> wrote:
> On Thu, 19 Jul 2007 13:43:17 -0600
> "Grant Likely" <[EMAIL PROTECTED]> wrote:
>
> > On 7/19/07, Scott Wood <[EMAIL PROTECTED]> wrote:
> > > Grant Likely wrote:
> > > > From: Grant Likely <[EMAIL PROTECTED]>
> > > >
> > > > To boot from a cuImag
On Thu, 19 Jul 2007, Segher Boessenkool wrote:
> > > Your device is an rs5c372b. So, that's what you put in
> > > your device tree. Simple so far, right?
> > >
> > > Now some OF I2C code goes looking for IIC devices in the
> > > device tree. It finds this thing, and from a table or
> > > somet
On Jul 19, 2007, at 4:47 PM, Geoff Levand wrote:
> The PS3 bootwrapper files use instructions only available on
> 64-bit CPUs. Add the code generation directive '.machine "ppc64"'
> for toolchains configured for 32-bit CPUs.
>
> Signed-off-by: Geoff Levand <[EMAIL PROTECTED]>
while this is a fi
Signed-off-by: Christoph Hellwig <[EMAIL PROTECTED]>
Index: linux-2.6/arch/ppc/syslib/mv64x60.c
===
--- linux-2.6.orig/arch/ppc/syslib/mv64x60.c2007-07-19 22:47:07.0
+0200
+++ linux-2.6/arch/ppc/syslib/mv64x60.c 2007-07-
The PS3 bootwrapper files use instructions only available on
64-bit CPUs. Add the code generation directive '.machine "ppc64"'
for toolchains configured for 32-bit CPUs.
Signed-off-by: Geoff Levand <[EMAIL PROTECTED]>
---
Paul,
Please apply for 2.6.23-rc1.
arch/powerpc/boot/ps3-head.S |2
> commit id bafdb645779c63300763acb383f7b9dd2d427228 (on Linus' tree)
> causes breakage on my mpc8349 build (see below). I've worked around
> it by removing ps3* from arch/powerpc/boot/Makefile, but I have not
> dug into what the 'proper' solution should be.
> arch/powerpc/boot/ps3-head.S:40: Err
Kim Phillips wrote:
> the old FLAT_TREE u-boot fdt fixup code renames any existing chosen
> node out of the way, and adds its fixed up version as /chosen.
>
> The LIBFDT implementation replaces any existing /chosen with its fixed
> up version.
Could you point out the code that does this? I don't
On Thu, 19 Jul 2007 13:43:17 -0600
"Grant Likely" <[EMAIL PROTECTED]> wrote:
> On 7/19/07, Scott Wood <[EMAIL PROTECTED]> wrote:
> > Grant Likely wrote:
> > > From: Grant Likely <[EMAIL PROTECTED]>
> > >
> > > To boot from a cuImage requires the device tree to have a
> > > linux,stdout-path proper
On Thu, 2007-07-19 at 19:07 +0200, Segher Boessenkool wrote:
>
> So your plan is to prefer the device tree over the cputable, and
> maybe even deprecate the cputable?
Nah, you are fine not putting anything, but if it's in the DT it should
be correct, not "0". Else, just don't put it in the DT.
On Thu, 19 Jul 2007 16:04:38 -0500
Kumar Gala <[EMAIL PROTECTED]> wrote:
> >> Andrew,
> >>
> >> Are you sending this to linus directly or should this go via paul and
> >> me?
> >>
> >
> > I queued it up for Paul. I can send it over to Linus today if we
> > have a
> > reason for that. It's just
On Jul 19, 2007, at 4:10 PM, Kim Phillips wrote:
> On Fri, 13 Jul 2007 20:44:57 +0200
> Arnd Bergmann <[EMAIL PROTECTED]> wrote:
>
>> MPC83xx based machines don't need their own kernel,
>> but can run one that is shared with the other 6xx
>> compatible machines, so we should allow that
>> in Kcon
On Fri, 13 Jul 2007 20:44:57 +0200
Arnd Bergmann <[EMAIL PROTECTED]> wrote:
> MPC83xx based machines don't need their own kernel,
> but can run one that is shared with the other 6xx
> compatible machines, so we should allow that
> in Kconfig.
>
> Cc: Kumar Gala <[EMAIL PROTECTED]>
> Signed-off-by
>> Andrew,
>>
>> Are you sending this to linus directly or should this go via paul and
>> me?
>>
>
> I queued it up for Paul. I can send it over to Linus today if we
> have a
> reason for that. It's just that I dont understand the patch: does
> it fix
> -mm-only breakage? Does it fix somethi
Geert Uytterhoeven wrote:
> On Wed, 18 Jul 2007, Jan Engelhardt wrote:
>> Add some help texts to recently-introduced kconfig items
>>
>> Index: linux-2.6.23/drivers/macintosh/Kconfig
>> ===
>> --- linux-2.6.23.orig/drivers/macintosh/Kc
On Jul 19, 2007, at 2:10 PM, Jon Loeliger wrote:
> On Thu, 2007-07-19 at 14:02, Scott Wood wrote:
>
>> glib != glibc.
>>
>> -Scott
>
> D'oh.
>
> So, It doesn't say what version it is.
> But it is also dated 8-Apr-2003.
The glibc jdl tested against is 2.2.5.
- k
_
Grant Likely wrote:
> On 7/19/07, Scott Wood <[EMAIL PROTECTED]> wrote:
>> Grant Likely wrote:
>>> From: Grant Likely <[EMAIL PROTECTED]>
>>>
>>> To boot from a cuImage requires the device tree to have a
>>> linux,stdout-path property in the chosen node. This patch adds it
>>> to the .dts files.
>
On Wed, 18 Jul 2007, Jan Engelhardt wrote:
> Add some help texts to recently-introduced kconfig items
>
> Index: linux-2.6.23/drivers/macintosh/Kconfig
> ===
> --- linux-2.6.23.orig/drivers/macintosh/Kconfig
> +++ linux-2.6.23/drivers
Kumar Gala wrote:
> On Jul 18, 2007, at 11:32 AM, Scott Wood wrote:
>> Kumar Gala wrote:
>>> Does 'fsl,cpm' really mean anything useful?
>>
>> Yes. It's can't be used on its own to show the complete programming
>> model, but there are lots of common things that it does indicate.
>>
>> get_brgfr
On Thu, 19 Jul 2007 14:55:23 -0500
Kumar Gala <[EMAIL PROTECTED]> wrote:
>
> On Jul 19, 2007, at 12:30 AM, Andrew Morton wrote:
>
> > On Fri, 13 Jul 2007 21:20:33 -0400 Mathieu Desnoyers
> > <[EMAIL PROTECTED]> wrote:
> >
> >> Powerpc - Include pagemap.h in asm/powerpc/tlb.h
> >>
> >> Fixes th
On 7/19/07, Jerry Van Baren <[EMAIL PROTECTED]> wrote:
> I think the "proper" solution is not to add the /chosen node in the dts
> but rather to generate a _correct_ one in u-boot. Note that
> linux,stdout-path is something that _should_ be generated based on the
> u-boot configuration (currently
On Jul 18, 2007, at 1:35 AM, Andy Fleming wrote:
> phy_read() returns a negative number if there's an error, but the
> error-checking code in the Vitesse driver's config_intr function
> triggers if phy_read() returns non-zero. Correct that.
>
> Signed-off-by: Andy Fleming <[EMAIL PROTECTED]>
Je
On Jul 19, 2007, at 12:30 AM, Andrew Morton wrote:
> On Fri, 13 Jul 2007 21:20:33 -0400 Mathieu Desnoyers
> <[EMAIL PROTECTED]> wrote:
>
>> Powerpc - Include pagemap.h in asm/powerpc/tlb.h
>>
>> Fixes this powerpc build error in 2.6.22-rc6-mm1 for powerpc 64 :
>>
>> In file included from includ
commit id bafdb645779c63300763acb383f7b9dd2d427228 (on Linus' tree)
causes breakage on my mpc8349 build (see below). I've worked around
it by removing ps3* from arch/powerpc/boot/Makefile, but I have not
dug into what the 'proper' solution should be.
Cheers,
g.
Toolchain: gcc version 4.0.0 (DENX
On 7/19/07, Scott Wood <[EMAIL PROTECTED]> wrote:
> Grant Likely wrote:
> > From: Grant Likely <[EMAIL PROTECTED]>
> >
> > To boot from a cuImage requires the device tree to have a
> > linux,stdout-path property in the chosen node. This patch adds it
> > to the .dts files.
>
> This will break many
From: Grant Likely <[EMAIL PROTECTED]>
Signed-off-by: Grant Likely <[EMAIL PROTECTED]>
CC: Scott Wood <[EMAIL PROTECTED]>
CC: Kumar Gala <[EMAIL PROTECTED]>
---
arch/powerpc/configs/mpc834x_itx_defconfig | 251 +--
arch/powerpc/configs/mpc834x_itxgp_defconfig | 349 ++
From: Grant Likely <[EMAIL PROTECTED]>
To boot from a cuImage requires the device tree to have a
linux,stdout-path property in the chosen node. This patch adds it
to the .dts files.
Signed-of-by: Grant Likely <[EMAIL PROTECTED]>
CC: Scott Wood <[EMAIL PROTECTED]>
CC: Kumar Gala <[EMAIL PROTECTED
The following series makes the mpc8349emitx* cuImage work 'out of the box'
Major changes are adding the linux,network-index property to the Ethernet
nodes and adding a default linux,stdout-path to the .dts files. With
these changes, a cuImage created by 'make mpc834x_itx_defconfig; make zImage'
sh
From: Grant Likely <[EMAIL PROTECTED]>
cuImage need to know the logical index of the ethernet devices in order
to assign mac addresses. This patch adds the needed properties
Signed-off-by: Grant Likely <[EMAIL PROTECTED]>
CC: Scott Wood <[EMAIL PROTECTED]>
CC: Kumar Gala <[EMAIL PROTECTED]>
---
From: Grant Likely <[EMAIL PROTECTED]>
Signed-off-by: Grant Likely <[EMAIL PROTECTED]>
CC: Scott Wood <[EMAIL PROTECTED]>
CC: Kumar Gala <[EMAIL PROTECTED]>
---
arch/powerpc/boot/devtree.c | 14 +++---
1 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/arch/powerpc/boot/dev
On 19/07/07, Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> wrote:
> On Thursday 19 July 2007, Michal Piotrowski wrote:
>
> > IDE
> >
> > Subject : compile error if CONFIG_BLOCK not enabled related to
> > linux/ide.h include
> > References : http://lkml.org/lkml/2007/7/18/11
> > Last k
On Thursday 19 July 2007, Michal Piotrowski wrote:
> IDE
>
> Subject : compile error if CONFIG_BLOCK not enabled related to
> linux/ide.h include
> References : http://lkml.org/lkml/2007/7/18/11
> Last known good : ?
> Submitter : Kumar Gala <[EMAIL PROTECTED]>
> Caused-By
On Thu, 2007-07-19 at 14:02, Scott Wood wrote:
> glib != glibc.
>
> -Scott
D'oh.
So, It doesn't say what version it is.
But it is also dated 8-Apr-2003.
jdl
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/l
>> Since you are using generic names, the only use for the "name"
>> of a node is for a human reader to understand your tree. Maybe
>> everyone using this specific SoC knows what a BCSR is; or maybe
>> there is a more friendly name you could use.
>
> It's the standard term used in Freescale board
On Thu, Jul 19, 2007 at 01:57:00PM -0500, Jon Loeliger wrote:
> Needless to say, one that showed the problem beforehand. :-)
> But to be precise:
>
> [root:~] ls -lsa /usr/lib/libglib*
>0 lrwxrwxrwx1 18005314 24012 21 Aug 15 2005
> /usr/lib/libglib-1.2.so.0 -> libglib-1.2.so.0.0
Grant Likely wrote:
> From: Grant Likely <[EMAIL PROTECTED]>
>
> To boot from a cuImage requires the device tree to have a
> linux,stdout-path property in the chosen node. This patch adds it
> to the .dts files.
This will break many current u-boots, as they blindly add a /chosen node
regardless
On Thu, 2007-07-19 at 12:16, Segher Boessenkool wrote:
> > Tested on 8641HPCN.
>
> Which glibc versions? glibc-2.4 and newer are fine without the
> patch already, glibc-2.3 seems to get away by accident; but 2.2
> (and before) are the problematic ones.
>
> No other userland program has been ide
Segher Boessenkool wrote:
> Since you are using generic names, the only use for the "name"
> of a node is for a human reader to understand your tree. Maybe
> everyone using this specific SoC knows what a BCSR is; or maybe
> there is a more friendly name you could use.
It's the standard term used
> Hmmm. The dangling else clauses are pretty gross,
I hoped you wouldn't notice. I guess I shouldn't have
commented them :-)
"It was the cleanest thing I could come up with". Every
other thing I tried ended up as a maze of #ifdefs or some
incomprehensible cross-jumping mess; and I was aiming f
On 07/19/2007 11:47 AM, Andrew Morton wrote:
> On Thu, 19 Jul 2007 11:39:32 +0200 (CEST) Geert Uytterhoeven <[EMAIL
> PROTECTED]> wrote:
>
>>> Oh dear.
>>>
>>> ps3rom_priv(dev) = host;
>>>
>>> that's 'orrid. We have an identifier pretending to be a function, only we
>>> go and treat it as a
On 19/07/07, Satyam Sharma <[EMAIL PROTECTED]> wrote:
> > Subject : ext4 build warnings
> > References : http://lkml.org/lkml/2007/7/18/420
> > Last known good : ?
> > Submitter : Jeff Garzik <[EMAIL PROTECTED]>
> > Caused-By : ?
> > Handled-By : Mingming Cao <[EMAIL P
Ragner Magalhaes wrote:
> ext Brian King wrote:
>> Ragner Magalhaes wrote:
>>> here also, as above ...
+ if (data && (dev->features & NETIF_F_IP_CSUM))
+ return 0;
+ if (!data && !(dev->features & NETIF_F_IP_CSUM))
+ return 0;
>> This change would make the li
ext Brian King wrote:
> Ragner Magalhaes wrote:
>> ext Brian King wrote:
>>
>>> +
>>> +static int ibmveth_set_rx_csum(struct net_device *dev, u32 data)
>>> +{
>>> + struct ibmveth_adapter *adapter = dev->priv;
>>> +
>> Why do not to do
>>
>> if ((data && adapter->rx_csum) || (!data && !adapt
Ragner Magalhaes wrote:
> ext Brian King wrote:
>
>> +
>> +static int ibmveth_set_rx_csum(struct net_device *dev, u32 data)
>> +{
>> +struct ibmveth_adapter *adapter = dev->priv;
>> +
>
> Why do not to do
>
> if ((data && adapter->rx_csum) || (!data && !adapter->rx_csum))
>
ext Brian King wrote:
> +
> +static int ibmveth_set_rx_csum(struct net_device *dev, u32 data)
> +{
> + struct ibmveth_adapter *adapter = dev->priv;
> +
Why do not to do
if ((data && adapter->rx_csum) || (!data && !adapter->rx_csum))
return 0;
less two lines.
> +
Satyam Sharma wrote:
>> Subject : ext4 build warnings
>> References : http://lkml.org/lkml/2007/7/18/420
>> Last known good : ?
>> Submitter : Jeff Garzik <[EMAIL PROTECTED]>
>> Caused-By : ?
>> Handled-By : Mingming Cao <[EMAIL PROTECTED]>
>> Status : unknown
>> Hmmm. The dangling else clauses are pretty gross, and in fact we
>> have
>> the same problem on POWER3 and RS64 processors (to be fair, we had
>> the problem before and didn't notice, but we should still fix it).
>>
>> How about this instead? Could people test it please? (Note that
>> CPU_F
>>> + fsl,cpm-brg = <1>;
>>> + fsl,cpm-command = <0090>;
>>
>> Are these two documented? Your patch queue is too
>> long for me to check for myself.
>>
> In fact, there were different approaches to describe CPM, and I am
> sure this is not the
+ /* Following required by dtc but not used */
+ i-cache-line-size = <0>;
+ d-cache-line-size = <0>;
+ i-cache-size = <4000>;
+ d-cache-size = <4000>;
+ };
>>>
>>> The 32 bits
> Subject : ext4 build warnings
> References : http://lkml.org/lkml/2007/7/18/420
> Last known good : ?
> Submitter : Jeff Garzik <[EMAIL PROTECTED]>
> Caused-By : ?
> Handled-By : Mingming Cao <[EMAIL PROTECTED]>
> Status : unknown
Mingming Cao fixed this:
>>> compatible = "fsl,mpc8241-i2c", "fsl-i2c";
>>
>> That looks good yes. Or if the kernel side code for
>> recognising fsl,mpc8241-i2c gets merged in time, you
>> can leave out fsl-i2c from your device tree completely.
>
> Hmm, there are really only two fsl,i2c controllers. The one we
> ca
>> The only difference here is that Sparc uses strncmp to match
>> compatibility
>> names while PowerPC uses strncasecmp.
>
> Could we put a comment in saying that both should really just use
> strcmp(), and that this mechanism should go away once any
> compatibility
> issues are found and addr
just my 2 cents.
[snip]
>
> > + fsl,cpm-brg = <1>;
> > + fsl,cpm-command = <0090>;
>
> Are these two documented? Your patch queue is too
> long for me to check for myself.
>
In fact, there were different approaches to describe CPM, and I am su
>> Yes indeed. The problem with your suggested "obvious way"
>
> I said it was obvious, not obviously correct. :-)
I know :-)
>> is that you wouldn't get a unit address included if your
>> interrupt-map points (for some entry) at your device tree
>> parent, either. Not all that hypothetical.
>
On Wed, 2007-07-18 at 01:35, Andy Fleming wrote:
> phy_read() returns a negative number if there's an error, but the
> error-checking code in the Vitesse driver's config_intr function
> triggers if phy_read() returns non-zero. Correct that.
>
> Signed-off-by: Andy Fleming <[EMAIL PROTECTED]>
> --
On Wed, 2007-07-18 at 19:00, Paul Mackerras wrote:
> Hmmm. The dangling else clauses are pretty gross, and in fact we have
> the same problem on POWER3 and RS64 processors (to be fair, we had
> the problem before and didn't notice, but we should still fix it).
>
> How about this instead? Could
On Thu, Jul 19, 2007 at 06:34:55PM +0200, Michal Piotrowski wrote:
> SYSFS
>
> Subject : sysfs root link count broken in 2.6.22-git5
> References : http://lkml.org/lkml/2007/7/15/62
> Last known good : ?
> Submitter : Jean Delvare <[EMAIL PROTECTED]>
> Caused-By : ?
> Hand
Kumar Gala wrote:
> Can you dump the POCMRx registers and report their values and what /
> proc/iomem looks like.
POTAR0: 0x0008
POTAR1: 0x000a
POTAR2: 0x
POBAR0: 0x0008
POBAR1: 0x000a
POBAR2: 0x000f6000
POCMR0: 0xa00e
POCMR1: 0x800e
POCMR2: 0xc00fe000
PITAR0: 0
Hi all,
Here is a list of some known regressions in 2.6.22-git.
Feel free to add new regressions/remove fixed etc.
http://kernelnewbies.org/known_regressions
List of Aces
NameRegressions fixed since 21-Jun-2007
Adrian Bunk3
Andi Kleen
On Wed, 2007-07-18 at 16:54, Benjamin Herrenschmidt wrote:
> Cache line size is used by the kernel on ppc64 for things like clearing
> memory (to get the stride between subsequent dcbz) or flushing the
> cache :-) It's also passed on to userland.
>
> If it's absent from the device-tree, we defaul
This removes the requirement for callers to get_cpu() to check in simple
cases. i386 and x86_64 already received a similar treatment.
Signed-off-by: Avi Kivity <[EMAIL PROTECTED]>
---
arch/powerpc/kernel/smp.c |7 ++-
1 files changed, 6 insertions(+), 1 deletions(-)
diff --git a/arch/po
Hi Scott,
On Thu, 19 Jul 2007 10:52:07 -0500 Scott Wood <[EMAIL PROTECTED]> wrote:
>
> On Fri, Jul 20, 2007 at 01:10:12AM +1000, Stephen Rothwell wrote:
> > The only difference here is that Sparc uses strncmp to match compatibility
> > names while PowerPC uses strncasecmp.
>
> Could we put a comm
On Fri, Jul 20, 2007 at 01:46:18AM +1000, Stephen Rothwell wrote:
> On Fri, 20 Jul 2007 01:44:32 +1000 Stephen Rothwell <[EMAIL PROTECTED]> wrote:
> >
> > git remote add powerpc
> > git://git.kernel.org/pub/scm/linux/kernel/git/paulus/powerpc.git
> > git fetch powerpc
> >
> > This will track the
On Fri, Jul 20, 2007 at 01:44:32AM +1000, Stephen Rothwell wrote:
> On Thu, 19 Jul 2007 08:32:17 -0700 "Mark A. Greer" <[EMAIL PROTECTED]> wrote:
> >
> > I was in the master branch of powerpc.git and did a 'git-pull'
>
> Sorry, I hadn't updated since this afternoon. Looks like Paul has reset
> hi
On Fri, Jul 20, 2007 at 01:10:12AM +1000, Stephen Rothwell wrote:
> The only difference here is that Sparc uses strncmp to match compatibility
> names while PowerPC uses strncasecmp.
Could we put a comment in saying that both should really just use
strcmp(), and that this mechanism should go away
> + compatible = "MPC8548CDS", "MPC85xxCDS";
No new "xx" please.
> + memory {
> + device_type = "memory";
> + reg = < 0800>; // 128M at 0x0
[EMAIL PROTECTED] Simplified rule: whenever there is a "reg",
there is an "@".
> + [EMAIL PROTECTED]
Add handlers for get_tso and get_ufo to prevent errors being printed
by ethtool.
Signed-off-by: Brian King <[EMAIL PROTECTED]>
---
linux-2.6-bjking1/drivers/net/ibmveth.c |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff -puN drivers/net/ibmveth.c~ibmveth_ethtool_get_tso drivers
Add ethtool hooks to ibmveth to retrieve driver statistics.
Signed-off-by: Brian King <[EMAIL PROTECTED]>
---
linux-2.6-bjking1/drivers/net/ibmveth.c | 53 +++-
1 file changed, 52 insertions(+), 1 deletion(-)
diff -puN drivers/net/ibmveth.c~ibmveth_ethtool_driver_
This patch adds the appropriate ethtool hooks to allow for enabling/disabling
of hypervisor assisted checksum offload for TCP.
Signed-off-by: Brian King <[EMAIL PROTECTED]>
---
linux-2.6-bjking1/drivers/net/ibmveth.c | 120 +++-
linux-2.6-bjking1/drivers/net/ibmveth
This patchset enables TCP checksum offload support for IPV4
on ibmveth. This completely eliminates the generation and checking of
the checksum for packets that are completely virtual and never
touch a physical network. A simple TCP_STREAM netperf run on
a virtual network with maximum mtu set yield
On Fri, 20 Jul 2007 01:44:32 +1000 Stephen Rothwell <[EMAIL PROTECTED]> wrote:
>
> git remote add powerpc
> git://git.kernel.org/pub/scm/linux/kernel/git/paulus/powerpc.git
> git fetch powerpc
>
> This will track the tree in branches called powerpc/ and do
> resets as necessary.
You should not m
On Thu, 19 Jul 2007 08:32:17 -0700 "Mark A. Greer" <[EMAIL PROTECTED]> wrote:
>
> I was in the master branch of powerpc.git and did a 'git-pull'
Sorry, I hadn't updated since this afternoon. Looks like Paul has reset
his master tree to be the same as Linus', so you do need to do a reset.
Or check
Segher Boessenkool wrote:
>> The CPU15 erratum on MPC8xx chips can cause incorrect code execution
>> under certain circumstances, where there is a conditional or indirect
>> branch in the last word of a page, with a target in the last cache line
>> of the next page. This patch implements one of t
1 - 100 of 148 matches
Mail list logo
