Re: Tickless Hz/hrtimers/etc. on PowerPC

2007-07-15 Thread Tony Breeds
On Thu, Jul 12, 2007 at 01:07:26PM +0100, Matt Sealey wrote: Hi Matt, > What does "isn't quite right yet" mean? Broken, acts funny, or just > a messy patch? If you compile with CONFIG_NO_HZ=y, the kernel is broken. Yours Tony linux.conf.auhttp://linux.conf.au/ || http://lca2008.linu

Re: [PATCH] the wrong variable checked after request_irq()

2007-07-15 Thread Benjamin Herrenschmidt
On Sun, 2007-07-15 at 23:02 +0100, Al Viro wrote: > On Mon, Jul 16, 2007 at 07:40:38AM +1000, Benjamin Herrenschmidt wrote: > > On Sun, 2007-07-15 at 20:59 +0100, Al Viro wrote: > > > Signed-off-by: Al Viro <[EMAIL PROTECTED]> > > > > Acked-by: Benjamin Herrenschmidt <[EMAIL PROTECTED]> > > > > O

Re: [PATCH] the wrong variable checked after request_irq()

2007-07-15 Thread Al Viro
On Mon, Jul 16, 2007 at 07:40:38AM +1000, Benjamin Herrenschmidt wrote: > On Sun, 2007-07-15 at 20:59 +0100, Al Viro wrote: > > Signed-off-by: Al Viro <[EMAIL PROTECTED]> > > Acked-by: Benjamin Herrenschmidt <[EMAIL PROTECTED]> > > Out of curiosity, how did you pick it up ? You have some automate

Re: [PATCH] the wrong variable checked after request_irq()

2007-07-15 Thread Benjamin Herrenschmidt
On Sun, 2007-07-15 at 20:59 +0100, Al Viro wrote: > Signed-off-by: Al Viro <[EMAIL PROTECTED]> Acked-by: Benjamin Herrenschmidt <[EMAIL PROTECTED]> Out of curiosity, how did you pick it up ? You have some automated tool to catch that (or sparse changes) or you just did -lots- of code inspection ?

[PATCH] the wrong variable checked after request_irq()

2007-07-15 Thread Al Viro
Signed-off-by: Al Viro <[EMAIL PROTECTED]> --- arch/powerpc/platforms/pseries/setup.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/powerpc/platforms/pseries/setup.c b/arch/powerpc/platforms/pseries/setup.c index 470db6e..a031d99 100644 --- a/arch/powerpc/platfor

[patch] use __attribute__ in asm-powerpc

2007-07-15 Thread Mike Frysinger
Pretty much everyone uses "__attribute__" or "attribute", no one uses "__attribute". This patch tweaks the three places in asm-powerpc where this comes up. While only asm-powerpc/types.h is interesting (for userspace), I did asm-powerpc/processor.h as well for consistency. Signed-off-by: Mike Fr

Re: [PATCH] Use resource_size_t for serial port IO addresses

2007-07-15 Thread Russell King
On Fri, Jul 13, 2007 at 12:02:26PM -0700, Andrew Morton wrote: > On Fri, 13 Jul 2007 09:02:16 -0500 > Josh Boyer <[EMAIL PROTECTED]> wrote: > > > This is a resend of a patch David sent out on May 7. Without it, the > > PowerPC 44x port in 2.6.22 and on is broken. I've rebased it off of > > Linus

Re: [RFC 0/3] lro: Generic Large Receive Offload for TCP traffic

2007-07-15 Thread David Miller
From: Christoph Hellwig <[EMAIL PROTECTED]> Date: Sun, 15 Jul 2007 10:12:53 +0100 > I'm not sure that's a good idea. If current chips can't handle ipv6 > lro there is no way to actually test it and the code will surely bitrot. Christoph, you can do LRO pretty much completely in software. __

Re: [RFC 0/3] lro: Generic Large Receive Offload for TCP traffic

2007-07-15 Thread Christoph Hellwig
On Sat, Jul 14, 2007 at 11:57:48PM -0700, David Miller wrote: > only request is to make this thing able to handle ipv6 as > well even if no current chips could facilitate that yet. I'm not sure that's a good idea. If current chips can't handle ipv6 lro there is no way to actually test it and the

Re: How to add platform specific data to a of_device

2007-07-15 Thread Benjamin Herrenschmidt
> Hmm, as I stated above: Handling the SPI slave devices is done in the SPI > framework. But including this data into the dts sounds better than including > it into the BSP. Is there some documentation around how to describe such a > SPI bus with its devices in the dts? I don't think so, I dou

Re: How to add platform specific data to a of_device

2007-07-15 Thread Juergen Beisert
Hi Ben, On Saturday 14 July 2007 22:48, Benjamin Herrenschmidt wrote: > On Sat, 2007-07-14 at 18:31 +0200, Juergen Beisert wrote: > > Hi, > > > > I'm trying to use the drivers/spi/mpc52xx_psc_spi.c as an open firmware > > device (ARCH=powerpc). This device needs some platform specific data (the >