Re: [linux-usb-devel] [PATCH] usbserial open/close unbalanced get/put

2004-11-06 Thread Al Borchers
Greg -- This patch does not correctly handle failures from try_module_get or usb_serial_get_by_index. Please ignore this patch--I will send a better one later. Thanks, -- Al --- linux-2.6.10-rc1-bk14.orig/drivers/usb/serial/usb-serial.c 2004-11-05 01:35:08.0 -0600 +++ linux-2.6.10-rc1-bk14

[linux-usb-devel] [PATCH] usbserial open/close unbalanced get/put

2004-11-06 Thread Al Borchers
Greg -- This patch fixes a problem in usbserial open/close. If the first open of a usbserial port fails, kref_put is called twice on serial->kref--once in the error handling in open and once in close, which is called even though the open failed. This patch does the put only in the failed open in