From: Tilman Schmidt <[EMAIL PROTECTED]>
Make there only be one reference to urb->status per URB callback, and none
outside, in preparation for removal of that field.
Signed-off-by: Tilman Schmidt <[EMAIL PROTECTED]>
---
drivers/isdn/gigaset/bas-g
From: Tilman Schmidt <[EMAIL PROTECTED]>
Remove pointless taking of spinlock around reading a single pointer-sized
or smaller variable.
Signed-off-by: Tilman Schmidt <[EMAIL PROTECTED]>
---
drivers/isdn/gigaset/bas-gigaset.c |9 +
drivers/isdn/gigaset/i4l.c
Am 24.07.2007 00:50 schrieb Greg KH:
> On Sun, Jul 22, 2007 at 04:44:24PM +0200, Tilman Schmidt wrote:
>> Should I do something similar for drivers/isdn/{bas,usb}-gigaset.c?
>
> If you want to do so before I do it, sure :)
The coding is done. Expect a patch soon. I just want to t
Am 22.07.2007 21:30 schrieb Pete Zaitcev:
> On Sun, 22 Jul 2007 16:44:24 +0200, Tilman Schmidt <[EMAIL PROTECTED]> wrote:
>
>> Should I do something similar for drivers/isdn/{bas,usb}-gigaset.c?
>> What exactly is the goal?
>
> In most cases of sweeping API ch
USB: misc: phidgetmotorcontrol: clean up urb->status usage
> USB: misc: usblcd: clean up urb->status usage
> USB: misc: usbtest: clean up urb->status usage
> USB: misc: uss720: clean up urb->status usage
Should I do something similar for drivers/isdn/{bas,usb}-gi
}
as not confirming to CodingStyle. So that last phrase should rather
read:
"Lots of developers seem to delight in avoiding rebukes."
:-)
T.
--
Tilman Schmidt
[EMAIL PROTECTED]
-
This SF.net email is sponsored
lopers seem to delight in avoiding
> learning that.
I beg to differ. I already got rebuked for writing sth like
--
Tilman Schmidt
[EMAIL PROTECTED]
-
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the
rom struct urb.
>> Remove the forgotten occurence in bas-gigaset.c
>>
>> Signed-off-by: Jiri Kosina <[EMAIL PROTECTED]>
> Signed-off-by: Tilman Schmidt <[EMAIL PROTECTED]>
I notice that 2.6.20-git6 still doesn't include either of these
end/resume within a USB device driver, or a showcase driver
which has perfect suspend/resume support and which I could use
as reference?
Thanks,
Tilman
--
Tilman Schmidt E-Mail: [EMAIL PROTECTED]
Bonn, Germany
Diese Nachricht besteht zu 100% aus wiederverwerteten Bits.
Ungeöff
of URBs will use fewer than that.
> A typical user of Iso URBs is USB audio; maybe Clemens can provide some
> guidance.
For the iso endpoints corresponding to the ISDN B channels in
driver/isdn/gigaset we use 8 iso packet descriptor
idth for INT/ISO request
> */
> atomic_t use_count; /* concurrent submissions counter */
> u8 reject; /* submissions will fail */
This breaks compilation of drivers/isdn/gigaset/bas-gigaset.c.
If you pass on this patch, please pass on Andrew&
ice error conditions which I
don't know how to clear except by telling the user to unplug the
device.
Thanks
Tilman
--
Tilman Schmidt E-Mail: [EMAIL PROTECTED]
Bonn, Germany
Diese Nachricht besteht zu 100% aus wiederverwerteten Bits.
Ungeoeffnet mindestens haltbar bi
Sorry for the late reply. I had overlooked this.
Am 08.11.2006 15:34 schrieb Mariusz Kozlowski:
> Hello,
>
> - usb_free_urb() cleanup
> - usb_kill_urb() cleanup
>
> Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]>
Acked-by: Tilman Schmidt <[EMAIL PROTECTED]>
ear except by telling the user to unplug the
device.
Thanks
Tilman
--
Tilman Schmidt E-Mail: [EMAIL PROTECTED]
Bonn, Germany
Diese Nachricht besteht zu 100% aus wiederverwerteten Bits.
Ungeoeffnet mindestens haltbar bis: (siehe
ted all drivers which I found affected.
Would you mind extending your patch to also adjust
drivers/isdn/gigaset/bas-gigaset.c accordingly?
Thanks,
Tilman
--
Tilman Schmidt E-Mail: [EMAIL PROTECTED]
Bonn, Germany
Diese Nachricht besteht zu 100% aus wiederverwerteten Bi
On 29.11.2005 08:53, Oliver Neukum wrote:
> Am Dienstag, 29. November 2005 01:24 schrieb Tilman Schmidt:
[tentative mods to cdc-acm.c for Siemens Gigaset M34 USB DECT adapter]
>>Am I on the right track at all or have I got it all completely wrong?
>>Do my changes to cdc-acm.c
On 11.07.2006 23:51, Andrew Morton wrote:
> Tilman Schmidt <[EMAIL PROTECTED]> wrote:
>
>>- class_device_create_file(cs->class, &class_device_attr_cidmode);
>>+ if (class_device_create_file(cs->class, &class_device_attr_cidmode))
>>+
From: Tilman Schmidt <[EMAIL PROTECTED]>
This patch to the Siemens Gigaset driver fixes the compile warning
"ignoring return value of 'class_device_create_file', declared with
attribute warn_unused_result" appearing with CONFIG_ENABLE_MUST_CHECK=y
in release 2.6.18-rc1-m
From: Tilman Schmidt <[EMAIL PROTECTED]>
The following patch to the common part of the Siemens Gigaset driver
prevents it from trying to send the +++ break sequence if the device
has been disconnected, and removes a couple of assignments which
didn't have any effect.
Signed-off
From: Tilman Schmidt <[EMAIL PROTECTED]>
The following patch to the Siemens Gigaset base driver adds graceful
recovery for some frequently encountered error conditions, by retrying
failed control requests (eg. stalled control pipe), and by closing and
reopening the AT command channel w
perly test its handling.
So is there a generic way of provoking a STALL condition for a given
endpoint, ideally without adverse side effects on device operation?
--
Tilman SchmidtE-Mail: [EMAIL PROTECTED]
Bonn, Germany
Diese Nachricht besteht zu 100% aus wiederverwer
ve access
to, it seems that the entire /sys/module directory didn't exist
there yet, anyway.
So your best bet might be to update to a more current Linux version
and try again. If it still doesn't work, look in the source of that
module to find out what goes wrong.
Hope that helps
Tilman
--
On 20.04.2006 17:32, Adrian Bunk wrote:
> On Thu, Apr 20, 2006 at 08:21:20AM -0700, Randy.Dunlap wrote:
[...]
>>>>Tilman Schmidt <[EMAIL PROTECTED]> wrote:
>>>>
>>>>>--- linux-2.6.17-rc2-work/drivers/isdn/gigaset.orig/bas-gigaset.c
>>>>
On 20.04.2006 09:11, Andrew Morton wrote:
> Tilman Schmidt <[EMAIL PROTECTED]> wrote:
>
>>This patch fixes a possible Oops in the Siemens Gigaset base driver when
>> the device is unplugged while an ISDN connection is still active, and
>> makes sure that the isdn4lin
From: Tilman Schmidt <[EMAIL PROTECTED]>
This patch fixes a possible Oops in the Siemens Gigaset base driver when
the device is unplugged while an ISDN connection is still active, and
makes sure that the isdn4linux link level (LL) is properly informed if a
connection is broken by the USB
like?
> I'll drop this patch for now, and only take the part that adds the new
> dev_* macro. Is that ok for everyone?
Can't say I'm happy with that.
> And if anyone wants to notify the kernel-janitors that this would be a
> good thing to do for the USB subsytem, f
On 09.03.2006 19:58, Jesper Juhl wrote:
> On 3/9/06, Tilman Schmidt <[EMAIL PROTECTED]> wrote:
>
>>On 09.03.2006 17:34, Randy.Dunlap wrote:
>>
>>>On Thu, 9 Mar 2006 03:02:57 -0800 Andrew Morton wrote:
>>>
>>>>Tilman Schmidt <[EMAIL PRO
On 09.03.2006 17:34, Randy.Dunlap wrote:
> On Thu, 9 Mar 2006 03:02:57 -0800 Andrew Morton wrote:
>
>>Tilman Schmidt <[EMAIL PROTECTED]> wrote:
>>
>>>The current versions of the err() / info() / warn() syslog macros
>>> insert __FILE__ at the beginnin
(THIS_MODULE ? THIS_MODULE->name : __FILE__)
succeeds and THIS_MODULE can actualy be dereferenced
I would like the code to compile and run successfully in all these cases.
--
Tilman SchmidtE-Mail: [EMAIL PROTECTED]
Bonn, Germany
Diese Nachricht besteht zu 100% aus wiederverwerteten Bits.
Ungeöffnet mindestens haltbar bis: (siehe Rückseite)
signature.asc
Description: OpenPGP digital signature
add macros notice(), dev_notice() (take 2)".
Signed-off-by: Tilman Schmidt <[EMAIL PROTECTED]>
---
usb.h | 14 ++
1 files changed, 10 insertions(+), 4 deletions(-)
--- linux-2.6.16-rc5-patch-splitpoint/include/linux/usb.h 2006-03-08
12:36:03.0 +0100
+++ l
drivers.
Signed-off-by: Tilman Schmidt <[EMAIL PROTECTED]>
---
device.h |2 ++
usb.h|2 ++
2 files changed, 4 insertions(+)
diff -ru linux-2.6.16-rc5/include/linux/device.h
linux-2.6.16-rc5-patch-splitpoint/include/linux/device.h
--- linux-2.6.16-rc5/include/linux/device.h 2
On Fri, 03 Mar 2006 07:53:28 +0100, Arjan van de Ven wrote:
> On Fri, 2006-03-03 at 00:03 +0100, Tilman Schmidt wrote:
>> So you are saying that, for example
>>
>> spin_lock_irqsave(&cs->ev_lock, flags);
>> head = cs->ev_head;
>> tail =
a tasklet.
> (GFP_ATOMIC is evil in the sense that spurious use of it gives trouble
> for the VM)
Does that mean that every function doing kmalloc() and which may be
called from both interrupt and non-interrupt context needs a gfp_t flags
argument?
Thanks again for your time and effort
Ti
(currently in the process of being submitted for the kernel tree)
but they really belong with their brothers and sisters in
include/linux/{device,usb}.h.
Signed-off-by: Tilman Schmidt <[EMAIL PROTECTED]>
---
device.h |2 ++
usb.h|2 ++
2 files changed, 4 insertions(+)
diff -ru
ch is significantly shorter and also tends to
be more useful to users trying to make sense of a particular message.
Signed-off-by: Tilman Schmidt <[EMAIL PROTECTED]>
---
usb.h |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff -ru linux-2.6.16-rc4-mm1-orig/include/linux/u
Hello Greg,
thank you for your comments. Just a few follow-up questions.
On 15.02.2006 04:19, Greg KH wrote:
> On Sat, Feb 11, 2006 at 03:52:27PM +0100, Hansjoerg Lipp wrote:
>
>>From: Tilman Schmidt <[EMAIL PROTECTED]>, Hansjoerg Lipp <[EMAIL PROTECTED]>
>>
&g
Hello Greg,
thank you for your comments. Just a few follow-up questions.
On 15.02.2006 04:27, Greg KH wrote:
> On Sat, Feb 11, 2006 at 03:52:27PM +0100, Hansjoerg Lipp wrote:
>
>>--- linux-2.6.16-rc2/drivers/isdn/gigaset/gigaset.h 1970-01-01
>>01:00:00.0 +0100
>>+++ linux-2.6.16-rc2-g
On 15.02.2006 04:19, Greg KH wrote:
> On Sat, Feb 11, 2006 at 03:52:27PM +0100, Hansjoerg Lipp wrote:
>
>>From: Tilman Schmidt <[EMAIL PROTECTED]>, Hansjoerg Lipp <[EMAIL PROTECTED]>
>>
>>This patch prepares the kernel build infrastructure for addition of the
n't all
> need to be global.
Well, I *hope* there aren't any unnecessary ones, but we'll re-check.
Regards
Tilman
--
Tilman Schmidt E-Mail: [EMAIL PROTECTED]
Bonn, Germany
Diese Nachricht besteht zu 100% aus wiederverwerteten Bits.
Ungeöffnet mindestens haltbar bis: (siehe Rückseite)
signature.asc
Description: OpenPGP digital signature
t more than one of these devices.
Is there a better alternative?
Thanks
Tilman
--
Tilman SchmidtE-Mail: [EMAIL PROTECTED]
Bonn, Germany
Diese Nachricht besteht zu 100% aus wiederverwerteten Bits.
Ungeöffnet mindestens haltbar bis: (siehe Rückseite)
-
en the corresponding device /dev/ttyACM0 with minicom and
try to send some AT commands to the device I never get any reply.
Am I on the right track at all or have I got it all completely wrong?
Do my changes to cdc-acm.c make any sense?
Thanks in advance for any hints.
Tilman
--
Tilman Schmidt
On 05.07.2005 08:11, Greg KH wrote:
> On Sat, Jul 02, 2005 at 12:51:39AM +0200, Tilman Schmidt wrote:
>
>>For a driver for a USB ISDN device [...]
>>on Ubuntu with kernel 2.6.10,
>>the setup is lost on every reboot. [...]
>>Unfortunately I cannot find any inf
cover
just by rmmod/modprobe-ing my driver, so there should be a way
of handling this in software, no?
Thanks,
Tilman
--
Tilman Schmidt E-Mail: [EMAIL PROTECTED]
Bonn, Germany
Diese Nachricht besteht zu 100% aus wiederverwerteten Bits.
Ungeöffnet mindestens haltbar bis: (
egister_device() call - or is there?
Any hints?
--
Tilman Schmidt E-Mail: [EMAIL PROTECTED]
Bonn, Germany
Diese Nachricht besteht zu 100% aus wiederverwerteten Bits.
Ungeöffnet mindestens haltbar bis: (siehe Rückseite)
signature.asc
Description: OpenPGP digital signature
be a side effect of moving to the kernel
build system, the full path to the source being passed to gcc on the
command line instead of just the file name?
--
Tilman Schmidt
Bonn, Germany
---
This SF.Net email is sponsored by: New Crystal Rep
ns and the :=
> assignment operator.
>
> I didn't think any one still uses PASCAL or similar language.
Oh yes, it's alive and kicking under the name of "Delphi".
HTH
Tilman
--
Tilman SchmidtE-Mail: [EMAIL PROTECTED]
Bonn, Germany
Diese Nachricht bes
SB device do something like that? ;-)
Anyway, the interface docs don't mention anything of that sort, but
after working on this device for a year nothing surprises me much
anymore. How could I find out?
Regards
Tilman
--
Tilman SchmidtE-Mail: [EMAIL PROTECTED]
Bonn, Ger
h might also occur - such as actual CRC errors?
Thanks in advance for any hints
Tilman
[1] Siemens Gigaset family of ISDN DECT bases - see
http://sourceforge.net/projects/gigaset307x/
--
Tilman SchmidtE-Mail: [EMAIL PROTECTED]
Bonn, Germany
Diese Nachricht besteht zu 100% a
48 matches
Mail list logo
