Re: [PATCH] usb: gadget: f_mass_storage: stop thread in bind failure case

2015-06-04 Thread snjsrwt
On 6/4/2015 5:15 PM, Michal Nazarewicz wrote: On Thu, Jun 04 2015, Sanjay Singh Rawat wrote: After the worker thread is launched, bind function is doing further configuration. Stop the thread in case of failure. Also use kthread_run to encapsulate thread creation and launch. Sounds like two s

Re: [PATCH v2 3/4] usb: gadget: move common storage gadget structure to header file

2015-06-08 Thread snjsrwt
On 6/8/2015 1:33 PM, Michal Nazarewicz wrote: On Mon, Jun 08 2015, Sanjay Singh Rawat wrote: struct fsg_common is used in multiple files, moving it to header file from the source file. Isn’t this patch a prerequisit for the previous patch? Just merge them together. Yes right, actually patc

Re: [PATCH v2 3/4] usb: gadget: move common storage gadget structure to header file

2015-06-08 Thread snjsrwt
On 6/8/2015 4:13 PM, Michal Nazarewicz wrote: On Mon, Jun 08 2015, snjsrwt wrote: On 6/8/2015 1:33 PM, Michal Nazarewicz wrote: On Mon, Jun 08 2015, Sanjay Singh Rawat wrote: struct fsg_common is used in multiple files, moving it to header file from the source file. Isn’t this patch a