Looks good to me.
Feel free to add my r-b.
On 2016-12-13 02:49 AM, Baolin Wang wrote:
Enable the xhci plat runtime PM for parent device to suspend/resume xhci.
Also call pm_runtime_get_noresume() in probe() function in case the parent
device doesn't call suspend/resume callback by runtime PM no
Looks good to me.
Feel free to add my r-b.
Rob.
On 2016-12-13 02:49 AM, Baolin Wang wrote:
For some mobile devices with strict power management, we also want to suspend
the host when the slave is detached for power saving. Thus we add the host
suspend/resume functions to support this requirem
suspend and
resume asynchronously.
Signed-off-by: Andrew Bresticker
Tested-by: Andrew Bresticker
Tested-by: Robert Foss
Signed-off-by: Robert Foss
---
drivers/usb/host/xhci-plat.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c
This series enables runtime PM and asynchronous resume/suspend support for
xhci-plat devices.
Due to Baolin Wangs series[1] part 1/2 of this series is now dropped.
[1] https://lkml.org/lkml/2016/12/13/32
Andrew Bresticker (1):
usb: xhci: plat: Enable async suspend/resume
drivers/usb/host/xhc
From: Grant Grundler
In order to R/W registers in suspend/resume functions, in_pm flags are
added to some functions to determine whether the nopm version of usb
functions is called.
Save BMCR and ANAR PHY registers in suspend function and restore them
in resume function.
Reset HW in resume func
From: WK Tsai
The change fixes AX88772x resume failure by
- Restore incorrect AX88772A PHY registers when resetting
- Need to stop MAC operation when suspending
- Need to restart MII when restoring PHY
Signed-off-by: WK Tsai
---
drivers/net/usb/asix_devices.c | 47 +
From: Vincent Palatin
Check the answers from the USB stack and avoid re-sending multiple times
the request if the device has disappeared.
Signed-off-by: Vincent Palatin
---
drivers/net/usb/asix_common.c | 56 +-
drivers/net/usb/asix_devices.c | 2 ++
2
From: Andrew Bresticker
USB host controllers can take a significant amount of time to suspend
and resume, adding several hundred miliseconds to the kernel resume
time. Since the XHCI controller has no outside dependencies (other than
clocks, which are suspended late/resumed early), allow it to su
From: Andrew Bresticker
Enable runtime PM for the xhci-plat device so that the parent device
may implement runtime PM.
Signed-off-by: Andrew Bresticker
---
drivers/usb/host/xhci-plat.c | 19 +--
1 file changed, 17 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/host/xhc
From: Grant Grundler
For the record, I believe I am not the author of these patches.
I believe the original author is
Signed-off-by: Freddy Xin
as recorded in the following code reviews (and testing) that I was
responsible for:
https://chromium-review.googlesource.com/#/q/owner:%22G
again, if another read error occurs). If there was no outstanding
response, this will bring the queue size back to 0, unblocking a future response
from the underlying device.
Signed-off-by: Prathmesh Prabhu
Tested-by: Robert Foss
Signed-off-by: Robert Foss
---
drivers/usb/class/cdc-wdm.c | 34
suspend and
resume asynchronously.
Signed-off-by: Andrew Bresticker
Tested-by: Andrew Bresticker
Tested-by: Robert Foss
Signed-off-by: Robert Foss
---
drivers/usb/host/xhci-plat.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c
From: Robert Foss
This series enables runtime PM and asynchronous resume/suspend support for
xhci-plat devices.
Andrew Bresticker (2):
usb: xhci: plat: Enable runtime PM
usb: xhci: plat: Enable async suspend/resume
drivers/usb/host/xhci-plat.c | 20 ++--
1 file changed, 18
From: Andrew Bresticker
Enable runtime PM for the xhci-plat device so that the parent device
may implement runtime PM.
Signed-off-by: Andrew Bresticker
Tested-by: Robert Foss
Signed-off-by: Robert Foss
---
drivers/usb/host/xhci-plat.c | 19 +--
1 file changed, 17 insertions
This series should be labelled v2 instead of v1.
This series enables runtime PM and asynchronous resume/suspend support for
xhci-plat devices.
Andrew Bresticker (2):
usb: xhci: plat: Enable runtime PM
usb: xhci: plat: Enable async suspend/resume
drivers/usb/host/xhci-plat.c | 20 +
On 2016-07-28 08:24 PM, Felipe Balbi wrote:
Hi,
robert.f...@collabora.com writes:
From: Andrew Bresticker
Enable runtime PM for the xhci-plat device so that the parent device
may implement runtime PM.
Signed-off-by: Andrew Bresticker
Tested-by: Robert Foss
Signed-off-by: Robert Foss
suspend and
resume asynchronously.
Signed-off-by: Andrew Bresticker
Tested-by: Andrew Bresticker
Tested-by: Robert Foss
Signed-off-by: Robert Foss
---
drivers/usb/host/xhci-plat.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c
From: Robert Foss
This series enables runtime PM and asynchronous resume/suspend support for
xhci-plat devices.
Changes since v1:
- Added Signed-off-by: Robert Foss
- Added proper metadata tags to series.
Changes since v2:
- Added missing changelog to cover-letter.
- Added error checking to
From: Andrew Bresticker
Enable runtime PM for the xhci-plat device so that the parent device
may implement runtime PM.
Signed-off-by: Andrew Bresticker
Tested-by: Robert Foss
Signed-off-by: Robert Foss
---
drivers/usb/host/xhci-plat.c | 24 ++--
1 file changed, 22
On 2016-08-02 08:23 AM, Oliver Neukum wrote:
On Thu, 2016-07-28 at 14:19 -0400, robert.f...@collabora.com wrote:
From: Prathmesh Prabhu
Implemented queued response handling. This queue is processed every
time the
WDM_READ flag is cleared.
In case of a read error, userspace may not actually
On 2016-08-02 09:59 AM, Oliver Neukum wrote:
On Tue, 2016-08-02 at 09:54 -0400, Robert Foss wrote:
On 2016-08-02 08:23 AM, Oliver Neukum wrote:
On Thu, 2016-07-28 at 14:19 -0400, robert.f...@collabora.com wrote:
From: Prathmesh Prabhu
Implemented queued response handling. This queue is
On 2016-08-03 06:39 AM, Oliver Neukum wrote:
On Tue, 2016-08-02 at 10:37 -0400, Robert Foss wrote:
On 2016-08-02 09:59 AM, Oliver Neukum wrote:
On Tue, 2016-08-02 at 09:54 -0400, Robert Foss wrote:
On 2016-08-02 08:23 AM, Oliver Neukum wrote:
On Thu, 2016-07-28 at 14:19 -0400, robert.f
On 2016-08-07 04:59 AM, Oliver Neukum wrote:
On Thu, 2016-08-04 at 13:44 -0400, Robert Foss wrote:
On 2016-08-03 06:39 AM, Oliver Neukum wrote:
On Tue, 2016-08-02 at 10:37 -0400, Robert Foss wrote:
How can that depend on what we return to user space?
In the driver we can continue just
From: Robert Foss
Implemented queued response handling. This queue is processed every time the
WDM_READ flag is cleared.
In case of a read error, userspace may not actually read the data, since the
driver returns an error through wdm_poll. After this, the underlying device may
attempt to send
From: Robert Foss
This series enables runtime PM and asynchronous resume/suspend support for
xhci-plat devices.
This is a resumbmission of v3.
Changes since v1:
- Added Signed-off-by: Robert Foss
- Added proper metadata tags to series.
Changes since v2:
- Added missing changelog to cover
suspend and
resume asynchronously.
Signed-off-by: Andrew Bresticker
Tested-by: Andrew Bresticker
Tested-by: Robert Foss
Signed-off-by: Robert Foss
---
drivers/usb/host/xhci-plat.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c
From: Andrew Bresticker
Enable runtime PM for the xhci-plat device so that the parent device
may implement runtime PM.
Signed-off-by: Andrew Bresticker
Tested-by: Robert Foss
Signed-off-by: Robert Foss
---
drivers/usb/host/xhci-plat.c | 24 ++--
1 file changed, 22
On 2016-08-09 09:51 AM, Greg KH wrote:
On Mon, Aug 08, 2016 at 11:48:52AM -0400, robert.f...@collabora.com wrote:
From: Robert Foss
Implemented queued response handling. This queue is processed every time the
WDM_READ flag is cleared.
In case of a read error, userspace may not actually
On 2016-08-09 05:19 AM, Felipe Balbi wrote:
Hi,
robert.f...@collabora.com writes:
From: Andrew Bresticker
Enable runtime PM for the xhci-plat device so that the parent device
may implement runtime PM.
Signed-off-by: Andrew Bresticker
Tested-by: Robert Foss
Signed-off-by: Robert Foss
suspend and
resume asynchronously.
Signed-off-by: Andrew Bresticker
Tested-by: Andrew Bresticker
Tested-by: Robert Foss
Signed-off-by: Robert Foss
---
drivers/usb/host/xhci-plat.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c
From: Robert Foss
This series enables runtime PM and asynchronous resume/suspend support for
xhci-plat devices.
Changes since v1:
- Added Signed-off-by: Robert Foss
- Added proper metadata tags to series
Changes since v2:
- Added missing changelog to cover-letter
- Added error checking to
From: Robert Foss
Enable runtime PM for the xhci-plat device so that the parent device
may implement runtime PM.
Signed-off-by: Robert Foss
Tested-by: Robert Foss
---
drivers/usb/host/xhci-plat.c | 26 --
1 file changed, 24 insertions(+), 2 deletions(-)
diff --git a
From: Robert Foss
This series enables runtime PM and asynchronous resume/suspend support for
xhci-plat devices.
Changes since v1:
- Added Signed-off-by: Robert Foss
- Added proper metadata tags to series
Changes since v2:
- Added missing changelog to cover-letter
- Added error checking to
From: Robert Foss
Enable runtime PM for the xhci-plat device so that the parent device
may implement runtime PM.
Signed-off-by: Robert Foss
Tested-by: Robert Foss
---
drivers/usb/host/xhci-plat.c | 29 +++--
1 file changed, 27 insertions(+), 2 deletions(-)
diff
suspend and
resume asynchronously.
Signed-off-by: Andrew Bresticker
Tested-by: Andrew Bresticker
Tested-by: Robert Foss
Signed-off-by: Robert Foss
---
drivers/usb/host/xhci-plat.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c
From: Robert Foss
This series enables runtime PM and asynchronous resume/suspend support for
xhci-plat devices.
Changes since v1:
- Added Signed-off-by: Robert Foss
- Added proper metadata tags to series
Changes since v2:
- Added missing changelog to cover-letter
- Added error checking to
From: Robert Foss
Enable runtime PM for the xhci-plat device so that the parent device
may implement runtime PM.
Signed-off-by: Robert Foss
Tested-by: Robert Foss
---
drivers/usb/host/xhci-plat.c | 29 +++--
1 file changed, 27 insertions(+), 2 deletions(-)
diff
suspend and
resume asynchronously.
Signed-off-by: Andrew Bresticker
Tested-by: Andrew Bresticker
Tested-by: Robert Foss
Signed-off-by: Robert Foss
---
drivers/usb/host/xhci-plat.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c
wrote:
From: Robert Foss
Enable runtime PM for the xhci-plat device so that the parent device
may implement runtime PM.
Signed-off-by: Robert Foss
Tested-by: Robert Foss
---
drivers/usb/host/xhci-plat.c | 29 +++--
1 file changed, 27 insertions(+), 2 deletions(-)
diff --
From: Robert Foss
From: Freddy Xin
In order to R/W registers in suspend/resume functions, in_pm flags are
added to some functions to determine whether the nopm version of usb
functions is called.
Save BMCR and ANAR PHY registers in suspend function and restore them
in resume function.
Reset
From: Robert Foss
From: Vincent Palatin
Check the answers from the USB stack and avoid re-sending multiple times
the request if the device has disappeared.
Signed-off-by: Vincent Palatin
Signed-off-by: Robert Foss
Tested-by: Robert Foss
---
drivers/net/usb/asix_common.c | 56
From: Grant Grundler
https://lkml.org/lkml/2014/11/11/947
Ben Hutchings is correct. IEEE 802.3 spec section "22.2.4.1.1 Reset" requires
up to 500ms delay. Mitigate the "max" delay by polling the phy until BCM_RESET
bit is clear.
Signed-off-by: Grant Grundler
Signed
function to ensure the PHY works correctly.
Signed-off-by: Freddy Xin
Signed-off-by: Robert Foss
Tested-by: Robert Foss
---
drivers/net/usb/asix.h | 40 +++--
drivers/net/usb/asix_common.c | 180 +++-
drivers/net/usb/asix_devices.c | 373
From: Robert Foss
From: Grant Grundler
https://lkml.org/lkml/2014/11/11/947
Ben Hutchings is correct. IEEE 802.3 spec section "22.2.4.1.1 Reset" requires
up to 500ms delay. Mitigate the "max" delay by polling the phy until BCM_RESET
bit is clear.
Signed-off-by: Grant Gru
From: Allan Chou
The change fixes AX88772x resume failure by
- Restore incorrect AX88772A PHY registers when resetting
- Need to stop MAC operation when suspending
- Need to restart MII when restoring PHY
Signed-off-by: Allan Chou
Signed-off-by: Robert Foss
Tested-by: Robert Foss
From: Robert Foss
From: Grant Grundler
The miii_nway_restart() causes a PHY link change activity and
ax88772_link_reset will be called. link_reset will set
AX_CMD_WRITE_MEDIUM_MODE register correctly.
The asix_write_medium_mode in reset() fills in a default value to the register
which may be
negotiation result. So do this first.
Ignore the ret value since it's ignored in XXX_link_reset() functions.
Signed-off-by: Grant Grundler
Signed-off-by: Robert Foss
Tested-by: Robert Foss
---
drivers/net/usb/asix_devices.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --
From: Robert Foss
This is a resubmission of v3, since the netdev
mailinlist was not sent the previous submission.
This series improves power management of the asix driver.
- Suspend/resume support is improved to save needed registers.
- Device disconnection is improved.
- Fixes AX88772x
From: Vincent Palatin
Check the answers from the USB stack and avoid re-sending multiple times
the request if the device has disappeared.
Signed-off-by: Vincent Palatin
Signed-off-by: Robert Foss
Tested-by: Robert Foss
---
drivers/net/usb/asix_common.c | 56
From: Robert Foss
From: Allan Chou
The change fixes AX88772x resume failure by
- Restore incorrect AX88772A PHY registers when resetting
- Need to stop MAC operation when suspending
- Need to restart MII when restoring PHY
Signed-off-by: Allan Chou
Signed-off-by: Robert Foss
Tested-by
echo "Command failed"
fi
done
iperf3 UDP:
sudo iperf3 -c 192.168.0.28 -u -b 100M -t 0
On 2016-08-29 09:32 AM, robert.f...@collabora.com wrote:
From: Robert Foss
This is a resubmission of v3, since the netdev
mailinlist was not sent the previous submission.
T
On 2016-09-01 12:43 PM, Eric Dumazet wrote:
On Mon, 2016-08-29 at 09:32 -0400, robert.f...@collabora.com wrote:
From: Robert Foss
From: Grant Grundler
The miii_nway_restart() causes a PHY link change activity and
ax88772_link_reset will be called. link_reset will set
On 2016-09-06 12:41 PM, Grant Grundler wrote:
On Thu, Sep 1, 2016 at 10:02 AM, Eric Dumazet wrote:
On Thu, 2016-09-01 at 12:47 -0400, Robert Foss wrote:
I'm not quite sure how the first From line was added, it
should not have been.
Grant Grundler is most definitely the author.
Woul
suspend and
resume asynchronously.
Signed-off-by: Andrew Bresticker
Tested-by: Andrew Bresticker
Tested-by: Robert Foss
Signed-off-by: Robert Foss
---
drivers/usb/host/xhci-plat.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c
This series enables runtime PM and asynchronous resume/suspend support for
xhci-plat devices.
Changes since v1:
- Added Signed-off-by: Robert Foss
- Added proper metadata tags to series
Changes since v2:
- Added missing changelog to cover-letter
- Added error checking to pm_runtime_get_sync
suspend and
resume asynchronously.
Signed-off-by: Andrew Bresticker
Tested-by: Andrew Bresticker
Tested-by: Robert Foss
Signed-off-by: Robert Foss
Reviewed-by: Baolin Wang
---
Changes since v8:
- Rebased on upstream/master
- Added r-b of Baolin Wang
drivers/usb/host/xhci-plat.c | 2 ++
1
Hi Björn,
Thanks for the thorough and explicit feedback, it was rather helpful.
On 2017-04-20 04:32 AM, Bjørn Mork wrote:
Hello Robert,
Sorry for being much too late here, but during recent attemts to debug
issues caused by my commit 833415a3e781 ("cdc-wdm: fix "out-of-sync" due
to missing no
On 2017-04-24 08:02 AM, Bjørn Mork wrote:
Aleksander Morgado writes:
On Thu, Apr 20, 2017 at 10:32 AM, Bjørn Mork wrote:
Sorry for being much too late here, but during recent attemts to debug
issues caused by my commit 833415a3e781 ("cdc-wdm: fix "out-of-sync" due
to missing notifications")
58 matches
Mail list logo
