Hi,
Isn't the "usb_free_all_descriptors(f)" after "fail" label
redundant? Is it needed at all ?
FILE : drivers/usb/gadget/function/f_eem.c
FUNCTION : eem_bind
In fact this can cause "double-free" in case of failures from
"usb_assign_descriptors"; cause
usb_assign_descriptors alread
>From 3272817673910c63682e8b91ce0efaef190a399a Mon Sep 17 00:00:00 2001
From: Pavitra
Date: Fri, 10 Oct 2014 16:05:30 +0530
Subject: [PATCH] usb: gadget: function: Remove redundant
usb_free_all_descriptors
Removed the usb_free_all_descriptors call in *_bind functions
as this call is already pres
0/2014 01:51 PM, pavi1729 ivap wrote:
>>>From 3272817673910c63682e8b91ce0efaef190a399a Mon Sep 17 00:00:00 2001
>> From: Pavitra
>> Date: Fri, 10 Oct 2014 16:05:30 +0530
>> Subject: [PATCH] usb: gadget: function: Remove redundant
>> usb_free_all_descriptors
>>
Oh! precisely what you are saying ..
On Fri, Oct 10, 2014 at 6:21 PM, pavi1729 ivap wrote:
> Rob,
>Got your point, will submit a new patch with a new error label.
> Also I just found that in f_hid.c f_rndis.c and f_uac2.c do need the
> freeing function.
> Will clean it up and
From: Pavitra
Date: Fri, 10 Oct 2014 16:05:30 +0530
Subject: [PATCH] usb: gadget: function: Remove redundant
usb_free_all_descriptors
Removed the usb_free_all_descriptors call in *_bind functions
as this call is already present in usb_assign_descriptors.
usb_assign_descriptors is the only call w
