[PATCH v2] usb_8dev: Add support for USB2CAN interface from 8 devices

2012-12-02 Thread krumbo...@universalnet.at
00..345ce6e --- /dev/null +++ b/drivers/net/can/usb/usb_8dev.c @@ -0,0 +1,1098 @@ +/* + * CAN driver for UAB "8 devices" USB2CAN converter + * + * Copyright (C) 2012 Bernd Krumboeck (krumbo...@universalnet.at) + * + * This program is free software; you can redistribute it and/or modify it

Re: [PATCH v2] usb_8dev: Add support for USB2CAN interface from 8 devices

2012-12-03 Thread krumbo...@universalnet.at
Hi Wolfgang! And please also drop the remaining sysfs files for firmware and hardware. I thinks it's enough that the versions are printed when the device is probed. Systemadministrators often use versions for configuration scripts. If you insist I will remove. +/* + * CAN driver for UAB "8

Re: [PATCH] usb2can: Add support for USB2CAN interface from 8 devices

2012-12-03 Thread krumbo...@universalnet.at
Hi Wolfgang! The Script checkpatch.pl didn't like this comment style. I'll change it again. I'm confused. Could you please show the comment and the checkpatch.pl message. I hope it does not argue against: http://lxr.linux.no/#linux+v3.6.8/Documentation/CodingStyle#L446 ... /* * Send comma

Re: [PATCH v2] usb_8dev: Add support for USB2CAN interface from 8 devices

2012-12-03 Thread krumbo...@universalnet.at
Hi Marc! +/* Send open command to device */ +static int usb_8dev_cmd_open(struct usb_8dev *dev) +{ +struct can_bittiming *bt = &dev->can.bittiming; +struct usb_8dev_cmd_msg outmsg; +struct usb_8dev_cmd_msg inmsg; +u32 flags = 0; +u32 beflags; +u16 bebrp; +u32 ctrlmod

[PATCH v3] usb_8dev: Add support for USB2CAN interface from 8 devices

2012-12-04 Thread krumbo...@universalnet.at
00..9202a12 --- /dev/null +++ b/drivers/net/can/usb/usb_8dev.c @@ -0,0 +1,1093 @@ +/* + * CAN driver for "8 devices" USB2CAN converter + * + * Copyright (C) 2012 Bernd Krumboeck (krumbo...@universalnet.at) + * + * This program is free software; you can redistribute it and/or modify it