only one instance of USB is supported
(including a fix in your latest pull request). To support multi
instance, the biggest obstacle is lack of multi phy support for
usb phy's of same type.
Earlier Kishon was working on usb phy device tree support, later it was
seen that generic phy layer was
On Friday 28 December 2012 12:05 AM, Aaro Koskinen wrote:
Hi,
On Thu, Sep 20, 2012 at 05:21:15AM +0200, Benoit Cousson wrote:
On 09/19/2012 11:32 AM, Kishon Vijay Abraham I wrote:
This patch series adds dt data to get MUSB working in omap4 and omap3
Changes from v2:
* Changes the subject of
Hi,
On Thursday 10 January 2013 03:28 PM, Benoit Cousson wrote:
Hi Kishon,
On 01/10/2013 07:19 AM, kishon wrote:
On Friday 28 December 2012 12:05 AM, Aaro Koskinen wrote:
Hi,
On Thu, Sep 20, 2012 at 05:21:15AM +0200, Benoit Cousson wrote:
On 09/19/2012 11:32 AM, Kishon Vijay Abraham I
Hi Arnd,
On Tuesday 15 January 2013 07:06 PM, Arnd Bergmann wrote:
On Tuesday 15 January 2013, Kishon Vijay Abraham I wrote:
+OMAP CONTROL USB
+
+Required properties:
+ - compatible: Should be "ti,omap-control-usb"
+ - reg : Address and length of the register set for the device. I
On Tuesday 15 January 2013 06:23 PM, Sergei Shtylyov wrote:
Hello.
On 15-01-2013 12:42, Kishon Vijay Abraham I wrote:
A seperate driver has been added to handle the usb part of control
module. A device for the above driver is created here, using the register
address information to be used by
Hi Arnd,
On Tuesday 15 January 2013 07:11 PM, Arnd Bergmann wrote:
On Tuesday 15 January 2013, Kishon Vijay Abraham I wrote:
Added a new driver for the usb part of control module. This has an API
to power on the USB2 phy and an API to write to the mailbox depending on
whether MUSB has to act
Hi Ravi,
On Tuesday 15 January 2013 09:36 PM, B, Ravi wrote:
Hi,
On Tue, Jan 15, 2013 at 08:09:22PM +0530, kishon wrote:
Hi Arnd,
On Tuesday 15 January 2013 07:11 PM, Arnd Bergmann wrote:
On Tuesday 15 January 2013, Kishon Vijay Abraham I wrote:
Added a new driver for the usb part of
Hi,
On Thursday 17 January 2013 03:09 PM, Roger Quadros wrote:
On 01/16/2013 05:00 PM, Kishon Vijay Abraham I wrote:
This is in preparation for the changes in PHY library to support adding
and getting multiple PHYs of the same type. In the new design, the
binding information between the PHY
Hi,
On Thursday 17 January 2013 03:07 PM, Roger Quadros wrote:
On 01/16/2013 05:00 PM, Kishon Vijay Abraham I wrote:
New platforms are added which has multiple PHY's (of same type) and
which has multiple USB controllers. The binding information has to be
present in the PHY library (otg.
Hi,
On Thursday 17 January 2013 05:41 PM, Vivek Gautam wrote:
Hi Kishon,
On Wed, Jan 16, 2013 at 8:30 PM, Kishon Vijay Abraham I wrote:
This is in preparation for the changes in PHY library to support adding
and getting multiple PHYs of the same type. In the new design, the
binding
Hi,
On Thursday 17 January 2013 09:37 PM, Roger Quadros wrote:
On 01/16/2013 05:00 PM, Kishon Vijay Abraham I wrote:
In order to add support for multipe PHY's of the same type, the API's
for adding PHY and getting PHY has been changed. Now the binding
information of the PHY and
S539 SuperSpeed SATA II 3.0G Bridge
Device Descriptor:
You are connecting to the wrong port.
Try connecting to bus2 which seems to have usb3.
Bus 002 Device 001: ID 1d6b:0003 Linux Foundation 3.0 root hub.
.
.
bcdUSB 3.00
.
.
Thanks
Kishon
--
To unsubscribe from this list: send the li
On Friday 18 January 2013 05:18 PM, Felipe Balbi wrote:
On Wed, Jan 16, 2013 at 08:30:56PM +0530, Kishon Vijay Abraham I wrote:
New platforms are being added which has multiple PHY's (of same type) and
which has multiple USB controllers. The binding information has to be
present in th
Hi,
On Friday 18 January 2013 05:29 PM, Felipe Balbi wrote:
Hi,
On Fri, Jan 18, 2013 at 03:10:42PM +0530, Kishon Vijay Abraham I wrote:
Added a new driver for the usb part of control module. This has an API
to power on the USB2 phy and an API to write to the mailbox depending on
whether MUSB
On Friday 18 January 2013 05:32 PM, Felipe Balbi wrote:
Hi,
On Fri, Jan 18, 2013 at 03:10:45PM +0530, Kishon Vijay Abraham I wrote:
Start using the control module driver for powering on the PHY and for
writing to the mailbox instead of writing to the control module
registers on their own
On Monday 21 January 2013 06:51 PM, Roger Quadros wrote:
On 01/16/2013 05:01 PM, Kishon Vijay Abraham I wrote:
Added an API devm_usb_get_phy_by_phandle(), to get usb phy by passing a
device node phandle value. This function will return a pointer to
the phy on success, -EPROBE_DEFER if there is
Hi,
On Monday 21 January 2013 06:48 PM, Roger Quadros wrote:
On 01/16/2013 05:01 PM, Kishon Vijay Abraham I wrote:
The OMAP glue has been modified to get PHY by phandle for dt boot.
Signed-off-by: Kishon Vijay Abraham I
---
drivers/usb/musb/omap2430.c |7 ++-
1 file changed, 6
Hi,
On Monday 21 January 2013 10:52 PM, Sergei Shtylyov wrote:
Hello.
On 01/21/2013 05:52 PM, Kishon Vijay Abraham I wrote:
No functional change. Just added a missing newline character.
Signed-off-by: Kishon Vijay Abraham I
---
drivers/usb/musb/musb_core.c |2 +-
1 file changed, 1
Hi,
On Tuesday 22 January 2013 07:37 PM, Roger Quadros wrote:
On 01/22/2013 11:58 AM, Kishon Vijay Abraham I wrote:
In order to add support for multipe PHY's of the same type, new API's
for adding PHY and getting PHY has been added. Now the binding
information for the PHY and control
On Tuesday 22 January 2013 07:47 PM, Roger Quadros wrote:
On 01/22/2013 11:58 AM, Kishon Vijay Abraham I wrote:
The OMAP glue has been modified to get PHY by phandle for dt boot.
Signed-off-by: Kishon Vijay Abraham I
---
drivers/usb/musb/omap2430.c |7 ++-
1 file changed, 6
On Tuesday 22 January 2013 08:17 PM, Roger Quadros wrote:
On 01/22/2013 04:37 PM, kishon wrote:
On Tuesday 22 January 2013 07:47 PM, Roger Quadros wrote:
On 01/22/2013 11:58 AM, Kishon Vijay Abraham I wrote:
The OMAP glue has been modified to get PHY by phandle for dt boot.
Signed-off-by
spin_unlock_irqrestore(&phy_lock, flags);
+
+ return phy;
+}
This means that on all of the exit paths, node's refcount is left incremented
incorrectly. You'll need an of_node_put(node) on each exit path.
Ok. Will fix it.
Thanks
Kishon
--
To unsubscribe from thi
Hi,
On Tuesday 22 January 2013 09:08 PM, Peter Ujfalusi wrote:
On 01/22/2013 04:21 PM, kishon wrote:
But it's better to check if deferred probing
takes place whenever a new driver is bound to a device as you just mentioned.
Whenever you load (might be also when you unload) a drive
On Tuesday 22 January 2013 09:11 PM, Koen Kooi wrote:
Op 22 jan. 2013, om 10:58 heeft Kishon Vijay Abraham I het
volgende geschreven:
This patch series adds support for adding multiple PHY's (of same type).
The binding information has to be present in the PHY library (otg.c) in
order f
Hi,
On Tuesday 22 January 2013 09:15 PM, kishon wrote:
On Tuesday 22 January 2013 09:11 PM, Koen Kooi wrote:
Op 22 jan. 2013, om 10:58 heeft Kishon Vijay Abraham I
het volgende geschreven:
This patch series adds support for adding multiple PHY's (of same type).
The binding informatio
On Tuesday 22 January 2013 10:32 PM, Koen Kooi wrote:
Op 22 jan. 2013, om 17:16 heeft kishon het volgende geschreven:
Hi,
On Tuesday 22 January 2013 09:15 PM, kishon wrote:
On Tuesday 22 January 2013 09:11 PM, Koen Kooi wrote:
Op 22 jan. 2013, om 10:58 heeft Kishon Vijay Abraham I
het
easy enough to patch in locally.
USB first instance of am335x works in mainline as of now.
Can you check if this series indeed breaks am335x?
Thanks for your help.
Regards
Kishon
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message
Hi,
On Tuesday 22 January 2013 07:39 PM, Roger Quadros wrote:
On 01/22/2013 11:58 AM, Kishon Vijay Abraham I wrote:
New PHY lib APIs like usb_add_phy_dev() and devm_usb_get_phy_dev() are
used in MUSB (OMAP), in order to make use of the binding information
provided in the board file (of OMAP
On Friday 25 January 2013 01:18 PM, Felipe Balbi wrote:
On Thu, Jan 24, 2013 at 09:32:46PM -0800, Stephen Warren wrote:
On 01/24/2013 06:19 PM, Kishon Vijay Abraham I wrote:
Added a new driver for the usb part of control module. This has an API
to power on the USB2 phy and an API to write to
On Friday 25 January 2013 01:13 PM, Felipe Balbi wrote:
Hi,
On Fri, Jan 25, 2013 at 08:42:24AM +0530, Kishon Vijay Abraham I wrote:
palmas-usb is made as a comparator driver to omap usb2 phy, so that
omap usb can make use of palmas for srp and also to set vbus.
Signed-off-by: Kishon Vijay
On Friday 25 January 2013 02:15 PM, Felipe Balbi wrote:
hi,
On Fri, Jan 25, 2013 at 02:12:41PM +0530, kishon wrote:
On Friday 25 January 2013 01:18 PM, Felipe Balbi wrote:
On Thu, Jan 24, 2013 at 09:32:46PM -0800, Stephen Warren wrote:
On 01/24/2013 06:19 PM, Kishon Vijay Abraham I wrote
On Friday 25 January 2013 03:57 PM, Felipe Balbi wrote:
Hi,
On Fri, Jan 25, 2013 at 03:54:00PM +0530, Kishon Vijay Abraham I wrote:
Start using the control module driver for powering on the PHY and for
writing to the mailbox instead of writing to the control module
registers on their own
return USB_DR_MODE_UNKNOWN;
+
+ for (i = 0; i < ARRAY_SIZE(usb_dr_modes); i++)
+ if (!strcasecmp(dr_mode, usb_dr_modes[i]))
+ return i;
Same comment applies here too.
Thanks
Kishon
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
have a corresponding *enum* representing the
drivers :-)
I don't mind having readable devicetrees. And we have it for ethernet
phys already with strings, so it would be consistent.
Ok. Fine with it then :-)
Thanks
Kishon
--
To unsubscribe from this list: send the line "unsubscribe linux-us
On Wednesday 30 January 2013 02:00 AM, Sascha Hauer wrote:
On Tue, Jan 29, 2013 at 07:14:51PM +0530, kishon wrote:
Hi,
On Tuesday 29 January 2013 04:52 PM, Sascha Hauer wrote:
From: Michael Grzeschik
This adds two little devicetree helper functions for determining the
dr_mode (host
n 0;
+}
+
+#define CI_VBUS_STABLE_TIMEOUT 500
Just curious.. how was this timeout value obtained?
Thanks
Kishon
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi,
On Wednesday 30 January 2013 03:41 PM, Sascha Hauer wrote:
On Wed, Jan 30, 2013 at 11:21:35AM +0530, kishon wrote:
On Wednesday 30 January 2013 02:00 AM, Sascha Hauer wrote:
On Tue, Jan 29, 2013 at 07:14:51PM +0530, kishon wrote:
Hi,
On Tuesday 29 January 2013 04:52 PM, Sascha Hauer
e given device_node
+ *
+ * The function gets phy interface string from property 'phy_type',
+ * and returns the correspondig enum usb_phy_interface
+ */
+enum usb_phy_interface of_usb_get_phy_mode(struct device_node *np)
+{
You agreed to move this function inside usb/phy.. no?
Thanks
Kishon
--
To
On Thursday 31 January 2013 01:13 PM, Sascha Hauer wrote:
On Thu, Jan 31, 2013 at 11:44:21AM +0530, kishon wrote:
Hi,
On Wednesday 30 January 2013 08:59 PM, Sascha Hauer wrote:
From: Michael Grzeschik
This adds two little devicetree helper functions for determining the
dr_mode (host
(at your option) any later version.
But your *MODULE_LICENSE("GPL")* below tells it's only GPL.
+ */
.
.
.
.
MODULE_LICENSE("GPL");
Thanks
Kishon
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to
Hi,
On Thursday 31 January 2013 02:31 PM, Sascha Hauer wrote:
Most of otg/otg.c is not otg specific, but phy specific, so move it
to the phy directory.
Signed-off-by: Sascha Hauer
Reported-by: kishon
Kishon Vijay Abraham I pls..
Thanks
Kishon
--
To unsubscribe from this list: send the
On Thursday 31 January 2013 02:58 PM, Sascha Hauer wrote:
On Thu, Jan 31, 2013 at 02:42:48PM +0530, kishon wrote:
Hi,
On Thursday 31 January 2013 02:31 PM, Sascha Hauer wrote:
From: Michael Grzeschik
This adds two little devicetree helper functions for determining the
dr_mode (host
dt.
I think, instead you can have a patch to use devm_usb_get_phy_dev() here
and in exynos platform specific code use usb_bind_phy() to bind the phy
and controller till you change it to dt.
In such cases, dwc3 should expect PHYs from its parent's node.
NAK.
Thanks
Kishon
--
To unsubscribe
Hi,
On Thursday 31 January 2013 05:02 PM, Sascha Hauer wrote:
Signed-off-by: Sascha Hauer
Some maintainers don't accept patches without a commit message.
Apart from that you can add,
Reviewed-by: Kishon Vijay Abraham I
Thanks
Kishon
--
To unsubscribe from this list: send the
On Thursday 31 January 2013 05:02 PM, Sascha Hauer wrote:
We now have usb_add_phy_dev(), so use it to register with the framework
to be able to find the phy from the USB driver.
Signed-off-by: Sascha Hauer
Reviewed-by: Kishon Vijay Abraham I
---
drivers/usb/otg/mxs-phy.c |9
;m not sure if there is any other better way to achieve the same
(without patching of.c ;-))
Thanks
Kishon
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi,
On Saturday 02 February 2013 02:43 AM, Marc Kleine-Budde wrote:
On 01/25/2013 03:33 AM, Kishon Vijay Abraham I wrote:
In order to support platforms which has multiple PHY's (of same type) and
which has multiple USB controllers, a new design is adopted wherin the binding
inform
-usb-xceiv.h
index 3265b61..148d351 100644
--- a/include/linux/usb/nop-usb-xceiv.h
+++ b/include/linux/usb/nop-usb-xceiv.h
@@ -6,6 +6,10 @@
struct nop_usb_xceiv_platform_data {
enum usb_phy_type type;
unsigned long clk_rate;
+
+ /* if set fails with -EPROBE_DEFER if can't ge
interrupts : should contain the TLL module's interrupt
+- ti,hwmod : must contain "usb_tll_hs"
+
+Example:
+
+ usbhstll: usbhstll@0x4a062000 {
The node name shouldn't have 0x. This comment applies to all your
patches adding device tree support.
Thanks
Kishon
--
To unsubs
}
+
+ } else {
+ ret = omap_usbhs_alloc_children(pdev);
+ if (ret) {
+ dev_err(dev, "omap_usbhs_alloc_children failed: %d\n",
+ ret);
+ goto err_alloc;
+ }
These child devices should be destroyed on driver remove..no?
Thanks
Kishon
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
interrupt-parent = <&gic>;
Just curious.. Were you facing issues if you are not having
interrupt-parent here? It's also missing in your dt node usbhstll.
Thanks
Kishon
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tuesday 05 February 2013 02:24 PM, Roger Quadros wrote:
On 02/05/2013 08:24 AM, kishon wrote:
On Monday 04 February 2013 09:28 PM, Roger Quadros wrote:
Adds device nodes for HS USB Host module, TLL module,
OHCI and EHCI controllers.
Signed-off-by: Roger Quadros
---
arch/arm/boot/dts
Hi,
On Tuesday 05 February 2013 04:28 PM, Roger Quadros wrote:
On 02/05/2013 08:16 AM, kishon wrote:
On Monday 04 February 2013 09:28 PM, Roger Quadros wrote:
Allows the OMAP HS USB host controller to be specified
via device tree.
CC: Samuel Ortiz
Signed-off-by: Roger Quadros
n usb-next.
Thanks
Kishon
The following changes since commit 88b62b915b0b7e25870eb0604ed9a92ba4bfc9f7:
Linux 3.8-rc6 (2013-02-01 12:08:14 +1100)
are available in the git repository at:
git://gitorious.org/linux-usb/linux-usb.git arm-usb-dt
for you to fetch changes
Hi Tony, Greg,
On Tuesday 05 February 2013 08:54 PM, kishon wrote:
Hi Tony,
As discussed, I'm sending a pull request for the arch/arm part of my USB
patches. These patches are necessary to get MUSB functional in both dt
and non-dt boot. Also added dt data for dwc3 present in OMAP. This
v_err(&pdev->dev, "error parse dt\n");
+ return ret;
+ }
+ r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
+ if (r == NULL) {
+ dev_err(&pdev->dev, "no phy I/O memory resource defined\n");
+ return -ENODE
in memory. The corresponding module_put() is missing in that patch.
This patch adds try_module_get() to usb_get_phy() and usb_get_phy_dev().
Further the missing module_put() is added to usb_put_phy().
Signed-off-by: Marc Kleine-Budde
---
Kishon, does this look ok for you ?
yes Felipe.
R
Hi,
On Wednesday 06 February 2013 01:48 PM, Chao Xie wrote:
On Wed, Feb 6, 2013 at 4:10 PM, kishon wrote:
Hi,
On Wednesday 06 February 2013 12:53 PM, Chao Xie wrote:
The PHY is seperated from usb controller.
The usb controller used in marvell pxa168/pxa910/mmp2 are same,
but PHY
Hi,
On Thursday 07 February 2013 07:56 AM, Chao Xie wrote:
On Wed, Feb 6, 2013 at 6:35 PM, kishon wrote:
Hi,
On Wednesday 06 February 2013 01:48 PM, Chao Xie wrote:
On Wed, Feb 6, 2013 at 4:10 PM, kishon wrote:
Hi,
On Wednesday 06 February 2013 12:53 PM, Chao Xie wrote:
The PHY is
t = <1>;
+num_eps = <16>;
+ram_bits = <12>;
Where are these bindings documented? The general convention is to use
a '-' for property names and not '_'
It's documented in Documentation/devicetree/bindings/usb/omap-usb.txt
Actua
nd when the controller
+ * requests this phy.
+ *
+ * To be used by platform specific initialization code.
+ */
+int __init usb_bind_phy(const char *dev_name, u8 index,
+ const char *phy_dev_name)
+{
+ struct usb_phy_bind *phy_bind;
+ unsigned long flags;
+
+ phy_bind = kzalloc(sizeof(*phy_bind), GFP_KERNEL);
+ if (!phy_bind) {
+ pr_err("phy_bind(): No memory for phy_bind");
+ return -ENOMEM;
+ }
+
+ phy_bind->dev_name = dev_name;
+ phy_bind->phy_dev_name = phy_dev_name;
+ phy_bind->index = index;
+
+ spin_lock_irqsave(&phy_lock, flags);
+ list_add_tail(&phy_bind->list, &phy_bind_list);
+ spin_unlock_irqrestore(&phy_lock, flags);
+
+ return 0;
+}
+EXPORT_SYMBOL_GPL(usb_bind_phy);
+
+
Unnecessary spaces here.
You might want to do this patch after applying *[PATCH] usb: otg: use
try_module_get in all usb_get_phy functions and add missing module_put*
by Marc.
This patch should go to mainline ASAP since it allows drivers other than
otg controllers to make use of PHY library.
Reviewed-by: Kishon Vijay Abraham I
Thanks
Kishon
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
(xhci_plat_suspend, xhci_plat_resume)
+};
"#endif" should be here.
Also a macro should be added and set to NULL if CONFIG_PM_SLEEP is not
defined. Just like how .pm in many other drivers is done.
Thanks
Kishon
--
To unsubscribe from this list: send the line "unsubscribe linux-usb&qu
g made too
oncece @prepare() has succeeded.
Thanks
Kishon
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
.
It can work only till retention or it can work with off-mode too with
this series? Form what I could make out, it'll work till retention. right?
Thanks
Kishon
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.
Hi,
On Monday 11 February 2013 05:07 PM, Felipe Balbi wrote:
On Mon, Feb 11, 2013 at 05:02:15PM +0530, kishon wrote:
Hi,
On Monday 11 February 2013 03:22 PM, Felipe Balbi wrote:
Add support for basic power management on
the dwc3 driver. While there is still lots
to improve for full PM
Hi,
On Monday 11 February 2013 07:32 PM, Felipe Balbi wrote:
On Mon, Feb 11, 2013 at 03:58:44PM +0200, Felipe Balbi wrote:
On Mon, Feb 11, 2013 at 03:55:06PM +0200, Felipe Balbi wrote:
Hi,
On Mon, Feb 11, 2013 at 05:26:41PM +0530, kishon wrote:
Hi,
On Monday 11 February 2013 05:07 PM
License for more details.
+ *
+ */
+
+#ifndef __MV_USB2_H
+#define __MV_USB2_H
+
+#define MV_USB2_PHY_INDEX 0
+#define MV_USB2_OTG_PHY_INDEX 1
+
+struct mv_usb2_phy {
+ struct usb_phy phy;
+ struct platform_device *pdev;
+ struct mutexphy_lock;
+ unsigned intrefcount;
+ unsigned inttype;
+ void __iomem*base;
+ struct clk **clks;
+ unsigned intclks_num;
+};
+
+#if defined(CONFIG_MV_USB2_PHY) || defined(CONFIG_MV_USB2_PHY_MODULE)
+
+
+#else
+
+
+#endif
This should be removed.
Thanks
Kishon
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
his. Consider the case where
devm_usb_get_phy_dev returns -EPROBE_DEFER. In that case you should
return -EPROBE_DEFER from probe instead of manually writing the return
value to -ENODEV.
This comment is applicable for the remaining patches that uses
devm_usb_get_phy_dev.
Thanks
Kishon
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi,
On Tuesday 19 February 2013 04:14 PM, Arnd Bergmann wrote:
On Tuesday 19 February 2013, Kishon Vijay Abraham I wrote:
Added a generic PHY framework that provides a set of APIs for the PHY drivers
to create/destroy a PHY and APIs for the PHY users to obtain a reference to
the PHY with or
Hi,
On Tuesday 19 February 2013 06:26 PM, Arnd Bergmann wrote:
On Tuesday 19 February 2013, Kishon Vijay Abraham I wrote:
+static struct class *phy_class;
+static LIST_HEAD(phy_list);
+static DEFINE_MUTEX(phy_list_mutex);
+static LIST_HEAD(phy_bind_list);
Hmm, so you actually do have a
Hi,
On Sunday 24 February 2013 04:14 AM, Rob Landley wrote:
On 02/18/2013 11:53:14 PM, Kishon Vijay Abraham I wrote:
The PHY framework provides a set of APIs for the PHY drivers to
create/destroy a PHY and APIs for the PHY users to obtain a reference
to the
PHY with or without using phandle
c3-omap: remove platform data associated with
dwc3-omap
[PATCH v3 08/11] usb: dwc3-omap: stop using nop-usb-xceiv
Thanks
Kishon
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://
On Tuesday 26 February 2013 07:20 PM, Felipe Balbi wrote:
On Tue, Feb 26, 2013 at 07:17:30PM +0530, kishon wrote:
Hi Felipe,
On Tuesday 26 February 2013 03:04 PM, Felipe Balbi wrote:
OMAP5 won't support non-DT boot, so instead of:
if (node)
foo();
return 0;
which returns zero
sb_put_phy().
Reviewed-by: Kishon Vijay Abraham I
Acked-by: Felipe Balbi
Signed-off-by: Marc Kleine-Budde
Signed-off-by: Michael Grzeschik
---
drivers/usb/otg/otg.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/otg/otg.c b/drivers/usb/otg/otg.c
ind
Hi,
On Tuesday 05 March 2013 08:26 PM, Felipe Balbi wrote:
On Tue, Mar 05, 2013 at 07:51:58PM +0530, Kishon Vijay Abraham I wrote:
return -EPROBE_DEFER from dwc3_omap_mailbox in dwc3-omap.c, if the probe of
dwc3-omap has not yet been executed or failed.
Signed-off-by: Kishon Vijay Abraham I
Hi,
On Tuesday 05 March 2013 08:11 PM, Sergei Shtylyov wrote:
Hello.
On 05-03-2013 18:37, Kishon Vijay Abraham I wrote:
Add dwc3 omap glue data to the omap5 dt data file. The information about
the dt node added here is available @
Documentation/devicetree/bindings/usb/omap-usb.txt
Signed
Hi,
On Tuesday 05 March 2013 08:24 PM, Felipe Balbi wrote:
On Tue, Mar 05, 2013 at 07:51:57PM +0530, Kishon Vijay Abraham I wrote:
While creating the child devices, *of_platform_populate* sets only
coherent_dma_mask but USBHCD sets *uses_dma* (determines whether the
controller is DMA'
Hi,
On Tuesday 05 March 2013 08:36 PM, Felipe Balbi wrote:
On Tue, Mar 05, 2013 at 08:31:58PM +0530, kishon wrote:
Hi,
On Tuesday 05 March 2013 08:26 PM, Felipe Balbi wrote:
On Tue, Mar 05, 2013 at 07:51:58PM +0530, Kishon Vijay Abraham I wrote:
return -EPROBE_DEFER from dwc3_omap_mailbox
Hi,
On Tuesday 05 March 2013 08:09 PM, Felipe Balbi wrote:
Hi,
On Tue, Mar 05, 2013 at 08:07:03PM +0530, Kishon Vijay Abraham I wrote:
Add dwc3 core dt data as a subnode to dwc3 omap glue data in omap5 dt
data file. The information for the entered data node is available @
Documentation
On Wednesday 06 March 2013 02:49 PM, Felipe Balbi wrote:
Hi,
On Wed, Mar 06, 2013 at 02:25:48PM +0530, kishon wrote:
Hi,
On Tuesday 05 March 2013 08:09 PM, Felipe Balbi wrote:
Hi,
On Tue, Mar 05, 2013 at 08:07:03PM +0530, Kishon Vijay Abraham I wrote:
Add dwc3 core dt data as a subnode to
't HSIC supposed to be PHYless devices. Maybe a comment
explaining it might be helpful.
Thanks
Kishon
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
breaking PM.
Did you actually observed multiple interrupts? Actually we thought
debouncing should be handled in hardware.
The same goes for initial state, glue already defaults to "no cable"
state, so only bother it if we have VBUS or ID.
Signed-off-by: Grazvydas Ignotas
Reviewed-
->interface_type == MUSB_INTERFACE_UTMI) {
if (musb->xceiv->otg->set_vbus)
otg_set_vbus(musb->xceiv->otg, 0);
Shouldn't this otg_set_vbus be done inside omap2430_musb_set_vbus? Any
idea why they were doing this only for UTMI
Benoit,
Will you be queuing this patch series?
Thanks
Kishon
On Thursday 07 March 2013 07:05 PM, Kishon Vijay Abraham I wrote:
Hi Benoit,
Here are the dt data patches to get usb device functional in OMAP platforms.
All the patches deal with modifying arch/arm/boot except one which modifies
On Thursday 14 March 2013 03:29 AM, Grazvydas Ignotas wrote:
On Wed, Mar 13, 2013 at 10:47 AM, Kishon Vijay Abraham I wrote:
In the case where omap glue is loaded and musb core is not, glue->status
wont have a valid status if the phy drivers call omap_musb_mailbox. So
fixed the conditions h
On Thursday 14 March 2013 07:03 PM, Felipe Balbi wrote:
On Thu, Mar 14, 2013 at 11:53:55AM +0530, Kishon Vijay Abraham I wrote:
This series has some misc cleanup and fixes. The fix solves the cold
plug issue in omap3 which some have reported. Developed these patches on
fixes-for-v3.9-rc3 after
On Thursday 14 March 2013 08:17 PM, Felipe Balbi wrote:
On Thu, Mar 14, 2013 at 08:15:00PM +0530, kishon wrote:
On Thursday 14 March 2013 07:03 PM, Felipe Balbi wrote:
On Thu, Mar 14, 2013 at 11:53:55AM +0530, Kishon Vijay Abraham I wrote:
This series has some misc cleanup and fixes. The fix
On Thursday 14 March 2013 07:26 PM, Felipe Balbi wrote:
On Thu, Mar 07, 2013 at 06:51:45PM +0530, Kishon Vijay Abraham I wrote:
From: Graeme Gregory
This is the driver for the OTG transceiver built into the Palmas chip. It
handles the various USB OTG events that can be generated by cable
s as below:
- return IS_ERR(phy) ? PTR_ERR(phy) : -ENODEV;
+ return PTR_ERR(phy);
Reported-by: Alan Stern
Signed-off-by: Felipe Balbi
---
Kishon, what do you think of this patch ?
This looks correct.
Acked-by: Kishon Vijay Abraham I
Thanks
Kishon
--
To unsubscribe from this list: sen
On Friday 15 March 2013 06:11 PM, Benoit Cousson wrote:
+ Jon
Hi Kishon,
On 03/07/2013 02:35 PM, Kishon Vijay Abraham I wrote:
Hi Benoit,
Here are the dt data patches to get usb device functional in OMAP platforms.
All the patches deal with modifying arch/arm/boot except one which modifies
On Friday 15 March 2013 07:55 PM, Felipe Balbi wrote:
On Fri, Mar 15, 2013 at 06:58:49PM +0530, Kishon Vijay Abraham I wrote:
commit 63378a (usb: phy: remove CONFIG_USB_OTG_UTILS) removed
CONFIG_USB_OTG_UTILS from Kconfig but failed to removed from Makefile.
Fixed it here.
Signed-off-by
On Friday 15 March 2013 08:09 PM, Felipe Balbi wrote:
From: Kishon Vijay Abraham I
musb does not use DMA buffer for ep0 but it uses the same giveback
function *musb_g_giveback* for all endpoints (*musb_g_ep0_giveback* calls
*musb_g_giveback*). So for ep0 case request.dma will be '0'
On Monday 18 March 2013 01:37 PM, Felipe Balbi wrote:
On Fri, Mar 15, 2013 at 09:37:36PM +0530, kishon wrote:
On Friday 15 March 2013 08:09 PM, Felipe Balbi wrote:
From: Kishon Vijay Abraham I
musb does not use DMA buffer for ep0 but it uses the same giveback
function *musb_g_giveback* for
On Monday 18 March 2013 02:12 PM, Felipe Balbi wrote:
Hi,
On Mon, Mar 18, 2013 at 01:50:55PM +0530, kishon wrote:
@@ -141,7 +141,7 @@ static inline void map_dma_buffer(struct musb_request
*request,
static inline void unmap_dma_buffer(struct musb_request *request
- - phy_type : Should be one of "ulpi" or "utmi".
+ - reg : Defines the following set of registers, in the order listed:
+ - The PHY's own register set.
+ Always present.
+ - The register set of the PHY containing the UTMI pad control registers.
+ Present if-and-only
s which doesn't have *reg* property.
Thanks
Kishon
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Felipe,
On Wednesday 20 March 2013 06:42 PM, Felipe Balbi wrote:
On Wed, Mar 13, 2013 at 02:17:05PM +0530, Kishon Vijay Abraham I wrote:
This series has some misc cleanup and fixes. The fix solves the cold
plug issue in omap3 which some have reported. Developed these patches on
Linux 3.9-rc2
Hi,
On Thursday 21 March 2013 04:06 AM, Sylwester Nawrocki wrote:
Hi Kishon,
On 03/20/2013 10:12 AM, Kishon Vijay Abraham I wrote:
The PHY framework provides a set of APIs for the PHY drivers to
create/destroy a PHY and APIs for the PHY users to obtain a reference
to the
PHY with or without
Hi,
On Wednesday 20 March 2013 10:21 PM, Tony Lindgren wrote:
* Kishon Vijay Abraham I [130320 02:17]:
--- a/arch/arm/mach-omap2/board-2430sdp.c
+++ b/arch/arm/mach-omap2/board-2430sdp.c
@@ -265,6 +266,7 @@ static void __init omap_2430sdp_init(void)
omap_mux_init_signal("usb0h
Hi,
On Thursday 21 March 2013 02:29 AM, Stephen Warren wrote:
On 03/20/2013 03:12 AM, Kishon Vijay Abraham I wrote:
Updated the usb_otg_hs dt data to include the *phy* and *phy-names*
binding in order for the driver to use the new generic PHY framework.
Also updated the Documentation to
1 - 100 of 1344 matches
Mail list logo
