> + int i;
>> +
>> + /* Crude hack to ensure that we don't overwrite memory
>> +* if an odd length is supplied
Have a look at asix_get_eeprom() in asix_common.c for a better
implementation. There is also code for programming the eeprom
(asix_set_eeprom in asix_c
ørn, I am trying to reproduce the issue mentioned by Michael and I have a
question about submitting this driver.
Should I merge this driver into asix_devices.c and asix_common.c even through
the usb command, tx_fixup, and rx_fixup functions are totally different?
Thank you in advance for your reply.
On 02/07/2013 01:46 PM, Stephen Hemminger wrote:
On Thu, 7 Feb 2013 12:36:34 +0800
Freddy Xin wrote:
+static struct ethtool_ops ax88179_ethtool_ops = {
+ .get_link = ethtool_op_get_link,
+ .get_msglevel = usbnet_get_msglevel,
+ .set_msglevel
On 02/08/2013 04:02 AM, Ben Hutchings wrote:
On Thu, 2013-02-07 at 21:39 +0800, Freddy Xin wrote:
From: Freddy Xin
This is a resubmission.
Added "const" to ethtool_ops structure and fixed the coding style of
AX88179_BULKIN_SIZE array.
Fixed the issue that the default MTU is not 1
From: Freddy Xin
Disable TSO and SG network features in reset() and bind() functions,
and check the return value of skb_linearize() in tx_fixup() to prevent
TX throttling.
Signed-off-by: Freddy Xin
---
drivers/net/usb/ax88179_178a.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions
From: Freddy Xin
Correct the definition of AX_RXHDR_CRC_ERR and
AX_RXHDR_DROP_ERR. They are BIT29 and BIT31 in pkt_hdr
seperately.
Add VID:DID for Samsung USB Ethernet Adapter.
Signed-off-by: Freddy Xin
---
drivers/net/usb/ax88179_178a.c | 23 ---
1 file changed, 20
From: Freddy Xin
Correct the definition of AX_RXHDR_CRC_ERR and
AX_RXHDR_DROP_ERR. They are BIT29 and BIT31 in pkt_hdr
seperately.
Signed-off-by: Freddy Xin
---
drivers/net/usb/ax88179_178a.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/usb
From: Freddy Xin
Add VID:DID for Samsung USB Ethernet Adapter.
Signed-off-by: Freddy Xin
---
drivers/net/usb/ax88179_178a.c | 19 ++-
1 file changed, 18 insertions(+), 1 deletion(-)
diff --git a/drivers/net/usb/ax88179_178a.c b/drivers/net/usb/ax88179_178a.c
index 3569293
From: Freddy Xin
Add VID:DID for Samsung USB Ethernet Adapter.
Signed-off-by: Freddy Xin
---
drivers/net/usb/ax88179_178a.c | 19 ++-
1 file changed, 18 insertions(+), 1 deletion(-)
diff --git a/drivers/net/usb/ax88179_178a.c b/drivers/net/usb/ax88179_178a.c
index 3bcd0d9
From: Freddy Xin
Correct the definition of AX_RXHDR_CRC_ERR and
AX_RXHDR_DROP_ERR. They are BIT29 and BIT31 in pkt_hdr
seperately.
Signed-off-by: Freddy Xin
---
drivers/net/usb/ax88179_178a.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/usb
From: Freddy Xin
Remove AX_MEDIUM_ALWAYS_ONE in AX_MEDIUM_STATUS_MODE register.
Setting this bit may cause TX throttling in Half-Duplex mode.
Signed-off-by: Freddy Xin
---
drivers/net/usb/ax88179_178a.c | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers
From: Freddy Xin
This patch adds a workaroud to solve Suspend/Resume issue that AX88772B turns
off its Ethernet PHY power in the case that REMOTE_WAKEUP feature doesn't
be set when system suspend. In this case, the PHY power will not be turned
on again when system resume, so the HW reset mu
From: Freddy Xin
The AX88179_178A has a hardware feature that it can insert a 2-bytes pseudo
header in front of each received frame by setting the AX_RX_CTL_IPE bit.
This feature is used to let the IP header be aligned on a doubleword-aligned
address,
but the NET_IP_ALIGN may equals to 2 and
From: Freddy Xin
The AX88179_178A has a hardware feature that it can insert a
2-bytes pseudo header in front of each received frame by setting
the AX_RX_CTL_IPE bit. This feature is used to let the IP header
be aligned on a doubleword-aligned address, so the rx_submit() of
usbnet.c needn&#
From: Freddy Xin
Add VID:DID for Lenovo OneLinkDock Gigabit LAN
Signed-off-by: Freddy Xin
---
drivers/net/usb/ax88179_178a.c | 17 +
1 file changed, 17 insertions(+)
diff --git a/drivers/net/usb/ax88179_178a.c b/drivers/net/usb/ax88179_178a.c
index 955df81..460e823 100644
From: Freddy Xin
Add functions to support ethtool EEE manipulating, and the EEE
is disabled in default setting to enhance the compatibility
with certain switch.
Signed-off-by: Freddy Xin
---
drivers/net/usb/ax88179_178a.c | 264 +
1 file changed, 264
.
Signed-off-by: Freddy Xin
---
drivers/net/usb/Kconfig| 18 +
drivers/net/usb/Makefile |1 +
drivers/net/usb/ax88179_178a.c | 1424
3 files changed, 1443 insertions(+)
create mode 100644 drivers/net/usb/ax88179_178a.c
diff --git a/d
From: Freddy Xin
This is a resubmission.
Fixed coding style errors.
The _nopm version usb functions were added to access register in suspend and
resume functions.
Serveral variables allocted dynamically were removed and replaced by stack
variables.
ax88179_get_eeprom were modified from
From: Freddy Xin
This is a resubmission.
Fixed the issue that the default MTU is not 1500.
Added ax88179_change_mtu function and enabled the hardware jumbo frame function
to support an
MTU higher than 1500.
Fixed indentation and empty line coding style errors.
The _nopm version usb functions
From: Freddy Xin
This is a resubmission.
Added "const" to ethtool_ops structure and fixed the coding style of
AX88179_BULKIN_SIZE array.
Fixed the issue that the default MTU is not 1500.
Added ax88179_change_mtu function and enabled the hardware jumbo frame function
to support an
From: Freddy Xin
This is a resubmission.
Fixed endianness issue on big endian systems and verified this driver on iBook
G4.
Removed steps that change net->features in ax88179_set_features function.
Added "const" to ethtool_ops structure and fixed the coding style of
AX88179_BULK
From: Freddy Xin
This is a resubmission.
Added kfree() in ax88179_get_eeprom to prevent memory leakage.
Modified "__le16 rxctl" to "u16 rxctl" in "struct ax88179_data" and removed
pointless casts.
Removed asix_init and asix_exit functions and added
"mo
On 2013年12月10日 09:01, David Miller wrote:
From: fre...@asix.com.tw
Date: Fri, 6 Dec 2013 17:58:18 +0800
From: Freddy Xin
The AX88179_178A has a hardware feature that it can insert a 2-bytes pseudo
header in front of each received frame by setting the AX_RX_CTL_IPE bit.
This feature is used
NET_IP_ALIGN bytes for each SKB.
Freddy
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
to
NET_IP_ALIGN in USBNET, and I can change its value to
0 in AX88179_178A driver, right?
Freddy
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
25 matches
Mail list logo
