Re: [PATCH 1/1] usb,uhci: add a new tag for virtual uhci devices

2013-06-30 Thread ZhenHua
On 06/28/2013 10:22 PM, Alan Stern wrote: On Fri, 28 Jun 2013, Li, Zhen-Hua (USL-China) wrote: There was a problem, the warning "Controller not stopped yet". And your last patch for this problem does a wrong thing: It prevents all HP uhci devices from auto-stop, which make HP uhci devices waste

Re: [PATCH 1/1] driver,usb: Fix a warning in uhci-hcd driver

2013-04-23 Thread ZhenHua
On 04/23/2013 10:07 PM, Greg KH wrote: On Tue, Apr 23, 2013 at 03:15:01PM +0800, Li, Zhen-Hua wrote: From: "Li, Zhen-Hua" This patch is trying to fix bug QXCR1001261767. Sorry for the bug number. Please ignore this line. What is that bug number? Where can it be referenced? If you are goin

Re: [PATCH 1/1] driver,usb: Fix a warning in uhci-hcd driver

2013-04-23 Thread ZhenHua
! Thanks Zhen-Hua On 04/24/2013 09:57 AM, Greg KH wrote: On Wed, Apr 24, 2013 at 07:55:18AM +0800, ZhenHua wrote: On 04/23/2013 10:07 PM, Greg KH wrote: On Tue, Apr 23, 2013 at 03:15:01PM +0800, Li, Zhen-Hua wrote: From: "Li, Zhen-Hua" This patch is trying to fix bug QXCR1001261767.

Re: [PATCH 1/1] driver,usb: Fix a warning in uhci-hcd driver

2013-04-24 Thread ZhenHua
On 04/23/2013 11:10 PM, Alan Stern wrote: On Tue, 23 Apr 2013, Greg KH wrote: On Tue, Apr 23, 2013 at 03:15:01PM +0800, Li, Zhen-Hua wrote: From: "Li, Zhen-Hua" This patch is trying to fix bug QXCR1001261767. What is that bug number? Where can it be referenced? If you are going to put it

Re: [PATCH 1/1] driver,usb: Fix a warning in uhci-hcd driver

2013-04-25 Thread ZhenHua
I send out this patch for the second time. Changed try to int. And modified the comment. On 04/25/2013 03:11 PM, Li, Zhen-Hua wrote: This patch is trying to fix this bug on SLES11 SP2: https://bugzilla.novell.com/show_bug.cgi?id=817035 On a large HP system with 64T memory and 60 logical cp

Re: [PATCH 1/1] driver,usb: Fix a warning in uhci-hcd driver

2013-04-25 Thread ZhenHua
On 04/25/2013 10:54 PM, Alan Stern wrote: On Thu, 25 Apr 2013, ZhenHua wrote: +#define UHCI_SUSPENDRH_RETRY_MAX 10 +#define UHCI_SUSPENDRH_RETRY_DELAY100 Why is the delay set to 100 us? Isn't that excessively large? How long does it take for this controller to go into su

Re: [PATCH 1/1] driver,usb: Fix a warning in uhci-hcd driver

2013-04-26 Thread ZhenHua
There is a function wait_for_HP() in uhci-hub.c. In this patch, it is used in suspend_rh(), I think this can be a solution. And I have tested this patch, it can fix the bug. I think there is another patch needed. As Alan said in another mail, in the UHCI_RH_RUNNING_NODEVS case, it should not be

Re: [PATCH 1/1] driver,usb: Fix a warning in uhci-hcd driver

2013-04-26 Thread ZhenHua
On 04/26/2013 03:50 PM, ZhenHua wrote: I think there is another patch needed. As Alan said in another mail, in the UHCI_RH_RUNNING_NODEVS case, it should not be stopped if the uhci device is HP iLo virtual usb. correct: it should not be auto stopped if the uhci device is HP iLo virtual usb

Re: [PATCH 1/1] driver,usb: Fix a warning in uhci-hcd driver

2013-04-26 Thread ZhenHua
On 04/27/2013 12:51 AM, Alan Stern wrote: On Fri, 26 Apr 2013, ZhenHua wrote: There is a function wait_for_HP() in uhci-hub.c. In this patch, it is used in suspend_rh(), I think this can be a solution. And I have tested this patch, it can fix the bug. I think there is another patch needed

Re: [PATCH 1/1] driver,usb: Fix a warning in uhci-hcd driver

2013-04-27 Thread ZhenHua
On 04/27/2013 11:14 PM, Alan Stern wrote: On Sat, 27 Apr 2013, ZhenHua wrote: On 04/27/2013 12:51 AM, Alan Stern wrote: On Fri, 26 Apr 2013, ZhenHua wrote: There is a function wait_for_HP() in uhci-hub.c. In this patch, it is used in suspend_rh(), I think this can be a solution. And I