Re: Re: [PATCH] phy: add Rockchip RK3288 USB2 PHY driver.

2014-12-04 Thread Yunzhi Li
Hi Heiko Am Mittwoch, 3. Dezember 2014, 21:46:50 schrieb LiYunzhi: + +}; + +static int rockchip_usb_phy_power(struct rockchip_usb_phy *phy, + bool siddq) +{ + return regmap_write(phy->reg_base, phy->reg_offset, + SIDDQ_MS

[PATCH v2 3/5] usb: dwc2: Add generic PHY framework support for dwc2 usb controler platform driver.

2014-12-05 Thread Yunzhi Li
Get PHY parameters from devicetree and power off usb PHY during system suspend. Signed-off-by: Yunzhi Li --- drivers/usb/dwc2/gadget.c | 33 - drivers/usb/dwc2/platform.c | 34 ++ 2 files changed, 46 insertions(+), 21 deletions

[PATCH v2 0/5]

2014-12-05 Thread Yunzhi Li
total during sustem suspend. Yunzhi Li (5): phy: add a driver for the Rockchip SoC internal USB2.0 PHY. Documentation: bindings: add doc for the Rockchip usb PHY usb: dwc2: Add generic PHY framework support for dwc2 usb controler platform driver. ARM: dts: add rk3288 usb PHY ARM

Re: [PATCH v2 3/5] usb: dwc2: Add generic PHY framework support for dwc2 usb controler platform driver.

2014-12-07 Thread Yunzhi Li
Hi Paul: Thank you for replying. On 2014/12/6 3:04, Paul Zimmerman wrote: From: Yunzhi Li [mailto:l...@rock-chips.com] Sent: Friday, December 05, 2014 4:52 AM Get PHY parameters from devicetree and power off usb PHY during system suspend. Signed-off-by: Yunzhi Li --- drivers/usb/dwc2

[PATCH v3 0/5]

2014-12-08 Thread Yunzhi Li
->phy for NULL before calling generic phy APIs. - Add more context about the changes in the long description. Yunzhi Li (5): phy: add a driver for the Rockchip SoC internal USB2.0 PHY Documentation: bindings: add doc for the Rockchip usb PHY usb: dwc2: add generic PHY framework support

[PATCH v3 3/5] usb: dwc2: add generic PHY framework support for dwc2 usb controler platform driver.

2014-12-08 Thread Yunzhi Li
Get PHY parameters from devicetree and power off usb PHY during system suspend. Signed-off-by: Yunzhi Li --- Changes in v3: - Fix coding style: both branches of the if() which only one branch of the conditional statement is a single statement should have braces. - No need to test dwc2->

[PATCH v4 0/5] Patches to add support for Rockchip usb PHYs.

2014-12-08 Thread Yunzhi Li
PHY_ROCKCHIP_USB. Yunzhi Li (5): phy: add a driver for the Rockchip SoC internal USB2.0 PHY Documentation: bindings: add doc for the Rockchip usb PHY usb: dwc2: add generic PHY framework support for dwc2 usb controler platform driver. ARM: dts: add rk3288 usb PHY ARM: dts: Enable usb PHY

[PATCH v4 3/5] usb: dwc2: add generic PHY framework support for dwc2 usb controler platform driver.

2014-12-08 Thread Yunzhi Li
Get PHY parameters from devicetree and power off usb PHY during system suspend. Signed-off-by: Yunzhi Li Acked-by: Paul Zimmerman Changes in v3: - Fix coding style: both branches of the if() which only one branch of the conditional statement is a single statement should have braces. - No

[Resend PATCH v4 3/5] usb: dwc2: add generic PHY

2014-12-08 Thread Yunzhi Li
Get PHY parameters from devicetree and power off usb PHY during system suspend. Signed-off-by: Yunzhi Li Acked-by: Paul Zimmerman --- Hi Felipe, Sorry for my mistake, I have fixed the commit log. Changes in v4: None Changes in v3: - Fix coding style: both branches of the if() which

[PATCH v5 0/5] Patches to add support for Rockchip usb PHYs.

2014-12-10 Thread Yunzhi Li
dwc2->phy for NULL before calling generic phy APIs. Yunzhi Li (5): phy: add a driver for the Rockchip SoC internal USB2.0 PHY Documentation: bindings: add dt documentation for Rockchip usb PHY usb: dwc2: add generic PHY framework support for dwc2 usb controler platform dri

[PATCH v5 3/5] usb: dwc2: add generic PHY framework support for dwc2 usb controler platform driver.

2014-12-10 Thread Yunzhi Li
Get PHY parameters from devicetree and power off usb PHY during system suspend. Signed-off-by: Yunzhi Li Acked-by: Paul Zimmerman --- Changes in v5: None Changes in v4: None Changes in v3: - Fix coding style: both branches of the if() which only one branch of the conditional statement is a

[PATCH v6 0/5] Patches to add support for Rockchip usb PHYs.

2014-12-11 Thread Yunzhi Li
only one branch of the conditional statement is a single statement should have braces. - No need to test dwc2->phy for NULL before calling generic phy APIs. Yunzhi Li (5): phy: add a driver for the Rockchip SoC internal USB2.0 PHY Documentation: bindings: add dt documentation for Rockc

[PATCH v6 3/5] usb: dwc2: add generic PHY framework support for dwc2 usb controler platform driver.

2014-12-11 Thread Yunzhi Li
Get PHY parameters from devicetree and power off usb PHY during system suspend. Signed-off-by: Yunzhi Li Acked-by: Paul Zimmerman --- Changes in v6: None Changes in v5: None Changes in v4: None Changes in v3: - Fix coding style: both branches of the if() which only one branch of the

[PATCH v7 0/5] Patches to add support for Rockchip usb PHYs.

2014-12-12 Thread Yunzhi Li
calling generic phy APIs. Yunzhi Li (5): Documentation: bindings: add dt documentation for Rockchip usb PHY phy: add a driver for the Rockchip SoC internal USB2.0 PHY usb: dwc2: add generic PHY framework support for dwc2 usb controler platform driver. ARM: dts: rockchip: add rk3288 usb P

[PATCH v7 0/5] Patches to add support for Rockchip usb PHYs.

2014-12-12 Thread Yunzhi Li
calling generic phy APIs. Yunzhi Li (5): Documentation: bindings: add dt documentation for Rockchip usb PHY phy: add a driver for the Rockchip SoC internal USB2.0 PHY usb: dwc2: add generic PHY framework support for dwc2 usb controler platform driver. ARM: dts: rockchip: add rk3288 usb P

[PATCH v7 2/5] phy: add a driver for the Rockchip SoC internal USB2.0 PHY

2014-12-12 Thread Yunzhi Li
This patch to add a generic PHY driver for ROCKCHIP usb PHYs, currently this driver can support RK3288. The RK3288 SoC have three independent USB PHY IPs which are all configured through a set of registers located in the GRF (general register files) module. Signed-off-by: Yunzhi Li --- Changes

[PATCH v7 3/5] usb: dwc2: add generic PHY framework support for dwc2 usb controler platform driver.

2014-12-12 Thread Yunzhi Li
Get PHY parameters from devicetree and power off usb PHY during system suspend. Signed-off-by: Yunzhi Li Acked-by: Paul Zimmerman --- Changes in v7: None Changes in v6: None Changes in v5: None Changes in v4: None Changes in v3: - Fix coding style: both branches of the if() which only one

Re: [PATCH v7 3/5] usb: dwc2: add generic PHY framework support for dwc2 usb controler platform driver.

2015-01-10 Thread Yunzhi Li
Hi Paul: On 2015/1/9 10:15, Paul Zimmerman wrote: /* -* Attempt to find a generic PHY, then look for an old style -* USB PHY, finally fall back to pdata +* If platform probe couldn't find a generic PHY or an old style +* USB PHY, fall back to pdata

Re: [PATCH v7 3/5] usb: dwc2: add generic PHY framework support for dwc2 usb controler platform driver.

2015-01-10 Thread Yunzhi Li
Hi paul: 在 2015/1/9 10:15, Paul Zimmerman 写道: [...] /* -* Attempt to find a generic PHY, then look for an old style -* USB PHY, finally fall back to pdata +* If platform probe couldn't find a generic PHY or an old style +* USB PHY, fall back to pdata

[PATCH v1] usb: dwc2: reset AHB hclk domain before init

2015-08-10 Thread Yunzhi Li
. This patch could avoid warnning massage like in rk3288 platform: [2.074764] dwc2 ff58.usb: 256 invalid for host_perio_tx_fifo_size. Check HW configuration. Signed-off-by: Yunzhi Li --- drivers/usb/dwc2/platform.c | 12 1 file changed, 12 insertions(+) diff --git a

[PATCH v1 1/3] usb: dwc2: reset AHB hclk domain before init

2015-08-11 Thread Yunzhi Li
. This patch could avoid warnning massage like in rk3288 platform: [2.074764] dwc2 ff58.usb: 256 invalid for host_perio_tx_fifo_size. Check HW configuration. Signed-off-by: Yunzhi Li --- drivers/usb/dwc2/platform.c | 12 1 file changed, 12 insertions(+) diff --git a

Re: [PATCH v1] usb: dwc2: reset AHB hclk domain before init

2015-08-12 Thread Yunzhi Li
Hi , 在 2015/8/11 22:12, Felipe Balbi 写道: Hi, On Tue, Aug 11, 2015 at 10:27:42AM +0800, Yunzhi Li wrote: We initiate dwc2 usb controller in BIOS, when kernel driver start-up we should reset AHB hclk domain to reset all AHB interface registers to default. Without this the FIFO value setting

Re: [PATCH v1 1/3] usb: dwc2: reset AHB hclk domain before init

2015-08-13 Thread Yunzhi Li
在 2015/8/14 8:09, John Youn 写道: On 8/11/2015 12:57 AM, Yunzhi Li wrote: We initiate dwc2 usb controller in BIOS, when kernel driver start-up we should reset AHB hclk domain to reset all AHB interface registers to default. Without this the FIFO value setting might be incorrect because

[PATCH v2] usb: dwc2: reset dwc2 core before dwc2_get_hwparams()

2015-08-18 Thread Yunzhi Li
could avoid warnning massage like in rk3288 platform: [2.074764] dwc2 ff58.usb: 256 invalid for host_perio_tx_fifo_size. Check HW configuration. Signed-off-by: Yunzhi Li --- drivers/usb/dwc2/core.c | 2 +- drivers/usb/dwc2/core.h | 1 + drivers/usb/dwc2/platform.c | 6 ++ 3

Re: [PATCH v1 1/3] usb: dwc2: reset AHB hclk domain before init

2015-08-18 Thread Yunzhi Li
Hi John, 在 2015/8/15 3:41, John Youn 写道: > On 8/13/2015 8:29 PM, Yunzhi Li wrote: >> >> 在 2015/8/14 8:09, John Youn 写道: >>> On 8/11/2015 12:57 AM, Yunzhi Li wrote: >>>> We initiate dwc2 usb controller in BIOS, when kernel driver >>>> start-up

[PATCH v3] usb: dwc2: reset dwc2 core before dwc2_get_hwparams()

2015-08-19 Thread Yunzhi Li
could avoid warnning massage like in rk3288 platform: [2.074764] dwc2 ff58.usb: 256 invalid for host_perio_tx_fifo_size. Check HW configuration. Signed-off-by: Yunzhi Li --- drivers/usb/dwc2/core.c | 2 +- drivers/usb/dwc2/core.h | 1 + drivers/usb/dwc2/platform.c | 21

[PATCH] usb: dwc2: gadget: cleanup useless code

2015-04-26 Thread Yunzhi Li
dwc2 gadget driver s3c_hsotg_of_probe() run twice in dwc2_gadget_init() and the first one is useless, so remove it. Signed-off-by: Yunzhi Li --- drivers/usb/dwc2/gadget.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c index 6a30887

[PATCH v1] usb: dwc2: gadget: fix a memory use-after-free bug

2015-05-28 Thread Yunzhi Li
q+0x48/0x6c) [ 27.849695] [] (gic_handle_irq) from [] (__irq_svc+0x40/0x50) [ 27.886907] Exception stack(0xc0d01ee0 to 0xc0d01f28) Signed-off-by: Yunzhi Li --- drivers/usb/dwc2/gadget.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/usb/dwc2/gadget.c b/d

[RFC] usb: dwc2: hcd: fix split schedule issue

2015-11-06 Thread Yunzhi Li
Fix dwc2 split schedule sequence issue. Not schedule a SSPLIT_IN packet between SSPLIT-begin and SSPLIT-end. Signed-off-by: Yunzhi Li --- drivers/usb/dwc2/hcd.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/usb/dwc2/hcd.c b/drivers/usb/dwc2/hcd.c index e79baf7..a32ed01 100644

Re: [RFC] usb: dwc2: hcd: fix split schedule issue

2015-11-06 Thread Yunzhi Li
is is exactly the right way to schedule split transfers and if there is any dide effect with this patch. Please help review this patch. Thanks. Fix dwc2 split schedule sequence issue. Not schedule a SSPLIT_IN packet between SSPLIT-begin and SSPLIT-end. Signed-off-by: Yunzhi Li --- drivers/usb

Re: [RFC] usb: dwc2: hcd: fix split schedule issue

2015-11-09 Thread Yunzhi Li
hi Doug 在 2015/11/7 7:56, Doug Anderson 写道: lyz@, On Fri, Nov 6, 2015 at 1:36 AM, Yunzhi Li wrote: Fix dwc2 split schedule sequence issue. Not schedule a SSPLIT_IN packet between SSPLIT-begin and SSPLIT-end. Signed-off-by: Yunzhi Li --- drivers/usb/dwc2/hcd.c | 4 1 file changed, 4

Re: [RFC] usb: dwc2: hcd: fix split schedule issue

2015-11-12 Thread Yunzhi Li
Hi John 在 2015/11/12 12:29, John Youn 写道: On 11/11/2015 4:22 PM, Doug Anderson wrote: John, On Fri, Nov 6, 2015 at 2:04 AM, Yunzhi Li wrote: hi John , As we talked yesterday, I tried to fix the split schedule sequence. This patch will avoid scheduling SSPLIT-IN packet for another device

[PATCH] usb: dwc2: hcd: fix periodic transfer schedule sequence

2015-11-16 Thread Yunzhi Li
When checking dwc2 host channel interrupts, handle qh in periodic_sched_queued list at first, then we could make sure CSPLIT packets scheduled in the same order as SSPLIT packets. Signed-off-by: Yunzhi Li --- drivers/usb/dwc2/hcd_intr.c | 22 ++ 1 file changed, 22 insertions

Re: [PATCH v7 2/5] phy: add a driver for the Rockchip SoC internal USB2.0 PHY

2015-01-21 Thread Yunzhi Li
Hi Kishon : Hi, On Friday 12 December 2014 08:37 PM, Yunzhi Li wrote: This patch to add a generic PHY driver for ROCKCHIP usb PHYs, currently this driver can support RK3288. The RK3288 SoC have three independent USB PHY IPs which are all configured through a set of registers located in the GRF

Re: [PATCH v7 2/5] phy: add a driver for the Rockchip SoC internal USB2.0 PHY

2015-01-21 Thread Yunzhi Li
Hi Kishon : Hi, On Wednesday 21 January 2015 03:36 PM, Yunzhi Li wrote: Hi Kishon : Hi, On Friday 12 December 2014 08:37 PM, Yunzhi Li wrote: This patch to add a generic PHY driver for ROCKCHIP usb PHYs, currently this driver can support RK3288. The RK3288 SoC have three independent USB

[RFC PATCH v1] usb: dwc2: reduce dwc2 driver probe time

2015-02-10 Thread Yunzhi Li
board. It works well. Signed-off-by: Yunzhi Li --- drivers/usb/dwc2/core.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/usb/dwc2/core.c b/drivers/usb/dwc2/core.c index d5197d4..bdafb9d 100644 --- a/drivers/usb/dwc2/core.c +++ b/drivers/usb/dwc2/core.c

[PATCH] usb: dwc2: host: fix dwc2 disconnect bug

2015-03-05 Thread Yunzhi Li
When dwc2 controller detects a disconnect interrupt, dwc2_hcd_disconnect() should be called immediately to do clean-up jobs and set port_connect_status_change flag to notify usb hub driver disconnect status. Signed-off-by: Yunzhi Li --- drivers/usb/dwc2/core_intr.c | 3 +++ 1 file changed, 3

Re: [PATCH RESEND] usb: dwc2: avoid leaking DMA channels on disconnection

2015-03-16 Thread Yunzhi Li
t_channels; + } else { + hsotg->non_periodic_channels = 0; + hsotg->periodic_channels = 0; + } } /** I have reviewed this patch. Obviously,it makes sense. Reviewed-by: Yunzhi Li -- To unsubscribe from this list: send the line "unsubscribe l