[PATCH 19/19] usb: wusbcore: wa-xfer: don't print error when allocating urb fails

kmalloc will print enough information in case of failure. Signed-off-by: Wolfram Sang --- drivers/usb/wusbcore/wa-xfer.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/usb/wusbcore/wa-xfer.c b/drivers/usb/wusbcore/wa-xfer.c index 69af4fd9e07220..167fcc71f5f6e9

[PATCH] watchdog: don't print error when allocating urb fails

when we talked about it at LCJ in Tokyo a few weeks ago. Wolfram Sang (1): watchdog: pcwd_usb: don't print error when allocating urb fails drivers/watchdog/pcwd_usb.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) -- 2.8.1 -- To unsubscribe from this list: send the line "

[PATCH] watchdog: pcwd_usb: don't print error when allocating urb fails

kmalloc will print enough information in case of failure. Signed-off-by: Wolfram Sang --- drivers/watchdog/pcwd_usb.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/watchdog/pcwd_usb.c b/drivers/watchdog/pcwd_usb.c index 68952d9ccf8394..99ebf6ea3de648 100644

[PATCH 5/6] staging: rtl8192u: r8192U_core: don't print error when allocating urb fails

kmalloc will print enough information in case of failure. Signed-off-by: Wolfram Sang --- drivers/staging/rtl8192u/r8192U_core.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u/r8192U_core.c index

[PATCH 4/6] staging: most: hdm-usb: hdm_usb: don't print error when allocating urb fails

kmalloc will print enough information in case of failure. Signed-off-by: Wolfram Sang --- drivers/staging/most/hdm-usb/hdm_usb.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/most/hdm-usb/hdm_usb.c b/drivers/staging/most/hdm-usb/hdm_usb.c index

[PATCH 6/6] staging: vt6656: main_usb: don't print error when allocating urb fails

kmalloc will print enough information in case of failure. Signed-off-by: Wolfram Sang --- drivers/staging/vt6656/main_usb.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/drivers/staging/vt6656/main_usb.c b/drivers/staging/vt6656/main_usb.c index

[PATCH 3/6] staging: media: lirc: lirc_sasem: don't print error when allocating urb fails

kmalloc will print enough information in case of failure. Signed-off-by: Wolfram Sang --- drivers/staging/media/lirc/lirc_sasem.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/media/lirc/lirc_sasem.c b/drivers/staging/media/lirc/lirc_sasem.c index 2218d0042030ed

[PATCH 2/6] staging: media: lirc: lirc_imon: don't print error when allocating urb fails

kmalloc will print enough information in case of failure. Signed-off-by: Wolfram Sang --- drivers/staging/media/lirc/lirc_imon.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/staging/media/lirc/lirc_imon.c b/drivers/staging/media/lirc/lirc_imon.c index

[PATCH 0/6] staging: don't print error when allocating urb fails

when we talked about it at LCJ in Tokyo a few weeks ago. Wolfram Sang (6): staging: comedi: drivers: usbduxfast: don't print error when allocating urb fails staging: media: lirc: lirc_imon: don't print error when allocating urb fails staging: media: lirc: lirc_sasem: don'

[PATCH 1/6] staging: comedi: drivers: usbduxfast: don't print error when allocating urb fails

kmalloc will print enough information in case of failure. Signed-off-by: Wolfram Sang --- drivers/staging/comedi/drivers/usbduxfast.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/comedi/drivers/usbduxfast.c b/drivers/staging/comedi/drivers/usbduxfast.c

[PATCH 01/44] usb: atm: cxacru: don't print on ENOMEM

All kmalloc-based functions print enough information on failures. Signed-off-by: Wolfram Sang --- drivers/usb/atm/cxacru.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/usb/atm/cxacru.c b/drivers/usb/atm/cxacru.c index 18b281d73a39ee..f9fe86b6f7b5b6 100644 --- a

[PATCH 04/44] usb: atm: usbatm: don't print on ENOMEM

All kmalloc-based functions print enough information on failures. Signed-off-by: Wolfram Sang --- drivers/usb/atm/usbatm.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/usb/atm/usbatm.c b/drivers/usb/atm/usbatm.c index 5e4f46c5a30046..4dec9df8764b9a 100644

[PATCH 34/44] usb: musb: am35x: don't print on ENOMEM

All kmalloc-based functions print enough information on failures. Signed-off-by: Wolfram Sang --- drivers/usb/musb/am35x.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/usb/musb/am35x.c b/drivers/usb/musb/am35x.c index c41fe588d14d97..c14577dbedf71a 100644 --- a

[PATCH 44/44] usb: wusbcore: wa-nep: don't print on ENOMEM

All kmalloc-based functions print enough information on failures. Signed-off-by: Wolfram Sang --- drivers/usb/wusbcore/wa-nep.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/usb/wusbcore/wa-nep.c b/drivers/usb/wusbcore/wa-nep.c index 6140100ad50e41

[PATCH 16/44] usb: host: uhci-hcd: don't print on ENOMEM

All kmalloc-based functions print enough information on failures. Signed-off-by: Wolfram Sang --- drivers/usb/host/uhci-hcd.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/usb/host/uhci-hcd.c b/drivers/usb/host/uhci-hcd.c index a7de8e8bb4582b..5d3d914ab4fb44

[PATCH 40/44] usb: storage: sddr09: don't print on ENOMEM

All kmalloc-based functions print enough information on failures. Signed-off-by: Wolfram Sang --- drivers/usb/storage/sddr09.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/drivers/usb/storage/sddr09.c b/drivers/usb/storage/sddr09.c index c5797fa2125e94

[PATCH 12/44] usb: gadget: udc: goku_udc: don't print on ENOMEM

All kmalloc-based functions print enough information on failures. Signed-off-by: Wolfram Sang --- drivers/usb/gadget/udc/goku_udc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/usb/gadget/udc/goku_udc.c b/drivers/usb/gadget/udc/goku_udc.c index d2205d9e0c8b43

[PATCH 28/44] usb: misc: lvstest: don't print on ENOMEM

All kmalloc-based functions print enough information on failures. Signed-off-by: Wolfram Sang --- drivers/usb/misc/lvstest.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/usb/misc/lvstest.c b/drivers/usb/misc/lvstest.c index 961faae62ea087..af2952b918b843 100644

[PATCH 42/44] usb: wusbcore: crypto: don't print on ENOMEM

All kmalloc-based functions print enough information on failures. Signed-off-by: Wolfram Sang --- drivers/usb/wusbcore/crypto.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/usb/wusbcore/crypto.c b/drivers/usb/wusbcore/crypto.c index 33acd1599e99e9

[PATCH 32/44] usb: misc: uss720: don't print on ENOMEM

All kmalloc-based functions print enough information on failures. Signed-off-by: Wolfram Sang --- drivers/usb/misc/uss720.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/usb/misc/uss720.c b/drivers/usb/misc/uss720.c index 256d02da444d0f..356d312add5779 100644

[PATCH 09/44] usb: core: urb: don't print on ENOMEM

All kmalloc-based functions print enough information on failures. Signed-off-by: Wolfram Sang --- drivers/usb/core/urb.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/usb/core/urb.c b/drivers/usb/core/urb.c index c601e25b609fb5..a9039696476e68 100644 --- a

[PATCH 14/44] usb: host: fhci-hcd: don't print on ENOMEM

All kmalloc-based functions print enough information on failures. Signed-off-by: Wolfram Sang --- drivers/usb/host/fhci-hcd.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/usb/host/fhci-hcd.c b/drivers/usb/host/fhci-hcd.c index 0960f41f945aba..55a0ae6f2d7430

[PATCH 37/44] usb: renesas_usbhs: mod_host: don't print on ENOMEM

All kmalloc-based functions print enough information on failures. Signed-off-by: Wolfram Sang --- drivers/usb/renesas_usbhs/mod_host.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/usb/renesas_usbhs/mod_host.c b/drivers/usb/renesas_usbhs/mod_host.c

[PATCH 24/44] usb: misc: idmouse: don't print on ENOMEM

All kmalloc-based functions print enough information on failures. Signed-off-by: Wolfram Sang --- drivers/usb/misc/idmouse.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/misc/idmouse.c b/drivers/usb/misc/idmouse.c index 5105397e62fc76..2975e80b7a56f9 100644 --- a/drivers/usb

[PATCH 22/44] usb: misc: cytherm: don't print on ENOMEM

All kmalloc-based functions print enough information on failures. Signed-off-by: Wolfram Sang --- drivers/usb/misc/cytherm.c | 32 1 file changed, 8 insertions(+), 24 deletions(-) diff --git a/drivers/usb/misc/cytherm.c b/drivers/usb/misc/cytherm.c index

[PATCH 20/44] usb: misc: appledisplay: don't print on ENOMEM

All kmalloc-based functions print enough information on failures. Signed-off-by: Wolfram Sang --- drivers/usb/misc/appledisplay.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/usb/misc/appledisplay.c b/drivers/usb/misc/appledisplay.c index f7c48703347fb7..0b2617fe1c9b6f 100644

[PATCH 26/44] usb: misc: ldusb: don't print on ENOMEM

All kmalloc-based functions print enough information on failures. Signed-off-by: Wolfram Sang --- drivers/usb/misc/ldusb.c | 20 +--- 1 file changed, 5 insertions(+), 15 deletions(-) diff --git a/drivers/usb/misc/ldusb.c b/drivers/usb/misc/ldusb.c index 84890791c2f830

[PATCH 17/44] usb: host: xhci-tegra: don't print on ENOMEM

All kmalloc-based functions print enough information on failures. Signed-off-by: Wolfram Sang --- drivers/usb/host/xhci-tegra.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/host/xhci-tegra.c b/drivers/usb/host/xhci-tegra.c index 0f53ae0f464e6d..d39b37be71f01f 100644 --- a

[PATCH 00/44] usb: don't print on ENOMEM

x27;t save CLEAR_TT_BUFFER state"), I left it. This series saves ~4.5KB of "out of memory" permutations in .text and .rodata. For modified lines, (x == NULL) was replaced with (!NULL) as well. This seems to be the dominant style in this subsystem and checkpatch recommends it as well (and I prefe

[PATCH 29/44] usb: misc: trancevibrator: don't print on ENOMEM

All kmalloc-based functions print enough information on failures. Signed-off-by: Wolfram Sang --- drivers/usb/misc/trancevibrator.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/usb/misc/trancevibrator.c b/drivers/usb/misc/trancevibrator.c index 4145314a515b95

[PATCH 36/44] usb: renesas_usbhs: mod_gadget: don't print on ENOMEM

All kmalloc-based functions print enough information on failures. Signed-off-by: Wolfram Sang --- drivers/usb/renesas_usbhs/mod_gadget.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/usb/renesas_usbhs/mod_gadget.c b/drivers/usb/renesas_usbhs/mod_gadget.c

[PATCH 41/44] usb: usb-skeleton: don't print on ENOMEM

All kmalloc-based functions print enough information on failures. Signed-off-by: Wolfram Sang --- drivers/usb/usb-skeleton.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/usb/usb-skeleton.c b/drivers/usb/usb-skeleton.c index 89e02a7529b785..5133a0792eb041

[PATCH 18/44] usb: host: xhci: don't print on ENOMEM

All kmalloc-based functions print enough information on failures. Signed-off-by: Wolfram Sang --- drivers/usb/host/xhci.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c index 01d96c9b3a75b9..1a4ca02729c274 100644 --- a

[PATCH 05/44] usb: class: usbtmc: don't print on ENOMEM

All kmalloc-based functions print enough information on failures. Signed-off-by: Wolfram Sang --- drivers/usb/class/usbtmc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/usb/class/usbtmc.c b/drivers/usb/class/usbtmc.c index 22c235adacb3ad..da4f2509f56775 100644

[PATCH 25/44] usb: misc: iowarrior: don't print on ENOMEM

All kmalloc-based functions print enough information on failures. Signed-off-by: Wolfram Sang --- drivers/usb/misc/iowarrior.c | 20 ++-- 1 file changed, 6 insertions(+), 14 deletions(-) diff --git a/drivers/usb/misc/iowarrior.c b/drivers/usb/misc/iowarrior.c index

[PATCH 13/44] usb: gadget: udc: udc-xilinx: don't print on ENOMEM

All kmalloc-based functions print enough information on failures. Signed-off-by: Wolfram Sang --- drivers/usb/gadget/udc/udc-xilinx.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/usb/gadget/udc/udc-xilinx.c b/drivers/usb/gadget/udc/udc-xilinx.c index

[PATCH 38/44] usb: renesas_usbhs: pipe: don't print on ENOMEM

All kmalloc-based functions print enough information on failures. Signed-off-by: Wolfram Sang --- drivers/usb/renesas_usbhs/pipe.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/usb/renesas_usbhs/pipe.c b/drivers/usb/renesas_usbhs/pipe.c index c238772b9e9e1a

[PATCH 11/44] usb: gadget: udc: fsl_qe_udc: don't print on ENOMEM

All kmalloc-based functions print enough information on failures. Signed-off-by: Wolfram Sang --- drivers/usb/gadget/udc/fsl_qe_udc.c | 16 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/drivers/usb/gadget/udc/fsl_qe_udc.c b/drivers/usb/gadget/udc/fsl_qe_udc.c

[PATCH 43/44] usb: wusbcore: security: don't print on ENOMEM

All kmalloc-based functions print enough information on failures. Signed-off-by: Wolfram Sang --- drivers/usb/wusbcore/security.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/usb/wusbcore/security.c b/drivers/usb/wusbcore/security.c index b66faaf3e842e8

[PATCH 10/44] usb: dwc2: gadget: don't print on ENOMEM

All kmalloc-based functions print enough information on failures. Signed-off-by: Wolfram Sang --- drivers/usb/dwc2/gadget.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c index af46adfae41ca5..2ff03ae08e144d

[PATCH 02/44] usb: atm: speedtch: don't print on ENOMEM

All kmalloc-based functions print enough information on failures. Signed-off-by: Wolfram Sang --- drivers/usb/atm/speedtch.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/atm/speedtch.c b/drivers/usb/atm/speedtch.c index 0270d1312f834f..5083eb5b0d5ed9 100644 --- a/drivers/usb

[PATCH 15/44] usb: host: max3421-hcd: don't print on ENOMEM

All kmalloc-based functions print enough information on failures. Signed-off-by: Wolfram Sang --- drivers/usb/host/max3421-hcd.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/usb/host/max3421-hcd.c b/drivers/usb/host/max3421-hcd.c index 2f7690092a7ffb

[PATCH 31/44] usb: misc: usbsevseg: don't print on ENOMEM

All kmalloc-based functions print enough information on failures. Signed-off-by: Wolfram Sang --- drivers/usb/misc/usbsevseg.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/usb/misc/usbsevseg.c b/drivers/usb/misc/usbsevseg.c index 1fe6b73c22f300

[PATCH 03/44] usb: atm: ueagle-atm: don't print on ENOMEM

All kmalloc-based functions print enough information on failures. Signed-off-by: Wolfram Sang --- drivers/usb/atm/ueagle-atm.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/usb/atm/ueagle-atm.c b/drivers/usb/atm/ueagle-atm.c index f198291630d7dd

[PATCH 33/44] usb: misc: yurex: don't print on ENOMEM

All kmalloc-based functions print enough information on failures. Signed-off-by: Wolfram Sang --- drivers/usb/misc/yurex.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/usb/misc/yurex.c b/drivers/usb/misc/yurex.c index bb606bdc25e558..54e53ac4c08fd7 100644

[PATCH 27/44] usb: misc: legousbtower: don't print on ENOMEM

All kmalloc-based functions print enough information on failures. Signed-off-by: Wolfram Sang --- drivers/usb/misc/legousbtower.c | 16 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/drivers/usb/misc/legousbtower.c b/drivers/usb/misc/legousbtower.c index

[PATCH 23/44] usb: misc: ftdi-elan: don't print on ENOMEM

All kmalloc-based functions print enough information on failures. Signed-off-by: Wolfram Sang --- drivers/usb/misc/ftdi-elan.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/misc/ftdi-elan.c b/drivers/usb/misc/ftdi-elan.c index 45f303c1cc49ef..9beba9748d0f24 100644 --- a/drivers

[PATCH 39/44] usb: storage: alauda: don't print on ENOMEM

All kmalloc-based functions print enough information on failures. Signed-off-by: Wolfram Sang --- drivers/usb/storage/alauda.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/usb/storage/alauda.c b/drivers/usb/storage/alauda.c index 1d8b03c8103053

[PATCH 21/44] usb: misc: cypress_cy7c63: don't print on ENOMEM

All kmalloc-based functions print enough information on failures. Signed-off-by: Wolfram Sang --- drivers/usb/misc/cypress_cy7c63.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/usb/misc/cypress_cy7c63.c b/drivers/usb/misc/cypress_cy7c63.c index 402b94dd253159

[PATCH 08/44] usb: core: message: don't print on ENOMEM

All kmalloc-based functions print enough information on failures. Signed-off-by: Wolfram Sang --- drivers/usb/core/message.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/usb/core/message.c b/drivers/usb/core/message.c index 0406a59f05510c..5ab5c1a81462b6

[PATCH 19/44] usb: misc: adutux: don't print on ENOMEM

All kmalloc-based functions print enough information on failures. Signed-off-by: Wolfram Sang --- drivers/usb/misc/adutux.c | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/drivers/usb/misc/adutux.c b/drivers/usb/misc/adutux.c index c34a0b6980cdcd

[PATCH 30/44] usb: misc: usblcd: don't print on ENOMEM

All kmalloc-based functions print enough information on failures. Signed-off-by: Wolfram Sang --- drivers/usb/misc/usblcd.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/usb/misc/usblcd.c b/drivers/usb/misc/usblcd.c index 1184390508e983..9f48419abc46b9

[PATCH 35/44] usb: musb: da8xx: don't print on ENOMEM

All kmalloc-based functions print enough information on failures. Signed-off-by: Wolfram Sang --- drivers/usb/musb/da8xx.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/usb/musb/da8xx.c b/drivers/usb/musb/da8xx.c index b03d3b867fca2f..3c4dd1658f28db 100644 --- a

[PATCH 06/44] usb: core: hcd: don't print on ENOMEM

All kmalloc-based functions print enough information on failures. Signed-off-by: Wolfram Sang --- drivers/usb/core/hcd.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c index d2e3f655c26f6c..a0c87b617eddea 100644 --- a

[PATCH 07/44] usb: core: hub: don't print on ENOMEM

All kmalloc-based functions print enough information on failures. Signed-off-by: Wolfram Sang --- drivers/usb/core/hub.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c index 1d5fc32d06d007..b48dc76385b652 100644 --- a

Re: [PATCH,RFC] usb: add devicetree helpers for determining dr_mode and phy_type

it for ethernet phys already with strings, so it would be consistent. -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description: Digital signature

Re: [PATCH,RFC] usb: add devicetree helpers for determining dr_mode and phy_type

mplicit) rule that the enum mustn't be modified since it is exported to users. Also, you could map the strings to the enum first and then switch-case over it to make the code nicer. -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description: Digital signature

Re: [PATCH] usb: chipidea: ci13xxx-imx: remove global struct

form data 1:1 which is nearly always wrong. Having a quick look in the current devicetree bindings for USB shows that there is a transceiver property. So, the the (non-)presence of that property should make "require-transceiver" superfluous? Also, is "disable-streaming" a description of

Re: [PATCH] usb: chipidea: ci13xxx-imx: remove global struct

two, as well. -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description: Digital signature

[PATCH 19/27] drivers/usb/phy: don't check resource with devm_ioremap_resource

devm_ioremap_resource does sanity checks on the given resource. No need to duplicate this in the driver. Signed-off-by: Wolfram Sang --- Please apply via the subsystem-tree. drivers/usb/phy/phy-rcar-usb.c |5 - 1 file changed, 5 deletions(-) diff --git a/drivers/usb/phy/phy-rcar-usb.c

Re: [PATCH] i2c-tiny-usb: do not use stack as URB transfer_buffer

On Tue, Aug 06, 2013 at 02:17:42PM +0300, Jussi Kivilinna wrote: > Patch fixes i2c-tiny-usb not to use stack as URB transfer_buffer. URB buffers > need to be DMA-able, which stack is not. > > Patch is only compile tested. > > Cc: sta...@vger.kernel.org > Signed-off-by: Jussi Kivilinna Looks OK

Re: [PATCH] i2c-tiny-usb: do not use stack as URB transfer_buffer

On Thu, Aug 15, 2013 at 10:46:32PM +0300, Jussi Kivilinna wrote: > On 15.08.2013 20:55, Wolfram Sang wrote: > > On Tue, Aug 06, 2013 at 02:17:42PM +0300, Jussi Kivilinna wrote: > >> Patch fixes i2c-tiny-usb not to use stack as URB transfer_buffer. URB > >> buffers >

[RFC 30/42] drivers/usb/host: don't check resource with devm_ioremap_resource

devm_ioremap_resource does sanity checks on the given resource. No need to duplicate this in the driver. Signed-off-by: Wolfram Sang --- drivers/usb/host/ehci-atmel.c|9 + drivers/usb/host/ehci-mxc.c |8 +--- drivers/usb/host/ehci-platform.c |6 +- drivers

[RFC 29/42] drivers/usb/gadget: don't check resource with devm_ioremap_resource

devm_ioremap_resource does sanity checks on the given resource. No need to duplicate this in the driver. Signed-off-by: Wolfram Sang --- drivers/usb/gadget/bcm63xx_udc.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/drivers/usb/gadget/bcm63xx_udc.c b/drivers/usb/gadget

[RFC 31/42] drivers/usb/phy: don't check resource with devm_ioremap_resource

devm_ioremap_resource does sanity checks on the given resource. No need to duplicate this in the driver. Signed-off-by: Wolfram Sang --- drivers/usb/phy/phy-mv-u3d-usb.c |5 - drivers/usb/phy/phy-mxs-usb.c |5 - drivers/usb/phy/phy-samsung-usb2.c |5 - drivers/usb

[RFC 28/42] drivers/usb/chipidea: don't check resource with devm_ioremap_resource

devm_ioremap_resource does sanity checks on the given resource. No need to duplicate this in the driver. Signed-off-by: Wolfram Sang --- drivers/usb/chipidea/core.c |5 - 1 file changed, 5 deletions(-) diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c index 450107e

[RFC 24/42] drivers/staging/dwc2: don't check resource with devm_ioremap_resource

devm_ioremap_resource does sanity checks on the given resource. No need to duplicate this in the driver. Signed-off-by: Wolfram Sang --- drivers/staging/dwc2/platform.c |5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/dwc2/platform.c b/drivers/staging/dwc2/platform.c

Re: [RFC 30/42] drivers/usb/host: don't check resource with devm_ioremap_resource

On Fri, May 10, 2013 at 10:03:28AM -0400, Alan Stern wrote: > On Fri, 10 May 2013, Wolfram Sang wrote: > > > devm_ioremap_resource does sanity checks on the given resource. No need to > > duplicate this in the driver. > > > > Signed-off-by: Wolfram Sang >

[PATCH 22/33] drivers/usb/gadget: don't check resource with devm_ioremap_resource

devm_ioremap_resource does sanity checks on the given resource. No need to duplicate this in the driver. Signed-off-by: Wolfram Sang --- drivers/usb/gadget/bcm63xx_udc.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/drivers/usb/gadget/bcm63xx_udc.c b/drivers/usb/gadget

[PATCH 24/33] drivers/usb/phy: don't check resource with devm_ioremap_resource

devm_ioremap_resource does sanity checks on the given resource. No need to duplicate this in the driver. Signed-off-by: Wolfram Sang --- drivers/usb/phy/phy-mv-u3d-usb.c |5 - drivers/usb/phy/phy-mxs-usb.c |5 - drivers/usb/phy/phy-samsung-usb2.c |5 - drivers/usb

[PATCH 23/33] drivers/usb/host: don't check resource with devm_ioremap_resource

devm_ioremap_resource does sanity checks on the given resource. No need to duplicate this in the driver. Signed-off-by: Wolfram Sang --- drivers/usb/host/ohci-nxp.c |6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/usb/host/ohci-nxp.c b/drivers/usb/host/ohci-nxp.c index

[PATCH 18/33] drivers/staging/dwc2: don't check resource with devm_ioremap_resource

devm_ioremap_resource does sanity checks on the given resource. No need to duplicate this in the driver. Signed-off-by: Wolfram Sang --- drivers/staging/dwc2/platform.c |5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/dwc2/platform.c b/drivers/staging/dwc2/platform.c

[PATCH 21/33] drivers/usb/chipidea: don't check resource with devm_ioremap_resource

devm_ioremap_resource does sanity checks on the given resource. No need to duplicate this in the driver. Signed-off-by: Wolfram Sang --- drivers/usb/chipidea/core.c |5 - 1 file changed, 5 deletions(-) diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c index 450107e

Re: [PATCH] MIPS: OCTEON: Rename Kconfig CAVIUM_OCTEON_REFERENCE_BOARD to CAVIUM_OCTEON_SOC

27;t really do anything, we can > get the same configuration with CAVIUM_OCTEON_SOC. > > Signed-off-by: David Daney For I2C: Acked-by: Wolfram Sang -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vg

[PATCH 2/3] drivers/usb/host: remove leftover release_mem_region

When converting this driver to devm_ioremap_resource, the removal of this now unneeded function has been forgotten. Signed-off-by: Wolfram Sang --- drivers/usb/host/ohci-nxp.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/host/ohci-nxp.c b/drivers/usb/host/ohci-nxp.c index

[RFC 1/2] usb: core: add sanity checks when using bInterfaceClass with new_id

Check if that field is actually used and if so, bail out if it exeeds a u8. Make it also future-proof by not requiring "exactly three" parameters in new_id, but simply "more than two". Signed-off-by: Wolfram Sang --- drivers/usb/core/driver.c | 5 - 1 file changed

[RFC 2/2] usb: core: allow a reference device for new_id

Often, usb drivers need some driver_info to get a device to work. To have access to driver_info when using new_id, allow to pass a reference vendor:product tuple from which new_id will inherit driver_info. Signed-off-by: Wolfram Sang --- Documentation/ABI/testing/sysfs-bus-usb | 10

Re: [RFC 2/2] usb: core: allow a reference device for new_id

> Very nice, I like this a lot! Yay! > We've always had the problem of how to do this before, I don't think > anyone's thought of using a "reference" device in tha past, this should > solve the driver_data issue just fine. To be fair, Bjørn had this idea two years ago, but hesitated to implemen

[PATCH] usb: core: bail out if user gives an unknown RefId when using new_id

If users use the new RefId feature of new_id, give them an error message if they provided an unknown reference. That helps detecting typos. Signed-off-by: Wolfram Sang --- drivers/usb/core/driver.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/usb/core

Re: [RFC 2/2] usb: core: allow a reference device for new_id

> > I also wonder if we should return an error to the user in case we don't > > find a matching reference entry? It will otherwise be very difficult > > for the user to catch typos. > > Ah, yeah, that would be a good idea, Wofram, care to do an add-on patch > for that? Just sent. Another questi

Re: [RFC 2/2] usb: core: allow a reference device for new_id

> > To be fair, Bjørn had this idea two years ago, but hesitated to > > implement it. I found his mail while implementing my idea, though. > > I did? Wow. I know I was looking at solutions to this problem, but I > didn't remember thinking about taking the device reference from > userspace. :)

Re: [RFC 2/2] usb: core: allow a reference device for new_id

> Yes, it can, if you look at the comment in usb_match_id(), we have to > check for this there. Geez, /me blind... Will send a patch. Thanks! signature.asc Description: Digital signature

[PATCH] usb: core: check for valid id_table when using the RefId feature

When implementing the RefId feature, it was missed that id_tables can be NULL under special circumstances. Bail out in that case. Signed-off-by: Wolfram Sang --- drivers/usb/core/driver.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/usb/core/driver.c b/drivers/usb/core

[PATCH 5/7] drivers/usb/dwc3: don't check resource with devm_ioremap_resource

devm_ioremap_resource does sanity checks on the given resource. No need to duplicate this in the driver. Signed-off-by: Wolfram Sang --- Should go via subsystem tree drivers/usb/dwc3/dwc3-omap.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/usb/dwc3/dwc3-omap.c b/drivers/usb

Re: [PATCH v2] usb: core: Fix potential memory leak adding dyn USBdevice IDs

On Sun, Jan 26, 2014 at 05:21:34PM +0100, Christian Engelmayer wrote: > Fix a memory leak in the usb_store_new_id() error paths. When bailing out > due to sanity checks, the function left the already allocated usb_dynid > struct in place. This regression was introduced by the following commits: >

Re: [PATCH v3] usb: core: Fix potential memory leak adding dyn USBdevice IDs

: CID 1162604. > > Signed-off-by: Christian Engelmayer Acked-by: Wolfram Sang signature.asc Description: Digital signature

Re: [PATCH V2 2/5] i2c: pxa: prepare/unprepare clocks

On Mon, Nov 17, 2014 at 06:07:40PM +0300, Dmitry Eremin-Solenikov wrote: > Change clk_enable/disable() calls to clk_prepare_enable() and > clk_disable_unprepare(). You describe what is done but we can see that from the patch. Please describe here why the change is needed. > > Signed-off-by: Dmit

Re: [PATCH v4 2/3] i2c: add support for Cypress CYUSBS234 USB-I2C adapter

Hi, thanks for this submission. Looks like an interesting device. However, some very high level questions first: > +/* > + * It exposes sysfs entries under the i2c adapter for getting the i2c > transfer > + * status, reset i2c read/write module, get/set nak and stop bits. > + */ Yes, I see that

Re: [PATCH v4 2/3] i2c: add support for Cypress CYUSBS234 USB-I2C adapter

> For repeated start (Sr) scenario, the STOP bit will not be set. For > dummy write scenario (writing EEPROM address from I2C EEPROM slave), > the STOP bit should not be set. But, for normal I2C write, the STOP > bit should be set. We provide control to user to control when to > STOP/NAK to handle

[PATCH] usb: host: drop owner assignment from platform_drivers

These platform_drivers do not need to set an owner, it will be populated by the driver core. Signed-off-by: Wolfram Sang --- Those were missed by the original coccinelle script because of the strange include-mechanism. I now detected all included files with something like: awk '/#include

[PATCH 21/28] usb: gadget: udc: bdc: drop owner assignment from platform_drivers

This platform_driver does not need to set an owner, it will be populated by the driver core. Signed-off-by: Wolfram Sang --- Generated with coccinelle. SmPL file is in the introductory msg. The big cleanup was pulled in this merge window. This series catches the bits fallen through. The patches

[PATCH 00/28] remove .owner for most platform_drivers: the missing bits

ixed a coccinelle bug on the way :) Wolfram Sang (28): ARM: mach-exynos: drop owner assignment from platform_drivers mips: lantiq: xway: drop owner assignment from platform_drivers mips: pci: drop owner assignment from platform_drivers char: ipmi: drop owner assignment from platform_driver

[PATCH] usb: musb: dsps: compile suspend/resume only with PM_SLEEP

From: Wolfram Sang Depending on PM is not enough, because only PM_RUNTIME could be selected. Fixes: drivers/usb/musb/musb_dsps.c:703:12: warning: 'dsps_suspend' defined but not used [-Wunused-function] drivers/usb/musb/musb_dsps.c:721:12: warning: 'dsps_resume' defined but

Re: [PATCH v6 2/4] i2c: add support for Diolan DLN-2 USB-I2C adapter

Hi, > diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig > index 2ac87fa..6afc17e 100644 > --- a/drivers/i2c/busses/Kconfig > +++ b/drivers/i2c/busses/Kconfig > @@ -1021,4 +1021,14 @@ config SCx200_ACB > This support is also available as a module. If so, the module >

Re: [PATCH v8 2/4] i2c: add support for Diolan DLN-2 USB-I2C adapter

ce can be found in the > Programmer's Reference Manual [1], see section 6.2.2 for the I2C > master module commands and responses. > > [1] https://www.diolan.com/downloads/dln-api-manual.pdf > > Signed-off-by: Laurentiu Palcu > Signed-off-by: Octavian Purdila For the

Re: [PATCH 1/4] i2c: nvidia-gpu: add runtime pm support

> diff --git a/drivers/i2c/busses/i2c-nvidia-gpu.c > b/drivers/i2c/busses/i2c-nvidia-gpu.c > index 1c8f708f212b..9d347583f8dc 100644 > --- a/drivers/i2c/busses/i2c-nvidia-gpu.c > +++ b/drivers/i2c/busses/i2c-nvidia-gpu.c > @@ -175,6 +175,7 @@ static int gpu_i2c_master_xfer(struct i2c_adapter *adap

Re: [PATCH 3/4] i2c: nvidia-gpu: resume ccgx i2c client

> + /* runtime resume ccgx client so that it can see for any > + * connector change event. Old ccg firmware has known > + * issue of not triggering interrupt when a device is > + * connected to runtime resume the controller. > + */ Check coding style for comments. BTW how

Re: [PATCH 1/4] i2c: nvidia-gpu: add runtime pm support

> > I am not nacking this, yet the use of goto here seems too much for my > > taste. If > > you could try refactoring the whole code (dunno, maybe using a flag when to > > use stop?), I'd appreciate this. > Ok, I will add a local variable to make it more readable. I was brainstorming here, I am

Re: [PATCH v3 1/5] i2c: nvidia-gpu: refactor master_xfer

not sent before > exiting > > 2) When i2c stop failed after all transfers and we do not need to > send another stop before exiting. > > Signed-off-by: Ajay Gupta Nice! It was only a brainstorming suggestion to use a dedicated flag. But I must say I like the outcome; much better re

Re: [PATCH v3 2/5] i2c: nvidia-gpu: add runtime pm support

> @@ -211,6 +212,8 @@ static int gpu_i2c_master_xfer(struct i2c_adapter *adap, > goto exit; > } > > + pm_runtime_mark_last_busy(i2cd->dev); > + pm_runtime_put_autosuspend(i2cd->dev); > return i; > exit: > if (send_stop) { > @@ -218,6 +221,8 @@ static int

<    1   2   3   >