From: Wei Yongjun
The variable ep is initialized but never used
otherwise, so remove the unused variable.
Signed-off-by: Wei Yongjun
---
drivers/usb/gadget/f_uac2.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/usb/gadget/f_uac2.c b/drivers/usb/gadget
From: Wei Yongjun
Fixes the following sparse warning:
drivers/usb/musb/musb_dsps.c:270:6: warning:
symbol 'dsps_musb_clear_ep_rxintr' was not declared. Should it be static?
Signed-off-by: Wei Yongjun
---
drivers/usb/musb/musb_dsps.c | 2 +-
1 file changed, 1 insertion(+),
From: Wei Yongjun
Fixes the following sparse warning:
drivers/usb/host/xhci-mem.c:988:6: warning:
symbol 'xhci_free_virt_devices_depth_first' was not declared. Should it be
static?
Signed-off-by: Wei Yongjun
---
drivers/usb/host/xhci-mem.c | 3 ++-
1 file changed, 2 insert
From: Wei Yongjun
Fixes the following sparse warning:
drivers/net/usb/cdc_ether.c:469:6: warning:
symbol 'usbnet_cdc_zte_status' was not declared. Should it be static?
Signed-off-by: Wei Yongjun
---
drivers/net/usb/cdc_ether.c | 2 +-
1 file changed, 1 insertion(+), 1 deletio
From: Wei Yongjun
In case of error, the function devm_ioremap_resource() returns ERR_PTR()
and never returns NULL. The NULL test in the return value check should
be replaced with IS_ERR().
Fixes: 2fc305be364e ("usb: chipidea: msm: Mux over secondary phy at the
right time")
Signed-o
From: Wei Yongjun
Fixes the following sparse warning:
drivers/usb/host/ohci-at91.c:141:15: warning:
symbol 'at91_dt_syscon_sfr' was not declared. Should it be static?
Signed-off-by: Wei Yongjun
---
drivers/usb/host/ohci-at91.c | 2 +-
1 file changed, 1 insertion(+), 1 deletio
From: Wei Yongjun
Fix to return error code -ENOMEM from the usb_create_shared_hcd()
error handling case instead of 0, as done elsewhere in this function.
Signed-off-by: Wei Yongjun
---
drivers/usb/host/xhci-tegra.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/host/xhci
From: Wei Yongjun
Fix to return a negative error code from the usb_phy_generic_register()
error handling case instead of 0, as done elsewhere in this function.
Signed-off-by: Wei Yongjun
---
drivers/usb/musb/am35x.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a
From: Wei Yongjun
Fix to return error code -ENOMEM from the kmalloc() error handling
case instead of 0, as done elsewhere in this function.
Fixes: a19b882c07a6 ("wusb: Stop using the stack for sg crypto scratch
space")
Signed-off-by: Wei Yongjun
---
drivers/usb/wusbcore/crypto.c |
From: Wei Yongjun
There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.
Signed-off-by: Wei Yongjun
---
drivers/usb/host/ohci-da8xx.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/usb/host/ohci-da8xx.c b/drivers
Add missing platform_set_drvdata() in dwc3_of_simple_probe(), otherwise
calling platform_get_drvdata() in remove returns NULL.
This is detected by Coccinelle semantic patch.
Signed-off-by: Wei Yongjun
---
drivers/usb/dwc3/dwc3-of-simple.c | 1 +
1 file changed, 1 insertion(+)
diff --git a
Add missing platform_set_drvdata() in omap_otg_probe(), otherwise
calling platform_get_drvdata() in remove returns NULL.
This is detected by Coccinelle semantic patch.
Signed-off-by: Wei Yongjun
---
drivers/usb/phy/phy-omap-otg.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers
In case of error, the function platform_device_register_simple() returns
ERR_PTR() and never returns NULL. The NULL test in the return value
check should be replaced with IS_ERR().
Signed-off-by: Wei Yongjun
---
drivers/usb/usbip/vhci_hcd.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions
In case of error, the function usb_get_phy() returns ERR_PTR() and never
returns NULL. The NULL test in the return value check should be replaced
with IS_ERR().
Signed-off-by: Wei Yongjun
---
drivers/usb/renesas_usbhs/mod_gadget.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
Fixes the following sparse warning:
drivers/usb/host/xhci-ring.c:608:6: warning:
symbol 'xhci_unmap_td_bounce_buffer' was not declared. Should it be static?
Signed-off-by: Wei Yongjun
---
drivers/usb/host/xhci-ring.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
di
From: Wei Yongjun
There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.
Signed-off-by: Wei Yongjun
---
drivers/usb/mtu3/mtu3_plat.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/usb/mtu3
From: Wei Yongjun
Fix the error handling of dwc2_pci_probe() to avoid resources leak.
Signed-off-by: Wei Yongjun
---
drivers/usb/dwc2/pci.c | 21 ++---
1 file changed, 14 insertions(+), 7 deletions(-)
diff --git a/drivers/usb/dwc2/pci.c b/drivers/usb/dwc2/pci.c
index fdeb8c7
From: Wei Yongjun
Use the module_i2c_driver() macro to make the code smaller
and a bit simpler.
Signed-off-by: Wei Yongjun
---
drivers/usb/misc/usb3503.c | 13 +
1 file changed, 1 insertion(+), 12 deletions(-)
diff --git a/drivers/usb/misc/usb3503.c b/drivers/usb/misc/usb3503.c
From: Wei Yongjun
Since we will be removing items off the list using list_del() we need
to use a safer version of the list_for_each_entry() macro aptly named
list_for_each_entry_safe(). We should use the safe macro if the loop
involves deletions of items.
Signed-off-by: Wei Yongjun
From: Wei Yongjun
Remove duplicated include.
Signed-off-by: Wei Yongjun
---
drivers/usb/class/cdc-acm.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c
index 56d6bf6..9e16f51 100644
--- a/drivers/usb/class/cdc-acm.c
+++ b/drivers
From: Wei Yongjun
The memory return by kzalloc() or kmem_cache_zalloc() has already
be set to zero, so remove useless memset(0).
spatch with a semantic match is used to found this problem.
(http://coccinelle.lip6.fr/)
Signed-off-by: Wei Yongjun
---
drivers/usb/serial/cp210x.c | 1 -
1 file
From: Wei Yongjun
Using list_move_tail() instead of list_del() + list_add_tail().
spatch with a semantic match is used to found this problem.
(http://coccinelle.lip6.fr/)
Signed-off-by: Wei Yongjun
---
drivers/usb/host/fhci-sched.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions
From: Wei Yongjun
The dereference should be moved below the NULL test.
spatch with a semantic match is used to found this.
(http://coccinelle.lip6.fr/)
Signed-off-by: Wei Yongjun
---
drivers/usb/gadget/at91_udc.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers
From: Wei Yongjun
The dereference should be moved below the NULL test.
spatch with a semantic match is used to found this.
(http://coccinelle.lip6.fr/)
Signed-off-by: Wei Yongjun
---
drivers/usb/otg/fsl_otg.c | 34 --
1 file changed, 24 insertions(+), 10
From: Wei Yongjun
Add the missing unlock before return from function geth_alloc()
in the error handling case.
Introduced by commit 02832e56f88a981474ee4c7c141f46fc1b4454f4.
(usb: gadget: f_subset: add configfs support)
Signed-off-by: Wei Yongjun
---
drivers/usb/gadget/f_subset.c | 1 +
1
From: Wei Yongjun
Add the missing unlock before return from function ncm_alloc()
in the error handling case.
Introduced by commit e730660378be92b83288b59b824ccdace5cd2652.
(usb: gadget: f_ncm: add configfs support)
Signed-off-by: Wei Yongjun
---
drivers/usb/gadget/f_ncm.c | 1 +
1 file
From: Wei Yongjun
Add the missing unlock before return from function ecm_alloc()
in the error handling case.
Introduced by commit da92801c647cdebfd45001fd6aaecb8f0be7f56b.
(usb: gadget: f_ecm: add configfs support)
Signed-off-by: Wei Yongjun
---
drivers/usb/gadget/f_ecm.c | 1 +
1 file
From: Wei Yongjun
Remove duplicated include.
Signed-off-by: Wei Yongjun
---
drivers/usb/phy/phy-tegra-usb.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/usb/phy/phy-tegra-usb.c b/drivers/usb/phy/phy-tegra-usb.c
index 3446245..cec0855 100644
--- a/drivers/usb/phy/phy-tegra-usb.c
From: Wei Yongjun
free_irq() expects the same device identity that was passed to
corresponding request_irq(), otherwise the IRQ is not freed.
Signed-off-by: Wei Yongjun
---
drivers/usb/gadget/mv_u3d_core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb
From: Wei Yongjun
Fix to return -EINVAL in the vendor param set error handling
case instead of 0, as done elsewhere in this function.
Signed-off-by: Wei Yongjun
---
drivers/usb/gadget/f_rndis.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/f_rndis.c
From: Wei Yongjun
Add the missing unlock before return from function cppi41_dma_callback()
in the error handling case.
Signed-off-by: Wei Yongjun
---
drivers/usb/musb/musb_cppi41.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/musb/musb_cppi41.c b/drivers
From: Wei Yongjun
Using list_move_tail() instead of list_del() + list_add_tail().
Signed-off-by: Wei Yongjun
---
drivers/usb/wusbcore/wa-xfer.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/usb/wusbcore/wa-xfer.c b/drivers/usb/wusbcore/wa-xfer.c
index
From: Wei Yongjun
devm_clk_get() is used so there is no reason to explicitly
call clk_put() in probe or remove functions.
Signed-off-by: Wei Yongjun
---
drivers/usb/host/ehci-tegra.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/usb/host/ehci-tegra.c b/drivers
From: Wei Yongjun
There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.
Signed-off-by: Wei Yongjun
---
drivers/usb/phy/phy-omap-control.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/usb
From: Wei Yongjun
Fix to return -ENOMEM in the padding pkt alloc fail error handling
case instead of 0, as done elsewhere in this function.
Signed-off-by: Wei Yongjun
---
drivers/net/usb/usbnet.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/usb/usbnet.c b
From: Wei Yongjun
In case of error, the function platform_device_register_simple() returns
ERR_PTR() and never returns NULL. The NULL test in the return value check
should be replaced with IS_ERR().
Signed-off-by: Wei Yongjun
---
drivers/usb/phy/phy-generic.c | 3 ++-
1 file changed, 2
From: Wei Yongjun
Fixes the following sparse warning:
drivers/staging/dwc2/core.c:2672:6: warning:
symbol 'dwc2_set_param_uframe_sched' was not declared. Should it be static?
Signed-off-by: Wei Yongjun
---
drivers/staging/dwc2/core.c | 2 +-
1 file changed, 1 insertion(+),
From: Wei Yongjun
Remove duplicated include.
dpatch engine is used to auto generate this patch.
(https://github.com/weiyj/dpatch)
Signed-off-by: Wei Yongjun
---
drivers/usb/musb/musb_dsps.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/usb/musb/musb_dsps.c b/drivers/usb/musb
From: Wei Yongjun
The dereference should be moved below the NULL test.
dpatch engine is used to auto generate this patch.
(https://github.com/weiyj/dpatch)
Signed-off-by: Wei Yongjun
---
drivers/usb/otg/isp1301_omap.c | 32 +++-
1 file changed, 23 insertions(+), 9
From: Wei Yongjun
Add the missing unlock on the error handle path in function
net2272_irq().
Signed-off-by: Wei Yongjun
---
drivers/usb/gadget/net2272.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/net2272.c b/drivers/usb/gadget/net2272.c
index
From: Wei Yongjun
platform_device_unregister() only calls platform_device_del() and
platform_device_put(), thus use platform_device_unregister() to
simplify the code.
Also the documents in platform.c shows that platform_device_del
and platform_device_put must _only_ be externally called in
From: Wei Yongjun
platform_device_unregister() only calls platform_device_del() and
platform_device_put(), thus use platform_device_unregister() to
simplify the code.
Also the documents in platform.c shows that platform_device_del
and platform_device_put must _only_ be externally called in
From: Wei Yongjun
platform_device_unregister() only calls platform_device_del() and
platform_device_put(), thus use platform_device_unregister() to
simplify the code.
Also the documents in platform.c shows that platform_device_del
and platform_device_put must _only_ be externally called in
From: Wei Yongjun
platform_device_unregister() only calls platform_device_del() and
platform_device_put(), thus use platform_device_unregister() to
simplify the code.
Also the documents in platform.c shows that platform_device_del
and platform_device_put must _only_ be externally called in
From: Wei Yongjun
platform_device_unregister() only calls platform_device_del() and
platform_device_put(), thus use platform_device_unregister() to
simplify the code.
Also the documents in platform.c shows that platform_device_del
and platform_device_put must _only_ be externally called in
From: Wei Yongjun
platform_device_unregister() only calls platform_device_del() and
platform_device_put(), thus use platform_device_unregister() to
simplify the code.
Also the documents in platform.c shows that platform_device_del
and platform_device_put must _only_ be externally called in
From: Wei Yongjun
platform_device_unregister() only calls platform_device_del() and
platform_device_put(), thus use platform_device_unregister() to
simplify the code.
Also the documents in platform.c shows that platform_device_del
and platform_device_put must _only_ be externally called in
1
make: *** [drivers/usb/musb/ux500.o] Error 2
Signed-off-by: Wei Yongjun
---
drivers/usb/musb/ux500.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/musb/ux500.c b/drivers/usb/musb/ux500.c
index d62a91f..0e62f50 100644
--- a/drivers/usb/musb/ux500.c
+++ b/dri
From: Wei Yongjun
The dereference should be moved below the NULL test.
dpatch engine is used to auto generate this patch.
(https://github.com/weiyj/dpatch)
Signed-off-by: Wei Yongjun
---
drivers/usb/host/ehci-tegra.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a
From: Wei Yongjun
Test for tegra and hcd in tegra_ehci_remove() look like potential
NULL pointer dereference, but in fact those tests are not needed,
so remove these pointless tests entirely.
Signed-off-by: Wei Yongjun
---
v1 -> v2: remove those tests entirely
---
drivers/usb/host/e
From: Wei Yongjun
In the error handling case of tcm_usbg_drop_nexus(), the error code
is assigned to 'ret', but it is ingored. We'd better return 'ret'
instead of always return 0.
dpatch engine is used to auto generate this patch.
(https://github.com/weiyj/dpatch)
S
From: Wei Yongjun
In the error handling case of tcm_usbg_drop_nexus(), the error code
is assigned to 'ret', but it is ignored. We'd better return 'ret'
instead of always return 0.
dpatch engine is used to auto generate this patch.
(https://github.com/weiyj/dpatch)
S
From: Wei Yongjun
Fix to return a negative error code from the error handling
case instead of 0, as returned elsewhere in this function.
Signed-off-by: Wei Yongjun
---
drivers/usb/gadget/multi.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/multi.c
From: Wei Yongjun
Fix to return a negative error code from the error handling
case instead of 0, as returned elsewhere in this function.
Signed-off-by: Wei Yongjun
---
drivers/usb/gadget/f_obex.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/gadget/f_obex.c b/drivers/usb
From: Wei Yongjun
Fix to return a negative error code from the error handling
case instead of 0, as returned elsewhere in this function.
Signed-off-by: Wei Yongjun
---
drivers/usb/gadget/cdc2.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/cdc2.c b
On 04/06/2013 01:39 PM, Felipe Balbi wrote:
> On Sat, Apr 06, 2013 at 12:39:34PM +0800, Wei Yongjun wrote:
>> From: Wei Yongjun
>>
>> Fix to return a negative error code from the error handling
>> case instead of 0, as returned elsewhere in this function.
>>
>&
From: Wei Yongjun
Fix to return a negative error code from the error handling case instead
of 0, as returned elsewhere in this function.
Introduced by commit 59835a(usb: gadget: multi: use function framework for ACM.)
Signed-off-by: Wei Yongjun
---
v1 -> v2: add commit which added this prob
From: Wei Yongjun
Fix to return a negative error code from the error handling
case instead of 0, as returned elsewhere in this function.
Introduced by commit 29a664(usb: gadget: cdc2: use function framework for ACM)
Signed-off-by: Wei Yongjun
---
v1 -> v2: add commit which added this prob
From: Wei Yongjun
Fix to return a negative error code from the error handling
case instead of 0, as returned elsewhere in this function.
Signed-off-by: Wei Yongjun
---
drivers/staging/dwc2/hcd.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/dwc2/hcd.c b/drivers/staging
From: Wei Yongjun
The dereference to 'instance' in the debug code should be moved
below the NULL test.
Signed-off-by: Wei Yongjun
---
drivers/usb/atm/usbatm.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/atm/usbatm.c b/drivers/usb/atm/usba
From: Wei Yongjun
Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.
Introduced by commit cf9a08ae5aece88987bbeee8eb0dd0ebb5015815
(usb: gadget: convert source sink and loopback to new function interface)
Signed-off-by: Wei
From: Wei Yongjun
Add the missing platform_device_put() before return from
omap2430_probe() in the error handling case.
Introduced by commit ca784be36cc725bca9b526eba342de7550329731
(usb: start using the control module driver)
Signed-off-by: Wei Yongjun
---
drivers/usb/musb/omap2430.c | 3
From: Wei Yongjun
Fix to return -ENOMEM in the devm_kzalloc() error handling
case instead of 0, as done elsewhere in this function.
Signed-off-by: Wei Yongjun
---
drivers/usb/musb/musb_dsps.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/musb/musb_dsps.c b/drivers/usb/musb
From: Wei Yongjun
Fix to return a negative error code in the gpio_to_irq() error handling
case instead of 0, as done elsewhere in this function.
Signed-off-by: Wei Yongjun
---
drivers/usb/gadget/s3c2410_udc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/gadget/s3c2410_udc.c
From: Wei Yongjun
Fix to return -ENOMEM in the request alloc error handling
case instead of 0, as done elsewhere in this function.
Signed-off-by: Wei Yongjun
---
drivers/usb/gadget/r8a66597-udc.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/gadget
From: Wei Yongjun
Fix to return -ENOMEM in the request alloc error handling
case instead of 0, as done elsewhere in this function.
Signed-off-by: Wei Yongjun
---
drivers/usb/gadget/m66592-udc.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/m66592
From: Wei Yongjun
Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.
Signed-off-by: Wei Yongjun
---
drivers/usb/gadget/fusb300_udc.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/gadget
From: Wei Yongjun
Fix to return -ENOMEM in the kzalloc() error handling case instead
of 0(following platform_device_add_data() will overwrite it to 0), as
done elsewhere in this function.
Signed-off-by: Wei Yongjun
---
drivers/usb/gadget/dummy_hcd.c | 4 +++-
1 file changed, 3 insertions
From: Wei Yongjun
Fix to return a negative error code in the go through all configs error
handling case instead of 0(usb_add_function() will overwrite ret to 0).
Also use error code from usb_gstrings_attach() in all strings init error
case instead of -EINVAL.
Signed-off-by: Wei Yongjun
From: Wei Yongjun
convert list_for_each() to list_for_each_entry() where
applicable.
Signed-off-by: Wei Yongjun
---
drivers/usb/host/fusbh200-hcd.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/usb/host/fusbh200-hcd.c b/drivers/usb/host/fusbh200-hcd.c
index
From: Wei Yongjun
Fix to release all resources when fusbh200_setup() fail instead of only
return error.
Signed-off-by: Wei Yongjun
---
drivers/usb/host/fusbh200-hcd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/host/fusbh200-hcd.c b/drivers/usb/host
On 05/31/2013 07:21 PM, gre...@linuxfoundation.org wrote:
> On Fri, May 31, 2013 at 02:35:41AM +, Wendy Yuan-Hsin Chen(��元馨) wrote:
>> -Original Message-
>> From: Wei Yongjun [mailto:weiyj...@gmail.com]
>> Sent: Tuesday, May 21, 2013 10:41 AM
>> To: gre...
On 05/31/2013 08:29 PM, Greg KH wrote:
> On Fri, May 31, 2013 at 08:05:22PM +0800, Wei Yongjun wrote:
>> On 05/31/2013 07:21 PM, gre...@linuxfoundation.org wrote:
>>> On Fri, May 31, 2013 at 02:35:41AM +, Wendy Yuan-Hsin Chen(??元馨) wrote:
>>>> -Original Messa
From: Wei Yongjun
Remove unneeded error handling on the result of a call
to platform_get_resource() when the value is passed to
devm_ioremap_resource().
Signed-off-by: Wei Yongjun
---
drivers/usb/phy/phy-keystone.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/usb/phy/phy
From: Wei Yongjun
The variable 'dev' is initialized but never used
otherwise, so remove the unused variable.
Signed-off-by: Wei Yongjun
---
drivers/usb/gadget/gr_udc.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/usb/gadget/gr_udc.c b/drivers/usb/gadget/gr_udc.c
ind
From: Wei Yongjun
Remove duplicated include.
Signed-off-by: Wei Yongjun
---
drivers/usb/gadget/s3c-hsotg.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/usb/gadget/s3c-hsotg.c b/drivers/usb/gadget/s3c-hsotg.c
index c0ff1cb..1172eae 100644
--- a/drivers/usb/gadget/s3c-hsotg.c
Add the missing unlock before return from function ccg_cmd_write_flash_row()
in the error handling case.
Fixes: 5c9ae5a87573 ("usb: typec: ucsi: ccg: add firmware flashing support")
Signed-off-by: Wei Yongjun
---
drivers/usb/typec/ucsi/ucsi_ccg.c | 1 +
1 file changed, 1 insertio
probe")
Signed-off-by: Wei Yongjun
---
drivers/usb/gadget/udc/lpc32xx_udc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/gadget/udc/lpc32xx_udc.c
b/drivers/usb/gadget/udc/lpc32xx_udc.c
index d8f1c60793ed..00fb79c6d025 100644
--- a/drivers/usb/gadget/udc/lpc
In case of error, the function devm_ioremap_nocache() returns NULL
pointer not ERR_PTR(). The IS_ERR() test in the return value check
should be replaced with NULL test.
Fixes: f6fb9ec02be1 ("usb: roles: Add Intel xHCI USB role switch driver")
Signed-off-by: Wei Yongjun
---
drivers
Fix to return error code -ENOMEM from the alloc fail error handling
case instead of 0, as done elsewhere in this function.
Fixes: ecd29dabb2ba ("usb: dwc2: pci: Handle error cleanup in probe")
Signed-off-by: Wei Yongjun
---
drivers/usb/dwc2/pci.c | 4 +++-
1 file changed, 3 insert
+ if (!res)
+ return -EINVAL;
... when != res == NULL
e = devm_ioremap_nocache(e1, res->start, e2);
Signed-off-by: Wei Yongjun
---
drivers/usb/roles/intel-xhci-usb-role-switch.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/usb/roles/intel-xhci-usb-role-switch.c
b/drivers/u
Fixes the following sparse warning:
drivers/usb/dwc3/gadget.c:169:6: warning:
symbol 'dwc3_gadget_del_and_unmap_request' was not declared. Should it be
static?
Signed-off-by: Wei Yongjun
---
drivers/usb/dwc3/gadget.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Fixes the following sparse warnings:
drivers/usb/dwc3/drd.c:443:19: warning:
symbol 'dwc3_get_extcon' was not declared. Should it be static?
Signed-off-by: Wei Yongjun
---
drivers/usb/dwc3/drd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/dw
Fix to return error code -ENODEV from the get device failed error
handling case instead of 0, as done elsewhere in this function.
Fixes: a4333c3a6ba9 ("usb: dwc3: Add Qualcomm DWC3 glue driver")
Signed-off-by: Wei Yongjun
---
drivers/usb/dwc3/dwc3-qcom.c | 1 +
1 file changed, 1
Add the missing platform_device_put() before return from bdc_pci_probe()
in the platform_device_add_resources() error handling case.
Fixes: efed421a94e6 ("usb: gadget: Add UDC driver for Broadcom USB3.0 device
controller IP BDC")
Signed-off-by: Wei Yongjun
---
drivers/usb/gadg
Add the missing unlock before return from function
dp_altmode_activate() in the error handling case.
Fixes: 0e3bb7d6894d ("usb: typec: Add driver for DisplayPort alternate mode")
Signed-off-by: Wei Yongjun
---
drivers/usb/typec/altmodes/displayport.c | 6 --
1 file changed, 4
In case of error, the function pcim_iomap() returns NULL pointer not
ERR_PTR(). The IS_ERR() test in the return value check should be
replaced with NULL test.
Fixes: 7740d04d901d ("usb: dwc3: pci: Enable ULPI Refclk on platforms where the
firmware does not")
Signed-off-by: W
There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.
Signed-off-by: Wei Yongjun
---
drivers/usb/cdns3/core.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/usb/cdns3/core.c b/drivers/usb/cdns3
Add the missing platform_device_put() before return from
xhci_create_intel_xhci_sw_pdev() in the error handling case.
Fixes: 6ed151f26484 ("xhci-ext-caps.c: Add property to disable Intel SW switch")
Signed-off-by: Wei Yongjun
---
drivers/usb/host/xhci-ext-caps.c | 1 +
1 file
89 matches
Mail list logo
