Hi,
On Fri, Aug 29, 2014 at 12:18 AM, Mark Rutland wrote:
> On Thu, Aug 28, 2014 at 09:01:56AM +0100, Vivek Gautam wrote:
>> Exynos7 also has a separate special gate clock going to the IP
>> apart from the usual AHB clock. So add support for the same.
>>
>>
rations working."
[1] https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg710094.html
[2] http://comments.gmane.org/gmane.linux.ports.sh.devel/35932
[3] http://www.spinics.net/lists/linux-usb/msg112300.html
Vivek Gautam (4):
phy: Add provision for calibrating phy.
usb: host:
controller work at SuperSpeed.
So facilitating the HCDs to calibrate the PHY.
Signed-off-by: Vivek Gautam
---
drivers/usb/core/hcd.c | 18 ++
1 file changed, 18 insertions(+)
diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c
index c4ed66c..6e01d09 100644
--- a/driver
using xhci-hcd
[Also removed unnecessary extra lines in the register macro definitions]
Signed-off-by: Vivek Gautam
---
drivers/phy/phy-exynos5-usbdrd.c | 185 ++
1 file changed, 170 insertions(+), 15 deletions(-)
diff --git a/drivers/phy/phy-exynos5-usbdrd.c b
USB 3.0 type (PIPE3).
Signed-off-by: Vivek Gautam
---
drivers/usb/host/xhci-plat.c | 27 +++
1 file changed, 27 insertions(+)
diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c
index 1a0cf9f..6afd508 100644
--- a/drivers/usb/host/xhci-plat.c
+++ b
Some PHY controllers may need to calibrate certain
PHY settings after initialization of the controller and
sometimes even after initializing the PHY-consumer too.
Add support for the same in order to let consumers do so in need.
Signed-off-by: vivek Gautam
---
drivers/phy/phy-core.c | 36
On Fri, Aug 29, 2014 at 12:58 AM, Felipe Balbi wrote:
> On Thu, Aug 28, 2014 at 01:31:59PM +0530, Vivek Gautam wrote:
>> The Exynos-DWC3 USB 3.0 DRD controller is also present on
>> Exynos7 platform, so adding the dependency on ARCH_EXYNOS7
>> for this driver.
>>
>
On Tue, Sep 2, 2014 at 8:07 PM, Felipe Balbi wrote:
> On Mon, Sep 01, 2014 at 01:30:21PM +0530, Vivek Gautam wrote:
>> On Thu, Aug 28, 2014 at 8:36 PM, Daniele Forsi wrote:
>> > 2014-08-28 10:02 GMT+02:00 Vivek Gautam:
>> >
>> >> This USB 3.0 PH
Hi Felipe,
On Tue, Sep 2, 2014 at 8:04 PM, Felipe Balbi wrote:
> Hi,
>
> On Tue, Sep 02, 2014 at 04:42:18PM +0530, Vivek Gautam wrote:
>> Adding phy calibrate callback, which facilitates setting certain
>> PHY settings post initialization of the PHY controller.
>> Exy
On Wed, Sep 3, 2014 at 8:12 PM, Felipe Balbi wrote:
> Hi,
>
> On Wed, Sep 03, 2014 at 12:59:27PM +0530, Vivek Gautam wrote:
>> > On Tue, Sep 02, 2014 at 04:42:18PM +0530, Vivek Gautam wrote:
>> >> Adding phy calibrate callback, which facilitates setting c
On Fri, Sep 5, 2014 at 11:26 PM, Felipe Balbi wrote:
> On Thu, Sep 04, 2014 at 12:01:19PM +0530, Vivek Gautam wrote:
>> > Don't we have phy_power_on()
>> > for that ? It looks like you could just as well do this from
>> > phy_power_on() ?
>>
>> No, u
Hi,
On Mon, Sep 8, 2014 at 7:14 PM, Felipe Balbi wrote:
> Hi,
>
> On Mon, Sep 08, 2014 at 09:53:09AM +0530, Vivek Gautam wrote:
>> On Fri, Sep 5, 2014 at 11:26 PM, Felipe Balbi wrote:
>> > On Thu, Sep 04, 2014 at 12:01:19PM +0530, Vivek Gautam wrote:
>> &
adding Julius here,
On Tue, Sep 9, 2014 at 8:12 PM, Felipe Balbi wrote:
> On Tue, Sep 09, 2014 at 07:19:50AM +0530, Vivek Gautam wrote:
>> Hi,
>>
>>
>> On Mon, Sep 8, 2014 at 7:14 PM, Felipe Balbi wrote:
>> > Hi,
>> >
>> > On Mon, Sep 08,
On Wed, Sep 10, 2014 at 9:07 AM, Vivek Gautam wrote:
> adding Julius here,
i think i had missed adding Julius for this entire series :-(
I should be more careful with the CC list in future.
Added his chromium id, since that seems to be more active.
>
>
> On Tue, Sep 9, 2014 at 8:1
On Wed, Sep 10, 2014 at 10:23 AM, Felipe Balbi wrote:
> On Wed, Sep 10, 2014 at 09:09:57AM +0530, Vivek Gautam wrote:
>> On Wed, Sep 10, 2014 at 9:07 AM, Vivek Gautam
>> wrote:
>> > adding Julius here,
>>
>> i think i had missed adding Julius for this e
On Wed, Sep 10, 2014 at 10:53 AM, Vivek Gautam wrote:
> On Wed, Sep 10, 2014 at 10:23 AM, Felipe Balbi wrote:
>> On Wed, Sep 10, 2014 at 09:09:57AM +0530, Vivek Gautam wrote:
>>> On Wed, Sep 10, 2014 at 9:07 AM, Vivek Gautam
>>> wrote:
>>> > adding Ju
Hi,
On Thursday, September 11, 2014 1:52 AM, "Julius Werner"
wrote
right, use that to call phy_init() at the right time, then you need to
add a new ->calibrate() method which, likely, will only be used by you
;-)
so you mean, the xhci should itself call phy_init() at a time suitable,
s
Now that we have completely moved from older USB-PHY drivers
to newer GENERIC-PHY drivers for PHYs available with USB controllers
on Exynos series of SoCs, we can remove the support for the same
in our host drivers too.
Signed-off-by: Vivek Gautam
---
drivers/usb/host/ohci-exynos.c | 89
Now that we have completely moved from older USB-PHY drivers
to newer GENERIC-PHY drivers for PHYs available with USB controllers
on Exynos series of SoCs, we can remove the support for the same
in our host drivers too.
Signed-off-by: Vivek Gautam
---
drivers/usb/host/ehci-exynos.c | 81
s patch was part of the series "[PATCH 0/7] usb-phy: samsung: Cleanup the
unused drivers"
https://lkml.org/lkml/2014/8/14/235. I have dropped the phy cleanup patches
from that series-
Patches 1-5.
- Rebased this patch on top of 3.17-rc1.
Vivek Gautam (2):
usb: host: ehci-exynos:
Hi Alan,
On Wed, Sep 17, 2014 at 8:27 PM, Alan Stern wrote:
> On Wed, 17 Sep 2014, Vivek Gautam wrote:
>
>> Now that we have completely moved from older USB-PHY drivers
>> to newer GENERIC-PHY drivers for PHYs available with USB controllers
>> on Exynos series of SoCs, w
error when getting PHYs.
Signed-off-by: Vivek Gautam
Acked-by: Jingoo Han
Cc: Alan Stern
---
Changes since v3:
- Addressed review comments by Alan:
-- Skipped renaming 'phy_number' variable,
-- resorted to just adding minimal change required for phy assignment.
-- upd
error when getting PHYs.
Signed-off-by: Vivek Gautam
Acked-by: Jingoo Han
Cc: Alan Stern
---
Changes since v3:
- Addressed review comments by Alan:
-- Skipped renaming 'phy_number' variable,
-- resorted to just adding minimal change required for phy assignment.
-- upd
ar to how UM says.
anyways verified from Exynos5420 user manual.
with that change,
Reviewed-by: Vivek Gautam
[snip]
--
Best Regards
Vivek Gautam
Samsung R&D Institute, Bangalore
India
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
ch we see in SoC documentation.
>
> Signed-off-by: Anton Tikhomirov
> ---
> drivers/phy/phy-exynos5-usbdrd.c | 12 ++--
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
you can add my reviewed-by
Reviewed-by: Vivek Gautam
[snip]
> diff --git a/drivers/phy/phy-e
On Thu, Sep 18, 2014 at 8:20 PM, Alan Stern wrote:
> On Thu, 18 Sep 2014, Vivek Gautam wrote:
>
>> Now that we have completely moved from older USB-PHY drivers
>> to newer GENERIC-PHY drivers for PHYs available with USB controllers
>> on Exynos series of SoCs, we can re
error when getting PHYs.
Signed-off-by: Vivek Gautam
Acked-by: Jingoo Han
Acked-by: Alan Stern
---
Changes since v4:
- returning 'ret' instead of PTR_ERR(phy), since ret is nothing but that only.
Changes since v3:
- Addressed review comments by Alan:
-- Skipped renaming &
error when getting PHYs.
Signed-off-by: Vivek Gautam
Acked-by: Jingoo Han
Acked-by: Alan Stern
---
Changes since v4:
- returning 'ret' instead of PTR_ERR(phy), since ret is nothing but that only.
Changes since v3:
- Addressed review comments by Alan:
-- Skipped renaming &
Hi Greg,
On Mon, Sep 22, 2014 at 11:15 AM, Vivek Gautam wrote:
> Now that we have completely moved from older USB-PHY drivers
> to newer GENERIC-PHY drivers for PHYs available with USB controllers
> on Exynos series of SoCs, we can remove the support for the same
> in our host
On Mon, Sep 29, 2014 at 7:21 AM, Greg KH wrote:
> On Thu, Sep 25, 2014 at 10:50:22AM +0530, Vivek Gautam wrote:
>> Hi Greg,
>>
>>
>> On Mon, Sep 22, 2014 at 11:15 AM, Vivek Gautam
>> wrote:
>> > Now that we have completely moved from older USB-PHY dri
error when getting PHYs.
Signed-off-by: Vivek Gautam
Acked-by: Jingoo Han
Acked-by: Alan Stern
---
Changes since v4:
- returning 'ret' instead of PTR_ERR(phy), since ret is nothing but that only.
Changes since v3:
- Addressed review comments by Alan:
-- Skipped renaming &
ou will have to cherrypick two
patches each for ehci-exynos and ohci-exynos:
usb: host: ehci-exynos: Remove unnecessary usb-phy support
usb: host: ohci-exynos: Remove unnecessary usb-phy support
--
Best Regards
Vivek Gautam
Samsung R&D Institute, Bangalore
India
--
To unsubscribe from this list:
On Wed, Oct 1, 2014 at 8:42 PM, Daniel Drake wrote:
> On Wed, Oct 1, 2014 at 12:36 AM, Vivek Gautam
> wrote:
>> One reason i doubt why it could be coming is because we are
>> specifically putting the
>> child after doing everything with it.
>>
>> When
of_node_put() on the "prev" node. So there's no point
in putting the same node again in our routine.
Reported-by: Daniel Drake
Signed-off-by: Vivek Gautam
---
drivers/usb/host/ehci-exynos.c |1 -
drivers/usb/host/ohci-exynos.c |1 -
2 files changed, 2 deletions(-)
diff --gi
This PHY controller is also present on Exynos7 platform
in arch-exynos family.
So PHY_EXYNOS5_USBDRD should now depend on ARCH_EXYNOS.
Signed-off-by: Vivek Gautam
---
drivers/phy/Kconfig |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/phy/Kconfig b/drivers/phy
Exynos7 also has a separate special gate clock going to the IP
apart from the usual AHB clock. So add support for the same.
Signed-off-by: Vivek Gautam
---
drivers/usb/dwc3/dwc3-exynos.c | 16
1 file changed, 16 insertions(+)
diff --git a/drivers/usb/dwc3/dwc3-exynos.c b
7
from v1 of this series, since its not required now.
Vivek Gautam (4):
dwc3: exynos: Add support for SCLK present on Exynos7
phy: exynos5-usbdrd: Add pipe-clk and utmi-clk support
phy: exynos5-usbdrd: Add facility for VBUS-BOOST-5V supply
phy: exynos7-usbdrd: Update dependency for AR
Exynos7 SoC has now separate gate control for 125MHz pipe3 phy
clock, as well as 60MHz utmi phy clock.
So get the same and control in the phy-exynos5-usbdrd driver.
Signed-off-by: Vivek Gautam
---
.../devicetree/bindings/phy/samsung-phy.txt|4
drivers/phy/phy-exynos5-usbdrd.c
Some Exynos SoCs have a separate regulator controlling a
Boost 5V supply which goes as input for VBUS regulator.
So adding a control for the same in driver, to enable
vbus supply on the port.
Signed-off-by: Vivek Gautam
---
drivers/phy/phy-exynos5-usbdrd.c | 30
On Tue, Oct 7, 2014 at 7:41 PM, Felipe Balbi wrote:
> On Tue, Oct 07, 2014 at 03:49:33PM +0530, Vivek Gautam wrote:
>> Exynos7 also has a separate special gate clock going to the IP
>> apart from the usual AHB clock. So add support for the same.
>>
>> Signed-off-by:
boards instead. Thanks for pointing it out.
>
>> Boost 5V supply which goes as input for VBUS regulator.
>> So adding a control for the same in driver, to enable
>> vbus supply on the port.
>>
>> Signed-off-by: Vivek Gautam
>> ---
>> drivers/phy/phy-ex
> Exynos7 doesn't have "Gating all clocks for USBDRD30" bit. The clocks
> should be controlled separately.
true, on Exynos7 we have separate gates for the available clocks going to
USB-DRD block. So we will have to add these basic required number of
clocks.
--
Best Regard
AHB clock. So add support for the same.
>>
>> As we discussed before, Exynos7 SoCs have 7 clocks to be controlled
>> by the driver. Adding only sclk is not enough.
>>
>> >
>> > Signed-off-by: Vivek Gautam
>> > ---
>> > drivers/usb/dwc3/dwc3-exy
Hi,
On Sat, Jun 7, 2014 at 4:22 AM, Thierry Reding wrote:
> On Fri, Jun 06, 2014 at 06:32:42PM +0530, Vivek Gautam wrote:
>> On Wed, Jun 4, 2014 at 6:43 PM, Thierry Reding
>> wrote:
>> > On Wed, Jun 04, 2014 at 03:41:20PM +0530, Vivek Gautam wrote:
>> >> On
is purpose (you could
> still set it up from xhci_plat_probe(), and then call it from
> hcd_bus_resume() or something like that). Since XHCI host controllers
> already conveniently have two struct usb_hcd (one for 2.0 and one for
> 3.0), you can cleanly store references to your two PHYs in t
27;s going wrong.
Please try with the newer version of kernel like Greg suggested.
We maintain support for USB on Exynos5250, and would be happy to help
you out with any issue.
--
Best Regards
Vivek Gautam
Samsung R&D Institute, Bangalore
India
--
To unsubscribe from this lis
,
> however Greg wasn't eager to pick that up so far. Here's the last posting of
> my patch:
>
> http://marc.info/?l=linux-usb&m=140145917506582
Thanks for pointing to the patch, i have also been tracking this patch.
I will try to rework using this patch and post the relevant patches.
--
Best Regards
Vivek Gautam
Samsung R&D Institute, Bangalore
India
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
suggested:
usb: dwc3: host: convey the PHYs to xhci
(https://lkml.org/lkml/2014/6/5/585) and related patch series.
So if we use this second approach, we would need to override the
'phy_get()' that has been done in usb_add_hcd()
in xhci_plat_probe(), and then use them in later operations.
am i getting the things correctly ?
--
Best Regards
Vivek Gautam
Samsung R&D Institute, Bangalore
India
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
ome Host controllers need software interaction with phys;
> * other external phys should be software-transparent
> */
> - struct usb_phy *phy;
> + struct usb_phy *phy;
> + struct phy *gen_phy;
>
> /* Flags that
ivers.
So ensuring now that the controller driver requests the necessary
VDD regulators (if available, unless there are direct VDD rails),
and enable them so as to make them working.
Signed-off-by: Vivek Gautam
Cc: Jingoo Han
Cc: Alan Stern
---
Changes from v2:
- replaced devm_regulator_get()
s.
So ensuring now that the controller driver requests the necessary
VDD regulators (if available, unless there are direct VDD rails),
and enable them so as to make them working.
Signed-off-by: Vivek Gautam
Cc: Jingoo Han
Cc: Alan Stern
---
Changes from v2:
- replaced devm_regulator_get()
_S5P || ARCH_EXYNOS
> + select PHY_SAMSUNG_USB2 if ARCH_EXYNOS
> + help
> + Enable support for the Samsung Exynos SOC's on-chip EHCI controller.
>
> config USB_EHCI_MV
> bool "EHCI support for Marvell PXA/MMP USB controller"
> @@ -5
Hi Sachin,
On Thu, Jun 26, 2014 at 2:23 PM, Sachin Kamat wrote:
> Hi Vivek,
>
> On Thu, Jun 26, 2014 at 1:55 PM, Sachin Kamat
> wrote:
>> Hi Vivek,
>>
>> On Thu, Jun 26, 2014 at 1:39 PM, Vivek Gautam
>> wrote:
>>> Hi Sachin,
>>>
Hi,
On Wed, Jul 2, 2014 at 5:01 PM, Kishon Vijay Abraham I wrote:
> Hi,
>
> On Thursday 05 June 2014 06:51 PM, Vivek Gautam wrote:
>> Hi Heikki,
>>
>>
>> On Thu, Jun 5, 2014 at 6:22 PM, Heikki Krogerus
>> wrote:
>>> Hi,
>>>
>&
Cc: Alan, Mathias Nyman, Julius Werner, Heikki Krogerus
Hi,
On Wed, Jun 25, 2014 at 4:02 PM, Vivek Gautam wrote:
> Hi Sergei,
>
>
> On Fri, May 30, 2014 at 7:42 PM, Yoshihiro Shimoda
> wrote:
>> From Sergei Shtylyov
>>
>> Add the generic PHY support,
Hi,
On Sat, Jul 5, 2014 at 4:56 AM, Sergei Shtylyov
wrote:
> Hello.
>
>
> On 06/25/2014 02:32 PM, Vivek Gautam wrote:
>
>>> From Sergei Shtylyov
>
>
>>> Add the generic PHY support, analogous to the USB PHY support. Intended
>>> it to be
>
Hi,
On Mon, Jun 9, 2014 at 9:19 AM, Pratyush Anand wrote:
> On Fri, Jun 06, 2014 at 08:12:12PM +0800, Vivek Gautam wrote:
>> Some PHY controllers may need to calibrate certain
>> PHY settings after initialization of the controller and
>> sometimes even after initializing
USB 3.0 type (PIPE3), provided
by the parent - Synopsys's DWC3 controller
Signed-off-by: Vivek Gautam
---
drivers/usb/host/xhci-plat.c | 36
1 file changed, 36 insertions(+)
diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c
to get the controller work at SuperSpeed.
Signed-off-by: Vivek Gautam
---
drivers/usb/host/xhci-plat.c | 39 +--
1 file changed, 37 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c
index e50bd7d..decf
ls and Boost levels need to be
calibrated further post initialization of xHCI controller, to get
SuperSpeed operations working."
[1] https://lkml.org/lkml/2014/6/5/358
Vivek Gautam (4):
phy: Add provision for calibrating phy.
usb: host: xhci-plat: Get PHYs for xhci's hcds
usb: host:
using xhci-hcd
Signed-off-by: Vivek Gautam
---
drivers/phy/phy-exynos5-usbdrd.c | 169 ++
1 file changed, 169 insertions(+)
diff --git a/drivers/phy/phy-exynos5-usbdrd.c b/drivers/phy/phy-exynos5-usbdrd.c
index 56285af..b214483 100644
--- a/drivers/phy/phy
Some PHY controllers may need to calibrate certain
PHY settings after initialization of the controller and
sometimes even after initializing the PHY-consumer too.
Add support for the same in order to let consumers do so in need.
Signed-off-by: vivek Gautam
---
drivers/phy/phy-core.c | 36
Hi Julius,
On Wed, Jul 9, 2014 at 11:26 PM, Julius Werner wrote:
> On Wed, Jul 9, 2014 at 3:01 AM, Vivek Gautam wrote:
>> The host controller by itself may sometimes need to handle PHY
>> and/or calibrate some of the PHY settings to get full support out
>> of the PHY con
On Wed, Jul 9, 2014 at 11:28 PM, Julius Werner wrote:
> On Wed, Jul 9, 2014 at 3:01 AM, Vivek Gautam wrote:
>> Some quirky PHYs may require to be calibrated post the host
>> controller initialization.
>> The USB 3.0 DRD PHY on Exynos5420/5800 systems, coming along wi
ove_hcd(struct usb_hcd *hcd)
>
> usb_deregister_bus(&hcd->self);
> hcd_buffer_destroy(hcd);
> - if (hcd->remove_phy && hcd->phy) {
> - usb_phy_shutdown(hcd->phy);
> - usb_put_phy(hcd->phy);
> -
her post initialization of xHCI controller, to get
SuperSpeed operations working."
[1] https://lkml.org/lkml/2014/6/5/358
Vivek Gautam (4):
phy: Add provision for calibrating phy.
usb: host: xhci-plat: Get PHYs for xhci's hcds
usb: hcd: Caibrate PHY post hcd reset
phy: exyn
Some PHY controllers may need to calibrate certain
PHY settings after initialization of the controller and
sometimes even after initializing the PHY-consumer too.
Add support for the same in order to let consumers do so in need.
Signed-off-by: vivek Gautam
---
drivers/phy/phy-core.c | 36
using xhci-hcd
Signed-off-by: Vivek Gautam
---
drivers/phy/phy-exynos5-usbdrd.c | 169 ++
1 file changed, 169 insertions(+)
diff --git a/drivers/phy/phy-exynos5-usbdrd.c b/drivers/phy/phy-exynos5-usbdrd.c
index 56285af..30adbcb 100644
--- a/drivers/phy/phy
USB 3.0 type (PIPE3).
Signed-off-by: Vivek Gautam
---
drivers/usb/host/xhci-plat.c | 17 +
1 file changed, 17 insertions(+)
diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c
index 1a0cf9f..d097d60 100644
--- a/drivers/usb/host/xhci-plat.c
+++ b/drivers
controller work at SuperSpeed.
So facilitating the HCDs to calibrate the PHY.
Signed-off-by: Vivek Gautam
---
drivers/usb/core/hcd.c | 22 ++
1 file changed, 22 insertions(+)
diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c
index 2841149..a344b76 100644
--- a/d
USB 3.0 type (PIPE3).
Signed-off-by: Vivek Gautam
---
Changes from v3:
- Modified error message as per review comments from Julius.
drivers/usb/host/xhci-plat.c | 19 +++
1 file changed, 19 insertions(+)
diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci
;pdev->dev);
>> > }
>> > EXPORT_SYMBOL_GPL(platform_device_put);
>
> Why would a single call to this function remove an id? That seems
> really wrong, you should be able to call get and put on a device
> numerous times, only the "last" reference should ca
symbol, we end up getting
the NOP_USB_XCEIV phy when the same is enabled. And thus the PHYs
are not configured properly.
Signed-off-by: Vivek Gautam
Cc: Alan Stern
Cc: Jingoo Han
---
drivers/usb/host/ehci-exynos.c | 40 +-
drivers/usb/host/ohci-exynos.c | 47
symbol, we end up getting
the NOP_USB_XCEIV phy when the same is enabled. And thus the PHYs
are not configured properly.
Reported-by: Sachin Kamat
Signed-off-by: Vivek Gautam
Cc: Alan Stern
Cc: Jingoo Han
---
Based on 'usb-next' branch.
Resending it after adding 'Reported-by&
Hi Jingoo,
On Tuesday, August 05, 2014 4:28 PM, Jingoo Han wrote:
On Tuesday, August 05, 2014 7:39 PM, Vivek Gautam wrote:
Since we want to keep support for both older usb-phys as well as the
newer generic phys, lets first get the generic PHYs and fallback to
older USB-PHYs only when we fail
Cleaning up the driver further to enable only S3C64XX phy support,
while the support for rest all SoCs is removed in previous patches.
Signed-off-by: Vivek Gautam
---
- In the changes that have been left for S3C64XX, we have added DT based
pmu-isolation support for S3C64XX boards too
SAMSUNG_USB2PHY config symbol, we ended up getting the NOP_USB_XCEIV phy
when the same is enabled. And thus the PHYs are not configured properly.
Reported-by: Sachin Kamat
Signed-off-by: Vivek Gautam
---
drivers/usb/host/ohci-exynos.c | 64 ++--
1 file changed, 9
SAMSUNG_USB2PHY config symbol, we ended up getting the NOP_USB_XCEIV phy
when the same is enabled. And thus the PHYs are not configured properly.
Reported-by: Sachin Kamat
Signed-off-by: Vivek Gautam
---
drivers/usb/host/ehci-exynos.c | 53 ++--
1 file changed, 8
Now that we have moved to new PHY driver for Exynos5250's USB 2.0
controller, which is based on generic phy framework; we no longer
need to keep support of the same in older usb-phy based driver.
So removing this entire code for Exyno5250.
Signed-off-by: Vivek Gautam
---
drivers/usb/ph
Now that we have moved to new PHY driver for Exynos4X12's USB 2.0
controller, which is based on generic phy framework; so removing
this entire code for Exyno4X12.
Signed-off-by: Vivek Gautam
---
drivers/usb/phy/phy-samsung-usb.c | 42
drivers/usb/ph
Now that we have moved to new PHY driver for Exynos4210's USB 2.0
controller, which is based on generic phy framework; so removing
the code for Exyno4210.
Signed-off-by: Vivek Gautam
---
drivers/usb/phy/phy-samsung-usb.c | 35 ---
drivers/usb/phy/phy-sa
Removing this older USB 3.0 DRD controller PHY driver, since
a new driver based on generic phy framework is now available.
Signed-off-by: Vivek Gautam
---
drivers/usb/phy/Kconfig|8 -
drivers/usb/phy/Makefile |1 -
drivers/usb/phy/phy-samsung-usb.h | 80
Hi Alan,
On Tue, Aug 5, 2014 at 7:41 PM, Alan Stern wrote:
> On Tue, 5 Aug 2014, Vivek Gautam wrote:
>
>> Since we want to keep support for both older usb-phys as well as the
>> newer generic phys, lets first get the generic PHYs and fallback to
>> older USB-PHYs only
me testing this series.
[1] https://lkml.org/lkml/2014/8/5/142
Vivek Gautam (7):
usb-phy: samsung-usb3: Remove older phy-samsung-usb3 driver
usb-phy: samsung-usb2: Remove support for Exynos5250
usb-phy: samsung-usb2: Remove support for Exynos4X12
usb-phy: samsung-usb2: Remove support for Exyno
hat series.
[1] [PATCH 0/7] usb-phy: samsung: Cleanup the unused drivers
https://lkml.org/lkml/2014/8/14/235
drivers/usb/phy/phy-samsung-usb2 driver got replaced by
drivers/phy/phy-samsung-usb2 one and is no longer used.
Cc: Kamil Debski
Cc: Vivek Gautam
Signed-off-by: Bartlomiej Zolnierki
Hi Tomasz and Bartlomiej,
On Mon, Aug 18, 2014 at 4:52 PM, Tomasz Figa wrote:
> On 18.08.2014 13:02, Bartlomiej Zolnierkiewicz wrote:
>> On Thursday, August 14, 2014 08:07:40 PM Vivek Gautam wrote:
>>> On Thursday, August 14, 2014 7:55 PM, Bartlomiej Zolnierkiewicz
>>>
: remove old USB 2.0 PHY driver
> usb: phy: samsung: remove old USB 3.0 PHY driver
> usb: phy: samsung: remove old common USB PHY code
Reviewed-by: Vivek Gautam
--
Best Regards
Vivek Gautam
Samsung R&D Institute, Bangalore
India
--
To unsubscribe from this list: send the line "
Hi Felipe,
On Wed, Aug 20, 2014 at 11:44 PM, Felipe Balbi wrote:
> Hi,
>
> On Thu, Aug 14, 2014 at 07:53:53PM +0530, Vivek Gautam wrote:
>> - This series is based on 'usb-next' branch.
>>
>> Now that we have support for USB PHY controllers for Exynos SoC
SAMSUNG_USB2PHY config symbol, we ended up getting the NOP_USB_XCEIV phy
when the same is enabled. And thus the PHYs are not configured properly.
Reported-by: Sachin Kamat
Signed-off-by: Vivek Gautam
Acked-by: Alan Stern
Reviewed-by: Jingoo Han
---
- This patch was part of the series "[PATCH 0/7
SAMSUNG_USB2PHY config symbol, we ended up getting the NOP_USB_XCEIV phy
when the same is enabled. And thus the PHYs are not configured properly.
Reported-by: Sachin Kamat
Signed-off-by: Vivek Gautam
Acked-by: Alan Stern
Reviewed-by: Jingoo Han
---
- This patch was part of the series "[PATCH 0/7
inux-arm-kernel/2014-July/272833.html
[2] [PATCH v2 0/8] usb: add support for the generic PHY framework
http://www.spinics.net/lists/linux-usb/msg110557.html
--
Best Regards
Vivek Gautam
Samsung R&D Institute, Bangalore
India
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Sergei,
On Thu, Aug 21, 2014 at 6:37 PM, Sergei Shtylyov
wrote:
> Hello.
>
>
> On 08/21/2014 04:44 PM, Vivek Gautam wrote:
>
>>>> From Sergei Shtylyov
>
>
>>> Should be "From:".
>
>
>>>> Add the generic PHY
controller work at SuperSpeed.
So facilitating the HCDs to calibrate the PHY.
Signed-off-by: Vivek Gautam
---
drivers/usb/core/hcd.c | 22 ++
1 file changed, 22 insertions(+)
diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c
index c4ed66c..a42b448 100644
--- a/d
using xhci-hcd
Signed-off-by: Vivek Gautam
---
drivers/phy/phy-exynos5-usbdrd.c | 169 ++
1 file changed, 169 insertions(+)
diff --git a/drivers/phy/phy-exynos5-usbdrd.c b/drivers/phy/phy-exynos5-usbdrd.c
index 47f47fe..fa13784 100644
--- a/drivers/phy/phy
USB 3.0 type (PIPE3).
Signed-off-by: Vivek Gautam
---
drivers/usb/host/xhci-plat.c | 23 +++
1 file changed, 23 insertions(+)
diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c
index 1a0cf9f..56ef9cf 100644
--- a/drivers/usb/host/xhci-plat.c
+++ b
Some PHY controllers may need to calibrate certain
PHY settings after initialization of the controller and
sometimes even after initializing the PHY-consumer too.
Add support for the same in order to let consumers do so in need.
Signed-off-by: vivek Gautam
---
drivers/phy/phy-core.c | 36
xHCI controller, to get
SuperSpeed operations working."
[1] https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg710094.html
[2] http://comments.gmane.org/gmane.linux.ports.sh.devel/35932
Vivek Gautam (4):
phy: Add provision for calibrating phy.
usb: host: xhci-plat: Get P
Hi Heikki,
On Thu, Aug 21, 2014 at 5:03 PM, Heikki Krogerus
wrote:
> The users of the old method are now converted to the new one.
>
> Signed-off-by: Heikki Krogerus
> Tested-by: Vivek Gautam
> ---
> drivers/phy/phy-bcm-kona-usb2.c | 2 +-
> drivers/phy/phy-cor
On Mon, Aug 25, 2014 at 1:47 PM, Heikki Krogerus
wrote:
> On Mon, Aug 25, 2014 at 01:11:34PM +0530, Vivek Gautam wrote:
>> Please squash the attached diff which removes the 'init_data' field
>> from some of the other instances
>> of devm_phy_create() in few other
dded to use register two
separate no-op-xceivers of USB2_PHY type and USB3_PHY type,
so that platforms with no separate PHY can still be able to use dwc3.
>
> Cc: Olof Johansson
> Cc: Kukjin Kim
> Cc: Vivek Gautam
> Acked-by: Kyungmin Park
> Signed-off-by: Bartlomiej Zolnierki
701 - 800 of 868 matches
Mail list logo
