Re: [PATCH v5 1/2] phy: Add new Exynos5 USB 3.0 PHY driver

2014-04-27 Thread Vivek Gautam
Hi Tomasz, On Sat, Apr 26, 2014 at 4:33 AM, Tomasz Figa wrote: > Hi Vivek, > > > On 22.04.2014 10:03, Vivek Gautam wrote: >> >> Add a new driver for the USB 3.0 PHY on Exynos5 series of SoCs. >> The new driver uses the generic PHY framework and will interact >

[PATCH v7 2/2] phy: exynos5-usbdrd: Add facility for VBUS supply

2014-04-27 Thread Vivek Gautam
Adding support to enable/disable VBUS controlled by a regulator, to enable vbus supply on the port. Signed-off-by: Vivek Gautam --- Changes from v6: - Rebased on top of [PATCH v7 1/2] phy: Add new Exynos5 USB 3.0 PHY driver. drivers/phy/phy-exynos5-usbdrd.c | 32

[PATCH v7 1/2] phy: Add new Exynos5 USB 3.0 PHY driver

2014-04-27 Thread Vivek Gautam
framework. Signed-off-by: Vivek Gautam --- Changes from v6: - Addressed review comments: -- Sorted config entries in Kconfig and Makefile -- Made #define to_usbdrd_phy(inst) to a static inline routine. -- Restructured exynos5_rate_to_clk() as suggested. -- Amended 'val'

[PATCH v9 4/4] usb: ehci-exynos: Change to use phy provided by the generic phy framework

2014-04-28 Thread Vivek Gautam
] [gautam.vi...@samsung.com: Edited the commit message] Signed-off-by: Vivek Gautam Cc: Jingoo Han Cc: Alan Stern --- .../devicetree/bindings/usb/exynos-usb.txt | 18 +++ drivers/usb/host/ehci-exynos.c | 143 +--- 2 files changed, 141 insertions(+), 20

[PATCH 2/4] usb: ehci-exynos: Use struct device instead of platform_device

2014-04-28 Thread Vivek Gautam
Change to use struct device instead of struct platform_device for some static functions. Signed-off-by: Vivek Gautam Cc: Jingoo Han Cc: Alan Stern --- drivers/usb/host/ehci-exynos.c |5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/usb/host/ehci-exynos.c b

[PATCH v3 3/4] usb: ohci-exynos: Add facility to use phy provided by the generic phy framework

2014-04-28 Thread Vivek Gautam
support for older phys. Signed-off-by: Vivek Gautam Cc: Jingoo Han Cc: Alan Stern --- .../devicetree/bindings/usb/exynos-usb.txt | 19 +++ drivers/usb/host/ohci-exynos.c | 129 +--- 2 files changed, 132 insertions(+), 16 deletions(-) diff --git a

[PATCH 1/4] usb: ohci-exynos: Use struct device instead of platform_device

2014-04-28 Thread Vivek Gautam
Change to use struct device instead of struct platform_device for some static functions. Signed-off-by: Vivek Gautam Cc: Jingoo Han Cc: Alan Stern --- drivers/usb/host/ohci-exynos.c | 20 +--- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/drivers/usb/host

[PATCH v3 0/4] usb: ehci/ohci-exynos: Move to generic phy framework

2014-04-28 Thread Vivek Gautam
Added necessary checks. Kamil Debski (1): usb: ehci-exynos: Change to use phy provided by the generic phy framework Vivek Gautam (3): usb: ohci-exynos: Use struct device instead of platform_device usb: ehci-exynos: Use struct device instead of platform_device usb: ohci-exynos: Add faci

[PATCH v3 0/4] usb: ehci/ohci-exynos: Move to generic phy framework

2014-04-28 Thread Vivek Gautam
Added necessary checks. Kamil Debski (1): usb: ehci-exynos: Change to use phy provided by the generic phy framework Vivek Gautam (3): usb: ohci-exynos: Use struct device instead of platform_device usb: ehci-exynos: Use struct device instead of platform_device usb: ohci-exynos: Add faci

Re: [PATCH v3 0/4] usb: ehci/ohci-exynos: Move to generic phy framework

2014-04-28 Thread Vivek Gautam
On Mon, Apr 28, 2014 at 2:55 PM, Vivek Gautam wrote: > Based and tested on 'usb-next' branch of Greg's usb tree, with relevant > device tree patches[1] [1] [PATCH v7 0/2] dts: Add usb2phy to Exynos 5250 http://www.spinics.net/lists/linux-usb/msg106427.html > >

Re: [PATCH v7 1/2] phy: Add new Exynos5 USB 3.0 PHY driver

2014-04-29 Thread Vivek Gautam
Hi Kishon, Tomasz, On Mon, Apr 28, 2014 at 11:47 AM, Vivek Gautam wrote: > Add a new driver for the USB 3.0 PHY on Exynos5 series of SoCs. > The new driver uses the generic PHY framework and will interact > with DWC3 controller present on Exynos5 series of SoCs. > Thereby, remo

Re: [PATCH v3 3/4] usb: ohci-exynos: Add facility to use phy provided by the generic phy framework

2014-04-29 Thread Vivek Gautam
Hi, On Mon, Apr 28, 2014 at 9:11 PM, Alan Stern wrote: > On Mon, 28 Apr 2014, Vivek Gautam wrote: > >> Add support to consume phy provided by Generic phy framework. >> Keeping the support for older usb-phy intact right now, in order >> to prevent any functionality brea

[PATCH v10 4/4] usb: ehci-exynos: Change to use phy provided by the generic phy framework

2014-04-29 Thread Vivek Gautam
] [gautam.vi...@samsung.com: Edited the commit message] Signed-off-by: Vivek Gautam Cc: Jingoo Han Cc: Alan Stern --- Changes from v9: - Calling usb_phy_shutdown() when exynos_ehci_phy_enable() is failing. - Made exynos_ehci_phy_disable() return void, since its return value did not serve any

[PATCH v2 1/4] usb: ohci-exynos: Use struct device instead of platform_device

2014-04-29 Thread Vivek Gautam
Change to use struct device instead of struct platform_device for some static functions. Signed-off-by: Vivek Gautam Cc: Alan Stern Acked-by: Jingoo Han --- Changes from v1: - none drivers/usb/host/ohci-exynos.c | 20 +--- 1 file changed, 9 insertions(+), 11 deletions

[PATCH v4 3/4] usb: ohci-exynos: Add facility to use phy provided by the generic phy framework

2014-04-29 Thread Vivek Gautam
support for older phys. Signed-off-by: Vivek Gautam Cc: Jingoo Han Cc: Alan Stern --- Changes from v3: - Calling usb_phy_shutdown() when exynos_ohci_phy_enable() is failing. - Made exynos_ohci_phy_disable() return void, since its return value did not serve any purpose. - Calling

[PATCH v2 2/4] usb: ehci-exynos: Use struct device instead of platform_device

2014-04-29 Thread Vivek Gautam
Change to use struct device instead of struct platform_device for some static functions. Signed-off-by: Vivek Gautam Cc: Alan Stern Acked-by: Jingoo Han --- Changes from v1: - none drivers/usb/host/ehci-exynos.c |5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a

[PATCH 4/4] ARM: dts: Add usb 2.0 support on exynos5420

2014-04-30 Thread Vivek Gautam
Add required device node for ehci and ohci controllers to enable USB 2.0 support. Signed-off-by: Vivek Gautam --- arch/arm/boot/dts/exynos5420.dtsi | 36 +++- 1 file changed, 35 insertions(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/exynos5420.dtsi b

[PATCH 3/4] ARM: dts: Add usb2phy support on exynos5420

2014-04-30 Thread Vivek Gautam
Add required device node for usb2phy to let enable USB 2.0 support. Signed-off-by: Vivek Gautam --- arch/arm/boot/dts/exynos5420.dtsi | 10 ++ 1 file changed, 10 insertions(+) diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi index cfa3755..16b860a

[PATCH 2/4] ARM: dts: Add usb2phy to Exynos 5250

2014-04-30 Thread Vivek Gautam
EHCI] Signed-off-by: Vivek Gautam --- Changes from v7: None arch/arm/boot/dts/exynos5250.dtsi | 26 ++ 1 file changed, 26 insertions(+) diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi index 70f0cd5..51e554c 100644 --- a/arch/arm/boot

[PATCH v8 1/4] ARM: dts: Add sysreg sytem controller node to exynos5250 and exynos5420

2014-04-30 Thread Vivek Gautam
g.com: added similar syscon entry for exynos5420] Signed-off-by: Vivek Gautam --- Changes from v7: None arch/arm/boot/dts/exynos5250.dtsi |5 + arch/arm/boot/dts/exynos5420.dtsi |5 + 2 files changed, 10 insertions(+) diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boo

[PATCH 0/4] dts: Add usb2phy to Exynos 5250/5420

2014-04-30 Thread Vivek Gautam
or usb2phy from 'usb2_phy_new' to 'usb2_phy_gen' indicating generic phy. - Using clock macros in dt entries. Kamil Debski (1): ARM: dts: Add usb2phy to Exynos 5250 Vivek Gautam (3): ARM: dts: Add sysreg sytem controller node to exynos5250 and exynos5420 ARM: dts: Add usb2p

Re: [PATCH 3/4] ARM: dts: Add usb2phy support on exynos5420

2014-04-30 Thread Vivek Gautam
Hi Arun, On Wed, Apr 30, 2014 at 3:55 PM, Arun Kumar K wrote: > Hi Vivek, > > On 04/30/14 14:25, Vivek Gautam wrote: >> Add required device node for usb2phy to let enable USB 2.0 >> support. >> >> Signed-off-by: Vivek Gautam >> --- >> arch/arm/boo

Re: [PATCH v4 3/4] usb: ohci-exynos: Add facility to use phy provided by the generic phy framework

2014-05-02 Thread Vivek Gautam
Hi Tomasz, On Thu, May 1, 2014 at 10:46 PM, Tomasz Figa wrote: > Hi Vivek, > > Please see my comments inline. Thanks for the review, please find my answers inline. > > > On 30.04.2014 07:19, Vivek Gautam wrote: >> >> Add support to consume phy provided by Generic

Re: [PATCH v4 3/4] usb: ohci-exynos: Add facility to use phy provided by the generic phy framework

2014-05-02 Thread Vivek Gautam
On Fri, May 2, 2014 at 2:55 PM, Vivek Gautam wrote: > Hi Tomasz, > > > On Thu, May 1, 2014 at 10:46 PM, Tomasz Figa wrote: >> Hi Vivek, >> >> Please see my comments inline. > > Thanks for the review, please find my answers inline. > >> >> >

[PATCH v5 3/4] usb: ohci-exynos: Add facility to use phy provided by the generic phy framework

2014-05-02 Thread Vivek Gautam
support for older phys. Signed-off-by: Vivek Gautam Cc: Jingoo Han Acked-by: Alan Stern --- Changes from v4: - Removed 'phy-names' property from the bindings since we don't need it. - Restructured exynos_ohci_get_phy() function to handle error codes as well as return relev

[PATCH v11 4/4] usb: ehci-exynos: Change to use phy provided by the generic phy framework

2014-05-02 Thread Vivek Gautam
] [gautam.vi...@samsung.com: Edited the commit message] Signed-off-by: Vivek Gautam Cc: Jingoo Han Acked-by: Alan Stern --- Changes from v10: - Removed 'phy-names' property from the bindings since we don't need it. - Restructured exynos_ehci_get_phy() function to handle error code

[PATCH v3 2/4] usb: ehci-exynos: Use struct device instead of platform_device

2014-05-02 Thread Vivek Gautam
Change to use struct device instead of struct platform_device for some static functions. Signed-off-by: Vivek Gautam Acked-by: Alan Stern Acked-by: Jingoo Han --- Changes from v2: - none drivers/usb/host/ehci-exynos.c |5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff

[PATCH v3 1/4] usb: ohci-exynos: Use struct device instead of platform_device

2014-05-02 Thread Vivek Gautam
Change to use struct device instead of struct platform_device for some static functions. Signed-off-by: Vivek Gautam Acked-by: Alan Stern Acked-by: Jingoo Han --- Changes from v2: - none drivers/usb/host/ohci-exynos.c | 20 +--- 1 file changed, 9 insertions(+), 11

[PATCH v5 0/4] usb: ehci/ohci-exynos: Move to generic phy framework

2014-05-02 Thread Vivek Gautam
-exynos: Change to use phy provided by the generic phy framework Vivek Gautam (3): usb: ohci-exynos: Use struct device instead of platform_device usb: ehci-exynos: Use struct device instead of platform_device usb: ohci-exynos: Add facility to use phy provided by the generic ph

[PATCH v12 4/4] usb: ehci-exynos: Change to use phy provided by the generic phy framework

2014-05-04 Thread Vivek Gautam
] [gautam.vi...@samsung.com: Edited the commit message] Signed-off-by: Vivek Gautam Cc: Jingoo Han Acked-by: Alan Stern Acked-by: Kukjin Kim --- Changes from v11: - Removed setting phy explicitly to error pointer. - Changed error check to '-ENOSYS' instead of '-ENXIO'

[PATCH v6 3/4] usb: ohci-exynos: Add facility to use phy provided by the generic phy framework

2014-05-04 Thread Vivek Gautam
support for older phys. Signed-off-by: Vivek Gautam Cc: Jingoo Han Acked-by: Alan Stern Acked-by: Kukjin Kim --- Changes from v5: - Removed setting phy explicitly to error pointer. - Changed error check to '-ENOSYS' instead of '-ENXIO' in failure case of devm_of_phy_

[PATCH v4 1/4] usb: ohci-exynos: Use struct device instead of platform_device

2014-05-04 Thread Vivek Gautam
Change to use struct device instead of struct platform_device for some static functions. Signed-off-by: Vivek Gautam Acked-by: Alan Stern Acked-by: Jingoo Han Acked-by: Kukjin Kim --- Changes since v1: - none drivers/usb/host/ohci-exynos.c | 20 +--- 1 file changed, 9

[PATCH v4 2/4] usb: ehci-exynos: Use struct device instead of platform_device

2014-05-04 Thread Vivek Gautam
Change to use struct device instead of struct platform_device for some static functions. Signed-off-by: Vivek Gautam Acked-by: Alan Stern Acked-by: Jingoo Han Acked-by: Kukjin Kim --- Changes since v1: - none drivers/usb/host/ehci-exynos.c |5 ++--- 1 file changed, 2 insertions(+), 3

[PATCH 1/2] ARM: dts: Enable USB 3503 hub on exynos5250-snow

2014-05-05 Thread Vivek Gautam
The exynos5250-snow has a SMSC USB3503 connected in hardware only mode like a PHY. Enable support for it, and add necessary 'reset-gpio' for it. This is in correspondance to similar patch by Mark Brown 7c1b0ec ARM: dts: Enable USB hub on Arndale Signed-off-by: Vivek Gautam --- Bas

[PATCH 2/2] ARM: dts: Enable USB 3503 hub on exynos5420-peach-pit

2014-05-05 Thread Vivek Gautam
The exynos5420-peach-pit has a SMSC USB3503 connected in hardware only mode like a PHY. Enable support for it, and add necessary 'reset-gpio' for it. This is in correspondance to similar patch by Mark Brown 7c1b0ec ARM: dts: Enable USB hub on Arndale Signed-off-by: Vivek Gautam ---

Re: [PATCH v7 1/2] phy: Add new Exynos5 USB 3.0 PHY driver

2014-05-07 Thread Vivek Gautam
Hi Sylwester, On Tue, May 6, 2014 at 7:57 PM, Sylwester Nawrocki wrote: > On 28/04/14 08:17, Vivek Gautam wrote: >> Add a new driver for the USB 3.0 PHY on Exynos5 series of SoCs. >> The new driver uses the generic PHY framework and will interact >> with DWC3 controll

Re: [PATCH v7 1/2] phy: Add new Exynos5 USB 3.0 PHY driver

2014-05-08 Thread Vivek Gautam
On Thu, May 8, 2014 at 11:35 AM, Vivek Gautam wrote: > Hi Sylwester, > > > On Tue, May 6, 2014 at 7:57 PM, Sylwester Nawrocki > wrote: >> On 28/04/14 08:17, Vivek Gautam wrote: >>> Add a new driver for the USB 3.0 PHY on Exynos5 series of SoCs. >>> The ne

Re: [PATCH v7 1/2] phy: Add new Exynos5 USB 3.0 PHY driver

2014-05-09 Thread Vivek Gautam
Hi Sylwester, On Fri, May 9, 2014 at 3:43 PM, Sylwester Nawrocki wrote: > Hi Vivek, > > On 08/05/14 11:03, Vivek Gautam wrote: >>>>> diff --git a/Documentation/devicetree/bindings/phy/samsung-phy.txt >>>>> b/Documentation/devicetree/bindings/phy/samsung-p

[PATCH v2 4/4] ARM: dts: Add usb 2.0 support on exynos5420

2014-05-09 Thread Vivek Gautam
Add required device node for ehci and ohci controllers to enable USB 2.0 support. Signed-off-by: Vivek Gautam --- Changes from v1: - Removed 'phy-names' property from the 'port'. - Added node references for the nodes. arch/arm/boot/dts/ex

[PATCH v2 3/4] ARM: dts: Add usb2phy support on exynos5420

2014-05-09 Thread Vivek Gautam
Add required device node for usb2phy to let enable USB 2.0 support. Signed-off-by: Vivek Gautam --- Changes from v1: - Added node references for the phy node. arch/arm/boot/dts/exynos5420.dtsi | 10 ++ 1 file changed, 10 insertions(+) diff --git a/arch/arm/boot/dts/exynos5420.dtsi

[PATCH v2 0/4] dts: Add usb2phy to Exynos 5250/5420

2014-05-09 Thread Vivek Gautam
macros in dt entries. [1] http://www.spinics.net/lists/linux-usb/msg106908.html http://www.spinics.net/lists/linux-usb/msg106837.html [2] http://www.spinics.net/lists/linux-usb/msg106427.html Kamil Debski (1): ARM: dts: Add usb2phy to Exynos 5250 Vivek Gautam (3): ARM: dts: Add sysreg sytem

[PATCH v9 1/4] ARM: dts: Add sysreg sytem controller node to exynos5250 and exynos5420

2014-05-09 Thread Vivek Gautam
g.com: added similar syscon entry for exynos5420] Signed-off-by: Vivek Gautam --- Changes since v7: None arch/arm/boot/dts/exynos5250.dtsi |5 + arch/arm/boot/dts/exynos5420.dtsi |5 + 2 files changed, 10 insertions(+) diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boo

[PATCH v9 2/4] ARM: dts: Add usb2phy to Exynos 5250

2014-05-09 Thread Vivek Gautam
EHCI] Signed-off-by: Vivek Gautam --- Changes from v8: - Removed 'phy-names' property from the 'port'. - Dropped 'status' property, since default also takes status = okay. arch/arm/boot/dts/exynos5250.dtsi | 22 ++ 1 file changed, 22 insert

Re: [PATCH v7 1/2] phy: Add new Exynos5 USB 3.0 PHY driver

2014-05-09 Thread Vivek Gautam
On Fri, May 9, 2014 at 4:21 PM, Vivek Gautam wrote: > Hi Sylwester, > > > On Fri, May 9, 2014 at 3:43 PM, Sylwester Nawrocki > wrote: >> Hi Vivek, >> >> On 08/05/14 11:03, Vivek Gautam wrote: >>>>>> diff --git a/Documentation/devicetree/b

[PATCH v8 2/2] phy: exynos5-usbdrd: Add facility for VBUS supply

2014-05-09 Thread Vivek Gautam
Adding support to enable/disable VBUS controlled by a regulator, to enable vbus supply on the port. Signed-off-by: Vivek Gautam --- Changes from v7: - Rebased on top of [PATCH v8 1/2] phy: Add new Exynos5 USB 3.0 PHY driver. drivers/phy/phy-exynos5-usbdrd.c | 32

[PATCH v8 1/2] phy: Add new Exynos5 USB 3.0 PHY driver

2014-05-09 Thread Vivek Gautam
for the basic available PHYs. Signed-off-by: Vivek Gautam --- Changes from v7: - Providing an **alternative** approach for pmu-offset; instead of getting it from DT, using offset definitions from a header file, and making use of it in the driver. - Using 'aliases' for getti

[PATCH 6/6] usb: host: ohci-exynos: Use devm_ioremap_resource instead of devm_ioremap

2014-05-10 Thread Vivek Gautam
ll to the same region. Signed-off-by: Vivek Gautam --- drivers/usb/host/ohci-exynos.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/usb/host/ohci-exynos.c b/drivers/usb/host/ohci-exynos.c index 9cf80cb..aa64fb5 100644 --- a/drivers/usb/host/ohci-exynos.c +++ b/dr

[PATCH 5/6] usb: host: ehci-tegra: Use devm_ioremap_resource instead of devm_ioremap

2014-05-10 Thread Vivek Gautam
ll to the same region. Signed-off-by: Vivek Gautam --- drivers/usb/host/ehci-tegra.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/usb/host/ehci-tegra.c b/drivers/usb/host/ehci-tegra.c index 572634c..ccc6433 100644 --- a/drivers/usb/host/ehci-tegra.c +++ b/driver

[PATCH 4/6] usb: host: ehci-spear: Use devm_ioremap_resource instead of devm_ioremap

2014-05-10 Thread Vivek Gautam
ll to the same region. Signed-off-by: Vivek Gautam --- drivers/usb/host/ehci-spear.c |9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/usb/host/ehci-spear.c b/drivers/usb/host/ehci-spear.c index 8bd915b..6d84cf2 100644 --- a/drivers/usb/host/ehci-spear.c

[PATCH 1/6] usb: host: ehci-exynos: Use devm_ioremap_resource instead of devm_ioremap

2014-05-10 Thread Vivek Gautam
ll to the same region. Signed-off-by: Vivek Gautam --- drivers/usb/host/ehci-exynos.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/usb/host/ehci-exynos.c b/drivers/usb/host/ehci-exynos.c index 7f425ac..bccb6f1 100644 --- a/drivers/usb/host/ehci-exynos.c +++ b/dr

[PATCH 2/6] usb: host: ehci-msm: Use devm_ioremap_resource instead of devm_ioremap

2014-05-10 Thread Vivek Gautam
ll to the same region. Signed-off-by: Vivek Gautam --- drivers/usb/host/ehci-msm.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/usb/host/ehci-msm.c b/drivers/usb/host/ehci-msm.c index f341651..99989aa 100644 --- a/drivers/usb/host/ehci-msm.c +++ b/drivers/usb

[PATCH 3/6] usb: host: ehci-mv: Use devm_ioremap_resource instead of devm_ioremap

2014-05-10 Thread Vivek Gautam
ll to the same region. Signed-off-by: Vivek Gautam --- drivers/usb/host/ehci-mv.c |8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/usb/host/ehci-mv.c b/drivers/usb/host/ehci-mv.c index bd61612..5d03787 100644 --- a/drivers/usb/host/ehci-mv.c +++ b/drivers/usb

[PATCH 0/6] usb: host: Cleanup for ioremap'ing hcd memory

2014-05-10 Thread Vivek Gautam
Based on 'usb-next' branch of Greg's usb tree. devm_ioremap_resource() API is advantageous over devm_ioremap() and should therefore be preferred to request any ioremap'ed address for hcd. Vivek Gautam (6): usb: host: ehci-exynos: Use devm_ioremap_resource instead of

Re: [PATCH 1/6] usb: host: ehci-exynos: Use devm_ioremap_resource instead of devm_ioremap

2014-05-10 Thread Vivek Gautam
Hi, On Sat, May 10, 2014 at 3:36 PM, Alexander Shiyan wrote: > Sat, 10 May 2014 15:26:58 +0530 от Vivek Gautam : >> Using devm_ioremap_resource() API should actually be preferred over >> devm_ioremap(), since the former request the mem region first and then >> gives back

[PATCH v2 6/6] usb: host: ohci-exynos: Use devm_ioremap_resource instead of devm_ioremap

2014-05-10 Thread Vivek Gautam
ll to the same region. Signed-off-by: Vivek Gautam --- drivers/usb/host/ohci-exynos.c |7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/usb/host/ohci-exynos.c b/drivers/usb/host/ohci-exynos.c index 9cf80cb..dec691d 100644 --- a/drivers/usb/host/ohci-exynos.c

[PATCH v2 3/6] usb: host: ehci-mv: Use devm_ioremap_resource instead of devm_ioremap

2014-05-10 Thread Vivek Gautam
ll to the same region. Signed-off-by: Vivek Gautam --- drivers/usb/host/ehci-mv.c | 16 ++-- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/drivers/usb/host/ehci-mv.c b/drivers/usb/host/ehci-mv.c index bd61612..08147c3 100644 --- a/drivers/usb/host/ehci-mv.c +++ b/dr

[PATCH v2 2/6] usb: host: ehci-msm: Use devm_ioremap_resource instead of devm_ioremap

2014-05-10 Thread Vivek Gautam
ll to the same region. Signed-off-by: Vivek Gautam --- drivers/usb/host/ehci-msm.c |7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/usb/host/ehci-msm.c b/drivers/usb/host/ehci-msm.c index f341651..982c09b 100644 --- a/drivers/usb/host/ehci-msm.c +++ b/driver

[PATCH v2 5/6] usb: host: ehci-tegra: Use devm_ioremap_resource instead of devm_ioremap

2014-05-10 Thread Vivek Gautam
ll to the same region. Signed-off-by: Vivek Gautam --- drivers/usb/host/ehci-tegra.c |7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/usb/host/ehci-tegra.c b/drivers/usb/host/ehci-tegra.c index 572634c..6fdcb8a 100644 --- a/drivers/usb/host/ehci-tegra.c +++ b/dr

[PATCH v2 4/6] usb: host: ehci-spear: Use devm_ioremap_resource instead of devm_ioremap

2014-05-10 Thread Vivek Gautam
ll to the same region. Signed-off-by: Vivek Gautam --- drivers/usb/host/ehci-spear.c | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/drivers/usb/host/ehci-spear.c b/drivers/usb/host/ehci-spear.c index 8bd915b..1d59958 100644 --- a/drivers/usb/host/ehci-spear.c

[PATCH v2 1/6] usb: host: ehci-exynos: Use devm_ioremap_resource instead of devm_ioremap

2014-05-10 Thread Vivek Gautam
ll to the same region. Signed-off-by: Vivek Gautam --- drivers/usb/host/ehci-exynos.c |7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/usb/host/ehci-exynos.c b/drivers/usb/host/ehci-exynos.c index 7f425ac..c23a6d9 100644 --- a/drivers/usb/host/ehci-exynos.c

[PATCH v2 0/6] usb: host: Cleanup for ioremap'ing hcd memory

2014-05-10 Thread Vivek Gautam
s pointed out in the review comment in the mailing list. Vivek Gautam (6): usb: host: ehci-exynos: Use devm_ioremap_resource instead of devm_ioremap usb: host: ehci-msm: Use devm_ioremap_resource instead of devm_ioremap usb: host: ehci-mv: Use devm_ioremap_resource instead of devm_iorem

Re: [PATCH 5/6] usb: host: ehci-tegra: Use devm_ioremap_resource instead of devm_ioremap

2014-05-11 Thread Vivek Gautam
Hi, On Sun, May 11, 2014 at 1:13 AM, Sergei Shtylyov wrote: > Hello. > > > On 05/10/2014 01:57 PM, Vivek Gautam wrote: > >> Using devm_ioremap_resource() API should actually be preferred over >> devm_ioremap(), since the former request the mem region first and then &

Re: [PATCH v2 0/6] usb: host: Cleanup for ioremap'ing hcd memory

2014-05-11 Thread Vivek Gautam
Hi, On Sat, May 10, 2014 at 7:55 PM, Alexander Shiyan wrote: > Sat, 10 May 2014 17:30:04 +0530 от Vivek Gautam : >> Based on 'usb-next' branch of Greg's usb tree. >> >> devm_ioremap_resource() API is advantageous over devm_ioremap() >> and should theref

Re: [PATCH v8 1/2] phy: Add new Exynos5 USB 3.0 PHY driver

2014-05-12 Thread Vivek Gautam
Hi Kishon, On Mon, May 12, 2014 at 6:33 PM, Kishon Vijay Abraham I wrote: > Hi Gautam, > > On Friday 09 May 2014 07:27 PM, Vivek Gautam wrote: >> Add a new driver for the USB 3.0 PHY on Exynos5 series of SoCs. >> The new driver uses the generic PHY framework and will

Re: [PATCH] usb: gadget: s3c-hsotg: fix phy disable sequence

2014-05-12 Thread Vivek Gautam
t; > - s3c_hsotg_phy_disable(hsotg); > if (hsotg->phy) > phy_exit(hsotg->phy); We may want to remove above two lines too, isn't it ? > clk_disable_unprepare(hsotg->clk); -- Best Regards Vivek Gautam Samsung R&D Institute, Bangalo

Re: [PATCH v8 1/2] phy: Add new Exynos5 USB 3.0 PHY driver

2014-05-13 Thread Vivek Gautam
On Tue, May 13, 2014 at 12:13 PM, Kishon Vijay Abraham I wrote: > Hi, > > On Tuesday 13 May 2014 11:37 AM, Vivek Gautam wrote: >> Hi Kishon, >> >> >> On Mon, May 12, 2014 at 6:33 PM, Kishon Vijay Abraham I >> wrote: >>> Hi Gautam, >>&g

[PATCH v9 3/3] phy: exynos5-usbdrd: Add facility for VBUS supply

2014-05-13 Thread Vivek Gautam
Adding support to enable/disable VBUS controlled by a regulator, to enable vbus supply on the port. Signed-off-by: Vivek Gautam --- drivers/phy/phy-exynos5-usbdrd.c | 32 1 file changed, 32 insertions(+) diff --git a/drivers/phy/phy-exynos5-usbdrd.c b/drivers

[PATCH v9 0/3] Add Exynos5 USB 3.0 phy driver based on generic PHY framework

2014-05-13 Thread Vivek Gautam
tions. - Addressed the review comments for nits: -- Changed 'usbdrd_phy_config' structure with 'exynos5_usbdrd_phy_config' and corresponding instance names. Vivek Gautam (3): Documentation: Document Exynos5 USB 3.0 DRD PHY phy: Add new Exynos5 USB 3.0 PHY driver

[PATCH v9 2/3] phy: Add new Exynos5 USB 3.0 PHY driver

2014-05-13 Thread Vivek Gautam
for the basic available PHYs. Signed-off-by: Vivek Gautam --- drivers/phy/Kconfig| 11 + drivers/phy/Makefile |1 + drivers/phy/phy-exynos5-usbdrd.c | 644 include/linux/mfd/syscon/exynos5-pmu.h | 44 +++ 4

[PATCH v9 1/3] Documentation: Document Exynos5 USB 3.0 DRD PHY

2014-05-13 Thread Vivek Gautam
Add necessary binding documentation for USB 3.0 DRD PHY present on Exynos5 SoC series. Signed-off-by: Vivek Gautam --- .../devicetree/bindings/phy/samsung-phy.txt| 47 1 file changed, 47 insertions(+) diff --git a/Documentation/devicetree/bindings/phy/samsung

Re: [PATCH] usb: gadget: s3c-hsotg: fix phy disable sequence

2014-05-13 Thread Vivek Gautam
Hi, On Tue, May 13, 2014 at 12:30 PM, Marek Szyprowski wrote: > Hello, > > > On 2014-05-13 08:21, Vivek Gautam wrote: >> >> On Mon, May 12, 2014 at 10:19 PM, Kamil Debski >> wrote: >> > When the driver is removed s3c_hsotg_phy_disable is called three time

[PATCH v6 8/8] ARM: dts: exynos5800-peach-pi: Add Vbus regulator for USB 3.0

2014-05-14 Thread Vivek Gautam
From: Vivek gautam Add required fixed-regulator for VBUS supply for USB 3.0 controller phy. Signed-off-by: Vivek Gautam --- arch/arm/boot/dts/exynos5800-peach-pi.dts | 46 + 1 file changed, 46 insertions(+) diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts

[PATCH v6 6/8] ARM: dts: exynos5420-peach-pit: Add Vbus regulator for USB 3.0

2014-05-14 Thread Vivek Gautam
Add required fixed-regulator for VBUS supply for USB 3.0 controller phy. Signed-off-by: Vivek Gautam --- arch/arm/boot/dts/exynos5420-peach-pit.dts | 46 1 file changed, 46 insertions(+) diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts b/arch/arm/boot/dts

[PATCH v6 7/8] ARM: dts: exynos5420-smdk5420: Add Vbus regulator for USB 3.0

2014-05-14 Thread Vivek Gautam
Add required fixed-regulator for VBUS supply for USB 3.0 controller phy. Signed-off-by: Vivek Gautam --- arch/arm/boot/dts/exynos5420-smdk5420.dts | 46 + 1 file changed, 46 insertions(+) diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dts b/arch/arm/boot/dts

[PATCH v6 2/8] ARM: dts: exynos5420: Enable support for DWC3 controller

2014-05-14 Thread Vivek Gautam
Add device tree nodes for DWC3 controller present on Exynos 5420 SoC, to enable support for USB 3.0. Signed-off-by: Vivek Gautam Reviewed-by: Tomasz Figa --- arch/arm/boot/dts/exynos5420.dtsi | 34 ++ 1 file changed, 34 insertions(+) diff --git a/arch/arm

[PATCH v6 3/8] ARM: dts: exynos5250: Enable support for generic USB DRD phy

2014-05-14 Thread Vivek Gautam
Add device tree node for new usbdrd-phy driver, which is based on generic phy framework. Signed-off-by: Vivek Gautam Reviewed-by: Tomasz Figa --- arch/arm/boot/dts/exynos5250.dtsi |9 + 1 file changed, 9 insertions(+) diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot

[PATCH v6 4/8] ARM: dts: exynos5250: Update DWC3 usb controller to use new phy driver

2014-05-14 Thread Vivek Gautam
Removing the dt node for older usb3 phy driver from Exynos5250 device tree and updating the dt node for DWC3 controller to use new phy driver based on generic phy framework. Signed-off-by: Vivek Gautam Reviewed-by: Tomasz Figa --- arch/arm/boot/dts/exynos5250.dtsi | 17 ++--- 1

[PATCH v6 5/8] ARM: dts: exynos5250-snow: Add Vbus regulator for USB 3.0

2014-05-14 Thread Vivek Gautam
Add required fixed-regulator for VBUS supply for USB 3.0 controller phy. Signed-off-by: Vivek Gautam --- arch/arm/boot/dts/exynos5250-snow.dts | 22 ++ 1 file changed, 22 insertions(+) diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250

[PATCH v6 0/8] Enable USB 3.0 support on Exynos5 systems

2014-05-14 Thread Vivek Gautam
From: Vivek gautam Based on 'for-next' branch of Kgene's linux-samsung tree; along with dts patches for USB 2.0 phy[1], and Exynos5800 [2]. Also based on the latest USB 3.0 DRD phy driver patches posted [3]. Changes from v5: - Added node reference names for new boards. - Remov

[PATCH v6 1/8] ARM: dts: exynos5420: Enable support for USB 3.0 PHY controller

2014-05-14 Thread Vivek Gautam
Add device tree nodes for USB 3.0 PHY present alongwith USB 3.0 controller Exynos 5420 SoC. This phy driver is based on generic phy framework. Signed-off-by: Vivek Gautam Reviewed-by: Tomasz Figa --- arch/arm/boot/dts/exynos5420.dtsi | 20 1 file changed, 20 insertions

Re: [PATCH 1/2] ARM: dts: Enable USB 3503 hub on exynos5250-snow

2014-06-02 Thread Vivek Gautam
eds to be addressed. [1] https://lkml.org/lkml/2013/7/9/486 -- Best Regards Vivek Gautam Samsung R&D Institute, Bangalore India -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] usb: dwc3: Keeping 'resource' related code together

2014-06-03 Thread Vivek Gautam
Putting together the code related to getting the 'IORESOURCE_MEM' and assigning the same to dwc->xhci_resources, for increasing the readability. Signed-off-by: Vivek Gautam --- Based on 'next' branch of Felipe's usb tree. Also cleanly applies to 'usb-next'

Re: [PATCH] usb: dwc3: Keeping 'resource' related code together

2014-06-03 Thread Vivek Gautam
Hi, On Wed, Jun 4, 2014 at 12:41 AM, Paul Zimmerman wrote: >> From: linux-usb-ow...@vger.kernel.org >> [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of Vivek Gautam >> Sent: Tuesday, June 03, 2014 3:40 AM >> >> Putting together the code related to getti

[PATCH v2] usb: dwc3: Keeping 'resource' related code together

2014-06-04 Thread Vivek Gautam
Putting together the code related to getting the 'IORESOURCE_MEM' and assigning the same to dwc->xhci_resources, for increasing the readability. Signed-off-by: Vivek Gautam --- Changes from v1: - Fixed issue with 'res->start' as pointed out by Paul Zimmerman by d

Re: [PATCH v2 6/6] usb: host: ohci-exynos: Use devm_ioremap_resource instead of devm_ioremap

2014-06-04 Thread Vivek Gautam
Hi, On Sat, May 10, 2014 at 5:30 PM, Vivek Gautam wrote: > Using devm_ioremap_resource() API should actually be preferred over > devm_ioremap(), since the former request the mem region first and then > gives back the ioremap'ed memory pointer. > devm_ioremap_resource() calls r

Re: [PATCHv2 0/6] phy: simplified phy lookup

2014-06-05 Thread Vivek Gautam
be from this list: send the line "unsubscribe linux-usb" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Best Regards Vivek Gautam Samsung R&D Institute, Bangalore India -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 4/9] usb: phy: add the Berlin USB PHY driver

2014-06-05 Thread Vivek Gautam
pio, "power-gpio"); > + if (ret) { > + dev_err(&pdev->dev, "cannot request GPIO %d", gpio); > + return ret; > + } > + priv->pwr_gpio = gpio; > + > + priv->phy.io_priv = priv->base; > + priv-

Re: [PATCH 1/2] usb: ohci-exynos: Use NULL instead of 0

2014-06-06 Thread Vivek Gautam
gt; return -EINVAL; > } > > - phy = devm_of_phy_get(dev, child, 0); > + phy = devm_of_phy_get(dev, child, NULL); > of_node_put(child); > if (IS_ERR(phy)) { > ret =

Re: [PATCH 4/9] usb: phy: add the Berlin USB PHY driver

2014-06-06 Thread Vivek Gautam
Hi, On Fri, Jun 6, 2014 at 12:41 PM, Antoine Ténart wrote: > Hi, > > On Fri, Jun 06, 2014 at 12:09:06PM +0530, Vivek Gautam wrote: >> On Thu, Jun 5, 2014 at 9:18 PM, Antoine Ténart >> wrote: >> > Add the driver driving the Marvell Berlin USB PHY. This allows to

[PATCH v1 0/4] Fine tune USB 3.0 PHY on exynos5420

2014-06-06 Thread Vivek Gautam
https://lkml.org/lkml/2014/6/5/358 Vivek Gautam (4): phy: Add provision for calibrating phy. usb: host: xhci-plat: Add support to get PHYs usb: host: xhci-plat: Caibrate PHY post host reset phy: exynos5-usbdrd: Calibrate LOS levels for exynos5420/5800 drivers/phy/phy-core.c |

[PATCH 4/4] phy: exynos5-usbdrd: Calibrate LOS levels for exynos5420/5800

2014-06-06 Thread Vivek Gautam
using xhci-hcd Signed-off-by: Vivek Gautam --- drivers/phy/phy-exynos5-usbdrd.c | 168 ++ 1 file changed, 168 insertions(+) diff --git a/drivers/phy/phy-exynos5-usbdrd.c b/drivers/phy/phy-exynos5-usbdrd.c index 56285af..73689d5 100644 --- a/drivers/phy/phy

[PATCH 2/4] usb: host: xhci-plat: Add support to get PHYs

2014-06-06 Thread Vivek Gautam
. USB 2.0 type (UTMI+) and USB 3.0 type (PIPE3) from its parent. Signed-off-by: Vivek Gautam --- drivers/usb/host/xhci-plat.c | 24 drivers/usb/host/xhci.h |3 +++ 2 files changed, 27 insertions(+) diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host

[PATCH 3/4] usb: host: xhci-plat: Caibrate PHY post host reset

2014-06-06 Thread Vivek Gautam
ff-by: Vivek Gautam --- drivers/usb/host/xhci-plat.c | 50 -- 1 file changed, 48 insertions(+), 2 deletions(-) diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c index e7145b5..7be03df 100644 --- a/drivers/usb/host/xhci-plat.c +++ b/dr

[PATCH 1/4] phy: Add provision for calibrating phy.

2014-06-06 Thread Vivek Gautam
Some PHY controllers may need to calibrate certain PHY settings after initialization of the controller and sometimes even after initializing the PHY-consumer too. Add support for the same in order to let consumers do so in need. Signed-off-by: vivek Gautam --- drivers/phy/phy-core.c | 36

Re: [PATCH v2 6/6] usb: host: ohci-exynos: Use devm_ioremap_resource instead of devm_ioremap

2014-06-06 Thread Vivek Gautam
Hi, On Wed, Jun 4, 2014 at 6:43 PM, Thierry Reding wrote: > On Wed, Jun 04, 2014 at 03:41:20PM +0530, Vivek Gautam wrote: >> Hi, >> >> >> On Sat, May 10, 2014 at 5:30 PM, Vivek Gautam >> wrote: >> > Using devm_ioremap_resource() API should actually be

[PATCH v2 2/2] usb: ohci-exynos: Make provision for vdd regulators

2014-06-06 Thread Vivek Gautam
that, they request VDD regulators in their drivers, and enable them so as to make them working. Signed-off-by: Vivek Gautam Cc: Jingoo Han --- Changes from v1: - Addressed review comments for making the regulators optional, and thus refactored the checks for the obtained regulators. driver

[PATCH v2 1/2] usb: ehci-exynos: Make provision for vdd regulators

2014-06-06 Thread Vivek Gautam
that, they request VDD regulators in their drivers, and enable them so as to make them working. Signed-off-by: Vivek Gautam Cc: Jingoo Han --- Changes from v1: - Addressed review comments for making the regulators optional, and thus refactored the checks for the obtained regulators. driver

Re: [PATCH v2 1/2] usb: ehci-exynos: Make provision for vdd regulators

2014-06-13 Thread Vivek Gautam
Hi, On Wed, Jun 11, 2014 at 9:09 PM, Alan Stern wrote: > On Fri, 6 Jun 2014, Vivek Gautam wrote: > >> Facilitate getting required 3.3V and 1.0V VDD supply for >> EHCI controller on Exynos. >> >> With patches for regulators' nodes merged in 3.15: >> c

Re: [PATCH 3/5] phy: exynos5-usbdrd: Add facility for VBUS-BOOST-5V supply

2014-09-01 Thread Vivek Gautam
Hi Felipe, On Fri, Aug 29, 2014 at 12:46 AM, Felipe Balbi wrote: > hi, > > On Thu, Aug 28, 2014 at 01:31:58PM +0530, Vivek Gautam wrote: >> @@ -457,11 +458,19 @@ static int exynos5_usbdrd_phy_power_on(struct phy *phy) >> clk_prepare_enable(phy_drd->ref_clk); &g

Re: [PATCH 5/5] phy: exynos5-usbdrd: Adding Kconfig dependency for Exynos7

2014-09-01 Thread Vivek Gautam
On Thu, Aug 28, 2014 at 8:36 PM, Daniele Forsi wrote: > 2014-08-28 10:02 GMT+02:00 Vivek Gautam: > >> This USB 3.0 PHY controller is also present on Exynos7 >> platform, so adding the dependency on ARCH_EXYNOS7 for this driver. > >> +++ b/drivers/phy/Kconfig &g

<    2   3   4   5   6   7   8   9   >